From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by sourceware.org (Postfix) with ESMTPS id B4BCA3856DD5 for ; Fri, 6 May 2022 06:54:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B4BCA3856DD5 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01lp2050.outbound.protection.outlook.com [104.47.1.50]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-8-94qYxZ9XOyWQrMQveesS2g-1; Fri, 06 May 2022 08:54:31 +0200 X-MC-Unique: 94qYxZ9XOyWQrMQveesS2g-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iy5S6/aMR316yrnhRpY8/rNoG3H55+Ozwwv3ITXBeN3LJ6iunvr0Ok5+I0EpfZMa3lKw0G+PhlIqqtDffzzxB+zyA6hCkuYTHOcpnn+pBp26tH4ZyGcXVYfSjr5d2INE7S+c9ezOK2c5qmoztQT9LtZadKi8Z4HLJ5abvhRuQ0kHjoVK48IDpggGH2co/SxxIgKWwwin2coTrQYjoSUXi4W8zbKNfVA6ptTBny8IvMYxxzJ5/C7Ejg/cIrj/HTeXJAqNWY3PNJe8LTT1D7XD2NLvTN70eWEhh9/2/swniYxFmk2R8HUk6IBkt9A2nY4FmBnLzh2nIg3VkvvonOX97Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cib4hUiAJewiR6vaxW4Qo0gyi7nnLJsqwcm+2BXL6zQ=; b=dNHs0cuUFCH5FK4+gi3ledsYAi3mN92hW0WR+wJLmv/yA2NbU8u3uFxTJlrTExMfB7Qr9r+fW+3d0MOjE34JfgjArQVbFlpayv12q9XF4PdO2isASLW3kO3GScEfOliMQfmfg0kqbVOhSHxFcjKDtALMAEtcCSoHixanPLeTl++BvCnqO5QBZdLcxP7RGw0rSchBtyRP7rw7k6HE32NdalawzqwjPG+bVD/EvWpZTH47rX2hAFnJELFw/Duf4zw4m2cOcxn6oDUr1w+cZHEOvTcUtOGk2e/Em0Ixcc3WUn5ET8VxRNN1GSCkj88HOYS0S7iRXetA86XHDjOHgOlYvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by DB7PR04MB4426.eurprd04.prod.outlook.com (2603:10a6:5:34::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.27; Fri, 6 May 2022 06:54:30 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c%6]) with mapi id 15.20.5227.018; Fri, 6 May 2022 06:54:30 +0000 Message-ID: <6bd19d40-311e-723f-b299-46b75ae25989@suse.com> Date: Fri, 6 May 2022 08:54:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: [PATCH 2/5] COFF: make objcopy / strip honor --keep-file-symbols Content-Language: en-US To: Binutils Cc: Dave Korn References: <4242b48a-f2c3-4af2-db1e-35dbbbdc1b2e@suse.com> From: Jan Beulich In-Reply-To: <4242b48a-f2c3-4af2-db1e-35dbbbdc1b2e@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0090.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::6) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 69a22325-46be-40fb-bb22-08da2f2d44e2 X-MS-TrafficTypeDiagnostic: DB7PR04MB4426:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dJwmZFOvGqjakF/xM74UARZIXwDaKUqvPFEKXwdiMf+t02O2QA33z31B0RPdX7CZT5pV7co13RXrrs1Ga0nPux/dzxk6Ed3ACWdOy61RojYBNURcuCikd9f0YRNheCSgITXYhHY22EbXyqGGzAFhefkBp+3dicEx4oxxsa4ATlPyIi5MuV//yusYC9dsCA3ldAOGeace6dugNVUuYQX85pIK+tBOPiJZ+xN7H84sSihXgH05b9ZhLT2KgJLQQW0g/hhyrS5Xx/NC01FJVWR5VQdw4xTDbRQGay2tt6cBqxUcKn3WEymKTGCurkXzi1igj7aLloSuy0cN0bMpp6XRSPkeb6Zgj+Nke122Vy5opmWJjXa1qLEXiiZ/xQekPU97hs/qERj1OQhLoOdbHFdJ3DPKsQjX0mrvUDe5vXNEhl+jv6P0/qryJApXdwG85jOaN3+vXagd6P45kErjbcnB9QxwXU1EzGUARrdbBh5HubP8PP9585YpwVXIFETy92+0bSg86abWhw4FP8XSjlfO5xjrcDDu1CcVksGhBo5EljWtBsCe4T9Ac97oa2GZrQhBquZxD/aLQMmqVcSOEJdHwqHmxq3FDX+1TEwOxV/pHL+5WLDqn/tZqNnV7csZyHB2UMKFmkgn7p7w8V3kHF2FUGPGZnzk8DWzsPqQIzDHznZHSxDEb9qpgevYYDuN3lGreKP+71xk2HN7LpeLYUtEc8uD6fzGC1ZtgZHd8AEHdD9o1gpJ9G4Vr9GczQCqDgUh X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8616.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6506007)(2616005)(6916009)(31686004)(8936002)(6512007)(26005)(5660300002)(508600001)(2906002)(6486002)(36756003)(86362001)(66946007)(66556008)(186003)(31696002)(8676002)(66476007)(316002)(83380400001)(38100700002)(4326008)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SU1Jblh2dVI0YXpjdldGbytVdS9PZG5tMlVoVzFYQUk1RFBKV3Z0VlB6Mlpm?= =?utf-8?B?NDhlajRPajNYbHVyYXRQemNXVGN2U09XM1FlMkMxMWRxT29xblFCYzdCRWlh?= =?utf-8?B?d0hLSEd1NVNQRWNaYlJDRHZUd0ozV2hWa1FrMnovTEFwMXpmNTU4KzdNOTNF?= =?utf-8?B?N2pHRWdBMTJodmJmVk9vWThPYS9KeUlPODJmZ0g4Q0FpQzVSeFZZK3Q3T3Fx?= =?utf-8?B?ZDkwWXdGM0RjQVkxZHhubmVtUmM1M01NVDJrdVhzZ3U2U1pjWStJRXQzVmRV?= =?utf-8?B?bG1na1FtYWdMd3pKMmNpUEZCcU01ejlySCtobWc0UTJXYmtLZzFvMHJ5ekJm?= =?utf-8?B?ZS9FTDFuZlRHUlJlOUtiajFqWWVzV1VLODVucCtEWHNSdWJFVlVhemRmb0ZC?= =?utf-8?B?NlprRTFQV2ltZ2Y1K0pRZitkYjBlZ2lLWlZ3SWpTYXFlRDFvT2xTTWxxUlBO?= =?utf-8?B?Q29tVG5scm9vYVlsN2VxMmhsSjNUOHE5Z0FHYTRkWlo2N0Z5Y0EyTzRST1VH?= =?utf-8?B?dENGN2ZrUVNhbDk4TTl4bnY2bmVHRVFZM01FeHFyVXRnZ1R3RGM5TFdaeE1B?= =?utf-8?B?R0FnWkUyTE1GbWxkcTc5SHh6cGlFQjM1bk55ZmhVMUE2UjZuaWxTS0hxT2RG?= =?utf-8?B?MXluckpxT1VhcHowVUpIaEM0bFhxMXdIZ0hyTjF5ZEZKTzRwcHpIaEdRbnRR?= =?utf-8?B?aUgwdC9Sd0lQOEpKQ1VTZWF4d2VoNlRkeCtJVEFDcCtITHFXQTBZUnI0Z0Fl?= =?utf-8?B?QmZGNnFTcHBFVFBLVGFvMWNTOVJ0M3RKT2JFVVNBRnNDS3NMNFo0M0MvN2NW?= =?utf-8?B?U2pVWUVGcnFTT2ljSCt6RFJzTHlmR3lFL0NuRm11UTRPWTZRZVhwazBwUEhR?= =?utf-8?B?TXlhcEZ0MXViZlFTQmlhc1owcjJ5WDZqdEtiQXpqRUdxekJYOVBXSmNIak5r?= =?utf-8?B?ZXRnOUtDWGtSbm9lektuV0d5WVJ3MVkyVEhYcEtib09LblNvMEFnQjd2Nnhv?= =?utf-8?B?VWhSVENGMmVKMVRSU0lQQWxOa3FtNk10enRKY0hBVFhhMlFZVlBsWUp1TnY1?= =?utf-8?B?cGp3eU1Bc01majkwMVZqNXFkQjN2RUE1OWUyaFF5VjFjRXhqMGQrY0M1Q214?= =?utf-8?B?OHlYN3hlRjRVbGRndnZkbjRXQkxDMnJDTUNmY2ttSTFDdTZveFNQckNKMTNM?= =?utf-8?B?VzFmeGtOQm4vYjAwZElESE9QdkkrZWx0RjhheDhMc2hOWGdkdTNObll1Kytt?= =?utf-8?B?Y2tTMm55MjdqZTZNQmViNzk2ekRnVFlic0JnMnFUdllUcDZUckVKdkE3NGg2?= =?utf-8?B?a1VpSXl2K3cybm1QM1VxMVVTSFhSYlRZMmdHQkprN1pPTEpOQmxaNHRncXp0?= =?utf-8?B?dUVCcTF5QWhSeWRXQmZxenZSVFZwcXdHZmdiTXdUeEVWL2FZd2VhUnZ5Y21D?= =?utf-8?B?OG1rcFZPWnp3bmNYM1VDT1p0blYvV0R2eUxad0tSWU9lYjRpQjVEcnU2RjZh?= =?utf-8?B?UkVad3lxdW9MU3p1SmZLekx2NSttVEIxeHJRNG9MYk1XbzV0ZS83RTNzdzhT?= =?utf-8?B?RlBpQkFkT0tPK1dTK1lWUU1JWWtZL2d5cEUxMjZINGhibXlqdVVnaEdYK29o?= =?utf-8?B?a2tmR0NNejdGRHA3VFMyaWQwSnFPSzJRYmZKWUtyc3AwaTExUFlHeWtCWXFP?= =?utf-8?B?Y0F5N1VpQ0NyaWJKcENlQlZ3NzFzVjhqaG03NTBZTVlIdVp4Q2lJSDBieFlF?= =?utf-8?B?bFo0S25BK1M3aE1nSDgzMDh3RnpWZ2dIYnpWNVdoNGw0WnlwL210MTd0clNC?= =?utf-8?B?U0VZaS90QU04V3RFR2VWOTlNRlk1d1hQZ3Uwa21IbnVhUXFZUWJjN085Y2Jv?= =?utf-8?B?S0psbzdHWEtCbjlGVit6Qk81dEc0OWlYNnFWRS9adEdnRWhsejZsZkJjSzRD?= =?utf-8?B?bk1DMmM2ZlNxa2NJSnFXQ0FxT2xRN3V4RzdIckFlSHJpU3R5emJlR0h2N00r?= =?utf-8?B?OXlLcVFTcjdPRUFpSFlITzVsYXNQdnZJR1d5Qkp6a3N3TFZaUTRDTXQ4WkxJ?= =?utf-8?B?cDYzQXdqaDh5U2pDT1ZOdGtSVjhna3hnMDQ2cENkWk8vblpYaVNsQzRCREZw?= =?utf-8?B?NFp5dGltbHBMaDRZdGhleHFKSDhVUEtuMFpjcHVNWm0yenFYV1JxaUJYTmxo?= =?utf-8?B?OUI3WGlPdHExa1Zyeldvc2hjRWE0ZUNvRUVVNDNXS0JnMDRxMVNXaStwemxh?= =?utf-8?B?MFZBL08vNkZ2bE9LZSt5SWlUMnBaQkJ3ZjBRR3RMTGhFZ1ZidnE1UVEwNVJS?= =?utf-8?B?QnFxUFBGcHZHb2FzK3NXN1NVSjFjdW80UWdtMndkdWF4azlzQm9lUT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69a22325-46be-40fb-bb22-08da2f2d44e2 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 06:54:30.3339 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CrmcsRTL/q6FUhVtHNV9e5Cv2YGAAf/agjf4WIv51YlYLorFaGyCcmDLF8GbxLifHkQBcQZop1dJBapjnbh2/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4426 X-Spam-Status: No, score=-3031.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 May 2022 06:54:35 -0000 So far this option had no effect when used together with e.g. --strip-debug. Set BSF_FILE on these symbols to change that. While altering this also join two adjacent blocks of case labeled statements with identical code. --- a/bfd/coffcode.h +++ b/bfd/coffcode.h @@ -4755,6 +4755,9 @@ coff_slurp_symbol_table (bfd * abfd) dst->symbol.value = src->u.syment.n_value; break; + case C_FILE: /* File name. */ + dst->symbol.flags = BSF_FILE; + /* Fall through. */ case C_MOS: /* Member of structure. */ case C_EOS: /* End of structure. */ case C_REGPARM: /* Register parameter. */ @@ -4768,11 +4771,6 @@ coff_slurp_symbol_table (bfd * abfd) case C_MOE: /* Member of enumeration. */ case C_MOU: /* Member of union. */ case C_UNTAG: /* Union tag. */ - dst->symbol.flags = BSF_DEBUGGING; - dst->symbol.value = (src->u.syment.n_value); - break; - - case C_FILE: /* File name. */ case C_STRTAG: /* Structure tag. */ #ifdef RS6000COFF_C case C_GSYM: @@ -4790,7 +4788,7 @@ coff_slurp_symbol_table (bfd * abfd) case C_FUN: case C_ESTAT: #endif - dst->symbol.flags = BSF_DEBUGGING; + dst->symbol.flags |= BSF_DEBUGGING; dst->symbol.value = (src->u.syment.n_value); break;