From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-sender-0.a4lg.com (mail-sender-0.a4lg.com [IPv6:2401:2500:203:30b:4000:6bfe:4757:0]) by sourceware.org (Postfix) with ESMTPS id 24F13385828D for ; Sat, 19 Nov 2022 02:56:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 24F13385828D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=irq.a4lg.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=irq.a4lg.com Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id DBFEF300089; Sat, 19 Nov 2022 02:56:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irq.a4lg.com; s=2017s01; t=1668826599; bh=e0LRuj6BKYnqxi9C6FO35jdVAPsdl+5zeGRPusdJtmA=; h=Message-ID:Date:Mime-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=WGtJ8quCqEBIeMx+QNu8MP63q89I+zupR4TR3XIUdI1U6bNe3VyOJFaWjv1teCK0n JDMW2xIr5Tvlmhc5VaDrQeeg+IeBOvHXQ6V89QExZ3yWRbtmxpynvPtD7rXy7uGsDH zvaX7S//UnFEaEvkTvDhrjqauylkOYnb/i/7dYFo= Message-ID: <6cc203c5-d24c-767a-f84e-8987c5df995e@irq.a4lg.com> Date: Sat, 19 Nov 2022 11:56:38 +0900 Mime-Version: 1.0 Subject: Re: [REVIEW ONLY 0/2] NEAR RATIFICATION RISC-V: Extensions from the RISC-V Profiles Content-Language: en-US To: Nelson Chu Cc: binutils@sourceware.org References: From: Tsukasa OI In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022/11/03 22:11, Nelson Chu wrote: > On Thu, Nov 3, 2022 at 8:26 PM Tsukasa OI wrote: >> >> Hello, >> >> This patchset implements all extensions from RISC-V Profiles (but not >> profile itself). I'm not sure whether this patchset helps someone >> implementing RISC-V Profiles but I hope so. >> >> Thanks, >> Tsukasa >> >> >> >> >> Tsukasa OI (2): >> NEAR-RATIFICATION RISC-V: Add 'Ssstateen' extension and its CSRs > > Looks good. I will commit this (PATCH 1/2) soon. > >> NEAR-RATIFICATION RISC-V: Add platform property/capability extensions > > If we just need to recognize them in assembler, then it looks good. > Thanks for arranging these bunch of extensions before everything gets > messy... Generally, since they are frozen, we have good reason to > commit them to the mainline. But if you prefer to wait until they are > ratified, then that's also work to me, I believe you know when will be > the best time, so please commit at that time. Some pointed out that an extension name 'Ssptead' is no good: https://github.com/riscv/riscv-profiles/issues/81 New name would be 'Svptead'? In any case, I'll wait PATCH 2/2 until... at least this issue is resolved in the main branch in some way. Thanks, Tsukasa > > Thanks > Nelson > > Nelson > >> bfd/elfxx-riscv.c | 38 +++++++++++++++- >> gas/config/tc-riscv.c | 20 +++++---- >> gas/testsuite/gas/riscv/csr-version-1p10.l | 48 ++++++++++----------- >> gas/testsuite/gas/riscv/csr-version-1p11.l | 48 ++++++++++----------- >> gas/testsuite/gas/riscv/csr-version-1p12.l | 48 ++++++++++----------- >> gas/testsuite/gas/riscv/csr-version-1p9p1.l | 48 ++++++++++----------- >> gas/testsuite/gas/riscv/csr.s | 2 +- >> gas/testsuite/gas/riscv/smstateen-csr-s.d | 22 ++++++++++ >> gas/testsuite/gas/riscv/ssstateen-csr.d | 22 ++++++++++ >> gas/testsuite/gas/riscv/ssstateen-csr.s | 13 ++++++ >> include/opcode/riscv-opc.h | 26 +++++------ >> 11 files changed, 215 insertions(+), 120 deletions(-) >> create mode 100644 gas/testsuite/gas/riscv/smstateen-csr-s.d >> create mode 100644 gas/testsuite/gas/riscv/ssstateen-csr.d >> create mode 100644 gas/testsuite/gas/riscv/ssstateen-csr.s >> >> >> base-commit: ae1c45ead6b60ef0fd338bbeb6a4c5e5808c6e6a >> -- >> 2.37.2 >> >