From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2044.outbound.protection.outlook.com [40.107.22.44]) by sourceware.org (Postfix) with ESMTPS id 4D3403857B8D for ; Thu, 23 Jun 2022 07:29:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4D3403857B8D ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U7D+wg+TUmrqcHkURTbXGiK8GnbljX3dzu12yuB453WiUIIjllOjZ94np7GwEfWY/Q0cOQgPI2DPJZRtbCjZ0Age2znF8Khcj+k4DKD83A0WuaXJEPkfdwaFsMEa3dn1RopyRE7Wu9vL04qk5LX+lMmxmbCrPnyZqe/OXECmXi8xQXF8hVDaPKs2wx5cRxSvo1/nc3reYFAZMiH/BI8H8y8bzV2KhY+qwHaaMdc3ot3IhBpAgiYu1G6SbuwRGqWfIy79j2Nqz5vV48faLduZz3jDFvKj4J2XkjYch/05jQLLgqYga0MVgC0Tj29n4Vwz1J6VImjxJZ2a47uOHbKPnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JBk8d3ti+3QIO9j1q6pBVSpAyQh6V/o+c48/j0ipAJk=; b=DJng1lVntNre4wfIYKSrytghtFOLspl0AZ+XGA/rYlV7ptF6gEYlPKrY1+LEgS7DTvC1xOSUqPLOjuQc6MEPNXu9QwnqHZHoMRlxYaZbPh62I2KtCWLhWwS090Mzbgv9OftxZgtDRtegrehT6J1UP+AdJpKTBARVgB7Cze2cX6gqSmRfL7CfSFA152OVGOeb+iO3gd7aM7qklpHw9hEuX/2rk3IJiJNFYH7k17s9UibbYJuP8z+3e4Epnsnm6PIn8lrR1xIjVTIrvinr6rorKw+MsJerS+bIW2WW7V0Bqg5o5qmdlI6dMK/FSic8FZEQq4K0b4LPIIKKsSqYGH9s6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB6272.eurprd04.prod.outlook.com (2603:10a6:803:fe::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.16; Thu, 23 Jun 2022 07:29:38 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5353.022; Thu, 23 Jun 2022 07:29:38 +0000 Message-ID: <6cdbbd05-3305-9595-4aca-e547347c80da@suse.com> Date: Thu, 23 Jun 2022 09:29:36 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] Correct cpu_flags for CPU_ANY_AVX512BW_FLAGS Content-Language: en-US To: "Cui,Lili" Cc: binutils@sourceware.org, hjl.tools@gmail.com References: <20220623071404.15863-1-lili.cui@intel.com> From: Jan Beulich In-Reply-To: <20220623071404.15863-1-lili.cui@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR0202CA0038.eurprd02.prod.outlook.com (2603:10a6:20b:3a::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a9cd1f13-52c2-41da-b623-08da54ea2112 X-MS-TrafficTypeDiagnostic: VI1PR04MB6272:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hHv6hpGBC/TTjaR3w1iy+q5ZCxAGI6/CA1RbvaRk8XrVjDZDqNkkcnYpP/cGFBLCSNNl45zvra7PrHGPTZg7ZUqitujkpSc6h59v+C8xjyJS/SIc8cg7f9Z2HDOFPB3hzKm5BP6lqfKJ606eSMaE4ga8aSX6AZJsvHv0u1TLj1QbmnXcRD4BJrSe5kPTJlmKndcmO3uqZ1EYs8cVJpvJRG2BXUiPqmC9pl/5JT4ftuvCGt2nZp9AoIt82l4OjSVjF8vG2cCoqFoIDz110OSRc8f1ZnrQm0Twsjlnia74eqwgV2p15e//y0NXACXzLySnHE7zHCllUg4VEeyA269f/QRd/T6HTdVAvJGVgms4AKz/y3TL4scK7FwztIaQifFc5dlMVAmN+53ZIygEQiZAlvOvR9sBYMKm3OH1xrTlzpylUBEC2O7LG/OwMTFt4oUtQOcD2g/r91iT1fz6xXp+8OuqaG7l72Laf5aZCGa+f2XDUTvG9lBEpKN0bw63eQMC52S5zdAicOd4BYlw3mJ0M80HqtfvWEcYLD5XZKnZvUWwTF2gE/GbsTBP4Sj43Ysxxxh1wwCS6S9MnpCjJ4geZQ6D2MtI3ebXMKLpdCzPCS+9zmtQjWoEEYS0mVTITt1AfAKmDTcmVDNCEUmUTfGgU+ILfrCqcI/0/yYgNgnwfQhi3ZtApK/rtR8tTDgp62onFdFWFuorTqbFqlR0FFmlo5nykW0V/jPLtnSKz4hJPyJXVkNh9WpWPVEqJVy7g4E6SLslhXZARmW9Jcnx2KU97IjR1FNj3Q9g2GPjGMvjWII= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(136003)(39860400002)(376002)(366004)(396003)(346002)(5660300002)(26005)(2616005)(66476007)(41300700001)(66946007)(8676002)(66556008)(4326008)(478600001)(6512007)(83380400001)(8936002)(36756003)(86362001)(6486002)(53546011)(38100700002)(316002)(31686004)(186003)(6506007)(6916009)(2906002)(31696002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N2hFQnZqdlhzbjFaYUt6cVBnZDBZcytteE5yU2paUGNaeUVSZndmVWZOdHBY?= =?utf-8?B?dGJBS0tGM0twcDYwQXR3QkEweVhPQzI3QmFOR0lhSzJ1RE5CenRVdmtHUGxW?= =?utf-8?B?YmJsM0lpMzlsUk00NUtBMjhHaHN2amgxYjNkR3ZVSjB1ZjBISEhzWHhMd2pq?= =?utf-8?B?MnRXc3VRYkNIUmliMmM0dDdyZmJpYlJlbWxiRWhSWEMzQXBMZVdTMytBdmpZ?= =?utf-8?B?TE5seXNiOXc3aDRGRERHWmNqME8xZ2RicXBkc0JNVFlqQXNkWXJYRlVyeVBT?= =?utf-8?B?RmZOZ3pLQVpLN0NVOVBtU1diRHJFaVZ4S2pqc2Uxa0krVkFnZTRoSzAzSlhC?= =?utf-8?B?aGpuYWx3WmhSUWg1YkhyNXMySjFwRUgvOUJFdjRoc0E5SkZsZXV0blRzTEVj?= =?utf-8?B?bTBRNWg4eWhVclFsUTFVRXNmM056MVB3dHVuYkEvdTRCNFhMc1FyT3FENWRi?= =?utf-8?B?MFNxZTNObDcyTXhtT0JrK2ZkMUw4blQzSVdyMlQ3YVZMdGRSNUQzK0RNWTRT?= =?utf-8?B?RTFidnR3VW1FdXNJdkp4RVZTUnZnR1RsZG9tZGhzTWt3MlBLbFcrT0w3VHRZ?= =?utf-8?B?eUV6Y0RRZVBFOGhtWE8rTXAvL1I1ejlpcU1MQytFWS96U01kZldlcG5hWmF2?= =?utf-8?B?bkpnV3ZqSDBCa2hjdVZDY3BLYVp5QWsvMDdlQzBRamkxU0VYeDgwWHBGU3BE?= =?utf-8?B?Ylg1UnVYa0Y5OVVWZkJFdTFBWThuZEF1dzBLOGVOVU1JRE1oUFdueGNTR0FL?= =?utf-8?B?QytzRy9nb205dEh2Z3c4Y1ZkTEIrZEdzSXR3VjlGeDZWODdtbFI4OXFQanRt?= =?utf-8?B?UWl1L2FCZ1R0akJGL3pVSTNtcnhESDRQU0lORDRyekpHeFM1NGd0bkc2UEcw?= =?utf-8?B?QzJCTnZVL2xsYTc0UTVsZEg4b0QvdUhnc2JONHVnY1F6N3NwRWdlSUpubnl0?= =?utf-8?B?UGdCZlg2eVRPYUFWZmFMSXJzWXYrZXhhc0dEb1BYWnNHOHJPb0NVZ2hWNkZL?= =?utf-8?B?OCs1T3JEcVhWNkU0SmNuUlZZWkhXbzdmYkI2OWdnRndLak1nU2tWLzluQ1px?= =?utf-8?B?bzJjYWdsajFiTUVPS2szTDljbnEzOWdoWEk4NnRKTUtvL05iRlM2SGhSU2Mz?= =?utf-8?B?WHh0NUdJUHNNbEVJT1FHNmEyYS9SdGdTTm9Vcktta2lSMlJlcDk3T0Z0bW5w?= =?utf-8?B?eUN1R1NNUDMycWs1L1p0cHpiQW5PVmlFVVFrWS9aK1pkd0ZVRGJkQ2FuQUZ2?= =?utf-8?B?WU95c3NkMEROcEpZY0VCQWxKNlNqMzQrWGpkUkZFZFVCTzB4YUtsbHAwVUow?= =?utf-8?B?Q2svOEwyTUoyNmQ1ZVN1ZkcrRFBuVXd1MjZ0TlI1NGJ4S3MxWmlBbzVPRmZK?= =?utf-8?B?V20zREU3T1FTak0yVkpETTFTTm9QenJ6aFJaaHVTOHpBeStyN2MvTldjeUJS?= =?utf-8?B?QzFGb3Z4R3dDLytsZVJ6ZTRQRHhNcVZYQ1RETnVZcDArdHNpMVZMRC9VZlB2?= =?utf-8?B?V3pKUitlVVJ2TDdvN2o2VnU0VzlWcDNxcjI2Q3lpOHdTUXpmZlFEd3BEYVU2?= =?utf-8?B?SDF2Ums3by8wMmgwNlZMdVVRVlhuY2dSakJzcytCUmJQaER1aFpDT2k5Unlq?= =?utf-8?B?RG1DbDdhZHo4OTVaaHVSSjFNUDh0RTJjRjltbEdjZG1WSk5xYmJHaXNGK2lx?= =?utf-8?B?aTU3UjUraUsraW5sMVJsWEl6cE9LV3ZSNktTZzVybzlkbDJJeTIxY1MwTEJm?= =?utf-8?B?djllcHpWQVRaaHNwWnpQcS94RDZ3M29PUDFMVTFhUHlPQXBvdmQ5UUVHWTRk?= =?utf-8?B?M29saENRdEE3V3VQUFBqNnF3dFdGNGowUDdqMWM2SUNuVjNHWkdGcFRoSm9W?= =?utf-8?B?emx2U0Q2K1VZTGJBSFUyNlpMM2RpdmVUa0UveU9tVjcvWVc3TVZnQm54S3Nk?= =?utf-8?B?YXJBb0ZXR0pVVEdpZFkyc053TVVBTWtGV3F3MGtGODIwNW0raHVEVERqN1lB?= =?utf-8?B?N0VqUHNaeWNrTG1XUTFoVERTMUhjNXhGK3pLU0hHYnM4bGdEVGlyY3BpR1Yz?= =?utf-8?B?UVJ2SC92RTJ5TWtnSkYxS1NtSXorNUVORkhBa2J2YTJrQjh4WkxFREVTTzcy?= =?utf-8?Q?Mfnq0KK0dRxDhZqQLkimzGwFe?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a9cd1f13-52c2-41da-b623-08da54ea2112 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2022 07:29:38.2332 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NY/zBYHwwlwgapjUP2VqIReTR1AApuYPiBc8viAiGP3erdTjsVXgJrID99rIekXMPsTdItF86bX3FnBRQlrYhg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6272 X-Spam-Status: No, score=-3036.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2022 07:29:44 -0000 On 23.06.2022 09:14, Cui,Lili wrote: > This patch is to correct cpu_flags for CPU_ANY_AVX512BW_FLAGS. > Make check-gas is ok. > Ok for master? > > Thanks, > Lili. > > Change it from "CPU_ANY_AVX512_FP16_FLAGS" to "CpuAVX512_FP16" You don't say what's wrong with what there is right now. I for one think what we have is correct: If one disables BW, _all_ its dependents should be disabled as well, which transitively means all dependents of FP16. Jan > opcodes/ > > * i386-gen.c (cpu_flag_init): Change cpu_flags of > CPU_ANY_AVX512BW_FLAGS. > --- > opcodes/i386-gen.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/opcodes/i386-gen.c b/opcodes/i386-gen.c > index d18a7d2754..5dc224efdb 100644 > --- a/opcodes/i386-gen.c > +++ b/opcodes/i386-gen.c > @@ -382,7 +382,7 @@ static initializer cpu_flag_init[] = > { "CPU_ANY_AVX512DQ_FLAGS", > "CpuAVX512DQ" }, > { "CPU_ANY_AVX512BW_FLAGS", > - "CpuAVX512BW|CPU_ANY_AVX512_FP16_FLAGS" }, > + "CpuAVX512BW|CpuAVX512_FP16" }, > { "CPU_ANY_AVX512VL_FLAGS", > "CpuAVX512VL" }, > { "CPU_ANY_AVX512IFMA_FLAGS",