From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 1C2BC38AAC1C for ; Tue, 11 Jan 2022 14:18:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1C2BC38AAC1C Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-320-LCgbCyrNPH2Pa-pBVQ__Qw-1; Tue, 11 Jan 2022 09:18:05 -0500 X-MC-Unique: LCgbCyrNPH2Pa-pBVQ__Qw-1 Received: by mail-wm1-f72.google.com with SMTP id o18-20020a05600c511200b00345c1603997so3250363wms.1 for ; Tue, 11 Jan 2022 06:18:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=7teFNlYK2kRk/3WLq3mKxWDdAUKcZY+pytfoWTdRVcM=; b=PWDlHwyIharOiCcmWdL5ojfsnswzNTSc0nIL7uqFznPbz1AbIPTuoug941RY53RtK1 IaZ5WKpFNdT4hHnej862vVw11K7RAeVT+xuJaQfnU3TlphWdKW+R7sW0BblPOPcerWoA YWPRyMJrVwWXpiua0yGl/0VMNTcxklvjZnQHDzMg9mLHzM4GKLKm948yHhnL1zMdxbY5 IU1Ibrph8K84F+7Js/0ymz/z4SfPKgmvrXrXaFUwOqbkU6wLEEpay3z2vc3QwlzGQJ+D 7rMqU9mJUW3c/CpQ7l/7pJAUtqmT5K91R/u702YR6YWa1jzT2r13u+9LuaxQoMUup96t IGmw== X-Gm-Message-State: AOAM530ia71GAl7PW7VLUnjYajjJyOL4QVU7hFMEuxMy2wv7ErK+uodL QVFu8Yp9BsFl50JLww7Q9fVIodVeZCPiIKDUpxz/APp3tfptd9W5iQL3g9OotCfbhKp4PyZcCQR Mi8er3oVN4zv+fxGhuQ== X-Received: by 2002:a5d:6dad:: with SMTP id u13mr4178185wrs.604.1641910684364; Tue, 11 Jan 2022 06:18:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJxd/pfcdc87fAVRQTLl1JcaAnpNp5Vt/F9GKdJKWvcU4layIW7Ig8wjp1ijmLmxQZ61v1s1Yw== X-Received: by 2002:a5d:6dad:: with SMTP id u13mr4178148wrs.604.1641910683858; Tue, 11 Jan 2022 06:18:03 -0800 (PST) Received: from [192.168.1.6] (adsl-164-239.freeuk.com. [80.168.164.239]) by smtp.gmail.com with ESMTPSA id j11sm2599229wmq.23.2022.01.11.06.18.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jan 2022 06:18:03 -0800 (PST) Message-ID: <6d3510af-c312-83c0-adb1-a96b8fa6d435@redhat.com> Date: Tue, 11 Jan 2022 14:18:02 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH 1/4] gas: add visibility support for XCOFF To: "CHIGOT, CLEMENT" , "binutils@sourceware.org" References: From: Nick Clifton In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_STOCKGEN, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jan 2022 14:18:11 -0000 Hi Clement, > XCOFF assembly defines the visibility using an additional argument > on several pseudo-ops: .globl, .weak, .extern and .comm. > This implies that .globl and .weak syntax is different than the > usual GNU syntax. But we want to provide compatibility with AIX > assembler, especially because GCC is generating the visibility > using this XCOFF syntax. > > PR 22085 > > bfd/ChangeLog: > > * coffcode.h (coff_write_object_contents): Change XCOFF header > vstamp field to 2. > * coffgen.c (coff_print_symbol): Increase the size for n_type. > > gas/ChangeLog: > > * config/tc-ppc.c (ppc_xcoff_get_visibility): New function. > (ppc_globl): New function. > (ppc_weak): New function. > (ppc_comm): Add visibility field support. > (ppc_extern): Likewise. > * testsuite/gas/all/cofftag.d: Adjust to new n_type size > providing by objdump. > * testsuite/gas/ppc/test1xcoff32.d: Likewise. > * testsuite/gas/ppc/aix.exp: Add new tests. > * testsuite/gas/ppc/xcoff-visibility-1-32.d: New test. > * testsuite/gas/ppc/xcoff-visibility-1-64.d: New test. > * testsuite/gas/ppc/xcoff-visibility-1.s: New test. > > include/ChangeLog: > > * coff/internal.h (SYM_V_INTERNAL, SYM_V_HIDDEN, > SYM_V_PROTECTED, SYM_V_EXPORTED, SYM_V_MASK): New defines. > * coff/xcoff.h (struct xcoff_link_hash_entry): Add visibility > field. > > ld/ChangeLog: > > * testsuite/ld-pe/pr19803.d: Adjust to new n_type size > providing by objdump. Approved - please apply. Cheers Nick