From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by sourceware.org (Postfix) with ESMTPS id 56F943858414 for ; Fri, 25 Feb 2022 11:06:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 56F943858414 Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-db5eur03lp2057.outbound.protection.outlook.com [104.47.10.57]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-2-kkWB2aVWMGKzqzZdwUHrjw-1; Fri, 25 Feb 2022 12:06:10 +0100 X-MC-Unique: kkWB2aVWMGKzqzZdwUHrjw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dPtXS/4XLYU9Oa3L7LOzUJeMyvq9mUhdIMQALEV4bVOSLQzH47i8/m4mgCL4w+xXmbr1j5Ig4+QzrW/8ptSmi6Ut9oBN6kDcc++1LSSYtEtiuDBBp8dgD+h1fNIJWkMGWNs+1OuAu4SbB1p7RAMaX/lAZDMmBf+s/IWcR96aeEcdkNMmcjTQHUYDB7dpkw7+fyK7uHYQKcX+R4dDqY0Ah+0+dnlTb5EZponzOEwwJrH580LbnJp7XP7Y8UlLpe0C4u6iZeQdSgniAWsw2CIUvHIdifKXVudAcy5wAJ8mJd3Zd+h+LMl9j5HKPdL8I6RwNh7kPVF8y8M4tiZ5x2jNlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YpVElvD3VZrD4pAY/FTykycNPRVBau+mjp3A8CJ+/ng=; b=CocCO3C2Dc5ZsGiHwpCMJx16iXfADgB87iTHva7k7fG6bEg6YmHsz/oSv+/affxkOIu1p77nupyoS06FSfOMBMrracp2fzgNaKkTVYrRUOarqifp2mrxUDCJ6pJqJcTV8n7PjrRXCTL8jVs6xdmoLK6lh7fxCScfMq/KXUZReuHq68Fol5fdHw0VCeMcCcH8uWJ+jj/h6tK3C77A5HUfJ6sQesV3+iCEEPDSG/UiZbp5tE8DVrmLtiS4O99OP0NCdAXmu8mgVsfO5w39r58gSoaQB6ejExjBTCDsVGGbnyFS2uwlu9d3JkDwa0zn7oHFwACnJb0SqMflW2WC1BAeFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by DB8PR04MB6380.eurprd04.prod.outlook.com (2603:10a6:10:10c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Fri, 25 Feb 2022 11:06:09 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.5017.025; Fri, 25 Feb 2022 11:06:08 +0000 Message-ID: <6d807b33-5409-b728-7d1e-9fef8a16490b@suse.com> Date: Fri, 25 Feb 2022 12:06:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Content-Language: en-US To: Binutils From: Jan Beulich Subject: [PATCH] RISC-V: make .insn actually work for 64-bit insns Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P191CA0045.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:7f::22) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cadc511f-9e45-4424-5f54-08d9f84ed34f X-MS-TrafficTypeDiagnostic: DB8PR04MB6380:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MEz9iRmNYAbXffS6D5YyXwvervQW5H/xRYwhb/Jcsdkv2mMwTJLu85WQPvZCYPOikBkSu0zbwZib+L9ygazF7mv7znYKixZIrQiCPgJRticO3iQOys5SZxQudUAovfPdecvxaHuhN914C4rIA93646BZLmpfw/nylBmGkPTXMiIZoi1nSjlG20cH9bN4eMVaPrlo5wGa4aWbyU5z83VOkhRG7h1Ef6E+S17b4hhppY9TsnaX4+cwmsbz4jsnE0HnSO0vjQGVv81eYh+OqhMCYNlnPV3YCbGx/SoJwFzIxddrR+SWpgIYXfxHGEV0hjfxcdRLEAWxLbH2vUUQIlIBg2+dxKQZ60920zBFEk+Yr4po0yuBTSCkuqogKljOLl7WrwrWmjKzHeFgzWuNlvn69U1wtXK2XyDDNrBGFekB8HuJg63NceoPxSIkwA7rebOpytg8mNUm+2cnk8UZFjeBIsSWy3cbocNQxCE4OcxMWU62qrW+9wSol0arTVuyhu2d8FVDi+paYJknRSy6gtk5yUuTwtKikTYrpGPkhV1WAntA+YJDDeI6lNf6LMdBTEuvoBuYckoShMLsuh4hb9+NqYuQKYpSy7BWMAVJ6KiXGdJCzS0vrCdvhDtMY+6LZh1avymLI0Ljr8qYnJv9mbqL8KLy/0U64EeR7qbKAS+4HDv4PP8m0hkCMh++is1OfC9OHVx6Qd2KwkA4RtGljJLZ5dkkSNkEzoBT7aFBs7j8QkYR4HWiAP7XdlFIKxEPYQx3dEZPWaHy3OLTIZwcWsqlyA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5600.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6916009)(38100700002)(86362001)(31696002)(6512007)(6506007)(26005)(186003)(54906003)(6486002)(508600001)(5660300002)(2906002)(66556008)(66946007)(4326008)(8676002)(31686004)(66476007)(2616005)(316002)(8936002)(36756003)(142923001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TjNLZ0xicTVpZm5ndnE5TDYvbGdaY1FUZHF3YjVGWEtmL2thVFRDVG92N3Jn?= =?utf-8?B?WHgvRXZFNTJMMVltVjN0REp1L0d2SWxKaUNzN1dXOGpOMlFCMmIzNFVmRXBQ?= =?utf-8?B?NnpQcDYyUm1QcW9jdW1UUDM3T3ZTeHQ4dEZMcjJTM1J1R1A2cEZRK01EaXE4?= =?utf-8?B?VjVvMVJjbXVYZmV5WFJZajJHMG5FNE5DWVBiZ0pQeU9DWXo5OFhLNXdzcjR6?= =?utf-8?B?T3pJV3ZlNm9NZzRsTDloY09iSlZ1VzRhWFpDUHFaSzYrdFhhdHBjZnM0Mmdn?= =?utf-8?B?OThobDROT3BOdHNjY2lDMTQ3YWEzbk5IaU95NmRnNzhEZzhGT0tBcS9jYlRy?= =?utf-8?B?d0svRG1SMHNPWkd1OUQ1c3RNejVvY0NKZE4vaEpqZlE4MTJ6UzRSTzI3N1VU?= =?utf-8?B?VlNRL0RndzR2NUFEeEdvS0U3eE5zVG4vK2hKY1dZS0luQnBQc1VxN1BDL3VK?= =?utf-8?B?aGVJZmw4VDJFaHpGRmphWGpuNVNDeGZjUUp6NlZoSjRidXErTzdFckxxd0pP?= =?utf-8?B?Q3pOM0taMktmUnZYaFcxZjJwR1FsV3U4Z2J5Ym42UFZ3ZiswWSt0ZHhEL1h5?= =?utf-8?B?Nkc3bStRTVZqcnIxcm9ONEw4dmZ2Yzc1K0o4VnB0YlVWVEgzak1MeTVvbXFB?= =?utf-8?B?bFZNVHQ4bFZkNCsyS3doVy9Gd3hNbXRKLzRMQlFkVCswUHZpb1RaOHZkZjNk?= =?utf-8?B?TE0xeTBFM29jU3BBYXRFMHVHZUdLbnUyOExBcDN4VmhBaDhiRHpVVSs4ZmJz?= =?utf-8?B?ZGVxeUFkODR1NjlUdTZndmFkWGpPenVoMVl1UGxDQ1d5WlVvazhSaXJqYXgy?= =?utf-8?B?Tm1ETGFzVnVUNnJYMlFoYklFdmhPYTVzdDIxb2dqS2pjNnlBS1U3MDEyQzNp?= =?utf-8?B?bFhPMU1RN0RBb0g2VG52RGlQWVBxUm9tQkZCd0ZGaTI3cXBiZVdpckxTc3pj?= =?utf-8?B?bWJjRDVZcHM5SnZPWGtPUDl3SDNyWGhjR3Mvd2xCQmV1WmNhVFFKWEJielQ0?= =?utf-8?B?bHdIQXNWR2FEMlZ0RFpTSlk5Qk9EU2VVT1FncW9QeDh2YWVYUHFnQXZoQWlw?= =?utf-8?B?RGx3aUU4VmxTNHQ3QlhVQ3FXTTRoU0lETXhIZ2I1WjIwZHliMUUvNXoxeTJV?= =?utf-8?B?K1FzVnZnVUtWSkpHUjk0MGlWSVM1bTJ4YVpYNVc3T01SQmJocVpDV28yM3NC?= =?utf-8?B?c0ROYlNrZmc1bFJFQXZGUldNTnpsVWQ1RlBpQkpqanlvbnczRVlVVW42bThz?= =?utf-8?B?a0JSUkxDMjQ3K1ZiZ1ZwRndMdE55dkltdi83SDY5Y1Fic3U3V2NKV0J6Tm02?= =?utf-8?B?c0hRNm11bW9NNkx1VU5lcmJsVms2VmhhQUZ6dWF3WDNJRk5paHBLbDdTOFpN?= =?utf-8?B?YjErMkNndUcwNE55cTlGNUtoZE1kL3BsV2VoUUtGT2pMbXA4bmtwNFJqTUM5?= =?utf-8?B?V0ZUaTF2TUM2S2N4RG1BUk5LK3VUMDBwUFc0VWg3M2UxajBsSTNZSjI3VnJi?= =?utf-8?B?dFFXcHVDZjdjWHZrUzRiZHJla2tuRFVpcm5VMkZJODJiTmZuRWFWWElDQXp3?= =?utf-8?B?Y0xJcGVHcjNNSnJyeEVyQTJnelJMWVdXVi9ZNzVuQytnNjlWak5UVDRKK0hQ?= =?utf-8?B?YkZpTmxrZ0FVVFl2eGJSTCtIWklSOVZYQjFDamJzMjMrTjFoOVV1MGlpSXo5?= =?utf-8?B?ekJmazFJMTh1clRmdVpBTnNlYUVqSllzS2FkdGVNbXpwRi9Ub3N1SUwwZkx1?= =?utf-8?B?eHhHTmZrK29PajdscXZtQktGV0xwR3plMnN0Sm1YWTAzSWt2TUM3Z1hnQU43?= =?utf-8?B?RWlWcSttdnZzK1Vvd1F3aFZtZ1VlQ21VMUVTazRPb0tWMFFvRmRLVDFtbm85?= =?utf-8?B?Q3ArVnVxa3cranJEVWtXOEI4K28rYmxXTzBDeG1XNk8yUTY0NXoyUnJtVmxh?= =?utf-8?B?N0s0TzhQVlg1MlNsdW1KdGhGRXRsZmp1d0JOaFJBc1E5VWlpdys4TExEZjJz?= =?utf-8?B?MUNoQzM2T3hNVEVDeElrWDZiY25XQ1V4MHd0NWJKK1k1TFkvcnZNaUlZZVV6?= =?utf-8?B?UERJTnZHUVRsdHBmMU15RTZRMklVQy9aQVIwVERFMlhrTmgrU0M1SVVvaG1p?= =?utf-8?B?cjYvbDdVRkVnTVlFTk9IVlF4aWYwVlVITExIM2R6Y01rb05iWDVHOVlsdGdG?= =?utf-8?Q?GAdzV8sjMtAaHu2F5Gg+quY=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cadc511f-9e45-4424-5f54-08d9f84ed34f X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 11:06:08.8311 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4JjsEXqbkjmmnyARD1lU39agE8EE1jAkMNDJg5v1SKVjSV/2fvp0ljkl6fzqV7wJw6etugUUcGFZAloXCXTS9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6380 X-Spam-Status: No, score=-3032.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Feb 2022 11:06:14 -0000 Presently in this case, due to an undefined behavior shift, at least with x86 cross builds I'm observing: Error: value conflicts with instruction length `8,0x0000003f' Eliminate the UB and extend the respective testcase. --- a/gas/config/tc-riscv.c +++ b/gas/config/tc-riscv.c @@ -3248,7 +3248,7 @@ riscv_ip_hardcode (char *str, insn->match = values[num - 1]; create_insn (ip, insn); unsigned int bytes = riscv_insn_length (insn->match); - if (values[num - 1] >> (8 * bytes) != 0 + if ((bytes < sizeof(values[0]) && values[num - 1] >> (8 * bytes) != 0) || (num == 2 && values[0] != bytes)) return _("value conflicts with instruction length"); --- a/gas/testsuite/gas/riscv/insn.d +++ b/gas/testsuite/gas/riscv/insn.d @@ -71,5 +71,9 @@ Disassembly of section .text: [^:]+:[ ]+00c58533[ ]+add[ ]+a0,a1,a2 [^:]+:[ ]+0001[ ]+nop [^:]+:[ ]+00000013[ ]+nop +[^:]+:[ ]+001f 0000 0000[ ].* +[^:]+:[ ]+0000003f 00000000[ ].* [^:]+:[ ]+0001[ ]+nop [^:]+:[ ]+00000013[ ]+nop +[^:]+:[ ]+001f 0000 0000[ ].* +[^:]+:[ ]+0000003f 00000000[ ].* --- a/gas/testsuite/gas/riscv/insn.s +++ b/gas/testsuite/gas/riscv/insn.s @@ -56,5 +56,9 @@ target: .insn 0x0001 .insn 0x00000013 + .insn 0x0000001f + .insn 0x0000003f .insn 0x2, 0x0001 .insn 0x4, 0x00000013 + .insn 6, 0x0000001f + .insn 8, 0x0000003f