From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id D4E6C385841A for ; Mon, 1 Aug 2022 11:11:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D4E6C385841A Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-513-BHJohdcmNqSi9m7dMJ5o9A-1; Mon, 01 Aug 2022 07:11:35 -0400 X-MC-Unique: BHJohdcmNqSi9m7dMJ5o9A-1 Received: by mail-wm1-f70.google.com with SMTP id az39-20020a05600c602700b003a321d33238so5073798wmb.1 for ; Mon, 01 Aug 2022 04:11:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=lQkxM3F5OS8Wmt06qO+kSuGCZep7G+7LlLvm9zy96XI=; b=TsgAj8Ux47XUCn62VTWj0+DszYztQLatv3E7yt2DXYJw5Y55HBstEat3XBFa0z+U5z RF0OoRqm5beovFjGcaQSNSBZHKKcK2DHEcmpT6twcEoPplT4mialsCUdkU+DhDGjhSHg UKcyNnqDnqvjTXdv+GmgbhiwhREiSmZQs7LWRSLjmfPPAmlQeFSI/CcFA3crPn8AYkYj fXt/NlIdHCxPFdk5iq9KuX63ncalSfEXOy01zm3ewKi5iXmqP5IZNBLN/y52m1yKIUQA 5gtcESVrByPR4QONdKCvyTkC02EncdPdFYrz+YlGjYl5LldpBi/qcByC7G3QdzZfeH1q c+Fg== X-Gm-Message-State: AJIora/EfzvmtmAaiE6ggy2j80DX7NBfG4u/gAePjxXmQZdqpExa67Gl 15iCcrsGgjHTrd/mkGFmTHsuWrkgVChnyHwNDF297enzaShErByY1xQ7/fPD54czZq0wW2FPEad Iz5qeflzpfXim+Egmvg== X-Received: by 2002:a05:600c:503:b0:3a3:29ec:cd0 with SMTP id i3-20020a05600c050300b003a329ec0cd0mr10613607wmc.63.1659352294244; Mon, 01 Aug 2022 04:11:34 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sA6UlUo2v350ZRtG0BKH7Qu2RjB3XVj0g04KGVJeePSFFByWjJoHt7SeuOOU67zo/DwnDntg== X-Received: by 2002:a05:600c:503:b0:3a3:29ec:cd0 with SMTP id i3-20020a05600c050300b003a329ec0cd0mr10613598wmc.63.1659352294014; Mon, 01 Aug 2022 04:11:34 -0700 (PDT) Received: from [192.168.1.6] (adsl-2-solo-236-177.claranet.co.uk. [80.168.236.177]) by smtp.gmail.com with ESMTPSA id k13-20020a5d6d4d000000b0021d7ad6b9fdsm11491376wri.57.2022.08.01.04.11.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Aug 2022 04:11:33 -0700 (PDT) Message-ID: <6dbbfb87-203c-9b38-a854-6b53fce223a9@redhat.com> Date: Mon, 1 Aug 2022 12:11:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3 1/2] ld: Add support for a new option, -exclude-symbols, in COFF object file directives To: Martin Storsjo , binutils@sourceware.org References: <20220728133737.4049560-1-martin@martin.st> From: Nick Clifton In-Reply-To: <20220728133737.4049560-1-martin@martin.st> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Aug 2022 11:11:39 -0000 Hi Martin, > This maps to the same as ld's --exclude-symbols command line option, > but allowing specifying the option via directives embedded in the > object files instead of passed manually on the command line. > --- > v2: Fixed parsing multiple comma separated symbols. While pe_dll_add_excludes > does tokenize the string, the symbol tokens in deffilep.y don't > include commas, so we need to handle that at that level. > > v3: Added an x86_64 testcase too, changed i*86 into i?86 in the testcases. Patch approved - please apply. Cheers Nick