From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-61232-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 12269 invoked by alias); 28 Aug 2009 03:32:11 -0000
Received: (qmail 12261 invoked by uid 22791); 28 Aug 2009 03:32:10 -0000
X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 	tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from ey-out-1920.google.com (HELO ey-out-1920.google.com) (74.125.78.149)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 28 Aug 2009 03:32:04 +0000
Received: by ey-out-1920.google.com with SMTP id 5so370777eyb.24         for <binutils@sources.redhat.com>; Thu, 27 Aug 2009 20:32:01 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.216.86.85 with SMTP id v63mr120066wee.32.1251430321220; Thu,  	27 Aug 2009 20:32:01 -0700 (PDT)
In-Reply-To: <20090828031410.GC19523@bubble.grove.modra.org>
References: <20090828000233.GA23692@lucon.org> 	 <20090828031410.GC19523@bubble.grove.modra.org>
Date: Fri, 28 Aug 2009 05:50:00 -0000
Message-ID: <6dc9ffc80908272032p5b5a54a6h75caad74a27ffeda@mail.gmail.com>
Subject: Re: PATCH: PR ld/10569: -z max-page-size may not work for linker  	scripts
From: "H.J. Lu" <hjl.tools@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>, binutils@sources.redhat.com
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <binutils.sourceware.org>
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
X-SW-Source: 2009-08/txt/msg00518.txt.bz2

On Thu, Aug 27, 2009 at 8:14 PM, Alan Modra<amodra@bigpond.net.au> wrote:
> On Thu, Aug 27, 2009 at 05:02:33PM -0700, H.J. Lu wrote:
>> =A0 =A0 =A0 =A0PR ld/10569
>> =A0 =A0 =A0 =A0* ldlang.c (lang_add_output_format): Call
>> =A0 =A0 =A0 =A0bfd_emul_set_maxpagesize/bfd_emul_set_commonpagesize if
>> =A0 =A0 =A0 =A0maximum/common page sizes are specified and output target
>> =A0 =A0 =A0 =A0isn't the same as default target.
>
> I think this is the wrong place to call bfd_emul_set_maxpagesize
> (and the current call in elf32.em is wrong too). =A0You probably should
> be calling bfd_emul_set_maxpagesize in open_output. =A0Also,

Will open_output be called before any linker scripts are processed?

> bfd_emul_get_maxpagesize in fold_name shouldn't be using
> default_target. =A0Ditto for commonpagesize.
>

That is true. I will fix it.

--=20
H.J.