From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12050 invoked by alias); 31 Aug 2009 17:43:06 -0000 Received: (qmail 12041 invoked by uid 22791); 31 Aug 2009 17:43:05 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from fg-out-1718.google.com (HELO fg-out-1718.google.com) (72.14.220.154) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 31 Aug 2009 17:42:59 +0000 Received: by fg-out-1718.google.com with SMTP id d23so506132fga.8 for ; Mon, 31 Aug 2009 10:42:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.86.169.25 with SMTP id r25mr1162302fge.17.1251740576372; Mon, 31 Aug 2009 10:42:56 -0700 (PDT) In-Reply-To: <6dc9ffc80908301902y59e745f8jff2ec9f88ea07ac1@mail.gmail.com> References: <20090828000233.GA23692@lucon.org> <6dc9ffc80908272055l3daa1368l1f84cfafcc07c2de@mail.gmail.com> <20090828055016.GE19523@bubble.grove.modra.org> <6dc9ffc80908280640q35b52922gda316d43127b7ab7@mail.gmail.com> <20090828143141.GK19523@bubble.grove.modra.org> <6dc9ffc80908280737q3b02c3e1ybfec435dd9307512@mail.gmail.com> <20090830054221.GM19523@bubble.grove.modra.org> <6dc9ffc80908301142h6b7364cew9dca8f5198b366fa@mail.gmail.com> <20090831014723.GQ19523@bubble.grove.modra.org> <6dc9ffc80908301902y59e745f8jff2ec9f88ea07ac1@mail.gmail.com> Date: Mon, 31 Aug 2009 18:16:00 -0000 Message-ID: <6dc9ffc80908311042l486a5426sf38f23459de60340@mail.gmail.com> Subject: Re: PATCH: PR ld/10569: -z max-page-size may not work for linker scripts From: "H.J. Lu" To: "H.J. Lu" , binutils Content-Type: multipart/mixed; boundary=001636025e7d67d82404727390b5 X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00590.txt.bz2 --001636025e7d67d82404727390b5 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 1533 On Sun, Aug 30, 2009 at 7:02 PM, H.J. Lu wrote: > On Sun, Aug 30, 2009 at 6:47 PM, Alan Modra wrote: >> On Sun, Aug 30, 2009 at 11:42:20AM -0700, H.J. Lu wrote: >>> What should happen case where >>> >>> 1. No -z page size command line option is given. >>> 2. Output target is ELF and whose page size is different from default target. >>> >>> Your checkin changes the output page size to the page size of the default >>> target. >> >> Yes, I treat "--oformat other_elf" just the same as "--oformat srec". >> I don't really have a strong opinion as to what should be done in >> this case. >> > > It can also happen with > > OUTPUT_FORMAT("elf32-i386") > OUTPUT_ARCH(i386) > > in linker script and all input files are elf32-i386. I won't expect > the page size > won't be 4KB. This is a regression. > Here is a patch to call bfd_emul_set_maxpagesize and bfd_emul_set_commonpagesize only if they. OK to install? Thanks. -- H.J. --- 2009-08-31 H.J. Lu * ld.h (ld_config_type): Add maxpagesize_set and commonpagesize_set. * ldemul.c (set_output_arch_default): Call bfd_emul_set_maxpagesize/bfd_emul_set_commonpagesize only if config.maxpagesize_set/config.commonpagesize_set is TRUE. * ldmain.c (main): Initialize config.maxpagesize_set and config.commonpagesize_set to FALSE. * emultempl/elf32.em (gld${EMULATION_NAME}_handle_option): Set config.maxpagesize_set/config.commonpagesize_set to TRUE when config.maxpagesize/config.commonpagesize is set. --001636025e7d67d82404727390b5 Content-Type: text/plain; charset=US-ASCII; name="ld-page-size-3.patch" Content-Disposition: attachment; filename="ld-page-size-3.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fz1hx34j0 Content-length: 4201 MjAwOS0wOC0zMSAgSC5KLiBMdSAgPGhvbmdqaXUubHVAaW50ZWwuY29tPgoK CSogbGQuaCAobGRfY29uZmlnX3R5cGUpOiBBZGQgbWF4cGFnZXNpemVfc2V0 IGFuZAoJY29tbW9ucGFnZXNpemVfc2V0LgoKCSogbGRlbXVsLmMgKHNldF9v dXRwdXRfYXJjaF9kZWZhdWx0KTogQ2FsbAoJYmZkX2VtdWxfc2V0X2NvbW1v bnBhZ2VzaXplL2JmZF9lbXVsX3NldF9jb21tb25wYWdlc2l6ZSBvbmx5Cglp ZiBjb25maWcubWF4cGFnZXNpemVfc2V0L2NvbmZpZy5jb21tb25wYWdlc2l6 ZV9zZXQgaXMgVFJVRS4KCgkqIGxkbWFpbi5jIChtYWluKTogSW5pdGlhbGl6 ZSBjb25maWcubWF4cGFnZXNpemVfc2V0IGFuZAoJY29uZmlnLmNvbW1vbnBh Z2VzaXplX3NldCB0byBGQUxTRS4KCgkqIGVtdWx0ZW1wbC9lbGYzMi5lbSAo Z2xkJHtFTVVMQVRJT05fTkFNRX1faGFuZGxlX29wdGlvbik6IFNldAoJY29u ZmlnLm1heHBhZ2VzaXplX3NldC9jb25maWcuY29tbW9ucGFnZXNpemVfc2V0 IHRvIFRSVUUgd2hlbgoJY29uZmlnLm1heHBhZ2VzaXplL2NvbmZpZy5jb21t b25wYWdlc2l6ZSBpcyBzZXQuCgpJbmRleDogbGQvZW11bHRlbXBsL2VsZjMy LmVtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGxkL2VtdWx0ZW1wbC9l bGYzMi5lbQkocmV2aXNpb24gNjY2NykKKysrIGxkL2VtdWx0ZW1wbC9lbGYz Mi5lbQkod29ya2luZyBjb3B5KQpAQCAtMjE3OCw2ICsyMTc4LDcgQEAgZnJh Z21lbnQgPDxFT0YKIAkgIGlmICgqZW5kIHx8IChjb25maWcubWF4cGFnZXNp emUgJiAoY29uZmlnLm1heHBhZ2VzaXplIC0gMSkpICE9IDApCiAJICAgIGVp bmZvIChfKCIlUCVGOiBpbnZhbGlkIG1heGl1bSBwYWdlIHNpemUgXGAlcydc biIpLAogCQkgICBvcHRhcmcgKyAxNCk7CisJICBjb25maWcubWF4cGFnZXNp emVfc2V0ID0gVFJVRTsKIAl9CiAgICAgICBlbHNlIGlmIChDT05TVF9TVFJO RVEgKG9wdGFyZywgImNvbW1vbi1wYWdlLXNpemU9IikpCiAJewpAQCAtMjE4 Nyw2ICsyMTg4LDcgQEAgZnJhZ21lbnQgPDxFT0YKIAkgICAgICB8fCAoY29u ZmlnLmNvbW1vbnBhZ2VzaXplICYgKGNvbmZpZy5jb21tb25wYWdlc2l6ZSAt IDEpKSAhPSAwKQogCSAgICBlaW5mbyAoXygiJVAlRjogaW52YWxpZCBjb21t b24gcGFnZSBzaXplIFxgJXMnXG4iKSwKIAkJICAgb3B0YXJnICsgMTcpOwor CSAgY29uZmlnLmNvbW1vbnBhZ2VzaXplX3NldCA9IFRSVUU7CiAJfQogICAg ICAgLyogV2hhdCBhYm91dCB0aGUgb3RoZXIgU29sYXJpcyAteiBvcHRpb25z PyBGSVhNRS4gICovCiAgICAgICBicmVhazsKSW5kZXg6IGxkL2xkLmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gbGQvbGQuaAkocmV2aXNpb24gNjY2 NSkKKysrIGxkL2xkLmgJKHdvcmtpbmcgY29weSkKQEAgLTI4MCw4ICsyODAs MTQgQEAgdHlwZWRlZiBzdHJ1Y3QgewogICAvKiBUaGUgbWF4aW11bSBwYWdl IHNpemUgZm9yIEVMRi4gICovCiAgIGJmZF92bWEgbWF4cGFnZXNpemU7CiAK KyAgLyogVGhlIG1heGltdW0gcGFnZSBzaXplIGZvciBFTEYgaXMgc2V0LiAg Ki8KKyAgYmZkX2Jvb2xlYW4gbWF4cGFnZXNpemVfc2V0OworCiAgIC8qIFRo ZSBjb21tb24gcGFnZSBzaXplIGZvciBFTEYuICAqLwogICBiZmRfdm1hIGNv bW1vbnBhZ2VzaXplOworCisgIC8qIFRoZSBjb21tb24gcGFnZSBzaXplIGZv ciBFTEYgaXMgc2V0LiAgKi8KKyAgYmZkX2Jvb2xlYW4gY29tbW9ucGFnZXNp emVfc2V0OwogfSBsZF9jb25maWdfdHlwZTsKIAogZXh0ZXJuIGxkX2NvbmZp Z190eXBlIGNvbmZpZzsKSW5kZXg6IGxkL2xkbWFpbi5jCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIGxkL2xkbWFpbi5jCShyZXZpc2lvbiA2NjY3KQor KysgbGQvbGRtYWluLmMJKHdvcmtpbmcgY29weSkKQEAgLTI4MSw3ICsyODEs OSBAQCBtYWluIChpbnQgYXJnYywgY2hhciAqKmFyZ3YpCiAgIGxkZW11bF9j aG9vc2VfbW9kZSAoZW11bGF0aW9uKTsKICAgZGVmYXVsdF90YXJnZXQgPSBs ZGVtdWxfY2hvb3NlX3RhcmdldCAoYXJnYywgYXJndik7CiAgIGNvbmZpZy5t YXhwYWdlc2l6ZSA9IGJmZF9lbXVsX2dldF9tYXhwYWdlc2l6ZSAoZGVmYXVs dF90YXJnZXQpOworICBjb25maWcubWF4cGFnZXNpemVfc2V0ID0gRkFMU0U7 CiAgIGNvbmZpZy5jb21tb25wYWdlc2l6ZSA9IGJmZF9lbXVsX2dldF9jb21t b25wYWdlc2l6ZSAoZGVmYXVsdF90YXJnZXQpOworICBjb25maWcuY29tbW9u cGFnZXNpemVfc2V0ID0gRkFMU0U7CiAgIGxhbmdfaW5pdCAoKTsKICAgbGRl bXVsX2JlZm9yZV9wYXJzZSAoKTsKICAgbGFuZ19oYXNfaW5wdXRfZmlsZSA9 IEZBTFNFOwpJbmRleDogbGQvbGRlbXVsLmMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gbGQvbGRlbXVsLmMJKHJldmlzaW9uIDY2NjcpCisrKyBsZC9s ZGVtdWwuYwkod29ya2luZyBjb3B5KQpAQCAtMjI5LDggKzIyOSwxMCBAQCBz ZXRfb3V0cHV0X2FyY2hfZGVmYXVsdCAodm9pZCkKICAgYmZkX3NldF9hcmNo X21hY2ggKGxpbmtfaW5mby5vdXRwdXRfYmZkLAogCQkgICAgIGxkZmlsZV9v dXRwdXRfYXJjaGl0ZWN0dXJlLCBsZGZpbGVfb3V0cHV0X21hY2hpbmUpOwog Ci0gIGJmZF9lbXVsX3NldF9tYXhwYWdlc2l6ZSAob3V0cHV0X3RhcmdldCwg Y29uZmlnLm1heHBhZ2VzaXplKTsKLSAgYmZkX2VtdWxfc2V0X2NvbW1vbnBh Z2VzaXplIChvdXRwdXRfdGFyZ2V0LCBjb25maWcuY29tbW9ucGFnZXNpemUp OworICBpZiAoY29uZmlnLm1heHBhZ2VzaXplX3NldCkKKyAgICBiZmRfZW11 bF9zZXRfbWF4cGFnZXNpemUgKG91dHB1dF90YXJnZXQsIGNvbmZpZy5tYXhw YWdlc2l6ZSk7CisgIGlmIChjb25maWcuY29tbW9ucGFnZXNpemVfc2V0KQor ICAgIGJmZF9lbXVsX3NldF9jb21tb25wYWdlc2l6ZSAob3V0cHV0X3Rhcmdl dCwgY29uZmlnLmNvbW1vbnBhZ2VzaXplKTsKIH0KIAogdm9pZAo= --001636025e7d67d82404727390b5--