From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id DC1403858D20 for ; Thu, 16 Nov 2023 02:07:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DC1403858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DC1403858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700100447; cv=none; b=XW49sDr7mAigWRufp/m5CbtXbN5nN7/I/p4FjoA4qcIezolpdmbqHdRUa/TIBLMg9SIleo3gdFUhbYpkWeGIU7xnEy1XyJD1gDylMXC4hWibz1GHd/poAJvRFx9yyrl87SI6kRjB+/Ed6bIamkt0JbxDKMVZ2TkudzpMFqSSrV8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700100447; c=relaxed/simple; bh=KDR/xOaPwtBk8cZsPGf0NsYLa6SiDLw5hLkkohSS8wQ=; h=Subject:To:From:Message-ID:Date:MIME-Version; b=Nxrzd7Xu86xlmxyFMW8r2T9b0nFEzdqSPRZewtfNU03W3JW/rdiB2N6b4Dr2uZ+SUx5xYcN8wQ4FSq7adSgFoCI1iicc0FXibRExM9u2gbD8w1kwJttlc8yFW5xmylszUDx6UEIa/v4ae5/0k9MfnAn098tnxCXJz5JNVrHcQFc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from loongson.cn (unknown [10.20.4.171]) by gateway (Coremail) with SMTP id _____8DxVuhbeVVllm86AA--.14523S3; Thu, 16 Nov 2023 10:07:23 +0800 (CST) Received: from [10.20.4.171] (unknown [10.20.4.171]) by localhost.localdomain (Coremail) with SMTP id AQAAf8CxeuRaeVVlF5tDAA--.19181S3; Thu, 16 Nov 2023 10:07:23 +0800 (CST) Subject: Re: [PATCH 4/5] LoongArch: Remove "elf_seg_map (info->output_bfd) == NULL" relaxation condition To: Xi Ruoyao , binutils@sourceware.org Cc: xuchenghua@loongson.cn, chenglulu@loongson.cn, liuzhensong@loongson.cn, i.swmail@xen0n.name, maskray@google.com, cailulu@loongson.cn References: <20231013082445.290062-1-mengqinggang@loongson.cn> <20231013082445.290062-4-mengqinggang@loongson.cn> <23e214a61579094d9367f7b089f9e139378f4b5e.camel@xry111.site> <306c2568-29bf-83e8-7f6e-68bf578fa5b1@loongson.cn> <061e6e6227f26aeacf09a73ed5037e33d90e87bf.camel@xry111.site> From: mengqinggang Message-ID: <6dfd930b-7a7d-cb52-abb5-e8bd3c652dc5@loongson.cn> Date: Thu, 16 Nov 2023 10:06:52 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <061e6e6227f26aeacf09a73ed5037e33d90e87bf.camel@xry111.site> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8CxeuRaeVVlF5tDAA--.19181S3 X-CM-SenderInfo: 5phqw15lqjwttqj6z05rqj20fqof0/ X-Coremail-Antispam: 1Uk129KBj93XoWxCr4rtFyDZryUZF1Dtr45CFX_yoW5GFyxpr yvkFyfJFWrXwn5Jw1jqw1UWryDK348K3Wjqr1YgFyxAr4qvr12gF4Fgryq9F1UGw4fAr1j vF18Ja17ZF1xAabCm3ZEXasCq-sJn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUvYb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVWxJVW8Jr1l84ACjcxK6I8E87Iv6xkF7I0E14v2 6r4j6r4UJwAS0I0E0xvYzxvE52x082IY62kv0487Mc804VCY07AIYIkI8VC2zVCFFI0UMc 02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAF wI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JMxk0xIA0c2IEe2xFo4 CEbIxvr21l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG 67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r43MI IYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E 14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJV W8JwCI42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x07UE-erU UUUU= X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,BODY_8BITS,GIT_PATCH_0,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I will send a new patch today, it fix some bugs caused by address changed. 在 2023/11/16 上午8:03, Xi Ruoyao 写道: > On Mon, 2023-10-30 at 16:00 +0800, mengqinggang wrote: >> There are still some other modifications that need to be addend, >> and prepare to test whether a clfs system can be successfully >> compiled. > Ping again. We are very close to the end of GCC 14 stage 1, and we need > to determine if we should default to -mno-relax for -fpic (i. e. > disabling relaxation for anything that may be used in a shared object). > Silently producing broken shared object is not acceptable. > >> 在 2023/10/30 下午1:14, Xi Ruoyao 写道: >>> Ping. >>> >>> Is there any reason holding this patch? >>> >>> On Thu, 2023-10-19 at 22:04 +0800, Xi Ruoyao wrote: >>>> Hi, >>>> >>>> I don't know BFD very well, but IMO this should be applied and >>>> backported to 2.41 ASAP because "not relaxing shared objects" is a >>>> very >>>> serious issue. >>>> >>>> On Fri, 2023-10-13 at 16:24 +0800, mengqinggang wrote: >>>>> --- >>>>>   bfd/elfnn-loongarch.c | 6 +++++- >>>>>   1 file changed, 5 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c >>>>> index 47334943fde..38a25b63813 100644 >>>>> --- a/bfd/elfnn-loongarch.c >>>>> +++ b/bfd/elfnn-loongarch.c >>>>> @@ -3747,6 +3747,11 @@ loongarch_relax_pcala_addi (bfd *abfd, >>>>> asection *sec, >>>>>     uint32_t pca = bfd_get (32, abfd, contents + rel_hi->r_offset); >>>>>     uint32_t add = bfd_get (32, abfd, contents + rel_lo->r_offset); >>>>>     uint32_t rd = pca & 0x1f; >>>>> + >>>>> +  /* Because previous sections' relax, output_offset may increase >>>>> and need to >>>>> +     be updated before relax. But it update after relax in >>>>> +     size_input_section defaultly, so we manually updating here. >>>>> */ >>>>> +  sec->output_offset = sec->output_section->size; >>>>>     bfd_vma pc = sec_addr (sec) + rel_hi->r_offset; >>>>>     const uint32_t addi_d = 0x02c00000; >>>>>     const uint32_t pcaddi = 0x18000000; >>>>> @@ -3889,7 +3894,6 @@ loongarch_elf_relax_section (bfd *abfd, >>>>> asection *sec, >>>>>         || sec->sec_flg0 >>>>>         || (sec->flags & SEC_RELOC) == 0 >>>>>         || sec->reloc_count == 0 >>>>> -      || elf_seg_map (info->output_bfd) == NULL >>>>>         || (info->disable_target_specific_optimizations >>>>>      && info->relax_pass == 0) >>>>>         /* The exp_seg_relro_adjust is enum phase_enum (0x4),