From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2051.outbound.protection.outlook.com [40.107.8.51]) by sourceware.org (Postfix) with ESMTPS id 7307F3858D1E for ; Mon, 17 Jul 2023 07:08:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7307F3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iFdrU8tkz5EtlzUKP4EoaHb5pguh7NNL+gWnrW+ePH1zeUprrNB4L2tloR+wGBYHKEVjrRBluoAosFs5HFo3Oz9F8mGk2yM9X9Cb0LkOA3hzs1kUJ3hqfUiBl/BiRQUXDTh4M8jRSjFFbyhIENIoOf5i+dE5t+Nvoaqic9/BExndNBhmK4Wjev762rlbjMNa9qfYlQnPZKtPipPAGXic9XC2hM0gj/mJgy/1F3aiEZMBBewM0acYvAexHVm9RKI1tdOdHb6qfBemX0SVKkbuQz/GFbZlHWr9z5C1aE1/TRXVSsshVeZQRzrXPZnLnsmNW7jFSLxzAx2ty0lFh2thFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8zO7+EMda6mroOv5IZQ+9pZhCHXyJmrLbAbOTBDVaOw=; b=TvA1c/ZRIyV2fPfBbTH2OnARZN0t0T+9fL2k5yrwapTMRw0Juu9+Q8P908BRUWlkzbtIpLMJOp+XZTecqSlyXkPxpGydd1pW/m/JLi3+IjkgTG3j4YRXN8/+q+PONZtyr12vBtfqaWltKK74W6ICERA5p2gmt3d89vz6teEV4mCRiwepD5gVRdocKgvtmp3F+C5HRn3XvfKEyjAC4QT6sFlNboKeE1UkRdeuPuvLM8EmyJyuEwjXO5/Jm6Jgc+iDZM1lp9GY93P53J8pC3Yf9pjVlmQ6ptnKDHvKyXzmnLaF40LMnoWLUGzVEGmXmouoI/jRIxt+Xjb9k1G+NGY/Tg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8zO7+EMda6mroOv5IZQ+9pZhCHXyJmrLbAbOTBDVaOw=; b=XxMoKVkJb6SNOxdPGErJUByadlbFtvYu3LL6JPndlgmh268DOS15+u0harZ4AF+Ql9YbCEyHaY8F5xOWni3JoC5vVG+QFysGoMhXHZBZJdZO0uyEkciEDQfC933BW5EzBl5nH1AKhubCa0dT1GKJBlQzbjP5nbI5GyKVO9+N6AQdpoDKo61XN7tTPW3EeOHnbwgte5pn16oElLtlP3+N2Ebn+AsscKyNsTtAtjcjMDPJ1RePo/92NSb28ktUL8F+eywS82orj6YNhMTR3NbrQ9KIHdL70LG/2pwyrCAaw45Cn1xWfrMtEjppAajV3IegZsNZa5VAKSSbT41trGQjrw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS8PR04MB7831.eurprd04.prod.outlook.com (2603:10a6:20b:2a8::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.31; Mon, 17 Jul 2023 07:08:51 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::9bd3:48c9:ff58:9880]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::9bd3:48c9:ff58:9880%4]) with mapi id 15.20.6588.031; Mon, 17 Jul 2023 07:08:51 +0000 Message-ID: <6e5ddbfd-4060-edff-39ba-f3446b210eb5@suse.com> Date: Mon, 17 Jul 2023 09:08:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 2/2] x86: adjust disassembly of insns operating on selector values Content-Language: en-US To: "Jiang, Haochen" Cc: "H.J. Lu" , Binutils References: <3f44f9a7-2f4c-d92d-ec19-5023f317357a@suse.com> <7cc1eda0-713d-9172-c3ed-078e0899b0c4@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0176.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9f::14) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS8PR04MB7831:EE_ X-MS-Office365-Filtering-Correlation-Id: 40f65186-cee6-4c2d-cee5-08db8694acda X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kTBZqyf7wjLZsdsMiJZrOXKUEVaPwdKr9bwlgt47Cpnzz3aAXMRAOoI5XMTqSy5tb9wbE2amljFP8dBjPEMXakxiPpd+bj3sf1ogIQr6CdW+iqdXjaR1t0hj6osp11zWRhw/xs60OlEzEk0lHdrmrXocuoq6xqQ0lEbZwpY6HeRHR0VhFePJ/MmjULPuDnogmWI0H6LB9Jt4UM5x7tqyqXr94r5CuxNnC2DkOzyG2hmy084ZQT3xdK/q35qnww2l8ajMcP7hMA/tBShSHIkYjsjdOuzfd3pgmQDgTRqAatldVEL0ixOdAPcVJvyNjM8C2FvZLwLIprVkBt8rPbhXfV5wGQHGg4k6h+23l3Szm5sx+fwr/V+Owi6RUO6rB6ZQ6IQ4wXDBskf9yiP9KectyKl/oqrPwi6T++3OppTW8ozpVK5KbC2RjzPcDUJD+LAfs8j/ZTnfjifwEjPlNxpYWYaJq1TWC51R6/t5PWRmWqYu/kz06Ikdq/vI7SeKYxhJeqrhl1TT1E4Rbnff+ybFqTKgl+Cgsf03hMXMW/W8G3ZnQOnS3zEVZuSignosdJ+8LUjWMpOGoEazIPxsBW1+IIiRH8bt+PjPmwK3mSgmavjpFjB6p3g7VIBZyaZkLYjB94eW99GoXG5G+EBu/5bWbg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(366004)(136003)(39860400002)(376002)(396003)(451199021)(478600001)(66556008)(66476007)(66946007)(54906003)(5660300002)(4326008)(6916009)(316002)(8676002)(8936002)(2906002)(41300700001)(31686004)(6512007)(26005)(6506007)(53546011)(6486002)(38100700002)(186003)(2616005)(36756003)(86362001)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWtTQUlhS1lZM2FNdExvVGdKS05OaCs1NmVlVGprYXVNVDZwSmwrSGc5ZjFs?= =?utf-8?B?SzhpbElIYXM5Ky85WkR6RUM2OVk0cjVacVhrSHhSWllsaGFuLzdQbEU4SWJV?= =?utf-8?B?b3I5amhQeHVnZCtCNDVBbkQySURyRE1WcmpoblZHajNnOWJtdUVwMHJoREk1?= =?utf-8?B?ek03cndiV0xJS1NaV3ZnR1JpSEVONy9BVlhtWEtNR1RmWjdiZDJUYVVsaW1G?= =?utf-8?B?WXlYUTdRcHA1dW44VlREV2VNeFZuQW9pcnlEVFVVd29Mc1laV2xJdWY1Qy9V?= =?utf-8?B?ZzF1b3FZeU5kYWJudVZOUWFGNXZVN01pSTVJWVhMajJINU1iR1VZZjlnclg5?= =?utf-8?B?djBVU3RKd2V5WXV2M3RTNGw4MlV3ZS9EcERCSDNHdmFoenZaMUxRZC9zcVFu?= =?utf-8?B?TTkxajBiclVBRkRvUlI3Tm85OVFpNjdmYWlWZlkwbUVTaHA5RmNTQktMdy9W?= =?utf-8?B?ekZBZjZEdVBXMTNCVVMydE1Od2dvYk4yS2FySWhSMXhvMkxiMkZZeEs2Y2U2?= =?utf-8?B?di82WXVaVHBvRmtSR2FvM2h1OGRNNEJaOHJiZ2ZzQit4U0s0emczS2lNaDZV?= =?utf-8?B?VWJtTkZOQmVOZlhsYXJLMjBHMkIzWUM2NGpCb0xyK2lvVGEvdUREVmViMFNu?= =?utf-8?B?SVp0YjV5MUtrQUtaK3JrZWFHT0FHT0ZWQXdkNTR0ZVVsbkdQMHBlQ2FZZytW?= =?utf-8?B?Ukdtc1hqRFFSUytGNDh3dHA5OTZCUmd4NmlITDlnTklwZUZGYy9DSGd5ZWI0?= =?utf-8?B?YmxEeXJjLy9QekgvRUhxdCtCak9PZkJndHdkdC9JUnFEMkh6UW5SVGN5dkJY?= =?utf-8?B?Vk1DTGM2VERRRW9KQWtjcnA4Y0YyZmxtL1pMOWliWnpvUmg2dExCSW1HaXlH?= =?utf-8?B?Q0ZTcVZYZXJMZnpZSmhQbjc3TGhmZ2hFcm54YThLaGhHZnYvSkxtdXk5MG5H?= =?utf-8?B?czhSWEUzUTMrQmFiTVBhZVdNSXdHZEZQTlYya0pTZ0NKTEg5VDBrQ0cvbktQ?= =?utf-8?B?ZDcxY2JLUlQyRmQ5VDhvYitZUnMwckNIelZwMzZ4cE5kMDZsOFgrOHQzV1R1?= =?utf-8?B?dlJ6OHdJQ21XN2xKdlBBKzRMbkJVYmhXaUx4eU9rZXE5Y08rcHdmejVBN0ta?= =?utf-8?B?TmJnQm92aHE5YWd2aTQvQmM4QWhsTmdyRHlNY1NJVHMreFZLQWVzVUN2Nmlr?= =?utf-8?B?ck9QZVJBU1FPUTNrRHNpSStBUm5odkNZNzJZT05veVNFUXAySU9ESVlkTW0x?= =?utf-8?B?WUkrTW5lR1dLK3Zza3VLa0xNQTNqSlRlTG5tNUYvU2NWd2pGa0pTSW9veE1j?= =?utf-8?B?R2o3d2R1MWh1V0ZVNlM3Ly92Tng0LzJTZlNEV04rUEx2ZExNT2IxQkRsRmVD?= =?utf-8?B?RmltOWlmSUhMNHhnejRhOVBSdVdUeWc5eFZ5MXIycU90Z2F4bkIyRmVkd1dM?= =?utf-8?B?Nm5WajdqQ1Q0L3dTQW15emdzSis2VmxvZ3R5aWNxQWdHbEcyT0VhaFJ6a1Bu?= =?utf-8?B?WE5meE1xS2lKYlFreHo2bldCTkJsemdwRXJ4d0s0b2xjQ2FJTWx2R2poYzBp?= =?utf-8?B?S0p3bXkrU1ZNNHduV3pMRnJhZmZEK0lrM0s2eUtlRmZGckxHTDZ2OHJ4OWRE?= =?utf-8?B?R3pWa2p0UlJ0R010Yy94WHgrd2hlQUJmYk83QTRLU0lJK3pucGdqVkt6bmFr?= =?utf-8?B?c3RQZGRYVDA3QzEwOThBd1pqM09sekRXaldUZzVQWlZlYjVCYUJLTEhLWFlu?= =?utf-8?B?ZTBlaWdoTy93NGFjbnZQc016REJ5RzNKQk1TUUQxTmkrK3R2d0FIZmwwNVFF?= =?utf-8?B?Sk0xcGJNeGpOREpSUWNDcFVndUpNblUyVzFuRjRtMXVtQXhpdExDbEN0RFh3?= =?utf-8?B?aGgzclNDd1cybWhOUXNaaHFGOW9oN2FleTJUTkQ5aDhTQUJ2bUE4cjFXSGdW?= =?utf-8?B?aWRZSVg5amExUElHN01DNHVhNFRSTXRXdjRpR2tOejF6aGphUUZzQ3hYRko5?= =?utf-8?B?dmlwdkZWSXZMR2M0blcyQ1FDODR4SmtFY1gzSmNINElBd0pkVHBSdkdCYkdX?= =?utf-8?B?aS80UFFjV2NIeFBOOGh6aFpOeCs0V3gwTXV3RnZzUnlWK2JPaUZMUC91OFk1?= =?utf-8?Q?sl2ODIevfa/1BLqgLbRvOF8tF?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 40f65186-cee6-4c2d-cee5-08db8694acda X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2023 07:08:51.7424 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5dwGbiRJlmrQx/Xuy65Qai/sQBO+BHWDGcEmuUYOGX2Upriw1iV5O2ElyCUHtn54jsgGvCfxpRKGi8809S1SuA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7831 X-Spam-Status: No, score=-3027.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 17.07.2023 04:04, Jiang, Haochen wrote: >> --- a/gas/testsuite/gas/i386/opcode-suffix.d >> +++ b/gas/testsuite/gas/i386/opcode-suffix.d >> @@ -102,7 +102,7 @@ Disassembly of section .text: >> *[0-9a-f]+: 60[ ]+pushal >> *[0-9a-f]+: 61[ ]+popal >> *[0-9a-f]+: 62 90 90 90 90 90[ ]+boundl %edx,-0x6f6f6f70\(%eax\) >> - *[0-9a-f]+: 63 90 90 90 90 90[ ]+arpl[ ]+%dx,-0x6f6f6f70\(%eax\) >> + *[0-9a-f]+: 63 90 90 90 90 90[ ]+arpll[ ]+%edx,- >> 0x6f6f6f70\(%eax\) >> *[0-9a-f]+: 68 90 90 90 90[ ]+pushl[ ]+\$0x90909090 >> *[0-9a-f]+: 69 90 90 90 90 90 90 90 90 90[ ]+imull[ >> ]+\$0x90909090,-0x6f6f6f70\(%eax\),%edx >> *[0-9a-f]+: 6a 90[ ]+pushl[ ]+\$0xffffff90 >> @@ -248,7 +248,7 @@ Disassembly of section .text: >> *[0-9a-f]+: fc[ ]+cld >> *[0-9a-f]+: fd[ ]+std >> *[0-9a-f]+: ff 90 90 90 90 90[ ]+calll[ ]+\*-0x6f6f6f70\(%eax\) >> - *[0-9a-f]+: 0f 00 90 90 90 90 90[ ]+lldt[ ]+-0x6f6f6f70\(%eax\) >> + *[0-9a-f]+: 0f 00 90 90 90 90 90[ ]+lldtw[ ]+-0x6f6f6f70\(%eax\) > > H.J. is on vacation till Wednesday but I suppose H.J. has this question in my patch > before and he might raise again if he is here. > > Is this suffix needed since m16 is the only allowed memory here? All suffixes should be appended in suffix-always mode. The question of whether one can be omitted arises only in the default mode, where optional suffixes are left off (for clarity / ease of reading). Plus please recall that the changes here are for consistency, and e.g. in *[0-9a-f]+: 8c 90 90 90 90 90[ ]+movw[ ]+%ss,-0x6f6f6f70\(%eax\) the suffix is also present, no matter that only m16 is possible. In any event I'm not intending to commit this before the end of the week, so H.J. will have a chance to voice his opinion. Jan