From: Jan Beulich <jbeulich@suse.com>
To: Srinath Parvathaneni <srinath.parvathaneni@arm.com>
Cc: Nick Clifton <nickc@redhat.com>,
Richard Earnshaw <richard.earnshaw@arm.com>,
Binutils <binutils@sourceware.org>
Subject: Re: [PATCH v1 1/2][Biuntils] aarch64: Fix sve2p1 dupq/extq instructions encoding and syntax.
Date: Mon, 26 Feb 2024 10:57:17 +0100 [thread overview]
Message-ID: <6f490333-8649-4d70-9c69-5ffe7467c670@suse.com> (raw)
In-Reply-To: <15bd8211-0e3c-4aed-b316-5749d32f6fb7@arm.com>
On 23.02.2024 14:57, Srinath Parvathaneni wrote:
> This patch enables "FEAT_SVE2p1" by default for Armv9.4-A and fixes the
> encoding
> and syntax for sve2p1 "dupq" and "extq" instructions which were reported
> here.
I can't spot any encoding change. Or wait - it's operand encoding which
changes for dupq and syntax which changes for extq.
I'm also unconvinced the insn adjustments should be folded with the 9.4-A
related adjustment.
But I'm not an Arm64 maintainer, so neither of my comments (nor anything
else I might have to say, if only the patch was supplied inline to make
it easy to comment) matters overly much anyway.
Jan
> https://sourceware.org/pipermail/binutils/2024-February/132408.html
>
> Regression testing for aarch64-none-elf target and found no regressions.
>
> Ok for binutils-master? Also ok to be backported to binutils-2.42 branch?
>
> Regards,
> Srinath.
next prev parent reply other threads:[~2024-02-26 9:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 13:57 Srinath Parvathaneni
2024-02-23 13:59 ` [PATCH v1 2/2][Binutils] aarch64: Fix sve2p1 ld[1-4]q/st[1-4]q " Srinath Parvathaneni
2024-02-26 10:10 ` Jan Beulich
2024-02-26 9:57 ` Jan Beulich [this message]
2024-02-27 19:08 ` [PATCH v1 1/2][Biuntils] aarch64: Fix sve2p1 dupq/extq " Andrew Carlotti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f490333-8649-4d70-9c69-5ffe7467c670@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
--cc=richard.earnshaw@arm.com \
--cc=srinath.parvathaneni@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).