From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 613033858413 for ; Mon, 20 Nov 2023 14:32:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 613033858413 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 613033858413 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700490766; cv=none; b=papX8GPFLeFnzGvmhpkrDvelApnP7Q/p3vYnZ/ocmygVN020xe1qMM3Wq3jw5CqnEkLX6NkqFLsqjMWAzpCdQwlYYfXh9LCTxbkTqBnbMP8WTaa24qs54OF4ROWKuGONwwdW9MM2NqnYSwgsPcYw5joZmL/b6q+Snn7R2jZkzsU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700490766; c=relaxed/simple; bh=LcuDGiwHgPB+03p7p99T/pdX+U8oztam8APq3ZFtwnA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=hn4CeyDTaMGzszmTfOWmd53Ul147GPNdNRRdlleOdBojXubvBxgQBCMW+fUtAYM5zXAaGPXFp7ep2jXzFpUnzZJTwYZxR4FI1copIKHh3ZlZVgHcmbMEkbjfOfFt9KPxKU1pckldUvTvhzlWG8EqnnMAl557Pebg3LBYLdpGtWE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700490765; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=TalaRJRMggUHHdGr1HbQ81d7X47UOuAyD93watOZR6c=; b=HIUrV8mWnqlmX4d7+cqnqnzg/mGmKxxc6fvZvPN43KC0VNKRd7K1/9t1AKfempcvQ0/Zjw /MhdaPgwk/nMV1YEt7dm82fnNmwnXf9cZa86k4AhJUJ4EtV/XStibJQNq+XpbltjNb7O0E FxM+upn5D+Dwc7UKVp0EKvBOMu4zy54= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-66-YEqjpUqeOhO13J20x8BWFA-1; Mon, 20 Nov 2023 09:32:43 -0500 X-MC-Unique: YEqjpUqeOhO13J20x8BWFA-1 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-421b20c9893so64283801cf.0 for ; Mon, 20 Nov 2023 06:32:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700490763; x=1701095563; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TalaRJRMggUHHdGr1HbQ81d7X47UOuAyD93watOZR6c=; b=jiwpoGSvHHpDYR/iymRSS4jYnjOlyvbEi845wSFZaP0cn82ebk0f7+qdcXj4wgBaWF Grw6cuBWq0cSSO8XOWgilw5A0mKFp5V8YnZdVn6bkSdlEQneGQN7nfH0vAzXLHvxkOBi ur2D/rgRhwlqR5qQz7+Ctb6LYi/BJMV01HCde9+Da6cxPsBFFwB7g9hBrtIKtsVzxYf2 RlnsuwlrGrNZcJ90k8nadtOT7MgaEkzp9HAfnvxwEjVSBmgci1Nb2iXKcB9IM7GLk4aT Dx8lt0nwJ4gla0RDgLlk1I1aKa2TsdSDzFhEB0JcpPWw7Sc4+KbEKSitQMN9WRnkGSa1 wqjg== X-Gm-Message-State: AOJu0YzPUmL1sFK+qI/XPCt8/+SZ2EjeQ1ueE00HbXCmhcs7d945XXv5 RLlTi1r57LELhhtH2f8arBD5183aZ6Fy5956yHdQnCW/WLVR0pyrhyKTGdfXz43rl0j9oCuq7OM dfJZuwIAXBjQVA1Gyzqz1a0g1yA== X-Received: by 2002:a05:622a:353:b0:418:1059:dfbc with SMTP id r19-20020a05622a035300b004181059dfbcmr9571971qtw.45.1700490762938; Mon, 20 Nov 2023 06:32:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IE6OipGN+/fJomLSrt1fc6w4LmwIqDnNjdFhlznNNLRYD064Ct612FDelgSNzLLMQdAhjcM1w== X-Received: by 2002:a05:622a:353:b0:418:1059:dfbc with SMTP id r19-20020a05622a035300b004181059dfbcmr9571954qtw.45.1700490762697; Mon, 20 Nov 2023 06:32:42 -0800 (PST) Received: from [192.168.1.11] ([80.168.197.243]) by smtp.gmail.com with ESMTPSA id ks23-20020ac86217000000b00419ab6ffedasm2673196qtb.29.2023.11.20.06.32.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Nov 2023 06:32:42 -0800 (PST) Message-ID: <6f60fc6b-1bce-4344-a906-d3ed3489aae4@redhat.com> Date: Mon, 20 Nov 2023 14:32:40 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bad patch - also not on list? To: Tom Tromey , binutils@sourceware.org Cc: Vsevolod Alekseyev References: <87leatymeo.fsf@tromey.com> From: Nick Clifton Autocrypt: addr=nickc@redhat.com; keydata= xsFNBFm/2cUBEADkvRqMWfAryJ52T4J/640Av5cam9ojdFih9MjcX7QWFxIzJfTFYq2z+nb4 omdfZosdCJL2zGcn6C0AxpHNvxR9HMDkEyFHKrjDh4xWU+pH4z9azQEqJh331X7UzbZldqQo 16VkuVavgsTJaHcXm+nGIBTcUbl2oiTtHhmuaYxx6JTMcFjC7vyO5mLBw78wt52HBYweJ0Nj HBvvH/JxbAAULSPRUC61K0exlO49VFbFETQNG1hZTKEji95fPbre7PpXQ0ewQShUgttEE/J3 UA4jYaF9lOcZgUzbA27xTV//KomP0D30yr4e4EJEJYYNKa3hofTEHDXeeNgM25tprhBUMdbV RZpf2Keuk2uDVwc+EiOVri48rb1NU+60sOXvoGO6Ks81+mhAGmrBrlgLhAp8K1HPHI4MG4gH nrMqX2rEGUGRPFjC3qqVVlPm8H05PnosNqDLQ1Pf7C0pVgsCx6hKQB7Y1qBui7aoj9zeFaQg pYef+CEERIKEcWwrjaOJwK3pi9HFdxS0NNWYZj8HPzz/AsgTTQdsbulPlVq2SsctmOnL42CZ OCTppGYwl53CG/EqVY+UQBzFzJBaY8TJRFFYVEy5/HH4H11rMoZwqIkk71EOGU3X6mWlANRi kR3M4GhVITRzuaV69Fed+OeXcCmP94ASLfuhBR2uynmcHpBKpwARAQABzTtOaWNrIENsaWZ0 b24gKENoaWVmIEJpbnV0aWxzIE1haW50YWluZXIpIDxuaWNrY0ByZWRoYXQuY29tPsLBeAQT AQIAIgUCWb/ZxQIbAwYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQE/zvid2ePE9cOxAA 3cX1bdDaTFttTqukdPXLCtD2aNwJos4vB4LYPSgugLkYaHIQH9d1NQPhS0TlUeovnFNESLaV soihv0YmBUCyL4jE52FRoTjE6fUhYkFNqIWN2HYwkVrSap2UUJFquRVoVbPkbSup8P+D8eyd BbdxsY6f+5E8Rtz5ibVnPZTib7CyqnFokJITWjzGdIP0Gn+JWVa6jtHTImWx1MtqiuVRDapU hrIoUIjf98HQn9/N5ylEFYQTw7tzaJNWeGUoGYS8+8n/0sNbuYQUU/zwMVY9wpJcrXaas6yZ XGpF/tua59t9LFCct+07YAUSWyaBXqBW3PKQz7QP+oE8yje91XrhOQam04eJhPIBLO88g6/U rdKaY7evBB8bJ76Zpn1yqsYOXwAxifD0gDcRTQcB2s5MYXYmizn2GoUm1MnCJeAfQCi/YMob R+c8xEEkRU83Tnnw3pmAbRU6OcPihEFuK/+SOMKIuV1QWmjkbAr4g9XeXvaN+TRJ9Hl/k1k/ sj+uOfyGIaFzM/fpaLmFk8vHeej4i2/C6cL4mnahwYBDHAfHO65ZUIBAssdA6AeJ+PGsYeYh qs6zkpaA2b0wT4f9s7BPSqi0Veky8bUYYY7WpjzDcHnj1gEeIU55EhOQ42dnEfv7WrIAXanO P8SjhgqAUkb3R88azZCpEMTHiCE4bFxzOmjOwU0EWb/ZxQEQALaJE/3u23rTvPLkitaTJFqK kwPVylzkwmKdvd2qeEFk1qys2J3tACTMyYVnYTSXy5EJH2zJyhUfLnhLp8jJZF4oU5QehOaJ PcMmzI/CZS1AmH+jnm6pukdZAowTzJyt4IKSapr+7mxcxX1YQ2XewMnFYpLkAA2dHaChLSU/ EHJXe3+O4DgEURTFMa3SRN/J4GNMBacKXnMSSYylI5DcIOZ/v0IGa5MAXHrP1Hwm1rBmloIc gmzexczBf+IcWgCLThyFPffv+2pfLK1XaS82OzBC7fS01pB/eDOkjQuKy16sKZX6Rt57vud4 0uE5a0lpyItC2P7u7QWL4yT5pMF+oS8bm3YWgEntV380RyZpqgJGZTZLNq2T4ZgfiaueEV4J zOnG2/QRGjOUrNQaYzKy5V127CTnRg4BYF/uLEmizLcI3O3U1+mEz6h48wkAojO1B6AZ8Lm+ JuxOW5ouGcrkTEuIG56GcDwMWS/Pw/vNsDyNmOCjy9eEKWJgmMmLaq59HpfTd8IOeaYyuAQH AsYt/zzKy0giMgjhCQtuc99E4nQE9KZ44DKsnqRabK9s3zYE3PIkCFIEZcUiJXSXWWOIdJ43 j+YyFHU5hqXfECM6rzKGBeBUGTzyWcOX6YwRM4LzQDVJwYG8cVfth+v4/ImcXR43D4WVxxBE AjKag02b+1yfABEBAAHCwV8EGAECAAkFAlm/2cUCGwwACgkQE/zvid2ePE/dqQ/6ApUwgsZz tps0MOdRddjPwz44pWXS5MG45irMQXELGQyxkrafc8lwHeABYstoK8dpopTcJGE3dZGL3JNz 1YWxQ5AV4uyqBn5N8RubcA8NzR6DQP+OGPIwzMketvVC/cbbKDZqf0uTDy3jP65OFhSkTEIy nYv1Mb4JJl3Sq+haUbfWLAV5nboSuHmiZE6Bz2+TjdoVkNwHBfpqxu6MlWka+P98SUcmY8iV hPy9QC1XFOGdFDFf1kYgHW27mFwds35NQhNARgftAVz9FZXruW6tFIIfisjr3rVjD9R8VgL7 l5vMr9ylOFpepnI6+wd2X1566HW7F1Zw1DIrY2NHL7kL5635bHrJY4n7o/n7Elk/Ca/MAqzd IZxz6orfXeImsqZ6ODn4Y47PToS3Tr3bMNN9N6tmOPQZkJGHDBExbhAi/Jp8fpWxMmpVCUl6 c85cOBCR4s8tZsvGYOjR3CvqKrX4bb8GElrhOvAJa6DdmZXc7AyoVMaTvhpq3gJYKmC64oqt 7zwIHwaCxTbP6C6oUp9ENRV7nHnXN3BlvIgCo4QEs6HkDzkmgYlCEOKBiDyVMSkPDZdsspa+ K4GlU2Swi/BDJMjtDxyo+K0M81LXXxOeRfEIfPtZ3ddxBKPva1uSsuz+pbN9d1JY8Ko5T/h1 6susi2ReUyNJEJaSnjO5z13TQ1U= In-Reply-To: <87leatymeo.fsf@tromey.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Tom, > I noticed that this commit: > > commit b05efa39b47995db08c5537e4504271c8727702a > ... removes several hunks from display_gdb_index, causing readelf to be > incapable of reading v9 indices. Ah, I did notice that and wonder. > I think this was probably done in error. I think so. It looks like it might be just one delta that is causing the problem: @@ -10934,33 +10788,6 @@ display_gdb_index (struct dwarf_section *section, } } - if (version >= 9) - { - printf (_("\nShortcut table:\n")); - - if (shortcut_table_offset + 8 > constant_pool_offset) - { - warn (_("Corrupt shortcut table in the %s section.\n"), section->name); - return 0; - } - - uint32_t lang = byte_get_little_endian (shortcut_table, 4); - printf (_("Language of main: ")); - display_lang (lang); - printf ("\n"); - - uint32_t name_offset = byte_get_little_endian (shortcut_table + 4, 4); - printf (_("Name of main: ")); - if (name_offset >= section->size - constant_pool_offset) - { - printf (_("\n"), name_offset); - warn (_("Corrupt name offset of 0x%x found for name of main\n"), - name_offset); - } - else - printf ("%s\n", constant_pool + name_offset); - } - return 1; } If that code is restored, does v9 functionality then return ? > However, I also could not find > this patch on the mailing list. It was posted to the PR, and I thought that I had seen it on the mailing list too. But obviously I was wrong. Sorry about that. Cheers Nick