From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 005153858C31 for ; Mon, 12 Feb 2024 15:04:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 005153858C31 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 005153858C31 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707750280; cv=none; b=s8vS7Xf9arhPIrZHlKcTd0EQY5ie/So0VOc3mOCCgvrNHXk3Ubo7IZqZtulnlCTyGDasn8iVZKHnR5Gf+fkNhkf8WUwdTko47fZ/q9ZU8n8n/P/8TEBrwhoXprckjRZ1tUTR2XYqSz9efwNuzFk6IwAYGMosnIV0pEMgSh01e3Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707750280; c=relaxed/simple; bh=1XqFjMh22jjSnLFYfvkNyIH6Kxvt/YbCMdT3O737+vk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=pOHgp93oxq0N5hN8WeqY9BA/iuN1TbuA4z3kgX3Wi77bWsj1gbQA25wfCOJqLYXcUVmPxiZSGikyOBlw+CI2R8lg6TNlXcM9xcQ0+dHVeDhs/ELIOIsoo4/MBQKaGcTCVrt86sBk3pCFeZSixxwEypBoHdFm8t0PuQIm7RkkO4M= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707750277; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=a3RBwWk2IvsGYXElzVQ+PIJo74k5xdf4VNven37lHUw=; b=Yl8pNOkEYcBsndqNstvQfvK8yECV8+I7HJwYcR7IvGEGps361QZh6BkKOl6VvVvfkAc4Bb iH1cLvBAijRDkoAc3ZYAk5CsAeLXKGPacQQCK+1ABQYoq31REmfmBGdLPl1OSqSgviWl/C n+V/FZK1+m7prJ8IxO+CxvQjh3BK44Q= Received: from mail-oi1-f197.google.com (mail-oi1-f197.google.com [209.85.167.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-683-9lMSzOsHN3KWeZr-v1Hrcw-1; Mon, 12 Feb 2024 10:04:36 -0500 X-MC-Unique: 9lMSzOsHN3KWeZr-v1Hrcw-1 Received: by mail-oi1-f197.google.com with SMTP id 5614622812f47-3bff70e7380so3370765b6e.1 for ; Mon, 12 Feb 2024 07:04:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707750274; x=1708355074; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=a3RBwWk2IvsGYXElzVQ+PIJo74k5xdf4VNven37lHUw=; b=g+CFzF0XjPtjNFpN7eRUYMHFLEYphpV1qOdiOUpRL/1HVl6RffoqjvC7f2Xu+8HVm/ 1+IoinopcrIty4vr85tEacPzETz5FyOZVAtORymBL9uRN7D0T2M4YNDsWoeZn6QYv664 goeK6aE9MZx1SwCEBRPgBgfAC5yoAfKJ8/8vJvDV8AGzV9GzwNBc50HAu8t8Vwu6AbWy nWjggh5OoM3hr7V/t5fZ37NZqk3AmPkgwRxr+ekR7LhJAoNWW//Sx6U6JQ0dQLvrChR8 KQEuR06sdjxt88jKMbO+o/bK9oqLHTr0BrV9vydZ8JMhH6PVSL+/WapnKfVgz0vm0J5w VYlQ== X-Forwarded-Encrypted: i=1; AJvYcCWw/07WotgOwvu7hSO1hWJun4BFFJGamEuf8TuTt/xksRvIwEdKTnWwV7w6ZG9y4RUdpShAFoiGV7Oeg/Ei4eNTXESmtX9YzA== X-Gm-Message-State: AOJu0YwMUpSW8iytMdPJjF9pU7HueUpEr5DA5zJwnRmUnKtXFVsyPcX1 +MmUkUoIW1v3TSAD9jTPZ6sibZAmazF0oEM7SdVdCRmvzYbb+QnZkrVUdUhdVvDDR4DYDcb8XFX QiXBQj5xLG59fNeukEu8ZvdShqExAsgLiQfbKJBJhwSRe95tida+CxkzIy1mfVYA= X-Received: by 2002:a05:6808:2f17:b0:3bf:b800:e264 with SMTP id gu23-20020a0568082f1700b003bfb800e264mr9245239oib.11.1707750274695; Mon, 12 Feb 2024 07:04:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IFlrhuGDjokrjE2IbT6l1iGGKN7qzL6toFTgUT8F3fHnn9jP1mz39bqnX+vQ7bPnagf8xauxQ== X-Received: by 2002:a05:6808:2f17:b0:3bf:b800:e264 with SMTP id gu23-20020a0568082f1700b003bfb800e264mr9245211oib.11.1707750274459; Mon, 12 Feb 2024 07:04:34 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWdDjv3Ub6Aep6LDqP8ZFgp0N4ze7epi1VWorrYISym0cZFpvR94UNnuqTQVGjXIuh0SI6FOlvkz2Q5fPFw44tk7naQ6cXOnw== Received: from [192.168.1.5] ([79.123.79.31]) by smtp.gmail.com with ESMTPSA id q19-20020ac84513000000b0042c6e5192e6sm203023qtn.60.2024.02.12.07.04.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Feb 2024 07:04:34 -0800 (PST) Message-ID: <6f9baf65-10cf-4977-87e5-fe9c654b4ee4@redhat.com> Date: Mon, 12 Feb 2024 15:04:33 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] Introduce bfd_print_error function To: Tom Tromey , binutils@sourceware.org References: <20240130010540.1754740-1-tom@tromey.com> <20240130010540.1754740-4-tom@tromey.com> From: Nick Clifton Autocrypt: addr=nickc@redhat.com; keydata= xsFNBFm/2cUBEADkvRqMWfAryJ52T4J/640Av5cam9ojdFih9MjcX7QWFxIzJfTFYq2z+nb4 omdfZosdCJL2zGcn6C0AxpHNvxR9HMDkEyFHKrjDh4xWU+pH4z9azQEqJh331X7UzbZldqQo 16VkuVavgsTJaHcXm+nGIBTcUbl2oiTtHhmuaYxx6JTMcFjC7vyO5mLBw78wt52HBYweJ0Nj HBvvH/JxbAAULSPRUC61K0exlO49VFbFETQNG1hZTKEji95fPbre7PpXQ0ewQShUgttEE/J3 UA4jYaF9lOcZgUzbA27xTV//KomP0D30yr4e4EJEJYYNKa3hofTEHDXeeNgM25tprhBUMdbV RZpf2Keuk2uDVwc+EiOVri48rb1NU+60sOXvoGO6Ks81+mhAGmrBrlgLhAp8K1HPHI4MG4gH nrMqX2rEGUGRPFjC3qqVVlPm8H05PnosNqDLQ1Pf7C0pVgsCx6hKQB7Y1qBui7aoj9zeFaQg pYef+CEERIKEcWwrjaOJwK3pi9HFdxS0NNWYZj8HPzz/AsgTTQdsbulPlVq2SsctmOnL42CZ OCTppGYwl53CG/EqVY+UQBzFzJBaY8TJRFFYVEy5/HH4H11rMoZwqIkk71EOGU3X6mWlANRi kR3M4GhVITRzuaV69Fed+OeXcCmP94ASLfuhBR2uynmcHpBKpwARAQABzTtOaWNrIENsaWZ0 b24gKENoaWVmIEJpbnV0aWxzIE1haW50YWluZXIpIDxuaWNrY0ByZWRoYXQuY29tPsLBeAQT AQIAIgUCWb/ZxQIbAwYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQE/zvid2ePE9cOxAA 3cX1bdDaTFttTqukdPXLCtD2aNwJos4vB4LYPSgugLkYaHIQH9d1NQPhS0TlUeovnFNESLaV soihv0YmBUCyL4jE52FRoTjE6fUhYkFNqIWN2HYwkVrSap2UUJFquRVoVbPkbSup8P+D8eyd BbdxsY6f+5E8Rtz5ibVnPZTib7CyqnFokJITWjzGdIP0Gn+JWVa6jtHTImWx1MtqiuVRDapU hrIoUIjf98HQn9/N5ylEFYQTw7tzaJNWeGUoGYS8+8n/0sNbuYQUU/zwMVY9wpJcrXaas6yZ XGpF/tua59t9LFCct+07YAUSWyaBXqBW3PKQz7QP+oE8yje91XrhOQam04eJhPIBLO88g6/U rdKaY7evBB8bJ76Zpn1yqsYOXwAxifD0gDcRTQcB2s5MYXYmizn2GoUm1MnCJeAfQCi/YMob R+c8xEEkRU83Tnnw3pmAbRU6OcPihEFuK/+SOMKIuV1QWmjkbAr4g9XeXvaN+TRJ9Hl/k1k/ sj+uOfyGIaFzM/fpaLmFk8vHeej4i2/C6cL4mnahwYBDHAfHO65ZUIBAssdA6AeJ+PGsYeYh qs6zkpaA2b0wT4f9s7BPSqi0Veky8bUYYY7WpjzDcHnj1gEeIU55EhOQ42dnEfv7WrIAXanO P8SjhgqAUkb3R88azZCpEMTHiCE4bFxzOmjOwU0EWb/ZxQEQALaJE/3u23rTvPLkitaTJFqK kwPVylzkwmKdvd2qeEFk1qys2J3tACTMyYVnYTSXy5EJH2zJyhUfLnhLp8jJZF4oU5QehOaJ PcMmzI/CZS1AmH+jnm6pukdZAowTzJyt4IKSapr+7mxcxX1YQ2XewMnFYpLkAA2dHaChLSU/ EHJXe3+O4DgEURTFMa3SRN/J4GNMBacKXnMSSYylI5DcIOZ/v0IGa5MAXHrP1Hwm1rBmloIc gmzexczBf+IcWgCLThyFPffv+2pfLK1XaS82OzBC7fS01pB/eDOkjQuKy16sKZX6Rt57vud4 0uE5a0lpyItC2P7u7QWL4yT5pMF+oS8bm3YWgEntV380RyZpqgJGZTZLNq2T4ZgfiaueEV4J zOnG2/QRGjOUrNQaYzKy5V127CTnRg4BYF/uLEmizLcI3O3U1+mEz6h48wkAojO1B6AZ8Lm+ JuxOW5ouGcrkTEuIG56GcDwMWS/Pw/vNsDyNmOCjy9eEKWJgmMmLaq59HpfTd8IOeaYyuAQH AsYt/zzKy0giMgjhCQtuc99E4nQE9KZ44DKsnqRabK9s3zYE3PIkCFIEZcUiJXSXWWOIdJ43 j+YyFHU5hqXfECM6rzKGBeBUGTzyWcOX6YwRM4LzQDVJwYG8cVfth+v4/ImcXR43D4WVxxBE AjKag02b+1yfABEBAAHCwV8EGAECAAkFAlm/2cUCGwwACgkQE/zvid2ePE/dqQ/6ApUwgsZz tps0MOdRddjPwz44pWXS5MG45irMQXELGQyxkrafc8lwHeABYstoK8dpopTcJGE3dZGL3JNz 1YWxQ5AV4uyqBn5N8RubcA8NzR6DQP+OGPIwzMketvVC/cbbKDZqf0uTDy3jP65OFhSkTEIy nYv1Mb4JJl3Sq+haUbfWLAV5nboSuHmiZE6Bz2+TjdoVkNwHBfpqxu6MlWka+P98SUcmY8iV hPy9QC1XFOGdFDFf1kYgHW27mFwds35NQhNARgftAVz9FZXruW6tFIIfisjr3rVjD9R8VgL7 l5vMr9ylOFpepnI6+wd2X1566HW7F1Zw1DIrY2NHL7kL5635bHrJY4n7o/n7Elk/Ca/MAqzd IZxz6orfXeImsqZ6ODn4Y47PToS3Tr3bMNN9N6tmOPQZkJGHDBExbhAi/Jp8fpWxMmpVCUl6 c85cOBCR4s8tZsvGYOjR3CvqKrX4bb8GElrhOvAJa6DdmZXc7AyoVMaTvhpq3gJYKmC64oqt 7zwIHwaCxTbP6C6oUp9ENRV7nHnXN3BlvIgCo4QEs6HkDzkmgYlCEOKBiDyVMSkPDZdsspa+ K4GlU2Swi/BDJMjtDxyo+K0M81LXXxOeRfEIfPtZ3ddxBKPva1uSsuz+pbN9d1JY8Ko5T/h1 6susi2ReUyNJEJaSnjO5z13TQ1U= In-Reply-To: <20240130010540.1754740-4-tom@tromey.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Tom, > gdb likes to control its own output; for example, this is important > for gdb's pager, and for logging. While BFD provides a way to > intercept error output, via bfd_set_error_handler, it turns out to be > difficult for this function to truly generate the desired output in a > gdb-friendly way -- the error handler is expected to implement some > BFD printf format extensions. > > This patch introduces a new function that an error handler can use to > format the text. This way, gdb can set the error handler and arrange > for the output to be displayed as it likes. > > bfd/ChangeLog > 2024-01-29 Tom Tromey > > * bfd.c (bfd_print_callback): Rename from print_func. Move into > comment. > (_bfd_doprnt): Update. > (bfd_print_error): New function. > (error_handler_fprintf, error_handler_sprintf): Use > bfd_print_error. > * bfd-in2.h: Rebuild. Approved - please apply. Cheers Nick