From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2062.outbound.protection.outlook.com [40.107.21.62]) by sourceware.org (Postfix) with ESMTPS id 59646385842E for ; Tue, 10 Jan 2023 09:47:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 59646385842E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ko84U99T0+EFIqmpCfaRd37i6gLRYIh9E0rmvAHL9B2KPRqRQckrjjb5cTnu9uyLLVmi3hfyB1v5h6VBFsUHNQ/tY7aS8kkU1xRANZjrYyVAmmr3CWOUVyviAxe8dI//quC8h9+2tfyl/VBTDvoFUpyHvumRjH7OiGnauoop3LcHM2HQOee8WmBFZK/b/RhIitY3hgCmO0VksYTFpqtG5FZs49cS2wDA7gch+xI3qwhnXtpZjMbQnKGHVJYVSbC+Y9Ug0YWRXv81z0IQnFpf+7s8gF9BCRXOYOuGPKxAAwoWLNjPcE1Ihv5ESdpw0696uGCHYqKoBunHvWzLzZ07sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FGo9svlL7SgrcKHuap5+xdrQrBEJ+vJRLREmHaVABdA=; b=DIIvDwGnw8K7kPJKVbjBT0y5/2whnqHJRpLxMEayb3FVKUQdWDJbgKdp6QPVp1zmp3Z/tc9P1+LEo11gDtKCNIKFD9CBS5KnJpAm2B4Ps524NXBA7XjhdaQd4XA1iO9EnHCv/X3GdDlQaOR0kjMGWLF2t/DzgsC06GU1k7x+2XlkX9Ah+T6l7K2XSwUmQSU29HfP26BcIea9jKtIZJ6zQSWP0KM1dkmZFtPwhjJ94FysU3+OryS1xxpAWVUglU76AkN2Z5PhoWWb5smGKhWMTDYgsgm6H0g0+h6/PUSK/xE63rE/BjaAGKpBqqN+EypOF6PvFDx/8N46YkjJ4Ti/5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FGo9svlL7SgrcKHuap5+xdrQrBEJ+vJRLREmHaVABdA=; b=uLXAx2MgZlFH3Egy6q8jUGYS1FkiKft4q80WSvydC+h90bgNar2Tf/vfQsKQy42t8Phu6d/EXIVbuWafwgsEeLOpOusiTJmpMeYcIj925Gje+vcW9S+b5sX3YLQQ6VnkGe2SGa+Q6v3+cBTq8s9Sv+t571jaYRtMb5y+zkraHBB7vDmeX7ovyupQDpmmBlactxtqgMgerMLjChZGY299hlJGsH0BwW+SZpJOb4T1w14ckD83D4+1eN3KJGxQotwzp6Wg2poU6EMYL9KbYkBohAK5Ofx5wa6DZjuvcg7heafxRTnFGvTwRuv/TfYU4RoAKBqmF9w5C6+I0SQ+Ytsdwg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9472.eurprd04.prod.outlook.com (2603:10a6:102:2b1::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 09:47:28 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5986.018; Tue, 10 Jan 2023 09:47:27 +0000 Message-ID: <6fd40220-6dba-90f3-f31d-9c6859d22a3d@suse.com> Date: Tue, 10 Jan 2023 10:47:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: Move bfd_init to bfd.c Content-Language: en-US To: Alan Modra References: Cc: binutils@sourceware.org From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0105.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9472:EE_ X-MS-Office365-Filtering-Correlation-Id: 7b137bb2-eeb9-4ba0-5f90-08daf2efaec4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RqVenrQuiQmJEHc0BOYP9IYXAsAUu23W7uSkfSxYf8ANCdxKyg3SgyTRwN0Wt/bhEOscyjq78PUr1uJD9rE5q+IRCXOSqAv+7zWhIdyLa8dd26gQZIU005tX7VlL3Fa34W4eOzDyYSXiut4+idxDR6aP5StU57pFdg1H7InQuLpzT+qC0cVeT+S2n8eYSn+xb1auavoMzwE1WpFl+nwTARSwS2bnn12aHdOzRjyz7xNXolBFac1xwZYhCWHAdW0KRLow9sMu8nO3OZw/KskehZYmjBz2Q0x7dLwaCQA5z8xda1g07Tx/68BNjtAULRVmDYhxBNf4KqqZGC99JB0iu9K9DbJBwqdl162vY5iVXwyfExAi6Qh9eaBXltXFVGNYzo0Yu4DBLcck9nvBYs1cZcZ5FtLGiMyDB1K7AZEpcJMiBQ/OmTYVpL1F9itwXBPJVqJc1MJNTZxGcAy5EoVBPni31LbW8dLRyZxK7osTBVpgC7Udpyfu2lwLOx9kt2Lz9fch0gRFWoR6ZOA94HMRTfk3wMMyCbQOooieJVUUcai88+LxpuM1e8NC9uOqYbs2BoKRERnDREemVrb/n7fR77NCnBl6Xzlf7y3fJJ2upl+vAlh9/f3OZjYmUoWzuE5NQYjTCfy5ZkgH3eqfs+6rNPVLhSyPY5Vek4xPh8LuUBpJ8qnQRERD/e+nr3u//dc4n3yRhlDgAKyPUri39PqwTTrNlAGYUqWDa3k0qC80J1I= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(376002)(346002)(366004)(396003)(451199015)(31686004)(2906002)(5660300002)(4744005)(86362001)(36756003)(31696002)(8936002)(41300700001)(6916009)(8676002)(4326008)(66476007)(66946007)(66556008)(38100700002)(316002)(53546011)(6506007)(6486002)(83380400001)(26005)(2616005)(186003)(6512007)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WHhQOFJSeUNyQzVLMnEvWi9XR3pVb0ZpUUxJc1ZXb1VzbkxnQlNrYTdtQUJv?= =?utf-8?B?TTRoSXJqT1h1ZlFBYTZnU3JpRGExN0xkdGUzS2VBWExvZHZRQU5tcVJ3UVgz?= =?utf-8?B?SzJsMXkvS0M4RXByd0xnelg3Ylh0VUZvd0pxMGlHQ0xBTjVQTmcwOXNCQm5F?= =?utf-8?B?Z1huYThURmVDdVc3YytPUWo3TncwN1M3SWt2czVqQmlDS2QyRU1WM20rWVdL?= =?utf-8?B?aXAwZlJaemsxR0tHNjlnMkZ1dWd5NFlPMU83WGdOeU9HZ3VZZUpodFA5V3h0?= =?utf-8?B?VzZycHM1Z3Z4aGd3eS9rVDlSeURVWTBqVW9ZREJPanFTYitmZXRWWlYxYnIw?= =?utf-8?B?dFgySnBlNGpkOUc5UUYwLzltdGUrVHgyMDBvbW5NcmlIRXpUOGZEVlUxRzEw?= =?utf-8?B?WlVPejNGR2Njb0E4U0l0VGN3YklqSStEdEYyclRtbC92QXhGUHlWc0Z1clZO?= =?utf-8?B?NmNzUVU3SVFZWHNXMHR3MVBrSmNjdE1XWFIyaGZ5RzNidC9zelNQeWxpbFQy?= =?utf-8?B?YVcwRkZZd0hqVlpOd09HRzBhWjcwUWQyQjJiTVZjVUpMaWxrd0lGUzdyaTd5?= =?utf-8?B?UkE0SGNvOWRwQ0dQZUd5a3NmMUo5eU9lUk5oT2Q3ZXdoV29rek1jQU9IeFNY?= =?utf-8?B?SDhnQjEveTdiWUNvWHlQcXI5cEEvK1NZbmFrS3lFQTFRcC9BNlRuUE5yU1cw?= =?utf-8?B?Q1RhWjI0L1BoeW5pMU1ibkRUNTAzdXArdEE0ZTA0UkV0ZWM0eC8wNEQrZWpy?= =?utf-8?B?OEwyaXBmTXdvczA2MFNuN09ma212Ny9zcDJzWWlhT1ZsN3FpUEJUYkowNE9m?= =?utf-8?B?V0xYbXVLNUlHU2I1L21ZKzlnM1dVZE1zUHBJbEhSL3pPaEVGUVMyMWFQT3BN?= =?utf-8?B?c0lTZW41SlY2T0NWbnlFdUpQNmtxaUV5Wis5dGlFWE43ak13dWRybU1LcTdQ?= =?utf-8?B?Y3BLNTI4YisxUXBweG9xWWVSWDVHamxFSVRxTHZCMzA0ZVF3UmMrZnl2V3hJ?= =?utf-8?B?OVMybENrQzNtd3VFZjBXSnpTODVrVDQvdmJ5ZW80aklDaEZaQmZaNWZob2xD?= =?utf-8?B?MklHTW85a2RwQUEvMTlZWGoyeWdPUStCMjZicyt0dVJhcDNROTdaM2xoQlZS?= =?utf-8?B?NGtHdVQ0ZFZiL1dYNVRpUlFqd2dWRUNyOWhiY3IzOXFyOEFaMnQrNjBPSncz?= =?utf-8?B?U2hRMS8rempkT21wd2s2L2V0YWgrQzcvalUxcUk4c2lYbDg1bDBQT1ViRFFC?= =?utf-8?B?U3ZJL2w5MHRzWGgrSmFXVjdVdFlVaklwSlRmazRNcm9MOXJKMW04aWpyWWVS?= =?utf-8?B?SmN0QmFlV0JHYmlnRG1QanUvK1FZUndDV3VNT2NCaStzWVZsVlByWmdubzg2?= =?utf-8?B?MG4yNklrVHJOQ3NTZGRRMUh6a3kwcXVGRUpvcmJQMTVzNm9ISHFXK2V3bktK?= =?utf-8?B?eVpjZ1RpUTV4YTFXVml6aXFoeFZMKzZ4eFpyd3cvOXNtdFVzWlVPQTFVeVVX?= =?utf-8?B?S2VWVGNYYk8xN0svOUt5SnZGaDdSQ2krcG9SclJwSktUMHh2MTNIQzFVZzZn?= =?utf-8?B?bnljeFNyd0lEQU5EN1hrVFZ5K0Z5TEl4QmR6WThJcW5tNkRLR3V5dllWdlZL?= =?utf-8?B?WFRnWVhsWE5wbThLcXZJRUIvbHVPbVgzSWdzeEF2ZUZncFVJTW40MmtIYjdI?= =?utf-8?B?NS8wbG5jWEVNU1JVYS8wNEpCbVozUm5aN2ltOXgrZGpvMDM3TjViNjJFbTBi?= =?utf-8?B?ZUowRDZuZ1JTZHc5ZXA0NlFiU3NRVmtaVnpkS2RnOE9qSmFIUVJNbEJzYlBF?= =?utf-8?B?cmJJYnE2ZDkyUHlvVmJPeXROU3ljaFdwSkVvOEtqdGtzV3ZVSjJkYXZUbHlj?= =?utf-8?B?L0hHTFZDQWZOejBWUHNWZmk4MmdteG9WRmVTUkNXcm4vTnZ4bEFEbml3aXRy?= =?utf-8?B?dzVTaTNjcFBKSUZKQlpHTzUzTjMwNksxT3BsVksycVJPT2lhb3IzRFFzVy95?= =?utf-8?B?cWJmTVJEMG4vREhDMUUrZUZINGMrWmpoRnIvbWxMRFZQZXdlUG9YKy9UakR4?= =?utf-8?B?OUZ4VlpWcnVkeVFtUmt1REFGQnJ6dUZwV2JsRVlKL0VtRDk0eGRvNi9lMGJU?= =?utf-8?Q?b0/cxY4YA2eQvnN/MgZKGGTtm?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b137bb2-eeb9-4ba0-5f90-08daf2efaec4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 09:47:27.0963 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: A9k4EwGpi3mHp3xdlHIuBepjLRNJVTFv6qqE/OT3KCCpoaJpo0tEXez6ql0C8BGnodQFCvkwbFBoaevWXarjBg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9472 X-Spam-Status: No, score=-3028.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10.01.2023 00:18, Alan Modra via Binutils wrote: > init.c contains just one function that doesn't do much. Move it to > bfd.c and give it something to do, initialising static state. So far > the only initialisation is for bfd.c static variables. > > The idea behind reinitialising state is to see whether some set of > flaky oss-fuzz crashes go away. oss-fuzz stresses binutils in ways > that can't occur in reality, feeding multiple testcases into the > internals of binutils. So one testcase may affect the result of the > next testcase. > > * init.c: Delete file. Move bfd_init to.. > * bfd.c (bfd_init): ..here. Init static variables. > * Makefile.am (BFD32_LIBS): Remove init.lo. > (BFD32_LIBS_CFILES, BFD_H_FILES): Remove init.c. > * doc/local.mk: Remove mention of init.texi and init.c. If I'm not mistaken this should also have touched bfd.texi to remove the inclusion of init.texi? Jan