From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 13DFB3957030 for ; Wed, 25 Nov 2020 11:18:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 13DFB3957030 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-425-nd6B1-6LMiOdhAcX-o8jtw-1; Wed, 25 Nov 2020 06:17:58 -0500 X-MC-Unique: nd6B1-6LMiOdhAcX-o8jtw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DF8CE180E49D; Wed, 25 Nov 2020 11:17:57 +0000 (UTC) Received: from [10.36.115.1] (ovpn-115-1.ams2.redhat.com [10.36.115.1]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5A7DA60BE5; Wed, 25 Nov 2020 11:17:57 +0000 (UTC) To: Howard Chu Cc: binutils@sourceware.org References: <53b8973b-40a4-2550-3307-66d7f13707d5@symas.com> <64fe82bd-9c00-b232-98d2-f46182fb16ba@symas.com> <9889c54b-4dd3-2275-6621-c2391cfd268d@redhat.com> <31f9062e-175d-06e9-695a-797c7ee11420@symas.com> <58620dc1-3bb9-aaae-b476-ebb613ecb627@redhat.com> <1aaf4429-074c-7912-e6e6-4d2f82d6ef10@redhat.com> <7b118db2-9502-c45e-9f47-6b6f6a5f9646@symas.com> <7dba4046-3d50-c7e6-915d-08bf590bf057@redhat.com> <7b124cd4-529b-0069-3044-9d733a4e4e5c@symas.com> <20ad87a3-283d-7e49-9c2e-ed13001f6c87@symas.com> From: Nick Clifton Organization: Red Hat Subject: Re: [PATCH] dependency list for static libraries Message-ID: <70139665-0b8c-63dc-3a9d-b24a25bd8122@redhat.com> Date: Wed, 25 Nov 2020 11:17:55 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20ad87a3-283d-7e49-9c2e-ed13001f6c87@symas.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Nov 2020 11:18:02 -0000 Hi Howard, >> This linker plugin works with both ld and gold. > Ping: anything else needed for this, docs, etc.? Sorry, sorry - my mind has been a mile away. So - the code in the patch looks good. I am running regression tests now but I am not expecting to encounter any problems. There are some things missing however, the first of which is documentation as you guessed: * A entry in ld/NEWS describing the new plugin. * Documentation in ld/ld.texi describing how to use the plugin, preferably with examples. * One or more new tests in linker's testsuite to check the functionality of the plugin. Obviously these would have to be native only tests, but there are places in the testsuite where this is checked. (Eg ld/testsuite/ld-bootstrap/bootstrap.exp) One other thing - is the plugin installed into the correct location if "make install" is run ? (Ie: ${libdir}/bfd-plugins). I have not actually checked this yet, so maybe it works, but I would have guessed that some extra work would need to be done on ld/Makefile.am to manage the installation. Cheers Nick