From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2081.outbound.protection.outlook.com [40.107.21.81]) by sourceware.org (Postfix) with ESMTPS id 3A2333858D35 for ; Thu, 5 Jan 2023 07:42:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3A2333858D35 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kU7NFJqAYSiNQrE7HQAn8H0qr7uP0mnQlNfghd662zH35uQLaRyWLvmgpkW39y1io0DwPYGsFD8Mt2bI2mQNXldp3Cdo2GMfblng1JAuMe2kxO9+40uGmbUvJLPxNssPZhziMiKEW0UVn/dpFHkHgGrXI9ZDtqfGdx2Dag4FmOcoshZpkbGc6vS9160+TSfPLDUiwUQepk7mhYw+oq4tyXLtXjJH6JS6NoPgXAFXtoTg4o4TmQSd7FzPT2ed60CWwZh2o1w3uXw2gBa3kKQW7K93CpJcpbF8LJSXzjkAZNOf5U2Kd5ZvwxdhoB3EMGyQ0MQZyGdaCpDVKVQZJ/88bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C07s2kj3Lxs+2gex8l2Bs4xiyl8pcJH/MLT5dfQOExY=; b=LGF/n+PeDWqDJFTxcd0734HuRhoWlzIi5+gOFfk4XZiUv9pzLAQZgcUg+zAdqRtBsmXgWNFr9TPB3ETPT8pt0UNrRAZA3XiJrPLaA1y+BQAHTErD9CXejMgu0SMo4r7SLngE7CNVqX10PHJCUMzBzSJOSVvU317oduETjxtSeGKi1Q6Y7iOKoI/LngRabQ/pAW/tbHnu5xB2uFynxi6pBctwxOazW+Eu3YkRu0V2LhhctTNYGFLqP8VaxZQJh5BURtTARlV6rHYz4gYqS4p8jsfSeCYtA16NXhCIMmTC6doRDKxJFHToFODijE+uNEwyMHmNDbT1W6sI5lpquypUVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C07s2kj3Lxs+2gex8l2Bs4xiyl8pcJH/MLT5dfQOExY=; b=hGlSSG2juJgHMKxXgKOy9yEMco7ZXqZLT+xHie671AX9eS3dd1ZeXmdgysjhiYCfS2L0AVhK8cxofi8cyzfGMs/gnMjzaxCWBF87gZAcFNIF0KTSFxTcqiTWKQ/GQqplJUs/1g8e6pBb/OMabKEN0KdEPfEAcWczFMnRxKLSFV5y+QIeEtQf7Jc81y/y8A/oyX4FmIUUW3+6UZdc4IY4WON6fll3b1SdYWADuCOA29cB85kxtNl184l9h4PYTSCWQSuc6mnasSl1O+q1S4g7gWue9oMnfpkWfoXifdDekUhZ+DKrLRk33xrjH/mgRe0CGDnpvYURRSDq0T+Uwx3Zsw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8184.eurprd04.prod.outlook.com (2603:10a6:20b:3fa::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 07:42:31 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 07:42:31 +0000 Message-ID: <707373e1-01e6-21ea-c407-db61da912e22@suse.com> Date: Thu, 5 Jan 2023 08:42:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] x86: Remove duplicated I386_PCREL_TYPE_P/X86_64_PCREL_TYPE_P Content-Language: en-US To: "H.J. Lu" References: <20230104191414.149668-1-hjl.tools@gmail.com> Cc: binutils@sourceware.org From: Jan Beulich In-Reply-To: <20230104191414.149668-1-hjl.tools@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0197.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8184:EE_ X-MS-Office365-Filtering-Correlation-Id: c4926ad7-feff-435f-a666-08daeef06622 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 26HnXl9cs3Rh858POVcl9W0Jy7eQJ5tSIcModNuLfOVFstpa1vvDQzoUu814lWbDzIitKEN9c8SRxDopU4DYcon+QHTdrcYIaKqNw726TESupjwJKrElwlG/FlLFGKcQjelhp6x1unoKPQF9SOOsVDUVVyP/6hwbKRrtvCvAhTuCOKWHeuaP4F5EAdMj3m6459AViL7tcRlAknHofswkZmIbcoobRHQgM54QGBl99kNuq12xwll/WNxJnBP+mPIDaf+mz/TRPdpcVDKwa3f7vhlZgrjYYwlCJz07NX0SAlQe+N3k2EuZng7fk90uBlJ7CZOKOHoCGlLkEK+5rEHA0ASULjCutTH3vMF397rv+qVn5x0czSEDp8ZPx4Nyc8g67iSBKs3rpv1XmkyTef/2RpYE7WzOq+0njU3l1jOSx2D4kbNpoiFU1uvyZj5dkYseWknRE2JZ/lhwzHPuheeNJhbFso0T5/gQr5or9jpcZW8J2jciv2ssYWTRTxh0Ac+bmthHP6loXWgI0wdh+CkM6nONwpig/99JhklsbKgCJzlZ8D84hYuM4KuKdl2Ey4e06Gci/PZ4vmjqDqZ4ETb5AlO+IkHHjx5YHCICW+bl2C7uQZbfPK75PGKAcQAyRTx90x+NWJDoTu4J/7FV4Lef+B1ceNwfkfA5OlvkCWuh43iYeIhgyK+z7DcvnGwGQ9svMz1XGuioSSZgJhD7/ob3M+3gY0P80/n5fIWBZgFdzjg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(346002)(366004)(376002)(396003)(451199015)(66556008)(4326008)(8676002)(66946007)(6506007)(66476007)(6486002)(31696002)(53546011)(86362001)(478600001)(36756003)(38100700002)(2616005)(316002)(6916009)(4744005)(6666004)(8936002)(26005)(6512007)(186003)(5660300002)(31686004)(2906002)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MjJtd1ZJSi9nZCtVM0N2b0JYczlzV25LS3VEaWNNT2g4U1Y1MFI2d2hJMVIz?= =?utf-8?B?dHZpSEZGbzUzWUM2SlJDR0JTUCtHNFVGUTJUSkd0aHhKUkNLNnZLbGVNUjdW?= =?utf-8?B?c0p3aWpZZFhoNVNFN001RDJsTVNzK3pDUnk5RlJyMnlna2JXKzZXaC8weVl2?= =?utf-8?B?K1hMZjJIdWRSQi9sRVFaa1JjWkNzVlVQcUloVGY3UFdKS3N5NG1mUmdReW43?= =?utf-8?B?Rkd4L3JibVRDREtIWktmZ1NyUkVWaER2azNUWE5Ld1gvMFViSkxnMzNKT1li?= =?utf-8?B?SkNYUm41YVJRd1NkTTBqQ2lYSDFQWkdiQ2M2eUg0d1dyN2VYY2ZrNEp3NXFj?= =?utf-8?B?UW1kNzJ1K3ZWUmJMNTdhVVlCNy9nQVBldG9YYzNGZGx3WDUvQ2dkbklhb2Z5?= =?utf-8?B?a0RaUXNxdkpUSUVMSm92M3FwVDJDblJlTnYxVmVRWGx5T2lwc3pHZk81akNR?= =?utf-8?B?K2hSV2huUnNOcW5xYTRGMnBJTVVPNHhaTXM5VDJUaUxGd04rK3lId0hZMWR5?= =?utf-8?B?TXErYzRBbEhvNnlXNW9rTGxMeDFNNmhqQVo5YStQbzBFNThXNjdneDZCNGx6?= =?utf-8?B?THVlTmsyWW5QcWZQRXVNNDVBVWoxZTU0TkwvRkMxZ2VCNUJhOWY0ODkxSnhs?= =?utf-8?B?a2dBeXp2ZkIzMXNXcWR4UVZiUkUyb0NNaXN1M3FSMHpOdUdwZnhCTk5FV2xp?= =?utf-8?B?QlNsb1QxWHpWVjFsck1FcmNCT2liODM4bUViUnJyTzZscUpMTmtTdENsMlFW?= =?utf-8?B?dmtBYjNjY2NaMjlXeW5WcVNFMEZnUGlEOXF4RlRVTklneW4wYjRoRVh0ZlU3?= =?utf-8?B?R1ZNdnpzUExyT0hKUHVBNEI5eTVoYlZMNTFQN2t1Z0xzQ1ZCQncvNDRkQnJz?= =?utf-8?B?T2x1MExKdGVCU3lFTnZ3YVVXaExab0Q0T0NESWYyeWdVQkZBOTU2T0Z2a005?= =?utf-8?B?SnhraC9nbnZGaW4zaWtwNXI4dVJtcStZQ1FUUmpsZTdMQ2pJRTBlVXBQdURT?= =?utf-8?B?T1NqNlQvQWRRVW9JUkhsdWV1RFJ1enZyRUthanJmN0xHU2VPb25sTnpqVHFN?= =?utf-8?B?eXJlY1Q5bmlwWDJ1SGR6czVOZ3VzcXpDeXR2NGkxMlZNUGYxUGUwVVdmaHV4?= =?utf-8?B?RWgvaFJLTUF6VlozTnRLSG5pZGpnNXYzMTY4MzZOOGZlWFhkdFBSTDRSc3NN?= =?utf-8?B?Mms4eUZidXJTK3Avc0JtWFFEeFYrdkw2eDQ0bFlEbjB2SjUvcEtIWlNZU3R3?= =?utf-8?B?Z3hjbkg3NUFCTTBaNy96MSt4bzRlbFEyTnE4MG5aQWFNNmJKamdubzdGRDBM?= =?utf-8?B?em5EYjVHMmpxOE92N3A5M3ExTTlZdDJZaGh3TGtlazBzS0lFOG5LWWZFbW5w?= =?utf-8?B?dTgxNTlMMW1JKzN5RFRaVVlFRnJvdkNkamRTZytJTHZ2UWxSczVNTmxhTUJT?= =?utf-8?B?YllPQ21KNng2NWtjTmYxK1hUaHVqQS9FTGF5OFQvQlhNQjlHUE1uZEhBS1ps?= =?utf-8?B?cHBMdVBZUmRjY3pXSHJWSm1XMzRyVCtHY1krTnhjRGVVR3FnNytiU0tpSTRm?= =?utf-8?B?REZ4OUJvOGVkL0g5VTNrTWNoTklUMFRXcEtyZm5Gd096TzZLTHlKcUlhMXJI?= =?utf-8?B?c0VtVUovaTBLOEs4RDRQbUUvVFYwdHI4MnF3eFphUEdrUFAyeUJhUy9BMmtN?= =?utf-8?B?UUpLWlA0OG1ySmV6YjhxU1AvZ0hDWXBlbVVoZmFQTDN2LzVaSUJwM3REV0RM?= =?utf-8?B?amxNVHN1M2dXbDhROWZkczQ2c1lYbVZST0hITi8vYUdLSllBQVhNRktXeEwr?= =?utf-8?B?cUFBOEtaR0RybEdMaGJyRUhBWTAxYVJqZTNrMCs3M1hValQ2aTZoU3FTT2tX?= =?utf-8?B?d1U4eXZrNERmbSt1QUp2VDlwaldNUUVvN2NGU05YbHNqd1FMM1J3MmdScWFa?= =?utf-8?B?TjUvNk45aTErNTZEQk1iYXozYlhlNXczb08wN3pxRU1OU29TbGU5U1JrN01N?= =?utf-8?B?WENqcVp3d1U5eGZzbVpKa3ZyUUFiS3E5bW1BUGloaDNuVjR5bjZtSlh3S1Ru?= =?utf-8?B?enZjQXBQZzN3bjFudGgrQnlXR2FjU0VRdm4rbjVoZXdpZ1I3TkNxanFFTUFR?= =?utf-8?Q?edF9Ys93/FgBTnGohMSRdYSbP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c4926ad7-feff-435f-a666-08daeef06622 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 07:42:31.2735 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yVEpJ4+pGKw/gIu5r8bVE0x9khZHn9WN1+HbB1biV76UE4SgBNc2NDNNAqnXjNRS3BqWF7b/4/bFfaiJyUXHQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8184 X-Spam-Status: No, score=-3030.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 04.01.2023 20:14, H.J. Lu via Binutils wrote: > I386_PCREL_TYPE_P and X86_64_PCREL_TYPE_P are defined twice. Remove > the duplications. I recall noticing this as well, quite some time back, but I didn't feel like touching it because I was puzzled by ... > --- a/bfd/elfxx-x86.h > +++ b/bfd/elfxx-x86.h > @@ -97,13 +97,6 @@ > #define PLT_FDE_START_OFFSET 4 + PLT_CIE_LENGTH + 8 > #define PLT_FDE_LEN_OFFSET 4 + PLT_CIE_LENGTH + 12 > > -#define I386_PCREL_TYPE_P(TYPE) ((TYPE) == R_386_PC32) ... this not including PC8 and PC16 when ... > -#define X86_64_PCREL_TYPE_P(TYPE) \ > - ((TYPE) == R_X86_64_PC8 \ > - || (TYPE) == R_X86_64_PC16 \ > - || (TYPE) == R_X86_64_PC32 \ > - || (TYPE) == R_X86_64_PC64) ... this does. Jan