From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by sourceware.org (Postfix) with ESMTPS id 3975B3858C24 for ; Fri, 5 Apr 2024 07:09:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3975B3858C24 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3975B3858C24 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::334 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712300964; cv=none; b=FDE+kD7BNMGC821CizKqbI3prFcgDGuT0fAc5DoTDEhUfR5nJzOUc9uMG/oOmsbISH1a9I+FDq47wGjTDzgEXxvM0QR7LYpfRqgu62CqlRDj2jj1WFrDx5/lWO/8ObleItNshu2VZmOBaOgGleWMLEdVZEPDJlrIvN7nCmQ7kOc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712300964; c=relaxed/simple; bh=+YITzseOL+RrPCdHB+MHi8J3PAvZIHbLx3w7B/m5IpU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=n7BP/P0K+9hTaM9IX4PK2bw18K+fh/l1omXEeJMdgGZojhTLqc6hJw2llQ+b1a1u1BT8fAcfBX3g+2Ijj9mpDMuNSKDCqqt3TT0c/Un0JDBNwbhCyAYhCPQsMm7s8Em6fU5gyY4V01/lBsG9mmPOq9FHXAzZsWtr9U1oVojnEbU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-41550858cabso12062235e9.2 for ; Fri, 05 Apr 2024 00:09:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1712300961; x=1712905761; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=dF0WfuS+b+6oX+gIe5LjndL5Eazoq5yzWZZS2cRDVes=; b=cNfItfX9WxU3NnVRzQ2URnOI66e/SryFlwtczyw1i6VcUhgi2b4pejrs4wfG3/278S KL3a6bnAkXNbsW675JH3ZQEeGQJbb6rU853WOuWqjiJfBklEEVIkiN+i0F5+pACIchtn eujQIhgz42a3iD0vcFmorT2JM0mobjg6sGy168LFj9dk0jBd+1s3d9wx2WSCqjt5TSRL m/CVV+ssP+ayhCWx78XATo58pHDSI1MssXRdkY6Er9WO7CFuDTRJgS0RNRvjdIseiNV4 2qgHLSC/Y/q9ZKnWPBaKuOOVlPvXWHZQXq5rc1DWNQprbpuQc7ueAFKYfWc9oL8bqSRx 0pdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712300961; x=1712905761; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dF0WfuS+b+6oX+gIe5LjndL5Eazoq5yzWZZS2cRDVes=; b=UV9vMCP7OOF/9TfW5q797033BFHie15r76UPWTHvPQS93IJW+7/eHMIMDh97lakBlE 55ppnBlnvAxB5+8DTS1S4zMdaObCECc3e7gwaAcyhRDGFB17g1qR9vBuV3WslnSR+3D9 5nGKiNTNXUMWZYPhaEQ6r2iGJWUZWBtg8qAB5LgiR88rUi9KLDpjzuixkIIjMj2rbOr2 RAyAPV+ReGns1PsF/gcJwmKTHhfLjyWrD5n/1rYkrdEaa2n+nxOAqXB+AzJpzhXwH3Ok JWc4lz4R+H/UVPQRDyixLUf7wAVxorkLW9USb2Cp3soF1OC9JYu7A0rHqJ4HmcFViiZ8 pdLw== X-Forwarded-Encrypted: i=1; AJvYcCVMa+gf0ilynZSQrMk4goRuMujx1etWDw31VnC5eAKPHqDrgCZHslldvbbFRXuGNBjKssuWhiQoCSY4+CeqSfQJw6wKPtKUug== X-Gm-Message-State: AOJu0YwbUkwcAxbo3cfBnp1prlqOlf1O8eroBfjjESfw9oGChgk77dYA 3kcRKeoituJ+bFNQlb9JEhpvl3wGdv0t+wsOn5XQJylluQrZBS+xqFBSn6fsxg== X-Google-Smtp-Source: AGHT+IGYYQgHtoSZ42RMZpIXn/MyXKehwno4UaM/U52u2uR+yfx2jpRWKM2ShoWOWuIO7O8dRmMmvQ== X-Received: by 2002:a05:600c:1913:b0:416:2471:e102 with SMTP id j19-20020a05600c191300b004162471e102mr504279wmq.37.1712300960827; Fri, 05 Apr 2024 00:09:20 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id d14-20020adfe84e000000b00343bd6716b3sm1252971wrn.99.2024.04.05.00.09.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Apr 2024 00:09:20 -0700 (PDT) Message-ID: <70ec9c47-0825-4dad-b88a-e85bbbd89857@suse.com> Date: Fri, 5 Apr 2024 09:09:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/5] x86/APX: extend SSE2AVX coverage To: "Cui, Lili" Cc: "H.J. Lu" , Binutils References: <155929a3-eb8b-4b82-a4ca-84ab6de34b97@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3025.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 29.03.2024 10:10, Cui, Lili wrote: >> Legacy encoded SIMD insns are converted to AVX ones in that mode. When >> eGPR-s are in use, i.e. with APX, convert to AVX10 insns (where >> available; there are quite a few which can't be converted). >> >> For GFNI alter the gfni template such that VexW would be emitted even >> for the SSE templates: There the attribute is simply meaningless, but >> it simplifies the template quite a bit. > > For this part, although adding VexW to the SSE template is more concise, it also breaks the rules and creates hidden dangers, it feels a bit unworthy. Coming back to this: What rules is this breaking? I can see your point of "hidden dangers", yet I'm unsure about drawing the conclusion that it's "unworthy": The template would need dropping altogether in the alternative approach, doubling the number of insn template lines. That's not _that_ much, but still worthwhile to weigh against those latent risks. > GFNI SSE does not support eGPR-s, I'm not sure if we should give it an error instead of converting it. Well, this would mean not converting various others either. One of the goals, however, was to allow conversion of as many of the insns as possible, even if their legacy forms has no REX2 representation. Jan