From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 4ABF73942007 for ; Fri, 26 May 2023 07:43:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4ABF73942007 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34Q7TRn2009983; Fri, 26 May 2023 07:43:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-03-30; bh=c24MLdOA3BKC6V7Fv5C56OCnqo5gP6h+1f1mPcQnqLg=; b=grw1Y0WW4U3CqVbWM50Et8viDZe4busXDSgg7AN6vgn4FYIvGEcPnVMRkX4lyZ94ZknB WkNNsQP+Yx8HqzGcYR23eteohfqrnVsEzFbokIVDgoDdu3TCycpjzMis9SzIxbnpNPmd 4okpbG1NVu+F9WL4Z5/IXxRbOtb7+eDjierednrAn0ScqtjJ2eG7yhfCw/h3NSIkOioD a714vT/q+RCH+SEQJqGuNnAtQgCcAPfckJDP4gPWxHpz/QIe+3DFbKw92NVC1Ng76E7I a2gPrr9gNgG6KIS1ON07wntHjzQrtkZdcKvB6vDAgnaNC7MOr4cg4TIi167QhngOYPg2 hQ== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3qtrdyg0m6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 26 May 2023 07:43:53 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 34Q5nTNQ015799; Fri, 26 May 2023 07:43:52 GMT Received: from nam02-bn1-obe.outbound.protection.outlook.com (mail-bn1nam02lp2047.outbound.protection.outlook.com [104.47.51.47]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3qqk6p6s2w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 26 May 2023 07:43:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LN2k1152bFYVCmHaA2nIG2Obkj+EU5Uxcx/nJM3GF1VvGEDToGcifF6Wur618zBSuQanRB8RWBa0OqiXfCmroEb56IAa4aOg6PBhAb3C8zcqs5D2uT2cdDkQu+6IkrYsIdGPQbRqFuKqIboQm4c6hvjQGJn+IuNbLPJb/JOmfVhAiZYIc+s+Tb5zHqmZeOECdLt3lgDn7cpxZ++M00sZ0oCmCllidVsc6dQdzALlGDbb5KGXEe/KFVBEmc3P7hSmJsDNtD7aLS02fg5cfSmzbizp6Z/nDOR4iPVWoo0vV7HH7eJKYKXhi5iDIE2aai2tMZZc9dsTorCEERinz5cTvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c24MLdOA3BKC6V7Fv5C56OCnqo5gP6h+1f1mPcQnqLg=; b=mBWtDD7TGMyNRqYUcQRv4JcOoidT66YZf9+cKpgzhKvW89v0YnLHS8p9GK1YsLDhF74IfRdwnEaabn3VYRAiuipFwvVzRAbCKf8btiL2VH+dmm4F+1Sj2HyRLi69F9bMSlfE6UJD9fXwyjVYZ6Uo25Hn1UXEOb1IiJIQIL3vxHjJJuTEunqs2WYtMxho+1a9KVZM/PgJXnWqANMnN8cuwesM5SH+1dcGHP3fvtr17fiwZGWE7/7uI6OOv+V7pyTI3UK1go/LBjjOa5d90Chy9X/HloK0J3dZAugH+89xY+vdsbuFcd3J06KAznQDEt5K710YsNhZuwvn7ubd2isBBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c24MLdOA3BKC6V7Fv5C56OCnqo5gP6h+1f1mPcQnqLg=; b=J4W5VTAVWqW7JgWE1AwESwaDee6ULg7+g4VuyZxTY7nc9DG/XdNuTUstmyxChOFCljb3dEM2oJcjuracXmD22Hsdk824tUX6pRkH0wy43casfFeIg3YPqaCNVpt3ZuEp6AF9iIAt0t7O6iJdIKfTixM5TQqdVDRkm+O0ndc8V1A= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by SA1PR10MB7596.namprd10.prod.outlook.com (2603:10b6:806:389::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.19; Fri, 26 May 2023 07:43:51 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44%4]) with mapi id 15.20.6411.025; Fri, 26 May 2023 07:43:51 +0000 Message-ID: <7116fffa-c436-b2d7-3c0a-acbb0283f048@oracle.com> Date: Fri, 26 May 2023 00:43:48 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [COMMITTED] libsframe: revisit sframe_find_fre API Content-Language: en-US To: Jan Beulich Cc: binutils@sourceware.org References: <20230526070132.4185600-1-indu.bhagat@oracle.com> <20230526070132.4185600-3-indu.bhagat@oracle.com> From: Indu Bhagat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SJ0PR03CA0287.namprd03.prod.outlook.com (2603:10b6:a03:39e::22) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|SA1PR10MB7596:EE_ X-MS-Office365-Filtering-Correlation-Id: e7e98993-5ba1-4acc-6e8d-08db5dbcf2a1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WReGEAWUnoHapxeZL3kl8xw8dernZ2D9VkemOImgjHHBtawfw1biDIebkWq/9aDXzsVrWlt859I9YUJpmYsH+weNdIOTjUbAEShB45w2r/JeMlovwYnc4bCgx5fxjJpLRoDXeBI0nhV3xClg4gmlaJZbgoCR94SH08Vxd5GYvQmTA583G1YKYbe2yp2D8+i4k0r2PLuKK5W3IdKl0k8aSd0wRZowcJ6Ko4A8457SShvqQn/6zUspVYoY4Z2Gfkud4jmWkm281k7dUuKV6vuainOK1HRUwBgtUJN/GmFhFzGVBPkQylUhvV0BeiqFWRRogKyPAQNmAWxYq8Y+r4kxEBT8vhNH3YrzhH7GCAD5OKczzIj3xpZFouVU7KsDQxiEZOVMmh052604rZCIbAuLI7MJaw/smiQvcf5BbbccOyRiP9mxL+cpee6DD8CooE2yGH/1FgIFBULkXQ5vhWz6nlPNCbgXaO8+oZLJ5fjGgzzBCWKNBk610UOASuB1ZqSW/z13V0xNjUBpTxpXEVs/DnLwn9cGPD1g2/T7pfv0xQ/d3sQHKVPZnInLouQQ7P04wjxhuYq3bqGjRhMqS+A1Yv/jGU2W3kj1H67B7Y8jodSxlgL6c4eoBOy7Z385LHCuDxYrTJCsi0G2MZGiHe28CQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(136003)(39860400002)(346002)(396003)(366004)(451199021)(38100700002)(44832011)(8936002)(8676002)(5660300002)(478600001)(6486002)(6666004)(316002)(41300700001)(66946007)(4326008)(66556008)(66476007)(6916009)(36756003)(2616005)(86362001)(186003)(2906002)(31686004)(31696002)(83380400001)(6506007)(6512007)(53546011)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?REJpUW1aRXZ3MUVVS29jMElEU0RGV1MyU3l5NWlmUk5KOGEvS0dzTjVTbWpD?= =?utf-8?B?UVltU1YrMnFWdENXa292aWFGN2x6bmZLMENXTGZ2SGxjbFMzRjg0VkZhT3Bi?= =?utf-8?B?ODBveUVEOUFlaGFzYnZpZG1iYkwrWHlsZk9iaEw2Rk9GM1c2N3hxVWp0Yi9T?= =?utf-8?B?aFZWYzIwd0pjOEs2VUFIVmNTK2JrTXhVTW5ScERDMGFaZHdKZ0NKWWJ0aXRR?= =?utf-8?B?UVFScm5YTzlzSVk3ZnVqRE9YYzZkckY1MEdqdUtGcWFocG9BWXVTQUVPV0hs?= =?utf-8?B?eUJzcERIcVlEWjYreHlkUllXODgvbWJhTlBMbWhoVHduMmlmUDBaS0FEY2p6?= =?utf-8?B?TkdRUllzL0lGVjlKWXU0dlNtc3UrekxGRjBjc3ppWmpJaFY2Ly9Nei9uc08v?= =?utf-8?B?dWVmeG9pNEtSc0FPSm9TenpmRUk1bmFqUWoxVVAyOUVQNUE1L2czeE52Tnlt?= =?utf-8?B?UUhXajRaa1M0QXVMQVUyVFRkV3BidUM4RU05eW9BeFlLYkF0UFV3QkprVzg4?= =?utf-8?B?U0JjK2Rpd3FOazdEQXhna1IzSFRKN1ZsN1E4OFFWdUpQR0ovRldFYndRMS8v?= =?utf-8?B?U3lmUXVHdWo3TGhzbGM1b3FTeFhzTytiZlB4WFc1LzVUVXQ1eEF5MkRiSVVN?= =?utf-8?B?RUFOVlVvNzNlTGlzTVozK2ZwanZjakdYS1o3YndZQVdlVnVEa0pIZG1ISzY1?= =?utf-8?B?aGcvUklpYlg3TmxrRHl1eFRZcHVSQTNsMXBtTFFGc215YzZRMWhndjc4aU9s?= =?utf-8?B?em9CbnU2bTIwQm5MMjhXQWJwWEFZRHd3Zk1mTVVIaCt6dThBZWFmK3lwbFNN?= =?utf-8?B?MTBUNnFSRzhZK1ZIdENEemU1RU9GZGFiN1NyQ0x2c3hKdmlUck1tZzBPVHFr?= =?utf-8?B?aWhLQzZTc0RkWTFkMVRXMTRPUlRVOEp5bGh4L1k0dit2SUFGMnJJTDRLMHZv?= =?utf-8?B?bEgweVNIUEdEVFYrT0ZQZUZ0K2JkV3lnRHY1dWNvWDhQNFJwVEhveEU0cVor?= =?utf-8?B?K0I0VWRDNUxpc3YwOUQzV284UFZrQUlFNEx6dTNoVDNXVWNDejcyMndLQUo5?= =?utf-8?B?WVdWQTdFaFUzK3U3dkNiMHE5YlBhSWt0eXBTZzBBOTVBRzNqL3dmUHRFaXVY?= =?utf-8?B?ZnczSCtNL1ZocDFJNlVaUG16c3AvUTFMRFRuQkNUTk83Zi9YbVBXUWpkT3B3?= =?utf-8?B?STl1M1d2Y2gwalQzWHg2cVlTWTlvVTdnemtVbHA4UlU1WGl5RU9zSUozcDBW?= =?utf-8?B?azFiTytUNUF4WnFEY2dOcVRZUTI2NTBKa0FQaVY2cXh0WmdNQ0RZZkNudWxQ?= =?utf-8?B?TFcwNjJxZUg0K3JudDFPZzRDeldZd241YVp5UnhYSkcvcEtUR3ZacEN4UlRs?= =?utf-8?B?bThUSDFkQ0E5SnBZK2pjRllsK0I2RjBidXNBM2FyTWRINzNUbXNVdEVoNjJ6?= =?utf-8?B?WGR2M2FRL1pRTC9KajF0WExjMDVCUE5FL0FXWTU4RGU3RWJRdlNLUy9HQnJU?= =?utf-8?B?NGlUcmpsa3V2bUhYcUcwWUluL3F0YllKY2pEMFpxT01YU09jNmUxNkpja010?= =?utf-8?B?TDFVN2RqWkZxUmxkWFBudjJlSmM5NXZRaUZORzA5dWRxa1k0QzlzN0VzOWlH?= =?utf-8?B?VStDSS85bzNkd2FLUmhCZ3F5VXF2dU5xZERIZEdJUnJ2WmEyVG5DRTJaYWY2?= =?utf-8?B?RWtTZFRJSTNxZUFBaXpJbGdDclNZQU1vcndSVUdleTQ0VzdNSDhFK1Q3V0ZV?= =?utf-8?B?M05lL3F1WENCZ1lqS1FReHpFUm8veThVU3lsWC9JRTd0TWxOVjVweUtRc3Ez?= =?utf-8?B?M3doZytEVG1iTkg1MURVV1d6eGxIS20xQ0RiVW1ZQ3hKT3pnSXo2VjN4UDFE?= =?utf-8?B?SGkrUzR5cFNJZUdLbUx4b0VwLy9EMDQyWUl6SUFKS3lKM3lUdGN4YU90MzVU?= =?utf-8?B?ZVdZZ1duKzd2OE9TMXZ4aThVU2l5RFZCVlpWSUY5aWY1Wmw1SFFQUmwvWE0y?= =?utf-8?B?Q3IxREkrelBzcWFlNE94dGY3cUZPN0wxM2cwNklMY2lIM2dIbU5Ka2x3dlla?= =?utf-8?B?blQzaEdiZDdtRnk4MFlTM0dBZ05Kem8xM2svckwzWlRSMDJUVVJmT3NIZ2VL?= =?utf-8?Q?B8vZP4r4SD/PVV0RBo6NNA+XJ?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 3/f7DEE0Ppf+OQc4DNA1S+TT+Noy177i+dO36DtesM0Xw0ctwmEN9IiDHCvnqtbY+FdXiOvVr15eIN1QjyCphMADiW3N6/KvplCWkgFqU/kOwiygfLrI/G2gRGBd6iufDpaOgvmfGoNCRTlcBNSzvbJ7F5+31hLpJaJB/eWpyjIF+ORMYHdoCLe73KvYn+N1SL33N8ZH1oe/ANv0J7G+8sI7Bj9LQV2SDS5IPJ3QCe3HOClXpJAJAOejg8jQF9vgN9RZcWs9DGeRF1QAM/rvJMPcriRvHaxQBaop4Li6KKMG2z2CdZGakZCbOCOxH/VyJCbSFD4TOAISS79r7e/bSmpTOY5yyW+138jiTFtdwz0ZfCq5leNl0m3IUrUligMTfkeXZu0kAi6g9UAJjML6HWUw3wq5/Ds0+lpv/jtfCyS6X7RMvVhrPE6wMCoiFUGmocIJjBzbcGyrQZ4E+jKP2X1AIBZ690lLN82XfoQXdC7qxnTtvX8ZY4vi+ZvOVSr82F7t+vJub1zM/j/mn5CLnnZBLf+VcagW1uw/zAG0ZV2LNvcGkc36RQNydYQ5d63iALYuM8SJTJvL/WQPn+E2U7XwjbKfcmmK0kb9q1bo4HPG/v3jSG8r+7GJZTiWJ19xQ+b0XDlU4e3S7cm/T40+l6Sq0AM4ESxHyELetDiTfa7xcSC8pmO5gNiNk5mVMx5QVjtXogdSOxJSECIgt26Peo5CXlzqQwlP9qMnUIGAxrV+QBiBIN6k9e/ZmHwJNGLJkOJomgvydcf9FXIreZ9hErjIbjgdYXmyqjeNrijerVc= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e7e98993-5ba1-4acc-6e8d-08db5dbcf2a1 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2023 07:43:51.0539 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nzpwwAd7GxuiOu+Bhk/VUF7dyfSYILwpDMGxLoVyNesN/Osc51CqWM02LXjv7qz7hrng4i4ipUJbUtrfYYG+YA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB7596 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-05-26_01,2023-05-25_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 bulkscore=0 mlxlogscore=999 mlxscore=0 adultscore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2305260065 X-Proofpoint-GUID: HVDyGZS8tbNgYLxfHBIcc4ac2oMPIV_f X-Proofpoint-ORIG-GUID: HVDyGZS8tbNgYLxfHBIcc4ac2oMPIV_f X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/26/23 00:30, Jan Beulich wrote: > On 26.05.2023 09:01, Indu Bhagat via Binutils wrote: >> @@ -1022,40 +1049,28 @@ sframe_find_fre (sframe_decoder_ctx *ctx, int32_t pc, >> bitmask = 0xff; >> >> fres = ctx->sfd_fres + fdep->sfde_func_start_fre_off; >> + func_start_addr = fdep->sfde_func_start_address; >> + >> for (i = 0; i < fdep->sfde_func_num_fres; i++) >> { >> - err = sframe_decode_fre (fres, &next_fre, fre_type, &esz); >> - start_address = next_fre.fre_start_addr; >> + err = sframe_decode_fre (fres, &cur_fre, fre_type, &size); >> + if (err) >> + return sframe_set_errno (&err, SFRAME_ERR_FRE_INVAL); >> >> - if (((fdep->sfde_func_start_address >> - + (int32_t) start_address) & bitmask) <= (pc & bitmask)) >> + start_ip = func_start_addr + cur_fre.fre_start_addr; >> + end_ip_offset = sframe_fre_get_end_ip_offset (fdep, i, fres + size); >> + end_ip = func_start_addr + end_ip_offset; >> + >> + if ((start_ip & bitmask) > (pc & bitmask)) >> + return sframe_set_errno (&err, SFRAME_ERR_FRE_INVAL); >> + >> + if (((start_ip & bitmask) <= (pc & bitmask)) >> + && (end_ip & bitmask) >= (pc & bitmask)) >> { >> - sframe_frame_row_entry_copy (&cur_fre, &next_fre); >> - >> - /* Get the next FRE in sequence. */ >> - if (i < fdep->sfde_func_num_fres - 1) >> - { >> - sp += esz; > > The buildbot failure just reported was found on the commit prior to this > one, which removed the declaration of sp. Please try to make sure that > every patch builds (and works) okay individually. > > Jan [(Re)Sending to binutils@sourceware, I earlier sent my apologies to the builder@ ;-) ] Yes, my apologies. Turns out the 4 commits I just did were not bisectable truly. I split a change into two logical commits, and missed testing them one by one. Revision: 812d868850126d8e791795c7e248ffbf580925f6 causes build failures, but the subsequent commit (Revision: 83c219872b2131546ccec7edc57eb47c64b8911d) fixes the issue. Will take care in future. Indu