From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by sourceware.org (Postfix) with ESMTPS id 74FAF3858412 for ; Mon, 14 Feb 2022 14:04:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 74FAF3858412 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02lp2057.outbound.protection.outlook.com [104.47.6.57]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-5-iCIh0aLXOauuTZW9d7qx9w-1; Mon, 14 Feb 2022 15:04:54 +0100 X-MC-Unique: iCIh0aLXOauuTZW9d7qx9w-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cgKO9GcS04KYhifDGJODSaFI2h7ZuZhZCgRMxUaQBbGX+AfotQENtUHaG1JKv2RP/rjZWEgr1xCiwkplma8pl0Zn+2H4e1ykyVLL2b+SfIQMhaIWe+YUC93wzDufGjiSE6xx9MlB6hvZhvnQaxPTfMigGgys2TFp8r+MlSEg52Aosmj7dXpZNFou5eguJaQVXAXgv9seNBlT4/KlvrjonaYOvKrS9k/zKWREzEXtXGi789YvZa7ri0Lf/A4TH4YVl3EfUTdMlU8u+7TfZnQesciKz7sIOW5frExr6NHEhWpszxco3AQcn7ApALQAL6KBU1VyCWMwDiou56lyDUkvvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tEPl8mJ67JjqA/9oPPEl93E5vgFi0bXbRNcCdArVQiI=; b=PQUMd6viRpijDzaCxdkOz8YGdrOPH6c17kgi2yTZ4ACS1BGiop8Nigmt2qzyEvYeTQvusZILedXB/m811LyqjEDGiuMYKW52wYNIXpvW+RZHOwMDvn427EOi/eB6PwazH5HIPRX6ER4HdcYriUBXlNBdfcO8rrAhxCAtOeb/4IwzKePTAtqihu5VLHzo+qMSiHUJIjM9vZkcTzBq0mm6mX+Yl2UYygUgLOHEYuo3ESwNfKiPhoB+1aNrNlv2xZPaJ/YmeQNkP+LlvoRPcNPeztSLZCYMPge+G3izop3IaMQu1pibkvbIWCQdkGXyTUSRVWxqdo0oTNlP+g4v6YJHKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by AS8PR04MB8724.eurprd04.prod.outlook.com (2603:10a6:20b:42b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb 2022 14:04:53 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%5]) with mapi id 15.20.4975.015; Mon, 14 Feb 2022 14:04:53 +0000 Message-ID: <716e0452-bbd3-2e97-84c9-f5f11d8b9b0a@suse.com> Date: Mon, 14 Feb 2022 15:04:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: Arm64: assembling adrp with operand involving . Content-Language: en-US To: Nick Clifton Cc: Binutils References: <2b85b841-e617-618c-9a3d-50101faded80@suse.com> <84567b31-7ed1-a377-7d05-8b6596871ae7@redhat.com> From: Jan Beulich In-Reply-To: <84567b31-7ed1-a377-7d05-8b6596871ae7@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8P189CA0011.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:31f::24) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 344fc5d3-d54d-4908-fc7b-08d9efc2f904 X-MS-TrafficTypeDiagnostic: AS8PR04MB8724:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SGkd7Mx03nKrqvXsYYbYqNnG34SEN1wJw84Po6a11PMG3WgyUo+NGPD+4HLUZ3eGFRAEvJpg17+4iJCANeyUDpWQmm8pTtz0NHWfsE6NUvy3TwwHsj8HCdXHZ2TlPT8DqnoZ+Nqx1P7V/aai+4UaAuMVjPyi0uONRTYpsEnWLcSrcs6Z3aQBWZPVkaRiFgFZ85zHTmsZY6fg7aCY1MV11tOgMjpa64WX9QZRox0wyRQQgKf5sZ+qpW5xCrXqr7WCEZsnEpfI2AvC2OkkjB09DsbPkLX0grr78iwJxsmlAXO7rn68wIyjr1xsnhqgMi+LkWd7u19tkARphc87OafKwUx4bQvmN02Hm0PiQ2luYNhuTQfl6K4AMeIFWQJ+S/nzkxclhSIoP+EJy5JhuKm5zWAhyumU45gVKh3mPPzHSYqIJ/cB0g/TmZk81ufnEryQ9JpUQ9LTqDJwmU43eFx9ZpZ0FVFbUp2u/n0D1tUAuSc4ASgP0UitEMNmQPSg1yr7MNZkRYibLgZs046jVh0AVar/hse4c8xOzARIKSZxZqeAeNdyj/nyL95rnbuh+lqt2hF2plfGO265UqgpEi9vVM6IA5PRepYosscIgnjdJVaT7kbV08ZTIZZJuaoXqmieJJXBggMZbUyIsP5NgBAJTbZp77iyoHYSqJlQQPUnYY/h8BopjbefC2ORHOBjqWXoalr/3tkTD8ppObC6sxUmGaMP58SlFcpP6AjCSp3RG5g9L0FTT6o3v01+oVGsjWqH X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5600.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(2906002)(26005)(2616005)(186003)(6506007)(6512007)(83380400001)(53546011)(8936002)(66946007)(8676002)(4326008)(6916009)(31686004)(316002)(36756003)(66556008)(5660300002)(66476007)(38100700002)(508600001)(31696002)(86362001)(6486002)(132733001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZVdrNzU1ZlZQSUtKNS9XblN6c2pVRDAyUlpTWTlyNlJDTEFPVjVWNzgxWE8x?= =?utf-8?B?Sm9KZGY2MkhCOFV0VGh5SGg3QW5BYS9XTnVpOUh4UWNtdkt1ZmM4S1RaRmFn?= =?utf-8?B?dEVpOTI5ZSs1OVBlRjhleFFNYy9OdnlDM1QrcmtkbEh3QTB5YmpuTFY0eXRD?= =?utf-8?B?ZlIvbVJZc0ZZQVZ5QW5NRGRmMlJ5cTdmV3hCU1NGQVdjdVR5TnlBNlo1bHB0?= =?utf-8?B?MXFjRVVlZHdiMUdjU0t4QzFtblZlbGs4ZERjWUI0Z2RudVVrWm9MUzlHb0Nn?= =?utf-8?B?bFZzdHdDblBTWXJZb2NiMUtmR2ZObytnVDJxc2R2S3dMQkpvUFN1dHlvZCtp?= =?utf-8?B?L2t2R1JXL3JFWWtNQ2gwdVlJMFVyVlFpTU01NjRGMklpNUZidkpkMFNLckpw?= =?utf-8?B?bmVpb20yb2N1aWdXeWNzcHA1bFJ4RVErVStSWFd4VlNFN1l5RkQ4bjFDencx?= =?utf-8?B?b1A1dmVBbVczem4rMVBFSFl3dWllZGlzNUpLelhEODhsNVIxbXFKdzFwNms3?= =?utf-8?B?VXJ5YkdxdjZrSCtsc2dET1pHNzJmTjVleExhTS9WQ0hRcThvemE3Q2d4ZnFK?= =?utf-8?B?c0YwN09reFlTOHQvNHluMnhmK3ZLMHhhTUY3Q2EvYS8reGVhQ201RGhvNEhF?= =?utf-8?B?bzdRVTI5VVJtdk1nd0ZITkdoczZQRUhYNzJMWjd6eE1rdXYwcGFiRWRsYnVx?= =?utf-8?B?dzdwQUJJamhtb0pQaS9uYVBOZlJ4TmhicEx5UUNEdjFaU0cyMmtPZTVhV1Vk?= =?utf-8?B?a0UzSUt3VWJxNjhoR1V0ZTRKbERjT29qdlpVUmNyaWdWUll0ZVlVQ2Z1Qjlz?= =?utf-8?B?RkFFZWFsVDVTZzc0OHBJckM5NlJzQXhnSTVGUnZqdnlPVzdFRURzc0Q5aTVD?= =?utf-8?B?ZXFKdzRQdWFKQ2poZU1YRGZ1SmQwZzA4WU8wNGF0VzcvRHRiNDI1UmlsMHFh?= =?utf-8?B?a214c2RRWkN2dVVRMlgxaDV4d21PUU5NS3BxNEFndXNGdnhLMFUzby9GcHMy?= =?utf-8?B?Y3NielViVkZRQStNQUI0alJGRTdsVDRack5LRGNlaGVjbTdlMzE1cmQzRU5l?= =?utf-8?B?SWhPeG8zQnp3WGRUZnhkTkE3bmovN001Y3RHRFVjYytwdWZLc0RjWUorTVFt?= =?utf-8?B?REdsNmd0NW9oWTl4dTZ3azJTdS9Vam14Smp3cDR5T3JTbnh0M3FhdDFOTGpH?= =?utf-8?B?TmtWR05NOEExNjhGcDBmaktLcUx4QkIzL3pMMG1wK2xhR3hTeklTY2lMSnVh?= =?utf-8?B?RlNlSkx5QUE0L2JuQjVuaFpmRXNwWEFRQzZQblVGalVKd2dYRlJWb2VIYzI4?= =?utf-8?B?WEh5aDkxRU9Fcm1hVHdiU0hBY1FnL2x1Y2ZVc1dmMExzeWd1cm1aMlVuRWhL?= =?utf-8?B?clVwdFRVMk5HOHJnamJHSHJ6TWVkNGl2NFkrTU9razFBcmx0RWhESVVNWlov?= =?utf-8?B?WDU0eXdaMnJmRXhURnE1anNQaHVwWjdyZmVrOVRFcVg5VWhCU0ZMWUlmTkxI?= =?utf-8?B?d0VxMFhML1RuUkNMczFjQ25JNlM4bWNmci9XRXZ4bnVHZTIyblAvTy80aUJN?= =?utf-8?B?TCs3ZmRvMHJ0bE8zbEQybFRIVUEzSThERnBXQlRzeDJONXNZL0xMV00vc2tF?= =?utf-8?B?Y3RWR09vbjNRV2tVOWlEMXVjcUt5N0FxaS9CWFBtanphZWFLSkF6R2NzcUo3?= =?utf-8?B?SVc1T28vMkFFR3JiMk53dUQ2UE45Q2hMd2ZacEdFaXVBRVFxQzRDeGZKdlNT?= =?utf-8?B?SFlrZGVVaFhoU1B6eVdyUUQrU1BKVmtmWEtDUUhqbEs1TVcvSTlWUk81emxm?= =?utf-8?B?dVcyeVBEOXRoNVdPN2lHbXBKOWxyM1pBTEYvcnZ5WHl4OTB2MU5KcWU4aC85?= =?utf-8?B?eG5SeFFkUE0yR1BhMUZTQVgxNzhQVjVLVXZ0Zi9pSWEyTVpKUTljOGlvZVhr?= =?utf-8?B?WlpzVWV1SDJWKzFUZFQ5ZGxRSmN0eWF4Slc5OXp1YjJNUUJUZWQ3Wk1uVmZC?= =?utf-8?B?clMwWVJrR3Zkdm1tT2s3L3JRcUlEZXp4QklUTzU0aXI1UFNRVkRnbmV2UHln?= =?utf-8?B?OWx3L015MVRZbmpHRUsxTGxtTWNnemVEMGpHbmhZRVNaNGpiNVVIbFBWRVda?= =?utf-8?B?M0RseVViRmoxWmtMaStRNHpKVGU4UHZLdmM5L3NlL2htMHBYYVpxSGZLWFNK?= =?utf-8?Q?2P0KwwXIub2s2qoaC4953qM=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 344fc5d3-d54d-4908-fc7b-08d9efc2f904 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 14:04:53.1589 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rYp5JLHRO1sNxlGt8FiLfVK55Lo34fUQb3QL9/88DE+Eqb7gI6UP5137ebVpkIbwNAAYEShiq1yubabO/53uBA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8724 X-Spam-Status: No, score=-3032.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Feb 2022 14:04:58 -0000 On 14.02.2022 14:35, Nick Clifton wrote: >> I would expect these two >> >> adrp x0, . >> 1: adrp x0, 1b >> >> to assemble to the same encoding with similar attached relocations. > > Me too. > >> The first, however, appears to have evaluation of . deferred until the >> end of assembly, i.e. the resulting operand depends on the number of >> subsequent insns in the same source file. At a guess this is fallout >> from eac4eb8ecb26 "Fix a problem assembling AArch64 sources when a >> relocation is generated against a..." (for some reason the title is >> truncated). > > That is because I put the rest of the description on a second line, sorry. > The second line reads: > > generated against a symbol that has a defined value. > > The patch was created as a fix for PR 27217. > >> According to my observations other insns aren't affected, >> yet the change to parse_adrp() doesn't really stand out in said commit. >> Hence I'm neither really certain that's the one, nor how a possible fix >> could look like. Do you have any thoughts? > > Well the change added a new argument to the ...get_expression() function, > so all callers were updated. There was no specific intention to change > parse_adrp for some other reason. > > Anyway - this does look like a bug, although I think that it might be > restricted to just an unadorned reference to dot. ie: > > adrp x0, . > 1: adrp x0, 1b > adrp x0, . - 8 > > When assembled and then dumped, gives: > > 0000000000000000 <.text>: > 0: 90000000 adrp x0, 0 <.text> > 0: R_AARCH64_ADR_PREL_PG_HI21 .text+0xc > 4: 90000000 adrp x0, 0 <.text> > 4: R_AARCH64_ADR_PREL_PG_HI21 .text+0x4 > 8: 90000000 adrp x0, 0 <.text> > 8: R_AARCH64_ADR_PREL_PG_HI21 .text+0x4 > > So the ". - 8" expression has evaluated correctly, but the "." expression > has not. I've mentioned this aspect in the bug (see below), but now that I look again I'm not sure anymore: Wouldn't this be .text+0? And isn't it getting close only because no further insns are following? > Would you care to open a BZ for this ? Bug 28888. Jan