From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4588 invoked by alias); 30 Jul 2007 18:36:59 -0000 Received: (qmail 4579 invoked by uid 22791); 30 Jul 2007 18:36:59 -0000 X-Spam-Check-By: sourceware.org Received: from b.mail.sonic.net (HELO b.mail.sonic.net) (64.142.19.5) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 30 Jul 2007 18:36:54 +0000 Received: from webmail.sonic.net (b.webmail.sonic.net [64.142.100.148]) by b.mail.sonic.net (8.13.8.Beta0-Sonic/8.13.7) with ESMTP id l6UIaqxs006973; Mon, 30 Jul 2007 11:36:52 -0700 Received: from 12.7.175.2 (SquirrelMail authenticated user msnyder) by webmail.sonic.net with HTTP; Mon, 30 Jul 2007 11:36:52 -0700 (PDT) Message-ID: <7198.12.7.175.2.1185820612.squirrel@webmail.sonic.net> In-Reply-To: <20070726125019.GH11649@bubble.grove.modra.org> References: <4480.12.7.175.2.1185407110.squirrel@webmail.sonic.net> <20070726125019.GH11649@bubble.grove.modra.org> Date: Tue, 31 Jul 2007 00:39:00 -0000 Subject: Re: [PATCH] memory leak in coffgen From: msnyder@sonic.net To: msnyder@sonic.net, binutils@sourceware.org User-Agent: SquirrelMail/1.4.9a MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2007-07/txt/msg00536.txt.bz2 > On Wed, Jul 25, 2007 at 04:45:10PM -0700, msnyder@sonic.net wrote: >> * coffgen.c (_bfd_coff_read_internal_relocs): If internal_relocs >> are not to be cached, free the temporary buffer. > > OK. Alan, unfortunately, I think I was wrong about this one. We can't free "free_internal" at this point, because its aliased by internal_relocs, and we're going to return that. OK to back out this change? Michael