From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 162643875458 for ; Thu, 11 Jul 2024 17:59:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 162643875458 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 162643875458 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1720720771; cv=pass; b=RqaOKhg8T0V0SnGtflH7sUqK7mw2ArANKOaDZ9Dqsb+FTfTC+O1/kdtQSP6nkJ/0fAJkV/kr1GoyNyBOmqkpjDZoRmAZ8/2nQUj8jVFZkwxqPqo3QsxQCmF6jx+zT9FEO3WUlOKedhXZ9HZP06VYarwFTy1WEjzpqHcpyCZjBRA= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1720720771; c=relaxed/simple; bh=6hU6YiE+mM2518wYRrdvaLi0Gw8YFb5HkXDjqGRp1us=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=rWiPmL2f4sGCpLBwHREZLiMmosbUkVWoEE1mzV4xMBWYisCjRi60bpdqF8JYmQ6RsgtCQiGj/KNFM3zhd5j5kbxGhyNTogzyyg4jsy+F5iI2MfHNOB2N/RpN0XzhjEj85kEWtl93LQzcSeIASEdC71ZWSxUeobzGa/sbJMkkgvw= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 46BFBZAo027101; Thu, 11 Jul 2024 17:59:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= message-id:date:subject:to:references:from:in-reply-to :content-type:content-transfer-encoding:mime-version; s= corp-2023-11-20; bh=laoSlJ6aJMQeN4tKDjxbaIygqE+XYo85QGn0AVw9w/M=; b= BrCubQ6wUlCRFpvjlKwt/aQxTgiAR27U5g3ZercNTcXa4zM9ORFAhEuvCbJNEVi/ eVM/cWqB2A1OPV/EvaJKUYQyX/DPvJoRqnPZf/J67eksfK/QlzlY/WKlqO27dgFR 3Axhx2cWqWaJaVRhriUNKu2FXeyISoARudkzF6bjkf+t3jQ1RmGcCX9f2bXQsAku 3ZSaCM0n7RO8BKQQDzl2ZaKP7nxJg3N0vgLLGn7DfQRWTre2pmzeHYHDvmoEnCuG FV/cqVgkhBzDYOrLgnlUmWfowFpFRRajK7GK0FTzg6RneFsXlwoP1v1DjKOx32AR tBAGTqVob+G1EyquFGxvgQ== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 406wgq293b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Jul 2024 17:59:23 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 46BHnn5m022664; Thu, 11 Jul 2024 17:59:22 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2168.outbound.protection.outlook.com [104.47.59.168]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 409vv2tysr-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Jul 2024 17:59:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=meVxXFNFV6sprYRk0EBdWkJS+oV8RBLbI4R31c9dGoHsbq0HKfsHD+980MfkmqPOg0aao0oJW330HqKwfDpdL2teQmjGCUNi8N4LLDkCCoDeToFqKt7tGQT8gG2KTnYvvOo51UOrZtvWm1PEkLfbemMpoNodAfrwKzQbfV4qtpp/XLTICQW4N5ZArYXxzCAFmKoD6Jy7NBU9AEQ1YUzPdC1jdFhZgQ1M3A5hwemZilnGVTLXwA4dLkE4kUwjzZcLUBfnL12ys7yQuu7WiwiltzsnDj8sjcqCjjB0cWJ08YgPt27qmzRhbjACW852fxVMieJwOozGABVROhHvpO1C4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=laoSlJ6aJMQeN4tKDjxbaIygqE+XYo85QGn0AVw9w/M=; b=tgKP7+KI2DUdTZCZf1QdYubIlZYb+VF6A54ttUwdkGB7WHfQQFdUZ+DLYaMuVvBpC/THE1VAqNpWllUq27kayv5oIErERaJ3CzsqdUzAtQHXbLC+1W4EOAtqWrpbQXnk499bVxF5FM9AyWra1ooi+3xoYQBK7G20kR9lUK+isTby/BxW3wSXcrQVKXM/AbFy0Btae2pOfSAZ+xL3+eMieX+I8+Oewn1FH5gKdeXrw06QTuAO1Xk/jevAuqqSZd+idrnAvOuM4479DfVC37gy0aFxWLS8x7l1kE3y+4pVq6gjimREJTQc0mfxoDWTfpAd35EdRQMZOY+8WGuPTjTcpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=laoSlJ6aJMQeN4tKDjxbaIygqE+XYo85QGn0AVw9w/M=; b=PjJ/KwBxfuzdQJFwFXoU3cvju2CyvWWZPAQ1V/HI5HyQt8lPTTpqOH4w8IxZU9Ujiub3C2wly6VKGvE0tH7IA9RSyXsg8UnCGvuWwXVD2syCl2wMXi22HtHh92/Re6qvaBPdi+K1IevbryhU8Ge5bTE/uOWdv3hnqxUWg0bkSWE= Received: from MWHPR1001MB2191.namprd10.prod.outlook.com (2603:10b6:301:2c::32) by BLAPR10MB5060.namprd10.prod.outlook.com (2603:10b6:208:333::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.22; Thu, 11 Jul 2024 17:59:14 +0000 Received: from MWHPR1001MB2191.namprd10.prod.outlook.com ([fe80::d57a:d847:21f3:6449]) by MWHPR1001MB2191.namprd10.prod.outlook.com ([fe80::d57a:d847:21f3:6449%4]) with mapi id 15.20.7762.016; Thu, 11 Jul 2024 17:59:14 +0000 Message-ID: <722b9c07-d9d2-4516-a702-210042a229b5@oracle.com> Date: Thu, 11 Jul 2024 10:59:11 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH,V4 2/8] include: opcodes: aarch64: define new subclasses To: binutils@sourceware.org, Richard.Earnshaw@arm.com, richard.sandiford@arm.com References: <20240701025404.3361349-1-indu.bhagat@oracle.com> <20240701025404.3361349-3-indu.bhagat@oracle.com> <8f282d4f-8402-429c-967d-994ff23114ec@oracle.com> Content-Language: en-US From: Indu Bhagat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR04CA0319.namprd04.prod.outlook.com (2603:10b6:303:82::24) To MWHPR1001MB2191.namprd10.prod.outlook.com (2603:10b6:301:2c::32) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2191:EE_|BLAPR10MB5060:EE_ X-MS-Office365-Filtering-Correlation-Id: e087dcb2-7aff-41e7-cce4-08dca1d32cf8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?TDJTRHBhYis2UmRNbndRcitaMng4dktLYjBoQWJkR3dUMVE3ZzBFdTBZRlM0?= =?utf-8?B?cHZnZXdIYndWdHNxUTV3OXFocmd5VXFEWmcwUWtEZitHbDRWRDR4bUY0Vzdl?= =?utf-8?B?WjdKMUI1Mm1DODVRMjZlc3FVNlhSUFoxcW1PaHo4czBNTFFxN20zbjlRZTU5?= =?utf-8?B?ekFJTjZaOVhIRUxZR1grTmxxNDZwUUlxZFRISWE1SWg1QzhOa1lDN1ovMGlK?= =?utf-8?B?SGVtblNiNEptb2lrVys5dXE3eUhrR3QrKy84V2U3RGpodDZEUGhsczBoa3hX?= =?utf-8?B?UW5FOTIxbXd1STY0R2RvTHg2Ykp1cVNBWEJ5aVcrRW1DNHFPRlcyQjZra0FI?= =?utf-8?B?UDJrUzFDdGxzUWkrSUZ5RmxwWmk4cC9RNVJJUjN4WGxjc2pxcFNwZjJNWnNq?= =?utf-8?B?NEVsQittUGdEQmhlVEFMWjB2Ny9sakNFZHBGQmpaYTBTeUM0Nm96cWNCWU1X?= =?utf-8?B?UlQ1U0tCVCtKd3B6ZWFBVlhyVkg4N3VrRHpmY2E3RVVnQUt4M2x5c3ROKzMy?= =?utf-8?B?bjJWYjJseVdjTVoySWtuR2dBb1FIeEQ3UGM4Qjl5THFMQnFqUlZWdXpqK0Q2?= =?utf-8?B?VHBpd29lazZrb2d0blhCMFUvQVl4Q1VrV1FQYVVEQlB6NEtHVUlOdW9xenRW?= =?utf-8?B?S29MQXVHSGRieTZiUVpZN3c5enY2bUhITW0zVHpLM3k4ZlR0cDAyZHdadmpo?= =?utf-8?B?VzNuL0h6NEhtUFo1aHJPRmErSldtNmUxQWdXVHo3UE5MMWNsdFBHdS8yQWx6?= =?utf-8?B?Yng3Sk0xRGpjQkRkNGo4dlY4V1RreHloZGljLzVPRHN6M21SN2NIVG5jcXh2?= =?utf-8?B?bndKYkV3ZW9IRndkMDdtMWVxSGJKcHZSNWRIOEE4YStQRWpvZlJLUUMzb2Zl?= =?utf-8?B?QlNOdFVlcXAwZlVmLzc5WWNPc3p3aGIvVHZDVTlMKzdXalhSdXY5U0lQK1JV?= =?utf-8?B?TWJBSEpOTjE5VjVPUGE4ZFZaVE5WMXJDVUFTWHcrcGNGZVk3ZHJJVWQ0QWpo?= =?utf-8?B?d0tQZXFVOWhiamIvcDdGTzg2N1NEZEdYYUQwMlVleTlUZG1IQUlHS1I5RE9Z?= =?utf-8?B?MVVSN09sV0FBb0NwYkhMVFczRXV2TkkycjZIVzNmakZFMHJxMDBJbzB0SE56?= =?utf-8?B?T0NHYllwM1A2TjRMV1diWlNRZExPeGtjaG4vQUx4OXlqNzR3Q212L3NHMFVx?= =?utf-8?B?cnZYMENJc3BLb1dDR3QvaG9EN3daZmE1TjhEZ3RMdzZZVjJKSHkycUJ0NVJG?= =?utf-8?B?SmlXVmlZWm5DWmFLNzR4VHZtMXZXaUl6WnEzWUdkbU51RTdaNU53T1hlbHl1?= =?utf-8?B?cExzTGRNdHZlKzQ3NUh0RDJhdU1kWHIyUmFsa050VUZFNUl6ZlE1VURaVGd5?= =?utf-8?B?MndVMnY2L01LUnBnVXNTZnhiSUk3bW8vcW0rdjQvd215VFlxUVFPR0k2c1Na?= =?utf-8?B?ek1saUdjYi95UVMydUxPMmMxaG1OSlcrdDVGdGQvVndTVUFzNGc3eDYzK1FM?= =?utf-8?B?UTd1eHlyaFNaSDFUWUNEMndoMlBBa0tmOWtCMTRQTWpGMSs1MVlrNWlUWDY5?= =?utf-8?B?dWdFRVlLcnVLck9aazBtRTFUSzJKMko5bHl6cEZDZ3hsS1N3RE9VRnVKNnV2?= =?utf-8?B?dUFvNTNuMi96M0lQVDlaWko0cTFWbFZPYkt5emJINU9aSTBObElLT29lZWxK?= =?utf-8?B?WEdPMVVwN2hmUmRWZjFOZ0FZSU9FQ1prNG1BRlcyVGk2dkM4V0NXRVh1U1pk?= =?utf-8?B?cGxOZDRkMlRic01NUmZxQlFxMVFCVmlZMUVpUkhsSmpwc3AwclBQR1dhWGlr?= =?utf-8?B?dGdZK1lFeWppNDY3NjdlQT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2191.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L1NkaHBIbXBxcmxNT2F0RlJxc0FpcmlMZ0FYZ1lXRk1JVDI1WU5ETlB4cHQ1?= =?utf-8?B?aVRDVDlST3FRaHRLTHVQb0E5bkZqVUFzcHltcFlMMUd4THFqSEJBU3lWc2tX?= =?utf-8?B?c2RhWHp0ZTJGWlR6TjN0RWYrckdGTnJmUFgvOWhBbFk0NlkremlIdm0rYkVl?= =?utf-8?B?QmVzLzlQYXAwYVFLVGd6MFpYSklSYXZBanRpU3BTUmNqWko3MVBYRE9kaDVi?= =?utf-8?B?VTRQVUk3VVBCSFVhcngydkR4ekF1aG4wYmt1ZlJ4WDZyckpmTHB1bEY4WTFY?= =?utf-8?B?emtqL3hCNm5maVl6UGtSTnpRL28rcTdGUmpVYW9SdElGeWNqWldUeFpyb3dB?= =?utf-8?B?a2V0MVNwZUhneHlmQ3IxVWpaYVFxVkRTVFo4am5ybWRNbjZ3Z2Q1YXBjV0F4?= =?utf-8?B?ek1KRSs1VUpHZVVneEtIK0dNN1UxOTZtN2pvVHlISGloQmZDMDRpWWhaY0d3?= =?utf-8?B?VnhNTXYvY0VWUEtBTnNTQ2xPUTlqMnQ2ZDRzQ1FKdHpvL25UZlNsOWpwTWwr?= =?utf-8?B?L1daaHhFTFR3a2Z0R1RuSzJqMXRPVlRhN0h2SXBtMmVGOE9pMTE4L1dQa0M4?= =?utf-8?B?L0Q1R0NEeEtIQWF6dXVwM1VGdnczYmcrVlZoNS9Cb3pkUTc0SHo2R21IdWcx?= =?utf-8?B?MGV5STFDQUhWdW13NUluM2R2NG9jSmg0ZmxkWnl0eHlJeWxlNjdWRkRGRnZM?= =?utf-8?B?cmpvcTR6ck03Z0FaYWhCenE0QmN4RkhyWkxPYmhSR0VQYXEreEF3WDVudEtm?= =?utf-8?B?akVuOVVJdzhXRjlBZk10ZkJrR3hBcFRyWDNmeEVTUXg5bE9KZ2dRQ2R2RnB1?= =?utf-8?B?WUZRbjdQUUFQWEtSTk04VVdDby9QY2JQNkEzZk1iSUJIUi81bjR2QnhIcU1s?= =?utf-8?B?anFsRlZkRkZmUjVjQkorUDlxZVRMdEl0VURwSHI0U3JSOFBjM3FOdUZXdVJm?= =?utf-8?B?WUdOZnlVMnl5NVA0UHYxZisrRjlMNmRxa2R3Ums1UFdRTHc2eHZDc3NKa3Ix?= =?utf-8?B?WnNWaXdQbU5vTzhNZEVUV1ArRzgrclVRQjNzRVFkMG1xZ0F0R09WWTJjeVp6?= =?utf-8?B?L3NFUEJZejNDZTVGUHNXbkk1SGpFVi9PY2hRVk1ncFQ1a0xJSUtIeXl6YzlP?= =?utf-8?B?d1FwQWp4ZVIrZS9mTGthZ3dmZ1U4VXJVYWNwQUFNSGVEZ3VTb01HQmh3VHI1?= =?utf-8?B?L1g0b2phU1MrajJmVFJQc0w0UDBJVWw0azdnbUlwbWRvakJNTUJZYUZ1QVFw?= =?utf-8?B?dXlVeGEyb2h2Sk1odExQcXFFVmMxb3ZEL0NJU3hXL3Rvck05T1dFdXNJTDF1?= =?utf-8?B?R2F1czAxaHFzcVJpN3dEWEc2K2ZRZDhURFoyYjJVd0VFL0sxQnFRQU1IVWVx?= =?utf-8?B?Z25uWnJXODQ4LzdkSjFQdG5jRGVNK0hWVVVQRDdWTGl1MWY5VXlRWnRaQXg2?= =?utf-8?B?Mk41a3lwcm5EV1ZLc0VRbis0ZjBKVkg3TXhpZzY2NWJHVE5zaVN3S2gxYTVY?= =?utf-8?B?VFgzemczbnk4REdRU3JmdVU1VVR3RnlQK1lRc2VHdHFrUlVCc3FhZmhocFVm?= =?utf-8?B?N0d3a09qQnhIRkQ4dVVzcUtFRThmSWRYbS9wZmpVa1pBR3JYMUovc3drTlBu?= =?utf-8?B?VFFHditlWktOVEZlOW41L2o2QThBMDQ5MFJFUzhaVE5IZ0ZPUHZzVldpb1Bo?= =?utf-8?B?WVBEcjhVc1V4UUJQMmgrU3l3RjRJOFlRRVhxSWIwalJRNWpNeHNqUDRvRWN3?= =?utf-8?B?dVRQRVV5ZTFxZXRKeFFPV1dMRm9pUzdWdUVIVVgvenJoWW1zaU1aSTBPYm1o?= =?utf-8?B?VTdyZ2h0UjJrWjAzeWpsZFYvTWhJQjB6V0ZJY3JkcDVxOW5XUmd1bGM2NHB5?= =?utf-8?B?M0JzcFRqbXIvNU1vd3hKQnFRSWE5WXdEcG5mSTh3UU4xWWlsVXpDSzdJUHNS?= =?utf-8?B?anZFOE12SjVKODdXNVNOSXNKeWVlSVBCcHdVN0pyd2lJZmMxblpSYjZXR2tB?= =?utf-8?B?Y2lJSkI1RXVnRExrNzBxVFBBdGpKRVlCQWdhT3pHWUZWaEhiemVvekZHT0hJ?= =?utf-8?B?eXdHbmNIYnFXcXAxUTJFZ2hXWkd3ZEhMYmlHNlpCODdiTU5DVnJURzVUV2Ni?= =?utf-8?B?NW5GYXRqaFdRZWtLVjNxZ0RRVWJ2ZG9xMUltMm82KzhOMzNHa21ZR0taeEdY?= =?utf-8?Q?/j6Tkv6b3bRfzgXwKn3IVTc=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: rL5S8yNRwLXFVgphTrYrXJqmDH5FrTC/rQhECyFWAlqW+wJ5Cu9aRBm0WbEvtbXALdsJatHsHeGFxnEIl6ZI4E8zPd+MRle+iIRFu1kds6OIv3+1aP2WfJlp6cQdwpCZY5pOBWFg0e/o3Bv6nvQc8xBhJeoWIzbPUQvOGF6BDJDT9V8E3HOaZk4qk615MuMq3GPbHkNSHKbFoNDTXxnHjEhuFM1sOAd22KYZT4YCR38bKcNHhqL3W9bb2vKobqQunl+LGXg/QtHFgVDgj69TYyDjiObH8rL7/JwLxrCO/1t5400o7FDDAOYfxNsNcDvVmIMoLVMHH3mkr8VvotWw0sY+uF8N2LGETHlIRaf04kZ8VwESlDO5omPONQEbCKrEDDQzHMesqqiCEk/sYw/7BlUeAIRKryQ/joe1cEfLKRZk/ygcFh1SeWdjNpxcqX5Uw95XaMMD525aiR4oVocc3gvHx8mQBrGP9kNHp0JmgZjcNIn9Fe1w7eQ6jI3+kUw7NUfYk3qp6EgmXPXsBvoIELH7qmiHGg/g4ABog6/riaarj//BQIFNHoguok1KF2nTQTzrWi4J4xgmW3Z32aIAiuqyWQ6o7pTdmYV/V392pUk= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e087dcb2-7aff-41e7-cce4-08dca1d32cf8 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2191.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2024 17:59:14.5911 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4m0YLUd6CQQU2YPruPSrp4KfSDTyJ54vRFa6HBh0G2GELz1lu0nTzhm049ZhseAQyyLsIYCFj8Bzm46v678VAg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5060 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-11_13,2024-07-11_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 mlxscore=0 mlxlogscore=944 bulkscore=0 spamscore=0 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2406180000 definitions=main-2407110125 X-Proofpoint-ORIG-GUID: kzkLHQTphnjBP83tAbp7HPTCMrGEovzq X-Proofpoint-GUID: kzkLHQTphnjBP83tAbp7HPTCMrGEovzq X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 7/11/24 05:22, Richard Sandiford wrote: > Indu Bhagat writes: >> On 7/1/24 10:40, Richard Sandiford wrote: >>> Indu Bhagat writes: >>>> [New in V4] >>>> >>>> The existing iclass information tells us the general shape and purpose >>>> of the instructions. In some cases, however, we need to further disect >>>> the iclass on the basis of other finer-grain information. E.g., for the >>>> purpose of SCFI, we need to know whether a given insn with iclass of >>>> ldst_* is a load or a store. Similarly, whether a particular arithmetic >>>> insn is an add or sub or mov, etc. >>>> >>>> This patch defines new flags to demarcate the insns. Also provide an >>>> access function for subclass lookup. >>>> >>>> Later, we will enforce (in aarch64-gen.c) that if an iclass has at least >>>> one instruction with a non-zero subclass, all instructions of the iclass >>>> must have a non-zero subclass information. If none of the defined >>>> subclasses are applicable (or not required for SCFI purposes), >>>> F_SUBCLASS_OTHER can be used for such instructions. >>>> >>>> include/ >>>> * opcode/aarch64.h (F_SUBCLASS): New flag. >>>> (F_SUBCLASS_OTHER): Likewise. >>>> (F_LDST_LOAD): Likewise. >>>> (F_LDST_STORE): Likewise. >>>> (F_LDST_SWAP): Likewise. >>>> (F_ARITH_ADD): Likewise. >>>> (F_ARITH_SUB): Likewise. >>>> (F_ARITH_MOV): Likewise. >>>> (F_BRANCH_CALL): Likewise. >>>> (F_BRANCH_RET): Likewise. >>>> (F_MAX_SUBCLASS): Likewise. >>>> (aarch64_opcode_subclass_p): New definition. >>>> --- >>>> include/opcode/aarch64.h | 32 +++++++++++++++++++++++++++++++- >>>> 1 file changed, 31 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/include/opcode/aarch64.h b/include/opcode/aarch64.h >>>> index 61758c96285..c3ac1326b9c 100644 >>>> --- a/include/opcode/aarch64.h >>>> +++ b/include/opcode/aarch64.h >>>> @@ -1359,7 +1359,31 @@ extern const aarch64_opcode aarch64_opcode_table[]; >>>> #define F_OPD_SIZE (1ULL << 34) >>>> /* RCPC3 instruction has the field of 'size'. */ >>>> #define F_RCPC3_SIZE (1ULL << 35) >>>> -/* Next bit is 36. */ >>>> + >>>> +/* 4-bit flag field to indicate subclass of instructions. >>>> + The available 14 nonzero values are consecutive, with room for >>>> + more subclasses in future. */ >>>> +#define F_SUBCLASS (15ULL << 36) >>>> + >>>> +#define F_SUBCLASS_OTHER (F_SUBCLASS) >>>> + >>>> +#define F_LDST_LOAD (1ULL << 36) >>>> +#define F_LDST_STORE (2ULL << 36) >>>> +/* A load followed by a store (using the same address). */ >>>> +#define F_LDST_SWAP (3ULL << 36) >>>> +/* Subclasses to denote add, sub and mov insns. */ >>>> +#define F_ARITH_ADD (4ULL << 36) >>>> +#define F_ARITH_SUB (5ULL << 36) >>>> +#define F_ARITH_MOV (6ULL << 36) >>>> +/* Subclasses to denote call and ret insns. */ >>>> +#define F_BRANCH_CALL (7ULL << 36) >>>> +#define F_BRANCH_RET (8ULL << 36) >>> >>> When I said this field was an enum, I should have said that it's >>> a class-specific enum. I don't think we need the ldst and arith >>> subclasses to use independent values, and it might be better to >>> allow overlap from the outset, rather than try to retrofit it later. >>> >>> F_LDST_SWAP is no longer used (a good thing!) >>> >> >> OK. I have switched it to iclass-specific enum with overlap. I have >> removed F_LDST_SWAP and F_MAX_SUBLASS as they are unused. >> >> I have added function-level comments: >> >> /* Whether the opcode has the specific subclass flag. >> N.B. The overlap between F_LDST_*, F_ARITH_*, and F_BRANCH_* flags means >> that the callers of this function have the responsibility of >> checking for >> the flags appropriate for the specific iclass. */ >> static inline bool >> aarch64_opcode_subclass_p (const aarch64_opcode* opcode, uint64_t flag) >> { >> return ((opcode->flags & F_SUBCLASS) == flag); >> } > > Sounds good. How about "The overlap between flags like ... means that ...", > to make it clear that the list isn't meant to be exhaustive? We could add > other such subclasses in future. > Thanks. I too spotted this one and made that change already after I sent the email yesterday :)