From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140071.outbound.protection.outlook.com [40.107.14.71]) by sourceware.org (Postfix) with ESMTPS id E6CFF3858D3C for ; Wed, 19 Oct 2022 15:04:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E6CFF3858D3C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U7yTe0AKceywFFBdkD2cgrxChoaQg77hgec8kUwb4flrDfBRhtzoodpBnF96ged9BpTV1HksxgypUdEC2GsOapkWhuWfwz1JZuHHGmhTFEbjcQNjPI41YxgxhO12Ew00Ar3aUMWEXoWKZnahDUBeHXxCqihVR7D8nCFNg0QWKd7Q1IO94elk/tuYliTU3qJJY424UV+53hGxG/vrPZ0sxEfe+pjlidNQQItNsZE38iUTL9h0GNEn547eRUSGlPE7jhVyWQyLgMIAcNgWgEC4Tm/WA9AcMbAb+QwNAtzPGoXvuzIWJLz8ZgyWcKuHuzvNDJnePsDL1vTM0R+5nsfrZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3T9mQDBteopJeF5V3Y/ZR3fMjhQjTv3X2YIGmTEVqw0=; b=aCGNCCE6/EFc+KP+szAlj6032TWqwqTAM78mq9t2cPEwPeIw3SyxKVTqSclNt8TsdsxFcg/ZDqUuV1wbRoHZ3iFwXzjxY9kcSJ3m6u6LH06IKQ9wWzbC5rhq84RCpMgk2D0uJX/gLSnl+z2oR3JAkXLUCru6PWY8q2LYdaw+6oygNbv/IQilhXGSnte6Ux+Bqu6+4JVFr0PqLTldNfFLjECNMB+McHTz26Ez7PXmuDOeL3ChjVQqQyGTKcNfU0R+oscP3jk+whBtt2ORzEFGheWYHpb0h5uJa+NbPeC0X4bgcBjbxTTpQqnv/DDdMXBG/TBRKuajFqM+s8lqKggrdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3T9mQDBteopJeF5V3Y/ZR3fMjhQjTv3X2YIGmTEVqw0=; b=RPKDqndXT0iARj1oDEb7u0zoXIRw6G69iVd/33BZ32pPrycqcsWKbCIoEkmm+Fw3QeRDuMsK2AY7Y3aXELsl1Yk6Losg96gi25rP2VvePuUgAuhS+j6WW2h4z9kqmE9WvAzsS1EnDBQK7JhcFpKquGr6JxZpMDWuZzG7dZHuwHPobGEH8Fcqh6ygHlDyvLAijbvu7Rz7CzwISqkpoxUxBRw5beFfO4tckDbRWatsX9Eh00Unjzrv1uxMYDNtKSJnRu1tLpvpyKDvXtAl3ZS2lqIYhO4/HcECle/RXkMc9HGBdkeCJN8ygVK66hTwQNwAG+QFJ1f1tXzLqK5Yb4rxyQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7750.eurprd04.prod.outlook.com (2603:10a6:20b:2aa::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Wed, 19 Oct 2022 15:04:42 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022 15:04:42 +0000 Message-ID: <72ab468a-0299-d8a2-035d-5c9f04a5b626@suse.com> Date: Wed, 19 Oct 2022 17:04:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH 09/10] Support Intel AMX-FP16 Content-Language: en-US To: "Cui, Lili" Cc: "hjl.tools@gmail.com" , "binutils@sourceware.org" , "Jiang, Haochen" References: <20221014091248.4920-1-haochen.jiang@intel.com> <20221014091248.4920-10-haochen.jiang@intel.com> <8e2d8a02-1521-5fa2-d97f-3de4c997818f@suse.com> <5b7c68cd-3e39-7b5a-bff6-3b966ab33be7@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0167.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7750:EE_ X-MS-Office365-Filtering-Correlation-Id: ac8913c0-6b5b-40ac-2f93-08dab1e34067 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: V6g5YPdMmDNY2Y3hfQ1xS5qaKCxJids/P+B1vhIeT+kz5T7edXJBb7oQj6eLPZ4IK5iGxJGjI22zIqOeElDIb4SPS5Quo0hc5NJUmAdjy54z2fOkkxfxek/HjBQ4C6ztnb60j9RMZq1z0DewyNc3e0htEK8plh6wI/KNtXo4qs3xCm+06/fgHyObv74E/Fa/SR1t8aTDp4u9j5UXvzaymOmhpGH3PmNF8gN+fPlTtmkoJlcA8j6TNmb2TN0sUO6+uCk5JbhrVesWiN8NhFpL2wU2yK5FcSi710Korjwf39vBGW0+5VEhfttuQnF/82BukNqiSR5aonQywxsFU8d2ZUXJMulwi+Ya0nCKXUBWYGqsQOtn4keDRjN7Lz68+2Spc3xzWBZhKVhI2GvT/NrN/EJwb4rrUFnKvx+dhDZ5KhTAx2lXFmsA8nqimwMSczeNkt28qE2o8u0f+b7ZAOB/z0nxqnOxkjFq6RuDpJH7rfB+ajiMUY+nsKPfn99UGPMmnJazUvVZQLO4VH7yqgjm6pAYlIGDnHMlKKeQcP0WvzQfN8CZCjajSGba2LD2MJEHtKG14uCvVDWD8L5DUuG881OU6aQcS6xerX9CGRQEdINE89Dh75N9gpEpJtfGm0vmyjAEszmp5Kf0y19MVXv81DpyMeh7/fieHF1dWdASa8SlsO69EiZ19m82yKBdctJrEf4yDtYQkDKMpzH6kEFkb94DXONnpGzhXeC8TztU7PyWYLL6f+KGe4HvPi89Wyx+/3XfVFGQrqCTYKLu+eQwc4mmdcsRCTHNO069v3ZImDs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(346002)(376002)(366004)(396003)(39860400002)(451199015)(31686004)(36756003)(38100700002)(83380400001)(5660300002)(41300700001)(8936002)(2906002)(6916009)(316002)(54906003)(66556008)(66476007)(8676002)(66946007)(26005)(4326008)(6512007)(2616005)(186003)(6486002)(31696002)(86362001)(6506007)(478600001)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RkhUMm5QeXRoSXV4bCtvZStCRnZFZ3FIcWYvTVFIU0ZmdE1wQTIwU2NnTU9T?= =?utf-8?B?a0QvUnkxaHcyUDg5OEkxWEVFYm5Mc0xoZEZacmExZjVRRmszbUtJd29kTXBu?= =?utf-8?B?TExlU08xWDNXQ2h5U2dOeU9FaWoxS3JkQzIvTEhaKzFUYWw0ZXpheUNLR0xH?= =?utf-8?B?N3pCbjVsUy9kYlZHeEphNk9raHc5VXRxRGtlZjN6VnBVOGJUb0lQbGFWUWZE?= =?utf-8?B?QWwzM2xJOUcxTHZyUWJMS2h2eHAxVW9zL1dibHNMbG0vQUQ1MUVCSkI0Tm5Y?= =?utf-8?B?Y0JRejFxQ3VRYXJQYUxQTjNTRk50M0xxaXJJR04va0pibWN1aVNuZHY0SWFM?= =?utf-8?B?KzlodW40SzRFYnIwQmROZmR1TUdSVWZwWEpLOWdrcThSYnhlbWRnZXpKUmFt?= =?utf-8?B?YWJFSVpZMkhnYkw1aEhUam54TGRmeUVNMHlaN3FJV0tlWXRrM0dJeW9UUzUx?= =?utf-8?B?UVpNbkFLanBWc2RsQ0VaWG52cFhEWm9Udyt0VEtOYXBNcmJHYUpySnkyY3kv?= =?utf-8?B?WWdYUjVnb0M1UG9Lem02OEJxa2tjVjNYTXVmTEJkNENXYy9Ma3hXVmcrWVg2?= =?utf-8?B?ZWV1N1FLc2xZY3cvMG9pSkxFUVFacTRYQm1YNnROSGF1MnFNeEczQlY0VE5z?= =?utf-8?B?Uy9zL2M1RFRGNzduMitnczcydFM0aGxxRmZvempIcTJVOWJFYXNQbS9mYUNR?= =?utf-8?B?Y2hjTCtwSDB2dnVPQkRwU2pkNWFPNzNFc2lRQmdqQkVWSi9maUNnK2l1Q0th?= =?utf-8?B?M0V5dTE3U0xnRHIxVFFOSHc2NUcvYmNCMFZ1eURXWDc4alRZYWZJdFJjYXN3?= =?utf-8?B?RlRub2pGS0xDQjRoVkczaW9DTGtSSExZeTV0MVRzUE5QTkpYSVRTUjB5ZTlU?= =?utf-8?B?Qi9PdW5QUVRIY3JCMk5UTTVLbXhaclc3clZxbmpLdjB2bFFLR0Y5bzBTdUNF?= =?utf-8?B?dW40QU9ZZzZLSkc3M1p6N25SNmM3ZWNDOHJMSmNLVjZHR2VSR1VyR3E5ZGQw?= =?utf-8?B?Q3BXNndHSnVOM0kybnBORGljbUpBUWdTQkV4dVl2MXhCSHN5N21lQ0FzMGRa?= =?utf-8?B?RFFWRXpFajVqKzBkb2xCZVBVS0RTNVUzSm9LRzgwL0c3ZE0wZDQwdm8yNmN2?= =?utf-8?B?VGh0UldXbldvYVRxWWt2ZnVqQjhxTWZYelgzd21JTDZSeE9ubTFDOHR3TG1s?= =?utf-8?B?aExsSjFMeFBhUmIwNjVXQi91bUw4YmxDS013ZlBGVVlmM1ZKbWZjbEtIOFA2?= =?utf-8?B?ZE5yZkhxUml6Vk8zN1VWQ0xwNlZSblJoOWliK3puZUZkclZuSlNUMWxId01L?= =?utf-8?B?VUkzaThhZm9lV1NsTlZxZTJGOVhpQmtKdThvY0Uxdnp6V3dxdUJHVWNQcWUz?= =?utf-8?B?QlZ2NjJKU3VuMjdkNWgrMnY3dkZGbHRZWCtKWHlJcE96clNpQUttZXd6TzJp?= =?utf-8?B?MXp1WHFlMEFvYjFNc1hqTlZSeHczVWpUcERpaDNVb0tDTDZ4RittTXlQUUZN?= =?utf-8?B?elFHS2dHeWNjZ2NYeWdRMzI2VWRxVmpuSTIrL3ZXa2VKeTM5STJEU0d5QmYy?= =?utf-8?B?RzhWc21GM0dMeDhVdDBYbFovRFVjcWxUODAxa1JsVlF6bzlidlVoQ1hrQzFV?= =?utf-8?B?S2M1eGZLV1RaTlVodE85Qy9jdlZJeVEzMmQ2OUFQUjRQdUF1eUwyZkVRR1N6?= =?utf-8?B?Yk1Xa3RLZXRCb3Rnekt3RGtqSStobWx5RUg2ZVZTRmxacXhtdmhMdVdGMElC?= =?utf-8?B?KzZsZE1BMEMvZ2lrRDlZYVZKVWdNS1g1M2dYT3l0YVJMWE5CVUNBMzRGNFhj?= =?utf-8?B?RkJ5YktEWjVHOVlYcWNpeFNlQ0dDbU1YdDFKM3B4NVpxOHhTdWRSanZtSEUz?= =?utf-8?B?ZjFuZmhvUlNhclVkWm5vTVpEQXVaZ0psV2NpV1hjYXU2VlJxcEdETEFhVy9Z?= =?utf-8?B?YmZYZS9HZCtpaThhQk9aekRuYmpQZCt4amdjU1hUeVVXSHdZbDh0a05ML0RU?= =?utf-8?B?b29rUnZ3Wm0zRXZ0QzhjQTFVQ3ZxenFuWHJlNjhBeDkva3AyYVdKNGY4ci85?= =?utf-8?B?Q2JIcmI0dXJYRldwR2ZQNzg0SkFqbjVrSWNxUHdnTFZVUXZ4ODFtd0FxNFIz?= =?utf-8?Q?K/R/aY2drVAH1MiHHuuqWkh48?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ac8913c0-6b5b-40ac-2f93-08dab1e34067 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 15:04:42.3636 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FbklkY21eTH/ODHop/YRBzvwL4+Gn9yo9Jv/DiyMtod5T/mheYIOweOFgaMpORaIHbpMTyXCEa/5is60KWUGqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7750 X-Spam-Status: No, score=-3029.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 19.10.2022 16:41, Cui, Lili wrote: >>>>> --- a/opcodes/i386-gen.c >>>>> +++ b/opcodes/i386-gen.c >>>>> @@ -319,6 +319,8 @@ static initializer cpu_flag_init[] = >>>>> "CPU_AMX_TILE_FLAGS|CpuAMX_INT8" }, >>>>> { "CPU_AMX_BF16_FLAGS", >>>>> "CPU_AMX_TILE_FLAGS|CpuAMX_BF16" }, >>>>> + { "CPU_AMX_FP16_FLAGS", >>>>> + "CPU_AMX_TILE_FLAGS|CpuAMX_FP16" }, >>>>> { "CPU_AMX_TILE_FLAGS", >>>>> "CpuAMX_TILE" }, >>>>> { "CPU_MOVDIRI_FLAGS", >>>>> @@ -425,8 +427,10 @@ static initializer cpu_flag_init[] = >>>>> "CpuAMX_INT8" }, >>>>> { "CPU_ANY_AMX_BF16_FLAGS", >>>>> "CpuAMX_BF16" }, >>>>> + { "CPU_ANY_AMX_FP16_FLAGS", >>>>> + "CpuAMX_FP16" }, >>>> >>>> ... you request it to be constructed here. >>> >>> HAHA, you mean if there is no instruction that depends on CpuAMX_FP16, >> we don’t need to add *ANY* for it in arch_entry cpu_arch[]? Maybe when >> the dependency happens, we need to change it back. >> >> Right, that's why I did ask whether there are dependent features known to >> appear. If you go look you'll find that we don't have ANY_* for a fair part (if >> not a majority) of the features). > > I removed ANY_* for AMX_FP16, You did remove its use, but not ... > --- a/opcodes/i386-gen.c > +++ b/opcodes/i386-gen.c > @@ -319,6 +319,8 @@ static initializer cpu_flag_init[] = > "CPU_AMX_TILE_FLAGS|CpuAMX_INT8" }, > { "CPU_AMX_BF16_FLAGS", > "CPU_AMX_TILE_FLAGS|CpuAMX_BF16" }, > + { "CPU_AMX_FP16_FLAGS", > + "CPU_AMX_TILE_FLAGS|CpuAMX_FP16" }, > { "CPU_AMX_TILE_FLAGS", > "CpuAMX_TILE" }, > { "CPU_MOVDIRI_FLAGS", > @@ -425,8 +427,10 @@ static initializer cpu_flag_init[] = > "CpuAMX_INT8" }, > { "CPU_ANY_AMX_BF16_FLAGS", > "CpuAMX_BF16" }, > + { "CPU_ANY_AMX_FP16_FLAGS", > + "CpuAMX_FP16" }, ... it being created. This is the only remaining issue I see. Jan