From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 61DA03858D37 for ; Thu, 18 Aug 2022 02:12:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 61DA03858D37 Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27I0hj73007183; Thu, 18 Aug 2022 02:12:06 GMT Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3j195w08nd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Aug 2022 02:12:06 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 27I0U7Mh027094; Thu, 18 Aug 2022 02:12:05 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2100.outbound.protection.outlook.com [104.47.70.100]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3hx2da39y2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Aug 2022 02:12:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HibUz1Hd/8iCh4nhY+SK1OcF+JcHq5g0tAMoJQlg9l7lvBI8X+jDuGZie0RaESo4JaxM348oRAGpF3lnkv3ZZMxR/64iff+F6mzJAlEO6iWLiNSWuOBXEjDqo/8g6DCTrWeup8trp1yiGJyxU6Wp66dkkwKHCYme15TPzI4NLUcF6icgT6N/SNpgjCAZQQoBnw8Bygw74uRAcqO+RS9+S93hSdQa9sGfWj5nDO2Hm6qllcNSn57jXG1oImfS7b8HJkn/IPUeg4tN7g/DDnE/krKeLBax1tAquNenprBdjFxPi3atexrddvdLKDl+pcEjcb4abnmu/gSln5XpjVmCRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xtjlvbVOGbLCzYRrwv7IKyax8vvTAJNboLBwp4hCiW8=; b=n/lWXe43GJgDlstXSRxFacO2veVbEvOAG7ADYx7/9dY+s/tFiu5n658E7PShTuF7ntPkVZuI4r+TqHCZiXq9DnGCByfl9+yvtN/2JJbf8HPSiLosKKsTYB3QPfMRn823z7S9afHUk8hV1/SMdlvLYs57OmkwTdEvcKaKscgpcmdnz+GeDLOwLpFXXu7gsal8COgqiGq5ln86XSxm6giXjGjeVuvw2qdNisYZArT+pKMhTfUx/0TWt6kfP4/thYquf9GrCP9y63+uJWV0787fFbY1hE3QULAwi21ZewwH2r3TyyBe4O7qU/qSXcnZuD5ThBBXcquuilpz+Pr+A+DAIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by MN0PR10MB5910.namprd10.prod.outlook.com (2603:10b6:208:3ce::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.16; Thu, 18 Aug 2022 02:12:04 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::c1a:e14b:4f07:1378]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::c1a:e14b:4f07:1378%4]) with mapi id 15.20.5504.025; Thu, 18 Aug 2022 02:12:03 +0000 Message-ID: <73061799-cab9-e765-eeba-c21e27055e84@oracle.com> Date: Wed, 17 Aug 2022 19:11:54 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH,V6 06/10] bfd: linker: merge .ctf_frame sections Content-Language: en-US To: Nick Clifton , binutils@sourceware.org References: <20220802080452.1143351-1-indu.bhagat@oracle.com> <20220802080452.1143351-7-indu.bhagat@oracle.com> <9ae415ef-997a-ac14-4bbf-1d0413b9d6a1@redhat.com> From: Indu Bhagat In-Reply-To: <9ae415ef-997a-ac14-4bbf-1d0413b9d6a1@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BMXPR01CA0076.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:54::16) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2b844d9f-7902-43d8-fbb2-08da80bf0add X-MS-TrafficTypeDiagnostic: MN0PR10MB5910:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NLs5PKg9YWcYZBEOFkE+6JnI0Nv/RBylhKOPlnkmGLOyWnE0naAAlLdSwT54Kx4IasXVHCjIFc+VWYSqzgX9vn3wLbRFGlMcGZ8vqXPdP0UiuTAXsBqFrMlIzBJPepeeJeL9LmWs6BEekmuU+HkK1LOkerVM2CxzFkEj3YWZRwowCfQ+tmb49sBZDQMgO009OFxT4VjIQewKBA5EbMh0w2/3dh38Nx0RMWMGt4Ea15xRZVVi/97dewKTpUhP9vqhrBGGpFZGFf2J35F0V366wKVb2e5MXd+1uQBrm9KD1MRizsPo5TaB/ZOXC5pJyZky+qHFsTXEtu1phFJ8qA6WKiJE89wv4wz/kP8Zx/26z9E86/jIBs+Tm8kMwKPuK8ChIlGstNyay4KGFU0EXLrAQNKx8d6QZUnqsy9dKZsrxjGf4kz5R+4qEmzJd/VE3oDe/NzEMPw5hyRTj9S62RJY2oAlN4rYGXjlsb9Bp+g2YnCGKGBAXG6l9kElMYsp2FcA0S0ebs8PxyN/YueDfRzXj8qwPU1mOXFvW2qyYVcN5ZlpQ4SSmvx+pwMqx7COxFEE/w6++zA516ezMMR5SsSHyr0eNs7vSVyrID34BtpIKFf189HzaUwrMbrZ3s/E6PjG7SFxdnj6q6dUdH5XFs5xDGw7XPshCZPLpCRrbUrrPm2yLRP2cU68ilA4pykE6kU52F16Si6/K/IP1Sn/MuB6WvyCInxVqp46cKT8bkW+drSVG+D/j85bXEdLU4auih4u1nBK4CPMT85H74cVoD9RUmD2PfgmMsibmxQtY/cFDGEYPy2aaPtFQ0dfSCYcLc6c X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2158.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(396003)(366004)(136003)(376002)(346002)(39860400002)(36756003)(316002)(186003)(31686004)(83380400001)(38100700002)(6506007)(52116002)(53546011)(66946007)(8676002)(66476007)(66556008)(31696002)(2906002)(6486002)(86362001)(41300700001)(2616005)(478600001)(6512007)(6666004)(8936002)(5660300002)(44832011)(142923001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RUx4VmZXNytEYXpOc0xQNzhyTEQ1VklueDBNQzdJRGx4QUNPS3F0NmxjWjJO?= =?utf-8?B?d2FQeHdQKzZJMjdvR0FlWWlVMmxlQStzbVg0RTNvQm9PbnEvUUNnaVVuTmMx?= =?utf-8?B?b2JxVVJmYnF5dS9kbXVRbXNsMDYzMkc5aVdKSmdrd2hmSXFiT0ZoNlBId0dz?= =?utf-8?B?eXNxUXc3dDV6RUMvM3JkQ3ZRWWt1OFppY0Z0bGxMZWIvM3pQWmd0QjMzN2VP?= =?utf-8?B?aExqT2NmeHFoNVEvcFRmNkJuUm5BV0tEU2tBUE1BRCtRSTNKeU01dk9VNHpk?= =?utf-8?B?Y1B6UmJXVDRRR09rdVFRZkcxdFNUblk2Yi9jQlNTUmVuZllWVTliQUswd1NT?= =?utf-8?B?ZVRUelRZZVJGaWo1Y3dib2dJVHpPbDY0VlF3YWtMZVp0NVpuTVUvc01CRTdJ?= =?utf-8?B?VHRqSjhEOTI4T2ZyWUcrbDdpaTRDbXV3UFBpWFJ3Q2tpWEgwM0NXdElrRlF5?= =?utf-8?B?Y0ZjelZja0RxOC9sOXVIZTRRNnB1QnBqSzNUQVRMOW5HOW1QWmFmS0QrK2FS?= =?utf-8?B?dnlGMXBmc2pRRGM5cFNsci9Tc2E4U2pLSFJEcDdRdGZOZnU1dnByaDQrWnpq?= =?utf-8?B?R3F3TmtSZC9xKzdrY2MyWWZSUGRPN1NPRVdBcG15MlcvSmIvYy92Sndod05S?= =?utf-8?B?ZVgyT2JGZXNHT0dXbDgrNlQvQjFwSmtpUUF2ajd2bzJ5Sy95Q2h5SHJDZVBr?= =?utf-8?B?VHRPbnhLKzZyM0YxV09CYjAyNlNNNjQyZ3JxZFJrQkhNS3RjQUU3Z1J3Q3Vi?= =?utf-8?B?ckR3RFpNbFIwVnRSczNqSG12Ym1jK01FQTVkaWh5YXp3dlg4bThhTTJHVjBv?= =?utf-8?B?R1JPTFg0bjVKM0NxUjhmWHgvdU5LVzNCai8wZ0t3dlVnNVZSbjVybGlXTkFo?= =?utf-8?B?LzFhdTEvTE13KzRrNTBKdzBUeHhpVXIrUTVyT0RBT08wdkEveG0xVTVCM2FJ?= =?utf-8?B?cXpYaEMzNnR5K2dDZW1TZXdLYmwveGV3OXFnNzVETjdDWHhnek9YZnFkVVlM?= =?utf-8?B?WFdvOWg1RWN5clc0L0Fhb1RyeFc0V3lqcGIyeWhicHNoakM3THQyNkFCSWUv?= =?utf-8?B?V2RZWEE2NHBIN0JVSDFwck51TGRKck96SEZXSUZNdjRVK0dlQUVXOCs4TTBo?= =?utf-8?B?aGJZVEZ1ZGlFUVhCRGljSHpLYmNTZjhtOHhnZjZlOTNiVjNoL3dtTmlUVlls?= =?utf-8?B?QXBFQW5TYTdKVTFNSEgvMG1tZlFrUDNBbFNBMTBTUVEwTitoRGpDQTlYNEhU?= =?utf-8?B?Y2IxRDNuKzY4ZEJJemVlSjMvRFhhZG1Ed2RYWUREU0UxY0J6T0xLRjR5ek11?= =?utf-8?B?UFlpbXl3a2loNlExNVRQUWxabWtZd2hHQ3Ira1g5VS9NdzRvRmJDdWNMNmxu?= =?utf-8?B?Q1NPRzZRZUpKTHVoY1JoaWEvMFg0RGo0R3FzZjBrTERRQUJrem1GQisvT2c2?= =?utf-8?B?cFlsRUpUbzIycERXajZORHR5SGt4NGNjL0dBL0xlL2xQOW1rUDlacGw3bjNw?= =?utf-8?B?enFyK0hjK3RtaWZueTVIVEZ5RHUxaGZIcUpCbzBmMXZvZmhtYWRJYlJWQ21i?= =?utf-8?B?Q0p1bnNqWnJPYjkzdXhlZ25xTTBqQmhmWW5UTG9BZ0JWUXA5RkxlM3hwL24w?= =?utf-8?B?cGp1dzdWT2sxYnpsQ3Frc1FFM2RPMm9tM3duM2JrdVJlblBjZ2tkRmY0TkhP?= =?utf-8?B?elhVc0Ntbko2NVpMcFI5RkFBZDNJNjJ0R3dDWFhuR1V3TEx6NmlaMFE2eXI5?= =?utf-8?B?SC9JbGFmT2pqbzhJc3Q2dlVjblFBdnMwVVpxaDltYkgxWGZrWTlNM0VWaDNX?= =?utf-8?B?R1o2ZXIxdWg5TzZGUGJkRG9LcUQ1RGkxM25ZS3NpVGo1T2dRYlhOd1V3WjNL?= =?utf-8?B?TVdSS0ZoNWljUmdNUi9rd3hGbjhNdWxVQTI5aGxIM2pzckRINVVxVzA5QWdw?= =?utf-8?B?dWUxRHhxdG1VVmhIRXE2QW51TEppeWlIdStvQWJwME9xUjZpZEx3SXZOQ0xE?= =?utf-8?B?SFRjRXNpY0tSRjNucXhHM3E0K2N4bEtnbHJSQnh5Zkwra3lUcUZIZlZNRVJq?= =?utf-8?B?MDZjSnFEemR4djFNV2p6NmJIalhBYVQ3Z282dHpTODJMUmFxd21KN0hPZk5z?= =?utf-8?B?cm9Nb0RTb2E2ZTRrL1VCY292K3ZSTitTZjIrSXJVN3VwVlhJVjlpMzcrVTFU?= =?utf-8?B?M0V1WGNrM0pMOVU0OVFaY3hGNUEyOTRudTM0c1o1MlA1TjRmOHlxOGNjbXU3?= =?utf-8?B?Y29vNFkrbWdQYWtlQ01xb0xRMXJRPT0=?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: pkxTWuuXhJG6Ij/+F5KopdLtQIY+jdzMs9hMXd+BdRP//cmr3BfI3yBfHUrjWU9zc8hn3tdUlO2Lu9zMKn20070JDA4C0TomFpfHKTj83F+1A/6nfvB34jlp0AeZXuRUR44XdiTDrCKbi6ThYpmPbHpceboOm+TQZmetxfFzi4CtwNSwsVLYW50E+ULUMVrqWl7JM6LaKkjwHKzuCrkwd5aGY0CbIOwm/DlosWAwhEQ+kkh5U19+MGvJ6NxOW2Zo5ASht32EK95bLOML0eEviQQCjAat9fxjdzvrQ25Y4ttP2STzRYhOAaJShHBm+POfLIZfkaFjtWAPQGLwNmWP1mFJgW4vBG7u5agDPfpREi0CycVkkcGX2uquOULGK+iZadDwPA68YKthjNLskgvuIYyK2hqVkLO7vdJGCy2nd5nxgv4zs2xetXcht/ZBcvnuugQAx74K+w8BGvTrqOUidf0xNlC5/jQvkVJKefO/0mu5YGz8C1MRWOm9HnmOWjynBFREAQBh9zeT4BTubObsCektG/O7ln22GmI+uTJwbTepfHwqndkIq7aRkjecipGGNlZuEq9uq9o7cw5x5eOoX7uhpmN+2moGsf69n0Ss5qGgVRWVW8dm2Y1NwYZe8zIXtqmxPoPckn2qbCKl9yV8Wtah1I1uxirFBMj2fY5BzimNVK1A4Bq2SCRrRYlVNT3J6EY0h/sWde3COjpW/aZqqwhuYx8XBzKikW7sceSMOKVl9RjYynI4ILgjM9J54Hfh X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b844d9f-7902-43d8-fbb2-08da80bf0add X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Aug 2022 02:12:03.9212 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tts30oc8mw2P3oYXz1t/OkHM7dfm+GuOyAXfd310FORLmJ5hzp/uNJJtvy9QFt22q6dTLY1Ng6KAs8KjkFM+Ag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR10MB5910 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-17_17,2022-08-16_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2208180006 X-Proofpoint-ORIG-GUID: X7ExJzeJdSCur1XUW3XiVR3yGS7T7RFe X-Proofpoint-GUID: X7ExJzeJdSCur1XUW3XiVR3yGS7T7RFe X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Aug 2022 02:12:09 -0000 On 8/15/22 06:02, Nick Clifton wrote: > Hi Indu, > > >> +ctf_frame_decoder_mark_func_deleted (struct ctf_frame_dec_info >> *cfd_info, >> +                     unsigned int func_idx) >> +{ >> +  BFD_ASSERT (func_idx < cfd_info->cfd_fde_count); >> +  cfd_info->cfd_func_bfdinfo[func_idx].func_deleted_p = true; > > Just for the record, I am not a fan of assertions inside library > functions. > I believe that libraries should let their users decide what to do when > there > is a problem, rather than unilaterally calling abort.  (The better > approach > in my opinion is to return an informative error message to the caller). > > That said there are plenty of other places in the BFD library where > assertions > are used, so I am not going to complain about this.  I just wanted to > make > sure that you knew of my feelings on this issue. > > Noted.  I will work out something here. > >> +/* Try to parse .ctf_frame section SEC, which belongs to ABFD.  >> Store the >> +   information in the section's sec_info field on success. COOKIE >> +   describes the relocations in SEC.  */ >> + >> +void >> +_bfd_elf_parse_ctf_frame (bfd *abfd, struct bfd_link_info *info, >> +              asection *sec, struct elf_reloc_cookie *cookie) > > It seems to me that this function really ought to return a bool, > indicating success or failure. > I will change it to return success/failure. > >> +  /* Read the ctf frame unwind information from abfd.  */ >> +  if (!bfd_malloc_and_get_section (abfd, sec, &ctfbuf)) >> +    goto fail_no_free; > > The name of this label seems rather ironic, given that ... > >> +fail_no_free: >> +  _bfd_error_handler >> +   (_("error in %pB(%pA); no .ctf_frame will be created"), >> +    abfd, sec); >> +success: >> +  free (ctfbuf); > > ... it falls through into the free(). > Oops! I will change this. > > Cheers >   Nick >