From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00075.outbound.protection.outlook.com [40.107.0.75]) by sourceware.org (Postfix) with ESMTPS id B70383858404 for ; Thu, 15 Sep 2022 07:29:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B70383858404 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KRipuEmhUwtm2DCdtiAdbUk/ICmYFGDgbqakomuTWc/vpdOp5DfQ3iFcTZRphy6k/FqkaW/BJF01gXiTURwPTlfQwDdinfQaCgbXyha5PMVgAdqWL9B0SjFR9BOqGAvGtLjhgJ6iz8zxQW/e9Wpb6Js18cnv2CcrDzc5O4xD3HwsBEKw9ZvVKv9FXzFQ1TkYGbLp/vZfYMTj30chwa6JHVVHHpmB+ceT8wr8L5Y7A+LRtxHhKzvIT9zIoG2DW4ez85ZMKSDs96STGMENJdLoqogZY5iNHkH9FgQL9Lt+n5NkfBuF0o3Jgjb1KQ0XhUGS9lOfs7T9pf9alLc51EQu3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZKMkHRexQqSMhDcMDYix6kiMyjknql02h2+s32J44DE=; b=BcDYsy8fz49Kkka2OVZHBeQ/16sBPjcY/aLjl+TFT1wspTI9dM3ix2Afay5hMQY9DbevEc2Iuh6dvH/F7P9m6v+pGgVCKIS/jIvd7RqNz6dOttswoSVuHn0l8uRXKTruoly5vWYHcUWv7SLC4HjOenH+dG/hsBu/O6URVOzSX/2afoWZLz6CNtOgIiW+f+uPQ7aX0Ekhj14ZAJLRufQ/yHKG1vtHwzn648HCEK/Pp/EbiIKxN+CgjstthWzXmPdG/uFWqdCLCgrx6alGndSMhFmJ0BnKkxq6spjqLPzZ4GVgljKUXQgsdcp0cbSZZIzAZK8lARAC+6W4th18nZ+mWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZKMkHRexQqSMhDcMDYix6kiMyjknql02h2+s32J44DE=; b=UtaFvEBEKu8pCymYJfntvIkwok3ST11D1ESW58lWY5D7RQlIom7x0t3+qPUA8RyvicW9D1JY34OVAQQg6U5ccly+daiO4OuCIMAAbS8qOmntSLwFv0UdqMOe3aRE70tm+Fk0+nxB2sv4zbyxcr+iAZ6VptL6o97/avnGyoqQDg/7I8SeqbcAVxsr/r2AxCAVnE88xjNGNmbrkyBqxNRrhqqojNYweiQpKWnRLBYbPEgZxQJbXX2If701kt/EqHoPJbOCl39IuuWT+vCwjgOoxKLp+ycE0vnz0q27Doo2Kl/YKwnTcnkq3Yw7xU4Aa6o7GmW2RWUavjx7jY8RG2yh7Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6932.eurprd04.prod.outlook.com (2603:10a6:208:182::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.14; Thu, 15 Sep 2022 07:29:29 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5632.015; Thu, 15 Sep 2022 07:29:29 +0000 Message-ID: <73538f81-579a-d712-9f34-84170a437491@suse.com> Date: Thu, 15 Sep 2022 09:29:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 1/1] bfd, binutils, gas: Mark unused variables Content-Language: en-US To: Tsukasa OI Cc: binutils@sourceware.org, Nick Clifton , Ian Lance Taylor , Nelson Chu References: <41d8346fa386205b021320b71b3db50898c27bd7.1663215243.git.research_trasio@irq.a4lg.com> From: Jan Beulich In-Reply-To: <41d8346fa386205b021320b71b3db50898c27bd7.1663215243.git.research_trasio@irq.a4lg.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0140.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB6932:EE_ X-MS-Office365-Filtering-Correlation-Id: 711d1c35-62a9-4a5f-f6b7-08da96ec069a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hXrEVg2gaREY9GlC/f3E/zo5tjqcgRflwDo1iv0qAmc8mWv1quMDsKfsa1oQXS5249x4B4jX6EP/m7aQAt7Fu5ahWOv75cVDZWlFRAl99TARDrhsDv8gk1rD+hy0FOHv1j5uBBA6uKeMhw9v3hcyv9iL1E0CrcKQFblaZdnpOoSd6T4EA3rsWRJYcLPtyFtGCM9kDa36fKpwWJhvpR+b2K0elfyJ+SPyUzF/VYjDe5bGUo/pNOQV3I/x/DOrmylNqyfYTzmyv5v8iTR7xiSGxOcg4WmJUgHkhLFnTUQ0elT+C2aBUOJ6voCkndzuAde+qQ1UreIH7Va9YVdXM13SIGTFfijVUKuzr52255h88chAyis9upT9o6aEydD9sM7RPERuZLy3FD50mewAkr9QCYErFBa5MpSHIgVx/xruHE4YRfxneUaPOsG5PMqkdceui7VjyRBDcmza/sEcnbD9cnWNre2Spqf79ktf8N6zdK19UKbXdnKDaIUmXoy8OdAJ83hTvnSkC29bLQfSPO+1ZqZ5U1C60OMOduhT2pflq2raZErfFT2HzA1Hg0sMlxjOV+wPoyNtpZFBdM91K3dQSZ0Ru/W6yqDB+C2UTC4xWE32YheoW2vJ1ZUUR4VMRF4C/pNpeJYvVKUyGw6MubcvAp7SnQ4/+ot+nv27t0xyDwzfBjTLmbh3bSQXT6o+mD1fONOzflXRLFKzw+kyh73Q5fr4FhovDJ/lOcJNTef0j6uBG6zwr3zcqyPWGye/e5PpnBCNSbRvuNZjNgk/DZa1HjroPTN9lYbCTttjzqLWqpFrt0nhPmY7vydLMev+mscZBnQ8a2MD03OzMHU51SCkbQqynBU30Fx89o5m3B9Yn0M= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(376002)(136003)(39860400002)(396003)(451199015)(2616005)(53546011)(36756003)(66946007)(41300700001)(6506007)(8676002)(66476007)(4326008)(66556008)(5660300002)(2906002)(26005)(186003)(8936002)(6512007)(38100700002)(86362001)(31696002)(83380400001)(6916009)(54906003)(316002)(6486002)(478600001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WDBWcG9wRU5mZnpkRVZnOWRDZWkyVS9NZ1ZSMEdoTnJ0eDlJUnd0V3VlNU1M?= =?utf-8?B?STJsRDZiWTQvUGlJMmlyNmRGOUhidlJmdVp3QXhFRHp3VnJ1Mlk2c0xHN1po?= =?utf-8?B?UitXb3JINHgzc0hzZ0loOXFjL2FsZkRMNElSRU1RUStWUjd6MmlxdVlwNUFP?= =?utf-8?B?eXJ2UEVLUUo4cFJsVDh0SVY2ZGtxS2dpQkNmUUlEQTVLNWVSWHd0RzN1NUFn?= =?utf-8?B?UDNLK1lqOEZvcjNWa2VjSWxlRDdiZ0F2WnE3alJ6UkNVdnlzMFhERHRpWXlm?= =?utf-8?B?SFZ0aTlKQzhDSHpPbnJXSWVRZ0l4MjVWZk54aGtrM1U0aGRMRVYybTRjclNT?= =?utf-8?B?Q0pBcVdhRUdyL25tZ1RwelZ2T2RWeTJXaEVXbXFGd0tvYXgvZ3MyU0daYndL?= =?utf-8?B?d2w5T0UvNFByTFJLY1hZL1prTDRaV3hoU1J3WHhHb1R5d3JHZHFmMHNRZmk1?= =?utf-8?B?M2VtbDlGbkFXTGJMTEh1c2xLU0c5Um1icHl4Mk1GeGptRFY5RHVxTjBxREhs?= =?utf-8?B?VUl4VzRBMmJBRVdjUU1TUFBSSDRyNUp3dFV5RUV1bjZYaEY5S08xT0h5dlRn?= =?utf-8?B?Slk0S3RiZ3dhdFAzb0EvazcvSFlmZWJZRGprejM2T1hUSXlBSUswdzlsQzJB?= =?utf-8?B?Z29vNUpSY1ZoWmR1OGQ5M3J0QXNsN0dZMmkrTmZuU2N3ZHg0KytiWW1nSmZ2?= =?utf-8?B?SVRwVDY2cVB3YzJjYUphMGV1ejhqZEllRThxUjZ5NWdpTWpMOEVFQzBCM1pH?= =?utf-8?B?OVhWMFNtd1liekJmUHJaWUJZNi8zQ2Y0UjREdjJGa2orL2Z3bW5ZOFBJT3I1?= =?utf-8?B?clhuVkk3VWRaTVowWlppT1JDSFBWK3IzaUZXenZ0ZHJUeTBRRm1ib2tvRE9s?= =?utf-8?B?Zk9jNWpsTUs2dUdzWWNtbmVEbFkwRGZJdjZhd0FLc2hSTnVtUEhWamltWGpS?= =?utf-8?B?RnBvMnlha2kzOHdCZGJZNUxVZktUVmJOOG9uWEIvKytUb2lHTWFQYmczS1FB?= =?utf-8?B?NzlSUjZmK2Iva1ozOXV5TjBld0NlTmx1ZTZVYVBBZE9wZ3QzeXdGbElJMzE1?= =?utf-8?B?WU1lakt2NnFtWWZqM3FxbVRIWDR4QXdaRStsTVJaQVZCTEE0WHV0ZWNFR1pw?= =?utf-8?B?Mk5pbHVWTWU1Z0NkS08yUzFRZVBjaklqVjgxclBDSTUrWk45bEs4WjZXeXhl?= =?utf-8?B?NVp3NTgyN0hCNnVMNGRPSktFQ2pVRkpLNEFCaUtDWjZsUTF5dHh6VEhtakhH?= =?utf-8?B?TjBFZDBjMFpSY3hNMmF0VDBPbjViWHowOEVDSzlBTytQaW1wMXRCWTdBOGhr?= =?utf-8?B?N0dxQm1OQmx6cGtERkUvSGtaM3pVbXpOR21wK0Y5a1B3aitRenllMGQ4bndS?= =?utf-8?B?R2lmTXozaWR6UlJsNjY4OFNPY1JXQnFNc3NkT3R0ZjQvWjRnYkR0bGJpVDlw?= =?utf-8?B?N1hRYkFtUVE1U1BQTndKVS9TdFhYZVAvV01IcVVMRHNGQzFldmxNZkdCQVA2?= =?utf-8?B?TUNiRTFuZ0NzaWFVSTJCeENFT0FDankvdkNtbHBIMUgvNEZ4RGR0OW14Z01G?= =?utf-8?B?Mk9JdWpQdmxXbmswak1TVTBXZGMwVXFjN20xWm81OHZTS3ZKQ1ZjYWNkZ2xJ?= =?utf-8?B?TXd1bmsxM0J0VVR3WS9aVFpEZEhoTmkxRzIzN2RYdE5tc01zUUROZitHU252?= =?utf-8?B?QWdMajVLdmJRT1hvS0Q1M0phSG5DVlpDMmkvL3VZUzZXTGhCTlpnWU14VVlP?= =?utf-8?B?RHZuUFdkVk5yREsrQ2VzQzVCRkR2OEY4SEMzaW9WQzZwbC9VN1c2TEVsUFlI?= =?utf-8?B?cnBnM010L2JqL0wvUnBlRUQvYjBzSjlMSHk4SU9xSE9nVUtRL3BiNWsycVZ3?= =?utf-8?B?bkdOUjhoRjhvMi9ldnNiNmVJN0FzYVN6WlBDeHV2WHNDeVpES1p2UE1XbnFN?= =?utf-8?B?ai81RC9ZM2NzWFhpVzVXNWcvNG5vOGNIbWRnZ3VDT3NUU3FqZXJ3OEh3eG9H?= =?utf-8?B?d3dhd1pTdEEwa0NnbWFTdmFNanVNMk9mVWZTeG93TzNZbTZKYkJUVU9WWUdS?= =?utf-8?B?dEoxdTdlR1NJclNMQkI5TXRRc0NuY09xWjUzeXoyL1hzaTZNeE1CbWtuRFlK?= =?utf-8?Q?MkBlBvs2jq1wMrkehbiDjXqiA?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 711d1c35-62a9-4a5f-f6b7-08da96ec069a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2022 07:29:29.4863 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Xky0OKNYVBRFW/jKm13//xCbRNy5NnZTulX6H0yb0T/XQSnll4QQFgiqUenJnU6p4wDbv8JYZCJLmQr0hexN4A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6932 X-Spam-Status: No, score=-3030.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 15.09.2022 06:17, Tsukasa OI via Binutils wrote: > Clang generates a warning on unused (technically, written but not read > thereafter) variables. By the default configuration (with "-Werror"), it > causes a build failure (unless "--disable-werror" is specified). > > This commit, instead of just removing those variables, adds > ATTRIBUTE_UNUSED attribute to them, which means they are *possibly* unused > (can be used but no warnings occur when unused). May I ask why you chose to do so? I can see such a variable being consumed inside an #ifdef, but being declared unconditionally as a reason, but (looking just at code I'm a little familiar with) ... > --- a/gas/config/tc-riscv.c > +++ b/gas/config/tc-riscv.c > @@ -2303,7 +2303,7 @@ riscv_ip (char *str, struct riscv_cl_insn *ip, expressionS *imm_expr, > char save_c = 0; > struct riscv_opcode *insn; > unsigned int regno; > - int argnum; > + int argnum ATTRIBUTE_UNUSED; > const struct percent_op_match *p; > struct riscv_ip_error error; > error.msg = "unrecognized opcode"; > --- a/ld/pe-dll.c > +++ b/ld/pe-dll.c > @@ -1510,8 +1510,9 @@ generate_reloc (bfd *abfd, struct bfd_link_info *info) > int total_relocs = 0; > int i; > bfd_vma sec_page = (bfd_vma) -1; > - bfd_vma page_ptr, page_count; > - int bi; > + bfd_vma page_ptr; > + bfd_vma page_count ATTRIBUTE_UNUSED; > + int bi ATTRIBUTE_UNUSED; > bfd *b; > struct bfd_section *s; > ... in both of these cases there's truly no reading of the values, so I don't see why they would need maintaining. Jan