From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by sourceware.org (Postfix) with ESMTPS id 531023857726 for ; Wed, 27 Sep 2023 21:55:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 531023857726 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-io1-xd2b.google.com with SMTP id ca18e2360f4ac-79fe8986355so120016339f.2 for ; Wed, 27 Sep 2023 14:55:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695851751; x=1696456551; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FSyl9n9hSZGJ1aiVJMjbQw/djhC2rZ6I+tPWQTEaJOU=; b=k/k5fU0Z5/08kTvLtshFqJQF/HibV4hTCKAEHmug6MECHj1GP5rzqdOtm9C4Q/FKL6 TBvrV2jqFGavWKFKQL9oq/krwIAXO/HYUAAZQOHJDMGWFqXo8IbfZFboOCm4IyvVYL0z tvDH1d0Vxir/DY9Aw2WSy7QXRsgLWcx65R6oYW/yc9osET+fWqNfjIbQYmY9x3T6v6oO zP3A9Sv9n4t2r2miNaoLLayQg54LF1nRKQsprj4RpluSDSLsXbq7FAvBai/vZwJOVx67 CFyK25fr3qLQmTMLSCgaOryHLK7jYS2itIGAucKChqXvR9PSsqfqsdcTp3BHHEn8YOLc P6Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695851751; x=1696456551; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FSyl9n9hSZGJ1aiVJMjbQw/djhC2rZ6I+tPWQTEaJOU=; b=Q/bbDGnxr4xQ54iaRk9Jy/wEoAtc7lZyYYG4yVTD8HAI6sWQqriuDqyWJsH+IjtLXD RO6ufoZPICqF2tU1ETNfIx59wWUQK62WGw+BB1Gx5ul6EbynkCd/vEha7fNkY8Zk5vBI NTTqU3Z5eFzwfp8vtiAr4dHsaTTXsLTeMY2k6Gi/DBhyvaQf+C86CxUHNEe5vzFew15h niknAD2BqXM/wb7LNFDKZrc8hQgV7/FlUuDdiQqOT9+6yTQJhTUOvENMBqcv0wW53y9T QPrCxQXRLVi3Dt6MIyUINUR+KqF2VChMPCJJ+mgBp69LRBbYeIlnH2WaYQSpdAK1akB4 cJ8Q== X-Gm-Message-State: AOJu0YxtNRlRrjYQSyzCDkEpfpER5ADDO2aEN5rAIn6G0E6fAplko3NB rfH9qdBfHbOIxYYySIsOu5M= X-Google-Smtp-Source: AGHT+IGx2lQxUMVR77H7/w64hTj5a8dHNZCI2wgtv0sL8NO4XVEqVoHdIpWaqbKk6DyMgvc+zVetGg== X-Received: by 2002:a5e:8306:0:b0:783:63d6:4c5 with SMTP id x6-20020a5e8306000000b0078363d604c5mr3265219iom.12.1695851751483; Wed, 27 Sep 2023 14:55:51 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id fx20-20020a0566381e1400b0043a1d33a341sm4200658jab.81.2023.09.27.14.55.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Sep 2023 14:55:51 -0700 (PDT) Message-ID: <739f4c3c-9fd4-4bf8-b9c7-77e6c156cd7b@gmail.com> Date: Wed, 27 Sep 2023 15:55:49 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] RISC-V: Protect .got with relro Content-Language: en-US To: Andreas Schwab , Palmer Dabbelt Cc: binutils@sourceware.org, nelson@rivosinc.com References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/25/23 03:47, Andreas Schwab via Binutils wrote: > On Sep 25 2023, Palmer Dabbelt wrote: > >> I think we also want something like this >> >> diff --git a/ld/testsuite/ld-elf/binutils.exp b/ld/testsuite/ld-elf/binutils.exp >> index 674e8e9a575..b38e29ed6fb 100644 >> --- a/ld/testsuite/ld-elf/binutils.exp >> +++ b/ld/testsuite/ld-elf/binutils.exp >> @@ -95,7 +95,6 @@ proc binutils_test { prog_name ld_options test {test_name ""} {readelf_options " >> || [istarget "mips*-*-*"] \ >> || [istarget "nios2*-*-*"] \ >> || [istarget "or1k-*-*"] \ >> - || [istarget "riscv*-*-*"] \ >> || [istarget "sh*-*-*"] \ >> || [istarget "x86_64-*-rdos*"])] >> # Check if GNU_RELRO segment is generated. > > Thanks, I will squash that in. Thanks for taking care of the RELRO stuff. One of the many items that could have easily slipped through the cracks. jeff