From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2057.outbound.protection.outlook.com [40.107.7.57]) by sourceware.org (Postfix) with ESMTPS id D67543858C62 for ; Mon, 25 Sep 2023 12:37:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D67543858C62 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k/3po1RU8LVPCcW3O12dYQc2Apz4feBBv7QoqtsJBMsF9nd3RPCV02G3rJ+xtIT/ARwtq0dnkOkKbyFVYJ27zMTOUd9XpIKk3eiFcACkUGR0q6Ap6DIUF2MtKNbO1Y6Gn9sw291OC1mjOVyaJ3bMWD4Rgt2KwWqBpHytL1Ig7Mdh7JaiZGocuadhXw2PxB4PhJsTdPh1PlCqh9h193LMM0X8e5oJBfk2UW3C/MmLmZ6bjeGNEOmT5f6ff652b5F4wQ3WDqEgn5rMvGGKrDn3NijC9fyCibDlEJ/rszH4ViTjoQ8Na2xHf/XLcdlNfCJvXE05kQfyy6kdp9MfjiOcEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jx1xxhm21hOcunHzYIkfGtEKS7PL+S+onxgNFf79IyI=; b=YIy5TWplQ/136SpycYxQkmecO2KWtfA25r0kWvU/lhsL6agW4x12Art4hTr0O5CSuL3X33JW+pb3ZZhGociIigJE7M7IOqaKSUoVGDPfzCu1f5i6L0vi6V+N8sMS2F5OjSko/yeTOF/X75zN+DzCZ6rM87NuZNGJhOTkNfC88mCT/qyW1iKuiUDhE/ilLBcI9hV9t3GSTIgV6ChmFPewHpxx8FMauGN/qO14zkAFcfUs99ehAn1zwnjQ9kt+lHdpWCwSSYikP3lSx1vjw93pJYyDkqDOpO4wOQ1Nnd78ZI0CvnKcndn3h6FSJ7N52cYrKqXU8m7GEQGu0VczPmm+lA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jx1xxhm21hOcunHzYIkfGtEKS7PL+S+onxgNFf79IyI=; b=4MHmgVHHpQ/cFGm3xW4jBzxswAL9efckZansp3G4P+rHbyHlFAauSImNf51dhGoIjOJ83xmx8Xe/Oqb2yN6gv/RR48UXIJp8rxY8e98MmqvVp4+C9Dttq5P61rLDJgF+6gKwc1bTXIDBN23rt5L5BWPdEcm6CQYuGV3ksrVeczQYCkOQqhZzg3UQ4nfrCrrHiWEVOdPwNxCBIXgkg3xsB6FWJaqDjwJmlX4xhc0zKh2l40224I5TZa2FFzG68Lcp9Lh6gAhmu+6rlG7osTOgBBJBt51sIDVV4kN3Ngm+/RrEgqiPdq88zZCUJKeRMoaigjLzltgLYFJQZIfK3m1zng== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM8PR04MB7428.eurprd04.prod.outlook.com (2603:10a6:20b:1d5::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.28; Mon, 25 Sep 2023 12:37:43 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::1353:3b49:2b70:6303]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::1353:3b49:2b70:6303%3]) with mapi id 15.20.6813.027; Mon, 25 Sep 2023 12:37:43 +0000 Message-ID: <73d3228b-1cf8-2bc9-bf50-d14055241b3b@suse.com> Date: Mon, 25 Sep 2023 14:37:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Content-Language: en-US To: Binutils Cc: "H.J. Lu" From: Jan Beulich Subject: [PATCH] x86: tighten .insn SAE and broadcast checking Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0071.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::10) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM8PR04MB7428:EE_ X-MS-Office365-Filtering-Correlation-Id: 355e0dbb-d16b-4a31-0c73-08dbbdc436ea X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YpF9ybwp/hPCmHCR57v0yXfh7EHAZm8PN1/jdv21ogPQNHymgIAybmUBhbcbitsZjS6USFIToZKsI9f9NPNeYHm8jgC/Fu96s1EfYo2//mTFxlz/dC/r012cQ9iGILjJRs/reWEYPy1pkjK4bAMHW3XHbw5rLde4rSrgNVDytWggDIG5TUOV/pzGFokKvfUfQgmKIbg3wd+DCvAY0pC5NcqCW9bgvc24ip/hTqa1N7IsraloFqTrzTvptQAk4zbiTVulzOhuvYXbD8kOI4FI5G17T47mF5o3qHKWpvBb5NDBss1s6+RrsqBt4b8iQw1I5Opix4PLqRZ2AJ1QWzYCn322ybLTsY5Emrrd0b9UWW9CsntKGbHnxh3eOg6hL6s8pXV0GusVlCW1MwraSrXEIHIYhNdXtufZNDwNXPe9QtkwMWZqcWWTBpzcKgC2Ix2dgMSUWNgJ2pYGDEQUNjF5RYVa9RDbfW/U2ZOF0DbI/BYRoi6OTevjEwShlE+trF4N1uaBBMErlbjMOg/jjO/KgQhy1CQpXPN2j/UiQh1pybk/9SnVvR35J6H+ExLBU0POnQwxqxPAUoqSrpyKtnnv+KBqj3UYw4QYvZrBNWFBecQ+Wr0YrbCG2iz1D01RmbCBsXyaevn64JyjYsaVxL8YlQP2akHC8AJ6z5wVlGGRs4iM5ClOOKobhlASMAK6Qcv/ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(366004)(376002)(396003)(136003)(39860400002)(230922051799003)(451199024)(1800799009)(186009)(2906002)(4744005)(86362001)(31696002)(36756003)(38100700002)(2616005)(26005)(316002)(478600001)(41300700001)(6916009)(6512007)(31686004)(66476007)(66556008)(6486002)(6506007)(4326008)(66946007)(8936002)(8676002)(5660300002)(83380400001)(142923001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eHZzYXRWbVlzVno3bjU3S09Ea1Jwb25WOTFHalVtMytnSXIvUitaZjVPWUEw?= =?utf-8?B?Y2toekJKZ3QvQlZPRVJkUFdUY21oa3J2UVFSOEdUNkFDUHV0SlRrR3l5Z0Uv?= =?utf-8?B?UmNPWW50T0t4SktkOHRrZysyRFY5NEgyQWJRbjAvQzdTZWFIYVRmWmZIbW5J?= =?utf-8?B?djB3OElKNnlCbkkvZ0s5VFlJbG1YQkl3UmF5Z2xwdHEwYkEzVVFHdFhpNXdl?= =?utf-8?B?RUdJMGZvdmZxeHA2UzBDUEdvV0pnVmpWSmZCdlBhaEJvaTJjbVFBUTI2L0F2?= =?utf-8?B?MVdaTTRKcHQrLzNtVGMzVFdMSmhzZjhMZC9yZ3F3YzI1ME1KYXdKczhrMytF?= =?utf-8?B?eHhxeFp2UDF0U0NiUU1zVmlqdUpuV1Bua3Ixbm01Nlp0cDQzV3g2d293WXBV?= =?utf-8?B?UWptay9sNUhiUkxocWZHNWFUaWp5VEdGVHlLZnRubTRieldoTjRyRDF1eHVQ?= =?utf-8?B?QU8yYXcyeENuLzNLbXJSN2xMczFZY3dxQlRMNFJSZDZrT0xUaTVxYXFWOXM3?= =?utf-8?B?d1pBWGZOaktwTTQ5TGlLczFzdjV2bmpncEFVcENiNHhCZTdRVW1rbjFsUVll?= =?utf-8?B?NTFEck9Pam9CVHZTR0NHU3Mrci84SU0xK2F3TnE2akcwekVuSmdUamFpejBS?= =?utf-8?B?SDNBeHJ4RXo3QzZ1ZUFKY0FkWkVlYkdtOHJ0LzhNRm50SGJkWEU4K2pIL2xU?= =?utf-8?B?Z1lLVHRPUGd5MFRiZlpmWHIyRFd6Qk9RTHBmMTJSeVBFcHVCRS81azd0Nk95?= =?utf-8?B?Zk5nK1UxUVVXS1BOWkhuVXF4UjZDUEtMZ1UxV1pxQ3pKa3IzYmlqR2NoNE9w?= =?utf-8?B?KzJTbUNnK3RlNnN1WEpEanFNR0gwQnVHTmxBcTNDVkNrcU1HMjFlZExIQmxw?= =?utf-8?B?LzV4UEhTMTBsa1hERjhIY1ZNclBXQUlac0ZOR1ZBWHdnR1ROdkRnc0lBaUJ4?= =?utf-8?B?VXZrMEVRMlJZa29NSFRiSG84dGhnMHp2dktaYUUzNFZ2eXVZQlNKYm1LN2N2?= =?utf-8?B?bEM0ZUZtRlkzeGxha1oxeTU0WXpWVnFEcVBYeERPam1XN2NibEo4ajZJUEpS?= =?utf-8?B?OFFOZDIxdzlvcVpON0JnSHVNbGNqeS9saEVXMk1BUEFrSStKdFdjWWszSWNV?= =?utf-8?B?SWxOV3YrMS9Hd3JkYTM0RUVMV0tFU3Y3QVNXa0F2RXBhUFZDVWtVUC8vdm1C?= =?utf-8?B?U1RUMUk5SFJhWGxtL09GV1MrU0IxSHphYXZDQnBleUN3UkYzNVpRV3RQZjFL?= =?utf-8?B?RzlxQjQybHJBejZ6T0hmNW5SU2JoNFpIK09hT2RnOFAxUFpTbHlIVmRpOFNP?= =?utf-8?B?SE5ZbHNsMzAxTDhrRUJhQlA0Yko0TGRYaHhnNnJmdVUweDhnSC9mZkQrcGtG?= =?utf-8?B?bXdhRG9IU0NaZmlYV21obFkyMHJmMDlUckFBUFFQQWhuTVhJQWVoYUFsVkhC?= =?utf-8?B?WnRqVUVRQ2l5NEJCNWhzeWxVekJyREFhSm5rc05yNGw3YmFXdC9zN2RQZGR0?= =?utf-8?B?R25Ma3d1bnl5QjFBUG15a2Rna01XSDBPSDZuZnZpSkwrdlh4WHFVSTRaNUMw?= =?utf-8?B?dURRV0lIQnRSUUVDN0NvUmljdEU3Y01vbVpTK0NaNzdXN21VVWIxcEU4Q3Bv?= =?utf-8?B?a3ZadVQwbVM3NjdEaWY1WDBmUVlzbEY5Z0pacEQ1NjNwNk91R2JRUlJsM1Bz?= =?utf-8?B?WFVYU0tadmtvMzM5SGxsVUp0RzNBVUlGVGY0c2tnUU1vQmNiK1htTVcvaGNr?= =?utf-8?B?TkFXVnpXVjZVdGppeHlxSUZEZUhvKy9wWGUrYVJMdzhNR1JWZzlpMlFvdVE4?= =?utf-8?B?OFZsNVV1MDJEcGtlT0VGTk91dk9SUC9HMGNncE9scHRqT1kzRDAwUHVJV3ZP?= =?utf-8?B?NlZwcDVqYkN6SCt2YlFVQXhxOWxSNHJtR0RmQXYwYlQ3NHY2eStqU1NxaTU3?= =?utf-8?B?NlFRTHdUSWhLeDhMRjdlK0p6SllIb1NZM1p6N2lwZDlIWXpXeW5DS09OMlBH?= =?utf-8?B?RGpQM1ExRURBN01hc0dxVFFHLzFsV3dIK3QwcUorZXVvd3J4NUtucEFnS1pv?= =?utf-8?B?ZHlBei9mKzJ3bVcyN0xGeno1WmdTN0FFZVYwaDUwbUY1UGxGVzhZYkY1QjNI?= =?utf-8?Q?/ym+SJV+8mJxhSievaq0C5Jzv?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 355e0dbb-d16b-4a31-0c73-08dbbdc436ea X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2023 12:37:43.6709 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jJcjlBTjF6696xAQpj7dWkV835wQMBuJJMHoGf5NfyyC5Y3Y5zFdrJKz5vaN0LyoofTgAnH1Q0JE8ilkkFfPOw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7428 X-Spam-Status: No, score=-3026.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: SAE / embedded rounding are invalid when there's the memory operand, as the bit encoding this specifies broadcast in that case. Broadcast needs to be specified on the memory operand. --- Arguably, until the AVX10 spec spells out how embedded rounding is to be encoded for 256-bit operations, we may need to further insist on EVEX512 or EVEXLIG to be specified. In practice that would end up overly limiting though, as can be observed when using .insn to encode APX insns (where EVEX.brs is overloaded by EVEX.nd). --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -11538,8 +11538,9 @@ s_insn (int dummy ATTRIBUTE_UNUSED) ? i.broadcast.type || i.broadcast.bytes || i.rounding.type != rc_none || i.mask.reg - : (i.broadcast.type || i.broadcast.bytes) - && i.rounding.type != rc_none)) + : (i.mem_operands && i.rounding.type != rc_none) + || ((i.broadcast.type || i.broadcast.bytes) + && !(i.flags[i.broadcast.operand] & Operand_Mem)))) { as_bad (_("conflicting .insn operands")); goto done;