From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2044.outbound.protection.outlook.com [40.107.22.44]) by sourceware.org (Postfix) with ESMTPS id DAD063858C53 for ; Wed, 25 Oct 2023 08:48:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DAD063858C53 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DAD063858C53 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.22.44 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698223730; cv=pass; b=Hp0Erf2DAm5EBT4uBYvdx9WVuQfPIpMmns+IVIhjUblcBSOkhQDeQwE+sHb3x7qGipRwsuuN2tHBhHBanzUYj+HKAZrfMYPblNctO4x7N78DJ0yxLS5f8Ne0kNL9HL+HrXnxfzy18X45XM3uimEBVgnMaq35vrEppu8gEPt/vWA= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698223730; c=relaxed/simple; bh=iIFTEWciLyKLHWuN1IN+NVzIamSJfEAmQfd0mdE5bbw=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=tid0CQaM2IyyKGwj/cogj78TPNlRX79KF3K2/3qhE5IIWfc0v14QV6pXRn7Axl49gXaa1Jm7Yoq9YVbrBZHSzF8vnUW075IMMxFCZFocj0jmLRwF92GBZT8XcmlQdMBeD6bK/KvyrD6kDwGIlEtoEcUUv+bx/lVObUehlqqGwcM= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l/xw5eTCNyxICECY3Q2Mik+gGw69XdEHMn9XBh1rYlA/ccFjF2XzyVVDKiGUHuBfFLls7+JpseXE0GzOyJICXEcSlZN4DhOqT10vayhXzznQAdinolmeOzCaoqIhviBZI8pJDGkDug9TpfbDjXSc9UFj7zZaq9p3lDEflcFBlypMMUnLJVY/IsiiE8wEFw3hTgX4BvvnnIJfgga5jk/0o8zkr2kIOeNUlXNk0UvPFMy83x0rTsekgmfVCyaeMZ3Q3ihuFPZewiqChl9AZ2DU86WaDg2d0WTc080++K1NExI0Jh4rNkpplS4zRv5elwLxUnA7sRxQ/PXEiWjHqcaHtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qaKL/3xhgcjjiGIIaogqhXg1mEPfQ16Dig9fAEylmZI=; b=CjGBiFPVL0sypdXmx5/A/jbghgDk5uHU1uDwhAAKzyih8z1qvyOKQyUTphVVRbbsHKShVN574OvQ0TnzznS6xNnqK6+PPdirPTpwO7g0GGcnLai9hkWlFsvIBtFiyHb/2vWShFclM84T/djiYggkBS5+BWTWx7AwYisIgGYeIXY5b3bw2DsWucqwpPGuzJq6kwFn+8J9RbI0NhZcNC2e7ViZORXyupR96Afljih9MZYKpuwE/qcIPofp0gMC4fykyv8XJJOPlL8geBT7NvPbJ8lkuDc4m57Q5LYJ/if6bPco1vU5C0L9j8TQ8J9eDteYSuIrBYc78/Lafm/3Hvn13A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qaKL/3xhgcjjiGIIaogqhXg1mEPfQ16Dig9fAEylmZI=; b=0E8mQxUrdejuhbn0ilKM7C82Bpb5FoTTLMc9MTEsLP8n3wyU+zIgjkMXNqOHl69OstHXgWR+KQT/DWOCurYA3XlzAQ/UqLz4xk4xXsJhl0Vgnla696nn291cbVrkhFss8C8HeYG8drnM645lvoS3WBV9UwA2A9sPjw8yaGr++FtJgEURwtfYGvr4C5696XV29L/sis8FrUUUn5Lvyi+MXm+GDTnjYLe3iFm8PM4FFitfOreD5F98riguvT1lqkytGwYwNDNq0lG5PoxSxov5eZDMu6nVqfkZ6VAuRz/v6aFzWKBe2PEpIkrlCiVrK9rRu1R+4jbmxANLKBFROXacGg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB8PR04MB7068.eurprd04.prod.outlook.com (2603:10a6:10:fe::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.11; Wed, 25 Oct 2023 08:48:46 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::d924:b650:a2ad:7b25]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::d924:b650:a2ad:7b25%3]) with mapi id 15.20.6933.011; Wed, 25 Oct 2023 08:48:45 +0000 Message-ID: <73e9aef8-802c-2df6-563d-787512e1f2ac@suse.com> Date: Wed, 25 Oct 2023 10:48:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] Support Intel USER_MSR Content-Language: en-US To: "Hu, Lin1" Cc: "binutils@sourceware.org" , "Lu, Hongjiu" References: <20231010072401.1383177-1-lin1.hu@intel.com> <3504781c-a806-335f-a9df-615ed3565e5e@suse.com> <1760f135-7d53-7922-17b9-8e44c1296247@suse.com> <5c3a3d73-0f73-1941-ab31-6ad95050210e@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR4P281CA0048.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:cc::15) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB8PR04MB7068:EE_ X-MS-Office365-Filtering-Correlation-Id: 6170a799-acdc-4d07-3f40-08dbd53732f9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AAEdyqV9eG05pVw9/fj46GRrc0FuWn/kPaY+W8EiQ+4WruJ+3j27k50rtrrnQi7Ymjmvzv+ndB+SVn4zdDo+BvHAKPLEsUKfVs1AqHmCO13P8MPh8uWfBu/tQXjy/yIO0uHnDblyozeEksQpVg00r0H3xudOXDfJVNquQAgjwXHid1uLLlN8cuX6Pudd+wEvJA/vQna7yv5j/k+pp5KOF6dkS+Qjuhv70iDQFDQNGmTw7kUMSrsNOQX7v9yVk+I2D71SXQ1prCMsSMpw37CaAbP5CMEm5nXADtJblTQZXVaiFZ4aiwUh/uQ080KNr9rhx/ymCfdRJpchiMdN/yOCFYYT1Rm0RXWfaJpuxleD38U3iAl1tWtVCRId8KWctfahy/HJ9qZDJGpDL0GfpMlMquwXyWSMt6xSREhQeSfiwQGVxEMl5Q/c4Nmz8Lt+LQmrqjPSv0Qt3doe5x1lecDETEEEt6Dd7jP9n39hiSJA2C9RqdHgbS/A4DV4UPt80nGVB6l3QpJjkqcEQw+JHgbX10FKWWwDJd2ZkD8wT98idzyR0/RyPpYuZiYXO2nsUv7PF24hK5pBrnFDEACi0QEkXgrH1bfPi0nmVQhj2txwLjalGwlXoW09HowrBFFYp/Tz/eas8aDgzxiQc7Il6UR+6A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(396003)(376002)(39860400002)(136003)(346002)(230922051799003)(64100799003)(451199024)(1800799009)(186009)(86362001)(2906002)(31696002)(38100700002)(54906003)(41300700001)(66476007)(316002)(66946007)(66556008)(6916009)(478600001)(6506007)(6486002)(2616005)(53546011)(6512007)(83380400001)(4326008)(36756003)(5660300002)(8676002)(8936002)(26005)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SzBGK0NiZHBjdGNtMFhhMG5PdDdxaEt4NGY1Uk82NUpQbmJQazdEekNJMkpU?= =?utf-8?B?YmszN3dDdS9tMlJBOEgrV1VUdDJJTHNGakhlam4zOHJET2FtQlI3eHBkWEs2?= =?utf-8?B?SERDdWQraGFUYy9hUXFtKzVOTEV4N0JTV1dFQTlQNDJ4VjU2N1ovNWVpSkVZ?= =?utf-8?B?S1ZETXBCVXV5ZUNTaXdYZHBVU3dDRlFWRHgzMGhpcHNhWCs0ZnE0SXRDTm15?= =?utf-8?B?ZlhxaUtVclIzTDA2dSt4aDdJMVo0L0l5UjNJb0VYN0RGbVM3L25NR21MQ1Zq?= =?utf-8?B?V3dTSXFVOWpwd0MwNkZ2ajU1elZOMngrRzEzSkxxbkxFOHRVM2NkRTBoSmZ5?= =?utf-8?B?Wm50R2IwZER1UzJGWW16dVFVcGZyNldRWm9VT29PR3ZCZUZRRTdMZkwxY0R1?= =?utf-8?B?NWJxaURFT2dTeEhuckhFc2Rlb1FpSUpHY2V0UzJJcnFMQy9LckdZZHZ6N0Ra?= =?utf-8?B?SWRxdTAzbTc2cjhzVElQd0M0TUhiQUpoaHhWS1czd1p3eDdvdkt2R2hHbElP?= =?utf-8?B?dElCQWcxZlRSdXFIQ0lvUm5NWjBrd3BVVlJKclRTaUhmS3ZiRk92U29sZjFK?= =?utf-8?B?dDB5NEJtMjB6b0UzOVlwTFNXT0JISXZ6MnBnbkNNcHJ5SnNKM2lGS2FMQ25p?= =?utf-8?B?a3ZsQ09xNlBaSkFBVTFCYXVYcXZzZStkTHVxNFF6RGxYRk5EM3FjTmdPZnZD?= =?utf-8?B?c1RTNUxvWXBUMVBIVmIzRTI5RTh4bnhMemo2UnFyUVd2UGR5R0I5U2k1K0RC?= =?utf-8?B?Z2s4ZSswbDVFLzlXS3RvOFBSNkc1bHdpazBQL3NPWWQ5SWkzMUlXUEZqU3RJ?= =?utf-8?B?Mm5tSkJDRnVCcXZGblpaUHVCZ1hITERqclBOZmhUTkdhS3BjWktuZnQvMmJO?= =?utf-8?B?eCtKZVErMVR1eGc4Y3I5cWkySGozM0haMncrNjE2dFpaWHdRK21yTHdvcnFy?= =?utf-8?B?TWY0TW1uK2FjMUhCaW45OEFwSTZzVjQ3K1pETThlN25rVFJTUGVIQ3Roa2dx?= =?utf-8?B?VFFCd0FYZGpqd3lsKy83V1lGaWFNdnVJKytBQUU0VEFURmJJbmloS3R5OTJ0?= =?utf-8?B?UjRkS3Z2amU5a3pYVy8yVWtLT3dmV2VaOGphMXR2UzRTMnZUNWdtbDd2YXdM?= =?utf-8?B?UXczVXRUTWhQY2I0QkkrY29lejZQekRvL1diYnlORTdnRU1aVVNBSHhVQjJk?= =?utf-8?B?UFN1SitYaHNDdXhTRGlRUzFkREI0VGFBc0phdzRZanc1RVNBaGVmUzVqN2VH?= =?utf-8?B?Z2QyUHA1aTdOOU53TEQrMFVOcHk2S2o5MVREYk5KYjdPQ2d3Z1I0NWNCSEFW?= =?utf-8?B?ZnhzRmk5R0RkVS9hT1d6Qjg1UFB6RUk1ekczR3hRbHhZWFFmYWFTQkxqNjVs?= =?utf-8?B?UjNuVzJpQXBqYnJCam9EOGtjQ3pWdkhJUEIyUnpkNHFkVWlGY1RhUUtKLzd5?= =?utf-8?B?ZVh1M2JESVlFdDg4ZWxvSE14YjBmUytIS1NaV093bnVad1VFNE5aNEZhY3Zv?= =?utf-8?B?MUd3Kzh0aTJaa1Y4aEtTQ2Z3OTE2VENYdVpVejM5MlhmVGRiSjhqSlhuaDNE?= =?utf-8?B?ODRReUxMRlpRenFSSFdna0dyazk1TlZyaUd1dUlZcEtLRmI3bjNhRFBUNlNV?= =?utf-8?B?RmJ4OWJJbkxUbE82VUNTZGVYa3FMTnlKa25ua3VPQmFUZmhzcmJNSnMxNmh1?= =?utf-8?B?UUtJSnhxeWZxM0RhaDhUazdMRUpOZU5VVVNzK2p6MWNRSml6RVROUmszVUpQ?= =?utf-8?B?bi9tTmhTRWN4UkdPNmI0VEh0aWd6eENxWGhhMGhGSE1pS3hnWEV6clpZOXZM?= =?utf-8?B?S01pcXlzS0xDMmtvOWpYeEtnWlFSQ2RleENPeEVmdlVmZFBWaXhkZWZnTjk2?= =?utf-8?B?UmNtRXRkSitkQ2FyN0FrWmZmMWV0VHJGY1ZHVU9SRDR6K09mMFFFV3hwYzVt?= =?utf-8?B?NHJCSVlkYklVWEJGN3Mvb2JaeUl3UzNrY2R4czBGNzU2MVk5UDBINytpVTJI?= =?utf-8?B?OE82ZTFTM0x2SW41T1RNazhEVlFESnNESlU4c1BxbklUdE9iMVRiampsbWNn?= =?utf-8?B?N2ZzNlRpV1krTXUwb09STDJ5NWZuZUdtNTlReUQ0QlRjQnJ3SmYwdHR6Z1Zv?= =?utf-8?Q?lFriX5ZHJZy64B9YYaFR4ZrLe?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6170a799-acdc-4d07-3f40-08dbd53732f9 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2023 08:48:45.9281 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4dy/hSiw/2nq9cBmJAtcFhwDh/OztxldOb4kn+RyrD7RdoxgQTmrwF6qkeN6O4RyWjKIAV3rRGQssjwoDDNBoQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7068 X-Spam-Status: No, score=-3028.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 25.10.2023 04:01, Hu, Lin1 wrote: >> -----Original Message----- >> From: Jan Beulich >> Sent: Tuesday, October 24, 2023 8:02 PM >> To: Hu, Lin1 >> Cc: binutils@sourceware.org; Lu, Hongjiu >> Subject: Re: [PATCH] Support Intel USER_MSR >> >> On 24.10.2023 12:01, Hu, Lin1 wrote: >>>> -----Original Message----- >>>> From: Jan Beulich >>>> Sent: Tuesday, October 24, 2023 4:56 PM >>>> >>>> On 24.10.2023 10:38, Hu, Lin1 wrote: >>>>> I've thought of it so far is I can use a Fixup function like >>>>> >>>>> static bool >>>>> uwrmsr_Fixup (instr_info *ins, int bytemode, int sizeflag) { >>>>> if (bytemode == d_mode) >>>>> { >>>>> if (OP_Skip_MODRM (ins, 0, sizeflag)) >>>>> { >>>>> if (OP_I (ins, bytemode, sizeflag)) >>>>> { >>>>> ins->codep--; >>>>> } >>>>> return true; >>>>> } >>>>> } >>>>> return false; >>>>> } >>>>> >>>>> Then the uwrmsr's unit will be { "uwrmsr", { { uwrmsr_Fixup, >> d_mode }, >>>> Rq }, 0 }. >>>>> What‘s your opinion? >>>> >>>> Hmm, not very nice, but I can't exclude it simply won't get any better. >>>> My desire was for there to not be any new fixup function, and for >>>> OP_Skip_MODRM to be used directly in the table entry. (In any event, >>>> if you really need to keep this new function, please combine the >>>> three if()-s into a single one, helping readability quite a bit. >>>> >>> >>> I have another idea, can I have a new function like >>> >>> OP_back_codep(...) >>> { >>> Ins->codep--; >>> Return true; >>> } >>> >>> So the uwrmsr's unit will be { "uwrmsr", { Skip_MODRM, Id, Back_Codep, Rq }, >> 0 }. >> >> Well, the main thing I dislike is the decrementing of codep, no matter where it's >> put. In case you don't think you can get away without, I guess I'll try afterwards, >> aiming at an incremental change then. >> > > I have another one in mind at the moment. Can I have a bool variable in instr_info, > > @@ -221,6 +221,9 @@ struct instr_info > /* Record whether EVEX masking is used incorrectly. */ > bool illegal_masking; > > + /* Record whether the modrm byte has been skipped. */ > + bool has_skipped_modrm. > + > unsigned char op_ad; > > And the Skip mod/rm byte pattern will be > > @@ -11668,7 +11658,11 @@ OP_Skip_MODRM (instr_info *ins, int bytemode ATTRIBUTE_UNUSED, > > /* Skip mod/rm byte. */ > MODRM_CHECK; > - ins->codep++; > + if (!ins->has_skipped_modrm) > + { > + ins->codep++; > + ins->has_skipped_modrm = true; > + } > return true; > } > . > This change will be applied to all other similar sections (include OP_E). Yes, that's along the lines of what I had in mind. Jan