From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) by sourceware.org (Postfix) with ESMTPS id 166473858D20 for ; Tue, 20 Dec 2022 10:39:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 166473858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=foss.st.com Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BK9HkIV019113; Tue, 20 Dec 2022 11:39:04 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=+d0ph9kFu5wMHcEm35oEQ6rBqQUbtoI7oG1WPVPg2UA=; b=oLs2YbNcgcGsVyCYrPUOGm4V718ntK2yXWozcyYWGhlGxxQf6EIO5zSv//Fx87gw3cWy dyrePqxXtYwF685JFBXid+xEME4bqE1S+Fw3Zsqo9JE1ax6io+/FlMJ6waVvlCkejhqC ugWBe49ual9DA6bpezz2OKAp6UKRfAX+87cRo42j5Z8xzgrVQMw0Uxp+klBggXl8IIRd Te0G1IzVCMva2xdN+NnGg25Feem1Dob4E9JbNYu6PIh1YjhMuSbqYyCa0cJVBExTPCYG h7GYiNTcq2UWBST51ZU9e8gHKonsPhoNnCe/fbqEVySXSv3ZpqCp+zniDc+64L2izRuy Vw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3mka9x0qmp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 20 Dec 2022 11:39:04 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 1ADA910002A; Tue, 20 Dec 2022 11:38:59 +0100 (CET) Received: from Webmail-eu.st.com (shfdag1node3.st.com [10.75.129.71]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id E9404217B70; Tue, 20 Dec 2022 11:38:59 +0100 (CET) Received: from [10.252.5.234] (10.252.5.234) by SHFDAG1NODE3.st.com (10.75.129.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.13; Tue, 20 Dec 2022 11:38:56 +0100 Message-ID: <742a0e75-55c6-9449-68e7-d151bb3c1bea@foss.st.com> Date: Tue, 20 Dec 2022 11:38:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2] bfd: Discard region regardless of warning flag Content-Language: en-US To: Alan Modra CC: , , Yvan ROUX References: <20221219183450.3754890-1-torbjorn.svensson@foss.st.com> From: Torbjorn SVENSSON In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.252.5.234] X-ClientProxiedBy: EQNCAS1NODE3.st.com (10.75.129.80) To SHFDAG1NODE3.st.com (10.75.129.71) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-20_03,2022-12-20_01,2022-06-22_01 X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022-12-19 23:59, Alan Modra wrote: > On Mon, Dec 19, 2022 at 07:34:51PM +0100, Torbjörn SVENSSON via Binutils wrote: >> v1 -> v2: >> Added testcase >> >> Ok for trunk? > > This is OK except for a few minor things. > >> I have commit access for GDB. Do I still need someone to push this for >> me or do I automatically have write access to the complete binutils >> repository and just need the approval to push it myself? > > You should be able to push it. > >> The discard of the region should be performed regardless if the warning > > This should say "The discard of symbols in..." not "The discard of...". > The code here is handling symbols. > >> for the discard is enabled or not. > >> +++ b/ld/testsuite/ld-arm/non-contiguous-arm7.d >> @@ -0,0 +1,4 @@ >> +#name: non-contiguous-arm7 >> +#source: non-contiguous-arm7.s >> +#ld: --enable-non-contiguous-regions -T non-contiguous-arm7.ld --gc-sections > > Please remove --gc-sections. The testcase doesn't need it. > Pushed with the modifications mentioned above.