From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 389A43858403 for ; Tue, 16 Aug 2022 14:18:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 389A43858403 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-581--LXmqtESPUi-ZhKsZ8et5w-1; Tue, 16 Aug 2022 10:18:18 -0400 X-MC-Unique: -LXmqtESPUi-ZhKsZ8et5w-1 Received: by mail-wm1-f71.google.com with SMTP id f5-20020a1cc905000000b003a60ef7ec71so102389wmb.4 for ; Tue, 16 Aug 2022 07:18:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=gJsyETL3VNtjD8rbUWg/GXWptLf5IGkRflFNvxoyYNw=; b=q69KH9ZbY/Cl+9EzaSNRdyPHqNTJGul4XTEonNX0GgXSUJeQQXE1gyo7YlImxikrf8 KiTdb7SXElgZJSPOtJcd2fMvWRJuSyhsbMNyc1+MpdzskdSBiDrHtWWHvwHk1QeL5cQU 2fFbHCe5wmUbqU4p0tDNPSz7Me97LVMwhtF6BwWLo8/By5N39UpCAPIaT/GYrGo2rH+Z 2fWSlU1p5yLOc4EGjRdO23hBkD4RVj6QdYMp3z4A1S5vJ1i4J4Pn5siz81f94cLuhFSj C21ioc2b1AFqaM0mot3y8AkBZttr9tB/73vuB1S1awRh6Y+BBdxlTHIe/n+bvaoIjJLz co6A== X-Gm-Message-State: ACgBeo3KlyEMaIAkL58gnZmJbBLsHC+vT493RQ9WQ/FfqRmsZUl0q30v SmO3eu2fkRcK1Pgjt5ub+ect4aP7OWec1kE6zIvbhC04zMR0HwEgqkjfJdWz9S4x9qMsgA/lu12 Cmm8LccgWn9+Jw+svRw== X-Received: by 2002:a05:600c:4ed0:b0:3a6:de8:5e7d with SMTP id g16-20020a05600c4ed000b003a60de85e7dmr791127wmq.181.1660659497769; Tue, 16 Aug 2022 07:18:17 -0700 (PDT) X-Google-Smtp-Source: AA6agR7NV1/LJvTVTqJZ9yJGi/uD3ln3cBlyiSOgzisCyx0hqxZwavVNSTZ7m8XUOq8x1tLKnZl2cg== X-Received: by 2002:a05:600c:4ed0:b0:3a6:de8:5e7d with SMTP id g16-20020a05600c4ed000b003a60de85e7dmr791115wmq.181.1660659497574; Tue, 16 Aug 2022 07:18:17 -0700 (PDT) Received: from [192.168.1.6] (adsl-2-solo-236-177.claranet.co.uk. [80.168.236.177]) by smtp.gmail.com with ESMTPSA id k4-20020a5d66c4000000b002217a25ba8dsm10001175wrw.44.2022.08.16.07.18.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Aug 2022 07:18:17 -0700 (PDT) Message-ID: <7492551a-3f20-1a37-5c8e-6152d1df15fd@redhat.com> Date: Tue, 16 Aug 2022 15:18:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH] bfd: Define func prototype for old mingw To: =?UTF-8?Q?Torbj=c3=b6rn_SVENSSON?= , binutils@sourceware.org References: <20220815084902.3630298-1-torbjorn.svensson@foss.st.com> From: Nick Clifton In-Reply-To: <20220815084902.3630298-1-torbjorn.svensson@foss.st.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2022 14:18:26 -0000 Hi Torbjörn, > diff --git a/bfd/bfdio.c b/bfd/bfdio.c > index a7c7d5bd363..59f79203b88 100644 > --- a/bfd/bfdio.c > +++ b/bfd/bfdio.c > @@ -29,6 +29,11 @@ > #if defined (_WIN32) > #include > #include > + > +#if defined(__MINGW64_VERSION_MAJOR) && __MINGW64_VERSION_MAJOR < 9 > +/* This prototype was added to locale.h in version 9.0 of MinaGW-w64. */ > +_CRTIMP unsigned int __cdecl ___lc_codepage_func(void); > +#endif > #endif > > #ifndef S_IXUSR Approved - please apply. Cheers Nick