From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2051.outbound.protection.outlook.com [40.107.8.51]) by sourceware.org (Postfix) with ESMTPS id 7DBAE3858D32 for ; Wed, 15 Nov 2023 07:36:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7DBAE3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7DBAE3858D32 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.8.51 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700033767; cv=pass; b=WrN7r/1e2Tugz35k17Erls0Np6rwQ2mZygtoESsgqL+TGvduqozVp8Dsfp+Cp9Pg6ciy61ehE01ChfniBf0jfpYXLdoBHNRZ3g30FUpGyK092gv42lSu042PiuDcY5MXMQhGZqR45sqAj518zu4k4h8dYngpK0zB1ZZOzxNXlgo= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700033767; c=relaxed/simple; bh=jby4Hex89ZgxxDl78n+oUzG8ZmpmEl9z4Tli7E3qEvE=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=xUK6lnXD1NzKR+kHXuNnnxqME+kHFO9S+6+cv2Rh6xx2iwEYLu8692iTH9odojdZiALopBf2AcQLg1IoIQvl9XxvuRHQbBJ2jrdxBwKQgOzS+ei/CFJ25iuzYJEeqZ3FlCy84jcWcXHkRQUa7dhIrS7GAagSC1UwknI16WWEaXc= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CHTXTBCv/OTaM9XjmwiYzrLLDxswPYNuC7dxty7ol5p9LweSVSypF/MRVazz8AhuRj55OfuxmLH5djbRYadnMIagZfakQznLhXeybeO3r1YtmpxqpX5ZW9aHwPi7UVCmcrPIZ0CDOG3PO8pc0+86/sVuotPxXFR813ZGyCdyAeXXwu3womq+5ixOSwS9EGJe+3w30Q0ycLieRhNTCchLHmGAr3b39+/ZGFx7BjxUUMZBWt8ddXyxV4cBoiV3otFof0eevS+BJU+wlddW/63mB1B/G9UU/+7OMeFhk3qbrXPNm1Rqt33+fOFuUDZqPunA3gdN6i04VGyNaf69paEuFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EE94sOHd0cZ40xIXOUjWMVi7bh7wcx4IR9/RjLysSy8=; b=PKIUlhcqNBIVwIgg/Aknwu7xjrDj0VTDkN5/OybRDhBLeJqSxc4W6hZXaOPPorzw/uWZuKxJySJ3zKjE/Bw6mECQFYSxU4b6BejGTppUHzSAYAmlOPTrYBKVbOlpGStx57Ysq+sg7p4cITGHbV86HoS3lmXZhNqc1D7RQOZK0jKmFnTmMK2BqtjN40LcjImxRlAKZbQ347F3tPmILS6sG7RNaikYma7X6F9Zf3MV1GIQT74LffaRGfggZK84KmEvN3W4AQpWJCAHsneOXlsAfyvO5MjPy+upg4r55fg9nApvGTVaDvbu2r/ZIgWZEETOsJf1MU9sluqzWcX+tJd2NQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EE94sOHd0cZ40xIXOUjWMVi7bh7wcx4IR9/RjLysSy8=; b=Zt1JM5JN4L47O+fYf9pqP7HcI2gCo483Nj9/SA7PQNq8UQdCid2psfCylaI0N5Qii+I8J8sIgQ05E417gbcO67L7GZ7Muupp6SPWIM96z1MHYKUJCk8QQa+ln27GWbQ8wHVUyjzXs+Nzm0Eztn2z0sz9qo6fBvoCuh833dVoDFGP/vB0UGXveJd+wKhmOWfRXa9koOGXdr0EfS7snCHt1ZwN+0qHJOvdMGPNmIJUZ8Jka9m5MD+E2ApH8c4CwJfBRqiIsJKbObhz/eumntA1kwji//1b93sKPuFDTGUIx7iPkytfhhNqf2WkzzliXZgAVqYZbNS/lC3PLuRjZr4e7A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAWPR04MB9768.eurprd04.prod.outlook.com (2603:10a6:102:381::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.17; Wed, 15 Nov 2023 07:36:02 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44%3]) with mapi id 15.20.7002.019; Wed, 15 Nov 2023 07:36:02 +0000 Message-ID: <757971fd-4101-4073-960a-9c78c7cc5e9c@suse.com> Date: Wed, 15 Nov 2023 08:36:00 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH][v6] Support Intel USER_MSR Content-Language: en-US To: "Jiang, Haochen" Cc: "Lu, Hongjiu" , "binutils@sourceware.org" , "Hu, Lin1" , "Cui, Lili" References: <260c522e-dbb0-7e40-1419-5bb269fef823@suse.com> <20231031021410.1543517-1-lin1.hu@intel.com> <8c470237-ab0d-8927-af86-31e0f8d45752@suse.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0163.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::9) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAWPR04MB9768:EE_ X-MS-Office365-Filtering-Correlation-Id: 66effb03-1311-45c1-ca0b-08dbe5ad84d3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: txYU4C1G/xWxIhxWhd9mlcUkqpCrOxQiRmhy1ewdbK9PAbbHyhy3kleNSKJf0pUwlcAk0Y6wYVXce/Cgzmxq7+O3GhoK5Rg+mf1PcCRSggItmXlQVFCw5GmCsjgPydyScJbyc1XW+QKtRuH5c2Ka9h1eFwQoyLL0DuzcqxUnAZwzOMyfCehK9cK93Sujg3hc7fW9KOCiQXa/nTyqyxFUOZi1g9NqkJbslycmVxEW5LkZiAAGfnzAag2RKMvXAwexNGTl//dJ+2fD5750TRhPds9+H5OU2BYlLtxI7FBAY2PZFsrKO8SAWrgNQ0GDKC9iaJTg0971u3/xsJewCsURxlir+gOI3BQEj4xnE6G4KJXWKvgPzW2U8td9QFR3RMTYgjzakHPGs4UutJQgLKmLFUAu3CI6neoD1AZaxxb7hDryUjIH7m1ZLRuitbPGjO81qoJPvTYjbuSqRCdXMS4AtfDtlu60PQpZ6qG8bDfZ6Axl42o68gnvJ8h37ntwt8Q/cEictMB+HKTxaXDimDvg+C0k9sF6AMyX3JTVuVHeWUfEG1dIZbejG0nTBz5fq3JFjAbahuNOP5xtizMphll0mBdEf/LtS+LFIXkEYDKiMePo7gCOWLzN87ZnXg8t7keKNeiUgCZW64Ty61MmLSL0sQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(136003)(396003)(346002)(376002)(366004)(230922051799003)(186009)(64100799003)(1800799009)(451199024)(31696002)(53546011)(86362001)(41300700001)(26005)(83380400001)(38100700002)(31686004)(36756003)(6506007)(6486002)(2616005)(2906002)(54906003)(5660300002)(66476007)(66946007)(6916009)(316002)(66556008)(478600001)(8676002)(4326008)(8936002)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZG85YjNrVjllN05GeWpVZlFuK3hrQU1TZ3BuU0ZSRnI2UkY4STJFUjFaWTJZ?= =?utf-8?B?cWZScDdEMDdYVU14K2l3ZURkK2xLZ3ErS3lYYzJHNjlleTZxaFUzdHhWdDZ5?= =?utf-8?B?NnV1S1pES2E2Wm1JV3g4c2R4c1JZcmcvaHFEbjFud2hpV1J4ZnlpSTd4eUpk?= =?utf-8?B?RXlZSGNWSytHVjg2VEJlc1QwVmJDRXZMUTYzNXJLUUhFc2tHcEx5T3JScnh2?= =?utf-8?B?T2ZRQWNhYy9xOEhuVlczM2FxOEVlYm1nYUdKQ1JiZStjajZ1VDZNQzFYQUVl?= =?utf-8?B?R2hmTm9HM29vSlZycWFWOEF6bTRCOFk0R3JsS2Y0b2RsR1ZoY2szZ0tLYUNP?= =?utf-8?B?NmxjOFB5SmJGdXBvNGUycnYrRnIvNjh5MDhwUHMxd054K0VHbmFqc05DdFN1?= =?utf-8?B?M1pGcHdtNlZ0WEQrSjZRQXh3NFp5Wm5HelVYQUY3QVJBY2ZGRmxDbkN1em1T?= =?utf-8?B?c3VqRmlPYW1xUU1rcTF3dEFZZnVJRHRJYm13bjJQMVhuK1lQRXVqVUkrVEpM?= =?utf-8?B?QkZCYlRGWVI3RFFRVnJzVzE4dEVRRUZPR0duMXkxZlNBRlVkSjZ0RG9WQXZ3?= =?utf-8?B?WHNTNXZaUjVLQ3JjVElFUThSZ09Jek1wM0lDSnd5K2pzU2RGVG50V21sMWg0?= =?utf-8?B?YlhRWTAxTENMOVRYQ3BSdjZHZ2UrMFY4RlJjRS8vZkk0N084Z2pwYXJrR3Rw?= =?utf-8?B?OGVTdmhQVFkyNk53SE1XRnZwZFEyTG9VaHBBUm40ZmZvam9Ba1dJU1cvOElO?= =?utf-8?B?RWFHdm5FKzBZbkhENk0vV3c4cG11S1dpQnZsTFgyQng4enNGOWMyVzR2MVU4?= =?utf-8?B?QXNVZ2VSSFZ3RUl3OEw1dkxicGd2UGxJaWd1aVVtMlE0NkwzZWhUM3J1dlQw?= =?utf-8?B?UDFUbFhObzdxaHh6SGpWc21oQjNSSExlVDdvdzZoWGhoVTI5eXFkY1RydXQy?= =?utf-8?B?YUZ4WlZiMlFHZmg4UFFra1F3TEN1Y3o4T1JzRFAwNnBiUllydXlxRXQvRmhU?= =?utf-8?B?cDh2K0RmdVd4WVl2Y3NSYy9WVVFQYVRCNEdFeENRVlErZ05vQXRkMmJ4N3FB?= =?utf-8?B?dWhMKzVQRkJ0YTVxdlMyTUdpVWgyMTVVWEdmM1hhN0Q5eTUxMkU1a3BYYjk0?= =?utf-8?B?bFpNQ1FEdzFycmVQb0hIL3R2YzVJVmdtOUNBeUxic2N3b2ExUCt2VHJRZ0F1?= =?utf-8?B?K3o0ZWtGWkF1RlZ2SGxUWXJmVzRHQ3N1cWxEc2lGSWpMU1dLOU56a1IzT3N0?= =?utf-8?B?dWplV3ovWEhIbjlQQ0tkcnVQZngzc0tmVGNwMkpBc0crbTJaUlEvK3dZbWlY?= =?utf-8?B?SGg3ZzQyVnNEbm11Q09sSU50eVE1NWVrY245SitzWS9MUEo3VnEwVzllRmZ6?= =?utf-8?B?WFU4RzFMOXNYTzJjWGptQ0hJSzBFWnV2YmtWdjdDbUJRQUovUnY0Sno2RVRH?= =?utf-8?B?a3lPUUNhaGg4OWxvbG4zdEczK1NMVnpFWi85a1h5aC9IdXRKSTJpV1lIOFJq?= =?utf-8?B?N0ltYndXSkUzK0dhc0YrdGVqcVN2QW9TY2xhYXB4MnFtUXlIdWJhSVNocHJv?= =?utf-8?B?alllejNtTGlvU1BnRFlEbnlJTlpOSDUvN2szckMyaUh0bVhyNm54ZDZMeVN0?= =?utf-8?B?S1BoWTFEd0JjczJIZUkvNWdxWEg4bHpnSkd4QzJYUXRucG1jRElKTC9FZEVH?= =?utf-8?B?RGpVTmFOa2NRak5pc2NNUEg0N2hYS3h3dWNxSzd1MVl3ZTNPWkRCcWNlcFhL?= =?utf-8?B?RXB4KzhYQWNaKzl6eGZWa05wSk82TWN3UWQxN3F5ay9HRUE1aHZSM0VaT2F5?= =?utf-8?B?cDArKzNickhhRllhZmt2enhSaG1PRlFwQUZ0bFJ2azh6WkxUR2Y4LzNmL2Z3?= =?utf-8?B?NDZCeFNjQzVwSzBKL1QvbS92Zkc4QzBka2VGeHdvbVZTdWpLK09BUEFjbmFN?= =?utf-8?B?a0Q0eTVaQytPTXk3SkhqS2puWGdpOWdYNmpKOWk2U1pHcXBRSU43Q0FxVHNH?= =?utf-8?B?Wk5vYXpwd01pcWxoUHBnYk1KL1UrMWw2K0F5RzcyU2t2YU9MaGVLNkxybnVV?= =?utf-8?B?QXNxc0c0dGkwQzJFdHozdi9SbFdwOTN2TDJtTlZLU1FWZTBLdGcwbkZ1Ykxj?= =?utf-8?Q?LeJRWixM6HBAk/NjagKqFo2pE?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 66effb03-1311-45c1-ca0b-08dbe5ad84d3 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2023 07:36:02.6154 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Fc6b8EbItWky8v8G5cDMXLz3DodapvaIaX6Q6ONf3UARB8y86XYmuHW7FflX0na/wGhuwyy7iJSk0QB4ANWZ5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB9768 X-Spam-Status: No, score=-3026.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 15.11.2023 04:34, Jiang, Haochen wrote: >>>> + >>>> +// USER_MSR instructions. >>>> + >>>> +urdmsr, 0xf20f38f8, USER_MSR|x64, RegMem|NoSuf|NoRex64, >> { Reg64, >>>> +Reg64 } urdmsr, 0xf2f8/0, USER_MSR|x64, >>>> +Modrm|Vex128|VexMap7|VexW0|NoSuf, { Imm32, Reg64 } uwrmsr, >>>> +0xf30f38f8, USER_MSR|x64, Modrm|NoSuf|NoRex64, { Reg64, Reg64 } >>>> +uwrmsr, 0xf3f8/0, USER_MSR|x64, Modrm|Vex128|VexMap7|VexW0|NoSuf, >>> { >>>> +Reg64, Imm32 } >>> >>> Actually I think the choice of Reg64 here for the operand specifying the MSR >>> index is misleading, even if in line with what the doc presently says in the >>> Opcode / Instruction column. For both insns the description says that only the >>> low 32 bits are used (and the Exceptions section confirms this). Such operands, >>> however, are expressed as Reg32 everywhere else. I'd like to suggest that the >>> spec be adjusted, and I'm heavily inclined to change binutils regardless. Thoughts? > > I suppose the reason why it is using Reg64 is because when the other operand is > register, it is rare not to align the register size. I checked SDE and ISE and only > got one case. And this reg size is inherited from that. Only one? I know of two (MOVSX and MOVZX) without even needing to go look. Both registers matching in size is sensible only if both also express the same kind of entity. (Moves between GPRs and MM/XMM registers are other examples, just that there it's also register "kind" that's different.) Jan