public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: "Clément Chigot" <chigot@adacore.com>, binutils@sourceware.org
Cc: amodra@gmail.com
Subject: Re: [RFC] ld/testsuite: force warnings when dealing with execstack tests
Date: Wed, 28 Sep 2022 15:05:15 +0100	[thread overview]
Message-ID: <75dd5e03-6e4c-2dba-03ba-9935295e5fc3@redhat.com> (raw)
In-Reply-To: <20220928133542.471998-1-chigot@adacore.com>

Hi Clément,

> 	* testsuite/ld-elf/elf.exp (PR ld/29072): Force execstack and
> 	RWD segment warnings.

I like this patch - simplifying things is always a good idea in my opinion.
One suggestion though:

>       run_ld_link_tests [list \
>   	[list "PR ld/29072 (warn about an executable .note.GNU-stack)" \
> -	    "-e 0 $extra_link_opts" \
> +	    "-e 0 --warn-execstack --warn-rwx-segments" \
>   	    "" \
>   	    "" \
>   	    {pr29072-a.s} \

I would add a comment explaining why the two options are always used here.
Just in case a future reader thinks that they are redundant and submits a
patch to remove them. :-)

Cheers
   Nick


      reply	other threads:[~2022-09-28 14:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-28 13:35 Clément Chigot
2022-09-28 14:05 ` Nick Clifton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75dd5e03-6e4c-2dba-03ba-9935295e5fc3@redhat.com \
    --to=nickc@redhat.com \
    --cc=amodra@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=chigot@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).