From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 8BB033858283 for ; Wed, 28 Sep 2022 14:05:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8BB033858283 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664373921; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4M1AUR21BaESuXNF6wESx9ZmKltGxuhNPNP/93BKbtE=; b=KXLIJh7qSNHcLL6jYRmlQdyOYq7M5eGI+Ec3ee+6sUqOze3XLR2XqYYmr52V2CkTQUpUOm lofsoyoVIewnn/CMMN92q2UKzPMpPrfLWKsWtio2yEXlkyC64+qAo7P2sBd5FUmVx7y6ap 24j5C4ouDNZenUjzZ3piC6HLFROa3aY= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-389-4ghcL64xPaSeMD4QnjvAeg-1; Wed, 28 Sep 2022 10:05:20 -0400 X-MC-Unique: 4ghcL64xPaSeMD4QnjvAeg-1 Received: by mail-wr1-f71.google.com with SMTP id k6-20020adfc706000000b0022cc19d5dd2so1336435wrg.7 for ; Wed, 28 Sep 2022 07:05:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=4M1AUR21BaESuXNF6wESx9ZmKltGxuhNPNP/93BKbtE=; b=woZ2kHqFP0fbNYHfVBsX/klbsBSJ3et29lY9Sg+Dd40rimRXi+GBHIbNCUswIGbGel mFBnH198f/4dp0QDuksMsWA7uq5Anm6vtvjM7lTQVcF57RUCI2xYeLIi91F8AJbBHRPJ f4ijYQNmVGvvIVdBGXPQ1pR3umBoyfU1ffaPyUBEaxOPbbLUx9bbtRGenEUZ+Kcmh/jP gR1HU6fvCsrw3UEt/k0mFge6PLUMSgL8AJyckM/OcOJXAxp2ctC6YCRqOw2dzGTM4R3j 49tb+YWAQCy/jriTCH826y0PSn8toWrLmvI+ns//BTcaDrVmWu2vYDq1x+7L88XiWEqb hkwg== X-Gm-Message-State: ACrzQf3N0ZPxFz7Q2plA7KWSs2jZetk+/81Z+WlN8UwVjasgkw7kVGcL nn6bbj4rXTtCJ/QAqH90HDX2cTc4TKmYXT0bQp4meIpYE2IjM3ISjkNKi3nUoKf80+fcoDfWYKD p71J1JO/tpsdEbVsx5g== X-Received: by 2002:a05:600c:524d:b0:3b4:91ee:933e with SMTP id fc13-20020a05600c524d00b003b491ee933emr7185218wmb.80.1664373917635; Wed, 28 Sep 2022 07:05:17 -0700 (PDT) X-Google-Smtp-Source: AMsMyM47+12flGx4VrqoQpteXNntvkdqm3L26eyNMqTlN1O4MgoeEorfwSsUituvudBfcEiaj9XTqg== X-Received: by 2002:a05:600c:524d:b0:3b4:91ee:933e with SMTP id fc13-20020a05600c524d00b003b491ee933emr7185157wmb.80.1664373917112; Wed, 28 Sep 2022 07:05:17 -0700 (PDT) Received: from [192.168.1.18] ([212.126.151.172]) by smtp.gmail.com with ESMTPSA id m17-20020a05600c3b1100b003b476cabf1csm2613456wms.26.2022.09.28.07.05.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Sep 2022 07:05:16 -0700 (PDT) Message-ID: <75dd5e03-6e4c-2dba-03ba-9935295e5fc3@redhat.com> Date: Wed, 28 Sep 2022 15:05:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [RFC] ld/testsuite: force warnings when dealing with execstack tests To: =?UTF-8?Q?Cl=c3=a9ment_Chigot?= , binutils@sourceware.org Cc: amodra@gmail.com References: <20220928133542.471998-1-chigot@adacore.com> From: Nick Clifton In-Reply-To: <20220928133542.471998-1-chigot@adacore.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Clément, > * testsuite/ld-elf/elf.exp (PR ld/29072): Force execstack and > RWD segment warnings. I like this patch - simplifying things is always a good idea in my opinion. One suggestion though: > run_ld_link_tests [list \ > [list "PR ld/29072 (warn about an executable .note.GNU-stack)" \ > - "-e 0 $extra_link_opts" \ > + "-e 0 --warn-execstack --warn-rwx-segments" \ > "" \ > "" \ > {pr29072-a.s} \ I would add a comment explaining why the two options are always used here. Just in case a future reader thinks that they are redundant and submits a patch to remove them. :-) Cheers Nick