* [RFC] ld/testsuite: force warnings when dealing with execstack tests
@ 2022-09-28 13:35 Clément Chigot
2022-09-28 14:05 ` Nick Clifton
0 siblings, 1 reply; 2+ messages in thread
From: Clément Chigot @ 2022-09-28 13:35 UTC (permalink / raw)
To: binutils, nickc; +Cc: amodra, Clément Chigot
Hi Nick,
I've already raised the issue sometimes back inside a more general
patch. But with Alan, we weren't sure this was the good approach. This
test might also be there to ensure that warnings are printed by default
with a configuration not disabling them. Thus, I'm resubmitting it as RFC.
---
Binutils can be configured to avoid printing the execstack or RWD
segment warnings. In this case, the first test of PR ld/29072 will fail.
Fix that by always manually forcing the warnings for it.
ld/ChangeLog:
* testsuite/ld-elf/elf.exp (PR ld/29072): Force execstack and
RWD segment warnings.
---
ld/testsuite/ld-elf/elf.exp | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/ld/testsuite/ld-elf/elf.exp b/ld/testsuite/ld-elf/elf.exp
index 64b1d34f055..ad5bcb87cf1 100644
--- a/ld/testsuite/ld-elf/elf.exp
+++ b/ld/testsuite/ld-elf/elf.exp
@@ -237,18 +237,9 @@ if { [istarget *-*-*linux*]
return $text
}
- # The HPPA target disables the warnings by default since it needs an
- # executable stack to support older kernels and an RWX segment to
- # support its PLT. MIPS also turns off exec stack warnings.
- if { [istarget "hppa*-*-*"] || [istarget mips*-*-*] } {
- set extra_link_opts "--warn-execstack --warn-rwx-segments"
- } else {
- set extra_link_opts ""
- }
-
run_ld_link_tests [list \
[list "PR ld/29072 (warn about an executable .note.GNU-stack)" \
- "-e 0 $extra_link_opts" \
+ "-e 0 --warn-execstack --warn-rwx-segments" \
"" \
"" \
{pr29072-a.s} \
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RFC] ld/testsuite: force warnings when dealing with execstack tests
2022-09-28 13:35 [RFC] ld/testsuite: force warnings when dealing with execstack tests Clément Chigot
@ 2022-09-28 14:05 ` Nick Clifton
0 siblings, 0 replies; 2+ messages in thread
From: Nick Clifton @ 2022-09-28 14:05 UTC (permalink / raw)
To: Clément Chigot, binutils; +Cc: amodra
Hi Clément,
> * testsuite/ld-elf/elf.exp (PR ld/29072): Force execstack and
> RWD segment warnings.
I like this patch - simplifying things is always a good idea in my opinion.
One suggestion though:
> run_ld_link_tests [list \
> [list "PR ld/29072 (warn about an executable .note.GNU-stack)" \
> - "-e 0 $extra_link_opts" \
> + "-e 0 --warn-execstack --warn-rwx-segments" \
> "" \
> "" \
> {pr29072-a.s} \
I would add a comment explaining why the two options are always used here.
Just in case a future reader thinks that they are redundant and submits a
patch to remove them. :-)
Cheers
Nick
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-28 14:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-28 13:35 [RFC] ld/testsuite: force warnings when dealing with execstack tests Clément Chigot
2022-09-28 14:05 ` Nick Clifton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).