From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 0F81F385773C for ; Tue, 18 Jul 2023 15:24:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0F81F385773C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689693872; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GPf90nVn5gDkg+mcKzSGxj4c9To9NBG1rh5io3YjiMI=; b=P32s0aT7ACQa21NvfXmOPz6ZSMosa4vmLuI1x/lIBaRY7yF5dcnwtp5Wr+g7oqUFoPlzOh PcF/NZzbBfheL4x2fM3Qi00Hpu4hx7GIw0Gh0Km0+5oNqVQwwUl3fEPkvEKV5Xob6tz4HU SSfcZ9GlvKG6wGGgu5s9Z5JdGtVvMY0= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-357-i0OM-ADeNLqfh20Q_veeAg-1; Tue, 18 Jul 2023 11:24:30 -0400 X-MC-Unique: i0OM-ADeNLqfh20Q_veeAg-1 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-765a44ce88aso419312585a.1 for ; Tue, 18 Jul 2023 08:24:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689693870; x=1690298670; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GPf90nVn5gDkg+mcKzSGxj4c9To9NBG1rh5io3YjiMI=; b=BI5tMLFvmNNEBrpsSIj8PtXC/XrWwwAOBeP3HSODzda+aNbyYiPrzF7GR6JLtjg/x3 yRNmhaUKxgkSnSZYaBkDwBCTZLyx8hz5RGVSlRvkc7m3QRkPa50BgdDxZNgQqnw35U6l pm2252owOqJ1rwvpS9qavbSrwwS1Mku+3oLj6P2m0tyxm7sv1wzyD5YXkwVmttGinSN8 eom1AtYrMe3ef98luwaO+fr/g9LEYmEmqtj2kMb4xNAQIYYytyp9fGjXVdRHcd3QufoC DX4DISIbVx7Tw8y50YvjdScnDMURlAgrAgcYa/7V+UXbGe+yrMsZnc0iDbJxHv/xDUeV uGJg== X-Gm-Message-State: ABy/qLYgfD6kCczh4e4HmRTaXNavZacQzVUgiFuVKVqthd+O41NMlN6B 8meiK84Wxuc/y5/Wn3jd3unv3bH1yXlcnibY93/gFiXeI9zLNRHZzozGocS9Q9Lwu4H8mHoZn41 et/PGz0rCnaPKR4s+Gz8jAKcuYw== X-Received: by 2002:a05:620a:4553:b0:75b:23a1:d853 with SMTP id u19-20020a05620a455300b0075b23a1d853mr17052738qkp.21.1689693870093; Tue, 18 Jul 2023 08:24:30 -0700 (PDT) X-Google-Smtp-Source: APBJJlH5RTNwMlx6+npSCu4518hVAhqn4fTzKRO5udK2JSiqyIeco3KfG7oS3BPF7W1+MBPlkji9uA== X-Received: by 2002:a05:620a:4553:b0:75b:23a1:d853 with SMTP id u19-20020a05620a455300b0075b23a1d853mr17052718qkp.21.1689693869792; Tue, 18 Jul 2023 08:24:29 -0700 (PDT) Received: from [192.168.1.7] (adsl-2-solo-172-78.claranet.co.uk. [80.168.172.78]) by smtp.gmail.com with ESMTPSA id j27-20020a05620a001b00b00766fbeb3e7csm640634qki.132.2023.07.18.08.24.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Jul 2023 08:24:29 -0700 (PDT) Message-ID: <75e3c5a2-2098-90e6-13b0-4a007adcc58b@redhat.com> Date: Tue, 18 Jul 2023 16:24:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] objdump: Round ASCII art lines in jump visualization To: Waqar Hameed , binutils@sourceware.org References: <878rbrgzoz.fsf@gmail.com> From: Nick Clifton In-Reply-To: <878rbrgzoz.fsf@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Waqar, > Lines with rounded corners are easier to follow (and easier on the > eyes). Use `,` and `'` instead of `/` and `\`, respectively, when > drawing lines for jumps. Well this is kind of a personal thing, and not everyone may agree with your choice of characters. So how about allowing the user to select the characters that they like ? For example if you added a new command line option: --visualize-jump-chars="/,+>'" which could then be used to provide the characters displayed at various points on the graph. Obviously this would be a more complicated patch, and would require adding some more documentation, but overall I think that it would be worthwhile... Cheers Nick