* [PATCH] elf32-arm.c: Use prefix 0x when printing private flags. elfnn-aarch64.c: Likewise.
@ 2020-12-10 12:43 Alexander Fedotov
2020-12-14 12:46 ` Alexander Fedotov
0 siblings, 1 reply; 4+ messages in thread
From: Alexander Fedotov @ 2020-12-10 12:43 UTC (permalink / raw)
To: binutils
Currently objudmp for Arm and AArch64 shows flags in decimal format that is misleading.
---
bfd/ChangeLog | 6 ++++++
bfd/elf32-arm.c | 4 ++--
bfd/elfnn-aarch64.c | 4 ++--
3 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 99c275ce4f..3717cf4ffe 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,9 @@
+2020-12-08 Alexander Fedotov <alfedotov@gmail.com>
+
+ * elf32-arm.c (elf32_arm_print_private_bfd_data): Use prefix 0x
+ when printing private flags.
+ * elfnn-aarch64.c (elfNN_aarch64_print_private_bfd_data): Likewise.
+
2020-12-07 Siddhesh Poyarekar <siddhesh@sourceware.org>
PR 26945
diff --git a/bfd/elf32-arm.c b/bfd/elf32-arm.c
index 2f6bd88555..eadfc34249 100644
--- a/bfd/elf32-arm.c
+++ b/bfd/elf32-arm.c
@@ -15062,7 +15062,7 @@ elf32_arm_print_private_bfd_data (bfd *abfd, void * ptr)
/* Ignore init flag - it may not be set, despite the flags field
containing valid data. */
- fprintf (file, _("private flags = %lx:"), elf_elfheader (abfd)->e_flags);
+ fprintf (file, _("private flags = 0x%lx:"), elf_elfheader (abfd)->e_flags);
switch (EF_ARM_EABI_VERSION (flags))
{
@@ -15183,7 +15183,7 @@ elf32_arm_print_private_bfd_data (bfd *abfd, void * ptr)
flags &= ~ (EF_ARM_RELEXEC | EF_ARM_PIC);
if (flags)
- fprintf (file, _("<Unrecognised flag bits set>"));
+ fprintf (file, _(" <Unrecognised flag bits set>"));
fputc ('\n', file);
diff --git a/bfd/elfnn-aarch64.c b/bfd/elfnn-aarch64.c
index fcb6171679..96eef4ec43 100644
--- a/bfd/elfnn-aarch64.c
+++ b/bfd/elfnn-aarch64.c
@@ -7331,10 +7331,10 @@ elfNN_aarch64_print_private_bfd_data (bfd *abfd, void *ptr)
containing valid data. */
/* xgettext:c-format */
- fprintf (file, _("private flags = %lx:"), elf_elfheader (abfd)->e_flags);
+ fprintf (file, _("private flags = 0x%lx:"), elf_elfheader (abfd)->e_flags);
if (flags)
- fprintf (file, _("<Unrecognised flag bits set>"));
+ fprintf (file, _(" <Unrecognised flag bits set>"));
fputc ('\n', file);
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] elf32-arm.c: Use prefix 0x when printing private flags. elfnn-aarch64.c: Likewise.
2020-12-10 12:43 [PATCH] elf32-arm.c: Use prefix 0x when printing private flags. elfnn-aarch64.c: Likewise Alexander Fedotov
@ 2020-12-14 12:46 ` Alexander Fedotov
2020-12-21 9:26 ` Alexander Fedotov
0 siblings, 1 reply; 4+ messages in thread
From: Alexander Fedotov @ 2020-12-14 12:46 UTC (permalink / raw)
To: Nick Clifton, binutils
Hi Nick
Could you please take a look at this tiny fix. I've run make-check for
Arm and AArch64 w/o errors locally.
Best regards,
Alex
On Thu, Dec 10, 2020 at 3:43 PM Alexander Fedotov <alfedotov@gmail.com> wrote:
>
> Currently objudmp for Arm and AArch64 shows flags in decimal format that is misleading.
>
> ---
> bfd/ChangeLog | 6 ++++++
> bfd/elf32-arm.c | 4 ++--
> bfd/elfnn-aarch64.c | 4 ++--
> 3 files changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/bfd/ChangeLog b/bfd/ChangeLog
> index 99c275ce4f..3717cf4ffe 100644
> --- a/bfd/ChangeLog
> +++ b/bfd/ChangeLog
> @@ -1,3 +1,9 @@
> +2020-12-08 Alexander Fedotov <alfedotov@gmail.com>
> +
> + * elf32-arm.c (elf32_arm_print_private_bfd_data): Use prefix 0x
> + when printing private flags.
> + * elfnn-aarch64.c (elfNN_aarch64_print_private_bfd_data): Likewise.
> +
> 2020-12-07 Siddhesh Poyarekar <siddhesh@sourceware.org>
>
> PR 26945
> diff --git a/bfd/elf32-arm.c b/bfd/elf32-arm.c
> index 2f6bd88555..eadfc34249 100644
> --- a/bfd/elf32-arm.c
> +++ b/bfd/elf32-arm.c
> @@ -15062,7 +15062,7 @@ elf32_arm_print_private_bfd_data (bfd *abfd, void * ptr)
> /* Ignore init flag - it may not be set, despite the flags field
> containing valid data. */
>
> - fprintf (file, _("private flags = %lx:"), elf_elfheader (abfd)->e_flags);
> + fprintf (file, _("private flags = 0x%lx:"), elf_elfheader (abfd)->e_flags);
>
> switch (EF_ARM_EABI_VERSION (flags))
> {
> @@ -15183,7 +15183,7 @@ elf32_arm_print_private_bfd_data (bfd *abfd, void * ptr)
> flags &= ~ (EF_ARM_RELEXEC | EF_ARM_PIC);
>
> if (flags)
> - fprintf (file, _("<Unrecognised flag bits set>"));
> + fprintf (file, _(" <Unrecognised flag bits set>"));
>
> fputc ('\n', file);
>
> diff --git a/bfd/elfnn-aarch64.c b/bfd/elfnn-aarch64.c
> index fcb6171679..96eef4ec43 100644
> --- a/bfd/elfnn-aarch64.c
> +++ b/bfd/elfnn-aarch64.c
> @@ -7331,10 +7331,10 @@ elfNN_aarch64_print_private_bfd_data (bfd *abfd, void *ptr)
> containing valid data. */
>
> /* xgettext:c-format */
> - fprintf (file, _("private flags = %lx:"), elf_elfheader (abfd)->e_flags);
> + fprintf (file, _("private flags = 0x%lx:"), elf_elfheader (abfd)->e_flags);
>
> if (flags)
> - fprintf (file, _("<Unrecognised flag bits set>"));
> + fprintf (file, _(" <Unrecognised flag bits set>"));
>
> fputc ('\n', file);
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] elf32-arm.c: Use prefix 0x when printing private flags. elfnn-aarch64.c: Likewise.
2020-12-14 12:46 ` Alexander Fedotov
@ 2020-12-21 9:26 ` Alexander Fedotov
2021-01-04 15:16 ` Nick Clifton
0 siblings, 1 reply; 4+ messages in thread
From: Alexander Fedotov @ 2020-12-21 9:26 UTC (permalink / raw)
To: Andre Vieira (lists), binutils
Hi Andre
Could you please take a look in this patch ?
Best regards,
Alex
On Mon, Dec 14, 2020 at 3:46 PM Alexander Fedotov <alfedotov@gmail.com> wrote:
>
> Hi Nick
>
> Could you please take a look at this tiny fix. I've run make-check for
> Arm and AArch64 w/o errors locally.
>
> Best regards,
> Alex
>
>
> On Thu, Dec 10, 2020 at 3:43 PM Alexander Fedotov <alfedotov@gmail.com> wrote:
> >
> > Currently objudmp for Arm and AArch64 shows flags in decimal format that is misleading.
> >
> > ---
> > bfd/ChangeLog | 6 ++++++
> > bfd/elf32-arm.c | 4 ++--
> > bfd/elfnn-aarch64.c | 4 ++--
> > 3 files changed, 10 insertions(+), 4 deletions(-)
> >
> > diff --git a/bfd/ChangeLog b/bfd/ChangeLog
> > index 99c275ce4f..3717cf4ffe 100644
> > --- a/bfd/ChangeLog
> > +++ b/bfd/ChangeLog
> > @@ -1,3 +1,9 @@
> > +2020-12-08 Alexander Fedotov <alfedotov@gmail.com>
> > +
> > + * elf32-arm.c (elf32_arm_print_private_bfd_data): Use prefix 0x
> > + when printing private flags.
> > + * elfnn-aarch64.c (elfNN_aarch64_print_private_bfd_data): Likewise.
> > +
> > 2020-12-07 Siddhesh Poyarekar <siddhesh@sourceware.org>
> >
> > PR 26945
> > diff --git a/bfd/elf32-arm.c b/bfd/elf32-arm.c
> > index 2f6bd88555..eadfc34249 100644
> > --- a/bfd/elf32-arm.c
> > +++ b/bfd/elf32-arm.c
> > @@ -15062,7 +15062,7 @@ elf32_arm_print_private_bfd_data (bfd *abfd, void * ptr)
> > /* Ignore init flag - it may not be set, despite the flags field
> > containing valid data. */
> >
> > - fprintf (file, _("private flags = %lx:"), elf_elfheader (abfd)->e_flags);
> > + fprintf (file, _("private flags = 0x%lx:"), elf_elfheader (abfd)->e_flags);
> >
> > switch (EF_ARM_EABI_VERSION (flags))
> > {
> > @@ -15183,7 +15183,7 @@ elf32_arm_print_private_bfd_data (bfd *abfd, void * ptr)
> > flags &= ~ (EF_ARM_RELEXEC | EF_ARM_PIC);
> >
> > if (flags)
> > - fprintf (file, _("<Unrecognised flag bits set>"));
> > + fprintf (file, _(" <Unrecognised flag bits set>"));
> >
> > fputc ('\n', file);
> >
> > diff --git a/bfd/elfnn-aarch64.c b/bfd/elfnn-aarch64.c
> > index fcb6171679..96eef4ec43 100644
> > --- a/bfd/elfnn-aarch64.c
> > +++ b/bfd/elfnn-aarch64.c
> > @@ -7331,10 +7331,10 @@ elfNN_aarch64_print_private_bfd_data (bfd *abfd, void *ptr)
> > containing valid data. */
> >
> > /* xgettext:c-format */
> > - fprintf (file, _("private flags = %lx:"), elf_elfheader (abfd)->e_flags);
> > + fprintf (file, _("private flags = 0x%lx:"), elf_elfheader (abfd)->e_flags);
> >
> > if (flags)
> > - fprintf (file, _("<Unrecognised flag bits set>"));
> > + fprintf (file, _(" <Unrecognised flag bits set>"));
> >
> > fputc ('\n', file);
> >
> > --
> > 2.25.1
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] elf32-arm.c: Use prefix 0x when printing private flags. elfnn-aarch64.c: Likewise.
2020-12-21 9:26 ` Alexander Fedotov
@ 2021-01-04 15:16 ` Nick Clifton
0 siblings, 0 replies; 4+ messages in thread
From: Nick Clifton @ 2021-01-04 15:16 UTC (permalink / raw)
To: Alexander Fedotov, Andre Vieira (lists), binutils
Hi Alex,
> Could you please take a look in this patch ?
I had a look and it seems fine to me, so I have gone ahead and checked it in, along with this changelog entry:
Cheers
Nick
bfd/ChangeLog
2021-01-04 Alexander Fedotov <alfedotov@gmail.com>
* elf32-arm.c (elf32_arm_print_private_bfd_data): Prefix hex value
of private flags with 0x.
* elfnn-aarch64.c (elfNN_aarch64_print_private_bfd_data): Likewise.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-04 15:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-10 12:43 [PATCH] elf32-arm.c: Use prefix 0x when printing private flags. elfnn-aarch64.c: Likewise Alexander Fedotov
2020-12-14 12:46 ` Alexander Fedotov
2020-12-21 9:26 ` Alexander Fedotov
2021-01-04 15:16 ` Nick Clifton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).