From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by sourceware.org (Postfix) with ESMTPS id E9E54395200C for ; Thu, 17 Mar 2022 08:20:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E9E54395200C Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2050.outbound.protection.outlook.com [104.47.14.50]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-12-vye-JztqP2O7NcVAg8Wz3g-1; Thu, 17 Mar 2022 09:20:55 +0100 X-MC-Unique: vye-JztqP2O7NcVAg8Wz3g-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ljjp5Ep6M0lDsod7HadtmEdgZM9qWjjWmPmz6UgJSU3WCBMXJx/XgfusVYAcuyTp0/DeeMpe8ZaLQv/xvd0eDZUS9wJX1dWe+bbNESSI4UALp+bxtPwj+ZNRV4p9mwwZGyfWJkwL5Dap/VzjHmGj7+CfyfJaCFMWuS859akZz/8tiTnwLTILqxJBvjxCSpUmWoBozaN6FiDGRSjZp7r1BQVxtVJ0nfhtRYNC7j5qYkJwOyAWKu/OJffekzf9IVicBDMsjefQ6fY1pGvPCaRmDDSpaUzR3I48Li1LK2U7FNlUKB8czm0vN1g7RSoiQxDg0vkRtupTbo70GMybVcpkpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lnaGW/dvkvhtUUEcQMYaoCjUJMV/EnCx2ke+8oQrias=; b=PX/brIgJD5ZhUBd/8UhdTs+MSytLHQYhIYKTEZKE6jhUEFtgYHzHysdj6K2AGN+PtoHq+SdNWfVfN9nB4TzmclzBkahLcTasuk1s+SHcJO9MV6QjCeGZLHJRmuAzIIeZ3yQBIsd5LMjsj3JqRGJfNfYYbyr4AxppJRUt2sKmRkd1+Yd8w15gJJYGH2RlV0AlnCyVfGlmeTHVyo3AxfksV30qAu56So1Z/+xlVfAo7yFzFfx3kFU855EAcJK5HrlErvhHBBnwf0OGKmvzfMwA0TZWZukhdq3DHPx9DMsq4O8CklK+jwoudAipiWmtEhR7Bz58VznNJoFfBs+9fKGyrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AS8PR04MB8328.eurprd04.prod.outlook.com (2603:10a6:20b:3fc::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.17; Thu, 17 Mar 2022 08:20:52 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::2d79:4387:3887:ef9d]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::2d79:4387:3887:ef9d%9]) with mapi id 15.20.5081.017; Thu, 17 Mar 2022 08:20:52 +0000 Message-ID: <76486c50-3476-f357-a5a4-d5b08c9b7889@suse.com> Date: Thu, 17 Mar 2022 09:20:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] gas: retain whitespace between strings Content-Language: en-US To: Nick Clifton References: <941f3fdc-bc52-afc9-9f70-69d25a236bc1@redhat.com> Cc: Binutils From: Jan Beulich In-Reply-To: <941f3fdc-bc52-afc9-9f70-69d25a236bc1@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR05CA0034.eurprd05.prod.outlook.com (2603:10a6:20b:2e::47) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9ff6c9b4-7d7d-47f2-e8e6-08da07ef0cf8 X-MS-TrafficTypeDiagnostic: AS8PR04MB8328:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Vt17p30HVUTMVNCg4vyW6Vt/NLgLqgVROU6zisW3AXtkk+6ekP6hfgW0Gy/bLZ0MUOcOS6pO9V38GoxyBRNTDORQAhLi+4sxFRAKw1IRqQgsw+ihJd/5D0JadSCbCUGGUTUPRrt4rCZQRiiyBTTBZGL5A/j5/NOvz0bL/+RzWRyUSu6rz2P19YQomjDQTHd7Lzv3oYMmCm+krSy4gNBBeI0bgZbgS/F+SEqQ1Mf/7/GCPLzUL9JY8NNe3jp33Wefk2KFDwJ1XYHMARRyK6gXMzUYgUnP6Ldhl2yvdlnRv2m0Y9K+vh9Q3R2dkEOJNv+N7i+qbhFHXj5ALoNj/Om0lE7WBytl3oFc57MxecSIOG1iDs2dP4coXhsEur/GJjSMNgSgjTf6FZ0wahOJSV85EKSl+2ovJug82aTWDmMQPADN0S4/7BYw+cudh2bgI9AgJH4pxc1JM7so97cehWMZfYcHKs/i4m5YlDrvXBejBQUDAhjyKwaFOl8ULM8IwblplJmDvrlbxNZ2PPj7agKhbpRxPTFDJM25OAXJlTGQzY5hS3XomUkQHvxphcMnbmUXdYQJzvxFYNIMFiXp9nfx+8PX9S8seT6Te5NNnxyXYomPFvnpIAR6suz8UuMLmuKQ2RMbl+15Z54SKsQ6TwTt1K7LPDfsRBUSmXN2+C3nlkTLfJG+5leeukNcSt/pRF772yzC+SwCBWoj5KdgFk2Fh9m8pEh3PnYry24QR6kneVU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8616.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(8676002)(2616005)(26005)(186003)(6916009)(66556008)(66476007)(38100700002)(66946007)(508600001)(83380400001)(6486002)(86362001)(4326008)(316002)(2906002)(6506007)(53546011)(6512007)(31696002)(31686004)(36756003)(8936002)(5660300002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S3lORFVaNzBEb3BFS2IvcWtDVjQxNGFVTjhOWnl1R0cwM205RFRIRFUyTnpT?= =?utf-8?B?V1d6RHFpQ0M4MitrdzBQRmk2OG5CdXpzT1pBNjRNelV4Ukxub3pZbEtXRHEx?= =?utf-8?B?SFE3RGlMQWx0ODJ6dG5BQW1Zb0pNbUdZZ3pxVGpXUStVQVhwOWYvVGgwcity?= =?utf-8?B?c0tRUnpaN3VYV1VOaFJVYkJJSW82OGZwbmxyeFp0d3dZaXFwRlo3aGRGNkFC?= =?utf-8?B?dGN1QWZGRit1VUIvbEVKZEw3ZGJnckk4SGVSamNiRXhxVTh4UEVQeDFLaExt?= =?utf-8?B?Vm41TWVsUFZwZFE2UGdvSVA3Ui9FWVZjdjNGOVFhQjJqNXJNWitDVUhtZ2tE?= =?utf-8?B?QmlzRks2MnNrQWJXMmJjL05JMDNRZ2kzbXMrSjBwclh2QVd1ZVRPdFUwS21z?= =?utf-8?B?T1c0YlRXZnVDUEdKVWNZYkFPVlR5c3Z3N3Y5U1I4T0tYY1FzNmtCRkpwNWJ0?= =?utf-8?B?NWNXM2xxYVJaNGo1K0lGNWZXVW5sZjQ4Y3RmL1BVdlBwMzRsY2N1N2FzVllp?= =?utf-8?B?M2JYaExJK0EwNDB4Nko4QW04SktDeHlKMFhVQk1FTVJXc2JKM0tBL2FuVzBY?= =?utf-8?B?TkVEQklqY1pNcXRNc0lyNXhFSnFGRm0zc3RKbmJtNzR4RkduNDUzMjhvcU1j?= =?utf-8?B?M3ZxNGFKemcxV0pkZVVSMFhnOWdGOTBIMjR5a3duc3ZFRFNCbnFKTnFDdUJz?= =?utf-8?B?ZDIwNUk4Q2gvck9MdHBTYlVhZVNucTUxWnZ1RXdFbnNoYldQSUxkL0ZrUUda?= =?utf-8?B?L1QrcEVVRERJZE1TNUgyOGNMYndreEVxUW51U3Q4Nm8wVFdTZk43SkM5b2Iw?= =?utf-8?B?K1Y3Z1VHYytzS2kycHhJdzVHaWZXMXFFazErbEh2dnNrRTNHTk9hMWlQT0xr?= =?utf-8?B?WTlKbENXZzZLZnlqMzAvVUlTM0ROOTk2Z3R4aGliczNsVTZOQU1tVTJFQVdE?= =?utf-8?B?MWp2NjNWVTIwNVJPOWQwZ081RlJJSStCZ1l1UVJNNE8yVHZuVDVEYUNGcVgy?= =?utf-8?B?bEovTGd3YVlFTG1hbE9EUHEzbDgzUDQya1o4SGE4cnJaRVc5M1pXUHhjbGIy?= =?utf-8?B?dzlwMEpBS1pQMWNVTUNiMkVXMGZlZ3dYUHovZzl0Zi9GR2R0QWVVUk43SDQ2?= =?utf-8?B?ZUVOZ201QUZLNXd4aElKZFVqZ0prblBVTDN0dllFd1lvNFhkbmRhOUhqWWVq?= =?utf-8?B?TWUxYUNmSnQxRS9pOWhsMVlhQURpUTRuUXE3WG9ZKzRKM1Roa0JwNXFtOVpx?= =?utf-8?B?OUU5bWI2TWtWNzZBZXBkZFYxMFFXbi9lbVE2UkpZbXdwOWMrL00va2VQQXRI?= =?utf-8?B?dm9ZMDNwY25LZFdMVDZ2c0ZRTGFVeXZuL0QzUHhOK25PbGJkcSt6bFVtV0ZF?= =?utf-8?B?RnZCWWVkeGpKQTQ1cnNXOVFEZGJqWU5PZEZzcEhwb0o0aWJiWlliek8rb3I0?= =?utf-8?B?d0pmQkxSVVQ1UllSOXhRSmtmYlZmeUFZWFdFL2VhYVFQdkxPNGdKejYyaVc4?= =?utf-8?B?RmNXaHpMRzI2WTExeXhVOVZMVEdyMFVacngvUGR2UkdwUG5yeCtEZStoQlZ0?= =?utf-8?B?Z0l2YlpPVng4NjZDSFUrUUwxbmIxSXpWS3JtaFhQbTV0RUNqdXJrRG9PZ3cy?= =?utf-8?B?ZkI4R2I1R3ZDOUxBNW5qNU56U0FXSVdVd0dxYmJER3VUcnRFeE5iQTZRWmlR?= =?utf-8?B?ampLRTZoMFhiN1RFN0FRQTNGVTM0ckwxVmRhKzI2MW1NNDlacEpUM3hFVHRT?= =?utf-8?B?d0RGWVhQS2JKaEFVL1JmY0UyZnR0RmZxSGY1YmtwdzRJODkrRGtIVUJNdGF4?= =?utf-8?B?enIxWUtHREh6ZUl3YVNlQjFkU0xXNDcrMi8zZEZXeGFrMHFkYXVVY1hiSzdH?= =?utf-8?B?WWNZd3Z6cXVKaHRzN1JsV0RoUUloMCtuSmMzZWc1MlVZaU5Ta0RsQkR2Q0Yy?= =?utf-8?Q?vDIYssFZUhiPM9qSUduae9JF8lVdQpQA?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ff6c9b4-7d7d-47f2-e8e6-08da07ef0cf8 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2022 08:20:52.4438 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5urOxmdA0vS3uArzdVJIcujqZv444KhgX2dfrTXqMYl7kireALcpreKMzVU1M4WpBC0AMnrB2ZcAViTA2XmmlQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8328 X-Spam-Status: No, score=-3031.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Mar 2022 08:20:59 -0000 Nick, On 16.03.2022 17:55, Nick Clifton wrote: >> Change the scrubber to retain such whitespace, by making the processing >> of strings more similar to that of symbols. And indeed this appears to >> make sense when taking into account that for quite a while gas has been >> supporting quoted symbol names. > > OK, that makes sense. > >> Taking a more general view, however, the change doesn't go quite far >> enough. There are further cases where significant whitespace is removed >> by the scrubber. The new testcase enumerates a few in its ".if 0" >> section. I'm afraid the only way that I see to deal with this would be >> to significantly simplify the scrubber, such that it wouldn't do much >> more than collapse sequences of unquoted whitespace into a single blank. >> To be honest problems in this area aren't really surprising when seeing >> that there's hardly any checking of .macro use throughout the testsuite >> (and in particular in the [relatively] generic tests under all/). > > Plus assembler macro syntax has never been that well specified. > > >> Partly RFC: While I did test this for x86, I didn't get around yet to >> run a much wider set of tests. > > I ran my regression tester with the patch applied and nothing turned up, > so I am happy to approve the patch. Thanks. I did meanwhile get around to do a full run as well, but for now I can only say "likely nothing turned up" because I did this with "ELF32: don't silently truncate relocation addends" also in place. The regressions found are likely all from this 2nd patch (matching what Alan did point out already). But I didn't get around yet to inspect the test failures individually. > One thing though - I think that it > would be a good idea to extend the documentation to cover this behaviour. > I do not mind if you do that as a separate patch, or just an extension > to this one, but I think that it should be done. Hmm, I would probably want to fold a related doc change into the patch right away, but I'm having trouble seeing where this behavior would sensibly be described. It's an implementation detail, after all, which simply ended up broken internally. The behavior can't be described for any directive in particular (or for insns in general), and whether adjacent strings (irrespective of the intervening whitespace) are concatenated is directive-dependent. Or did you mean me to merely describe the specific behavior for .macro, leaving aside potential effects elsewhere? Jan