From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by sourceware.org (Postfix) with ESMTPS id 8E3533858D28 for ; Tue, 11 Oct 2022 19:06:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8E3533858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=martin.st Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=martin.st Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 29BJ6CpF005772-29BJ6CpG005772; Tue, 11 Oct 2022 22:06:12 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id C316AA1437; Tue, 11 Oct 2022 22:06:12 +0300 (EEST) Date: Tue, 11 Oct 2022 22:06:11 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: Mark Harmstone cc: binutils@sourceware.org Subject: Re: [PATCH v4 1/2] ld: Add --pdb option In-Reply-To: <20221011175332.17156-1-mark@harmstone.com> Message-ID: <766dd6bf-15a-2399-ebf0-4c8ab92b4bf@martin.st> References: <20221011175332.17156-1-mark@harmstone.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-FE-Policy-ID: 3:14:2:SYSTEM X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 11 Oct 2022, Mark Harmstone wrote: > Resubmission incorporating Martin's amendment > (https://sourceware.org/pipermail/binutils/2022-October/123481.html) > > --- > bfd/libpei.h | 6 +++-- > bfd/peXXigen.c | 30 ++++++++++++++++----- > bfd/peicode.h | 2 +- > ld/emultempl/pe.em | 50 +++++++++++++++++++++++++++++++---- > ld/emultempl/pep.em | 48 +++++++++++++++++++++++++++++++--- > ld/testsuite/ld-pe/pdb.exp | 53 ++++++++++++++++++++++++++++++++++++++ > ld/testsuite/ld-pe/pdb1.s | 5 ++++ > 7 files changed, 175 insertions(+), 19 deletions(-) > create mode 100644 ld/testsuite/ld-pe/pdb.exp > create mode 100644 ld/testsuite/ld-pe/pdb1.s Thanks! This version LGTM wrt the public option interface. // Martin