From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 32A313858D39 for ; Tue, 11 Jan 2022 14:19:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 32A313858D39 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-503-5BxPoOhbO1mN4vRxQ1zReQ-1; Tue, 11 Jan 2022 09:19:17 -0500 X-MC-Unique: 5BxPoOhbO1mN4vRxQ1zReQ-1 Received: by mail-wm1-f71.google.com with SMTP id l20-20020a05600c1d1400b003458e02cea0so1610062wms.7 for ; Tue, 11 Jan 2022 06:19:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=PPzgFNgLXep5+gCNeiQcbqqSStkeojjvVqA8NEOlgQo=; b=hCBVjpBzUChLcAd20yZ2Q88WxTvg91kScNPUE3ytLMbHqtf8rIumROQznb3cAELl7W 3qgXDtdFdmduU4pQ88dWUAoYiOInLfztZLSYNfsjDWDEKRagDEL6vHDW3n0OuiV/XaWH xpQ8+z2p4B8zGKwiCKGFqMMt0YiJx8koYiICgzqnf0Klc64kMeCXSM16Ef6qsSZ2Qk0x Dv3ofsB1JDWllArrZfrQ9ErbgYcfLPJDWem7W6d98EoOqFYGuiyye35Qqe+0j7G/l76P ARYsSW+vYDfbvoiyvRuy6bDBy99ridFKiVsrUF5b8ObB3khbnTePvJL5++iuFFP9Cg/t jnCQ== X-Gm-Message-State: AOAM533pps3Dqyrlmr8rrUBZ20WmhZrFBvxUZUhkM9gQ8qZUi1rmDDXv urGW/q0r9LNjtkmKiuk83qUIO3Wp0QVYLdTzoASmwj+Lw/xX1mxOP/EliubzjnzvakTJAe1NqRG sbWQUsKwKjhABRd3D1A== X-Received: by 2002:adf:fd42:: with SMTP id h2mr4214456wrs.256.1641910756087; Tue, 11 Jan 2022 06:19:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJyWId0GgolUy34n8nGc2YNxfup7jhYpWm7/durhU3UOoDM1Cy5j0NguCeRuFOAT/3mM8TWRtQ== X-Received: by 2002:adf:fd42:: with SMTP id h2mr4214446wrs.256.1641910755900; Tue, 11 Jan 2022 06:19:15 -0800 (PST) Received: from [192.168.1.6] (adsl-164-239.freeuk.com. [80.168.164.239]) by smtp.gmail.com with ESMTPSA id c7sm10660048wri.21.2022.01.11.06.19.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jan 2022 06:19:15 -0800 (PST) Message-ID: <770d2116-63af-357b-9f7b-169ad3d9c21c@redhat.com> Date: Tue, 11 Jan 2022 14:19:15 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH 4/4] ld: add hidden and internal visibility support for XCOFF To: "CHIGOT, CLEMENT" , "binutils@sourceware.org" References: From: Nick Clifton In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jan 2022 14:19:20 -0000 Hi Clement, > This patch adds a primary support for hidden and internal visibility in > GNU linker for XCOFF format. > The protected visibility isn't yet supported. > > PR 22085 > > bfd/ChangeLog: > > * xcofflink.c (xcoff_dynamic_definition_p): Add hidden > and internal visibility support. > (xcoff_link_add_symbols): Likewise. > (xcoff_auto_export_p): Likewise. > (bfd_xcoff_export_symbol): Likewise. > (xcoff_link_input_bfd): Likewise. > > ld/ChangeLog: > > * testsuite/ld-vsb/main.c: Adapt for XCOFF. > * testsuite/ld-vsb/sh1.c: Likewse. > * testsuite/ld-vsb/vsb.exp: Likewise. > * testsuite/ld-vsb/visibility-1-xcoff-32.d: New test. > * testsuite/ld-vsb/visibility-1-xcoff-64.d: New test. > * testsuite/ld-vsb/visibility-2-xcoff-32.d: New test. > * testsuite/ld-vsb/visibility-2-xcoff-64.d: New test. > * testsuite/ld-vsb/xcoffvsb.dat: New test. Approved - please apply. Cheers Nick