From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2045.outbound.protection.outlook.com [40.107.6.45]) by sourceware.org (Postfix) with ESMTPS id 9A8B73858D33 for ; Wed, 18 Oct 2023 06:05:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9A8B73858D33 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9A8B73858D33 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.6.45 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697609152; cv=pass; b=mvbjCiBwUgOW/X+05hmltyX345ip2uCqA9hSMvXOplOL9xCnG4qSAEU3KBr66zY4YuT0flUyghJO8BDRgEDuPqS0UHl5+pDkXxh9DMrv/xw/wvwwhEAe7ZbAsDIe2pzSc5zGdbNqWI4D7revmplSmlKdG6Z1HwIo4mSHK3QLxDw= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697609152; c=relaxed/simple; bh=7K46l8H9oU8H64TdsPWW4E0D4FNEwF0k4DJVPRfWK/M=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=FdweSq+Ly4Z+itEdzknX4CwlW3dprb7Zi9yCSbuq91zq6bHIOznsOpUhvYkujO5zhRuRLnoN2WiSQWeJsrMNj9MMTy3YLXJ2Z3ADzUxisTY2l5j0g/GD8qd/zSDcjhShqEoqbSTTrhgSgB+X6Vr9Efmt6qJ52YSugQkEdXQnlWk= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g1qvxc2NJQw4Q6aWoP1lOy5Ek1vFw5w5rf6E0J4G/pzE1Oi5qrOc6RjUVIYfpkwc8j/gm+Erip2fCdxAhoekALzm/0u1bvtq5dJeHpOGPHZaktQ4/RhQGSEXKTk6TJaD/b7IzQvCESbnRPlPW4xviSB8e95svn9fDlYIcSBlYPFQn8sgCSNpXB3OdPQJBYyiZ8N/GIK7LoUOOxoLV8Y8MD2hw1NlQ5vufkvpuDzvFIIfJc6FO70zuehJgr4D4dPiuOZWjen3VXx5Y0gSYHN0gMld3lYPB6MCk0g33niMYVwhtTid2LdaL88lHVvySNeQwwI/TC0/e/xPfknXFc37cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ByOPiT/g/0U+l//TSDIgtPSuWexW9cZH9DcUubHmp0E=; b=RCaQsziSMOrUexeFKxxL2x9jfmOXnUJuuC5NzWjoVxmoMlmuR8pFCOWF0wwOIVujan4zXJfB59E8pDtnEKD9C3I5HENhJF98OWoK2cGcYKWuFWTnHlWo6Bk5S8dc1SbL8g1hdyCUqq2A4YpO9zOru/7FGy9WW7cR+/N1tII80qsBnVT45zU90tITVpViXFOdpvQyRmQcigFRTKu+SJeoIVXcrLaVWl26GtLLN39dcSmNkiKxooDvrG+Zs1DJ7Y2j9kd0t0oC0Tf7ObRqCJZcMfabDCZo863EaJzY3lcwn0ze4ZsjXGVCq6fNUaZ38d/0OBzYQo89+9mJU0dBhXCAdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ByOPiT/g/0U+l//TSDIgtPSuWexW9cZH9DcUubHmp0E=; b=38ImAhREjK3NwiAwbe98OVDVLI6oCAlj3Kvtu+XKQhWE1vHcAWGOzgI2YRTu1PHiOjTnw1Utzoqyby88EAM8P8k+agyx3HFsxUU2a/WwM7oJx9KVUhvip2iXPS3Utpw0PXrahhyJ4c4c/o8DSFLpJ2v6EA7/+cDcS6h+nSwnSBUI4nsP436HptzzNRZsA0rUYIwGf5+qC2Uw13YIfkhjxAJ/eQhvvfg63f5eywIijuPVO3Nbu/whc/Fx1kWmMoJTtzdDe8Zgi2orotklI9g9zoX3Kt3inwFaqNEuQ1FI4l2GF5lHILbYKF8iZrUro9jJcgOjUrHwLu6pVMWpwHPIXg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS8PR04MB8930.eurprd04.prod.outlook.com (2603:10a6:20b:42d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.36; Wed, 18 Oct 2023 06:05:48 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::d9c0:d907:4d2d:15b3]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::d9c0:d907:4d2d:15b3%7]) with mapi id 15.20.6907.022; Wed, 18 Oct 2023 06:05:48 +0000 Message-ID: <772023ba-7bd2-331c-57b0-0aa45b0cc60e@suse.com> Date: Wed, 18 Oct 2023 08:05:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: FW: [PATCH 3/8] Add tests for APX GPR32 with extend evex prefix Content-Language: en-US To: "Cui, Lili" Cc: "Lu, Hongjiu" , "binutils@sourceware.org" References: <20230919152527.497773-1-lili.cui@intel.com> <20230919152527.497773-4-lili.cui@intel.com> <152263a9-5e04-ccec-a5f9-b3cef851a85a@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0118.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::13) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS8PR04MB8930:EE_ X-MS-Office365-Filtering-Correlation-Id: 2d31ae99-5fb7-4312-ad5f-08dbcfa045f5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AFuhj7PEbsCIn0Z48UNyS+d7BFDvuxew3gr5IkgBcGjV5cvULX8Z4PZbL3sC2cp1XzKn57/9KmcKgleV2RtFi9So70QvCKQkSk8KiMYbcSTZhZgFPqZuxrc+n3pkdG/9lAf0i+htOfOBVqgXt0gjYdeCK5qEPzu/cqWhqnbPCTfESX0bJJDOugX98mKDwvehpcUE4JR3sGT6DxmD39hvO+pgbweYauILZQD+D8AwDENKjpjmzB+63UUFGC6zbTFQ2GAfkbRf43QHKmXCLgkkHYEQqh+gjnB9qcwWDQ3P4DqfGsHFfAmxlHhlqzKqqEsZ7zsSxTiCfBeIVEl080p+HoSqGH34CXfMH0c3JBR+wmm6oti2nGplzDLmf0Kf3XpRVQwSx113eZbbNhMWmL9kJOwMTyXNzzoz9QUdjAUvuuSXymJg9KmqBUig0gM0UA6pscmPhhVd/ZIMtcyfiSgMdKn941h6cHrTb5Ikgxpov+KO8RbfVYRSbjyhISYfMG+oZao3/f7UpAN7Kt5vhyVWfBJLNInYmFfjWaNx3jixtLQv9KDoSTw899JYodIDZzdPo6bGY8zwHjmBmc8OwuK0xNMlCGeftsGl8qsilZN5UBwvuHZHS+ZiMJmK4lREuw9tsnG5a473898Zt2Ycp8CuAQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(366004)(396003)(376002)(346002)(136003)(230922051799003)(1800799009)(64100799003)(186009)(451199024)(6916009)(54906003)(66946007)(66476007)(31696002)(2906002)(86362001)(66556008)(5660300002)(8676002)(41300700001)(4326008)(316002)(8936002)(36756003)(2616005)(38100700002)(478600001)(6506007)(53546011)(31686004)(6512007)(6486002)(26005)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aHNOOE13eFVEQmoyU1lIWHZkbU1SZkFGWGMyMzJqaVNsUEdzQW5GbG9VYkd6?= =?utf-8?B?Y3luTzh2dGc3b0dIRU5OZlpKbnJyRnRGM0RHZSt5SEUwRGFTa3FleGNsVExj?= =?utf-8?B?cnlaM3oyaU41emRCSXN5bERCeXNMZXY1RWpLbXBaZ3Z3WnJNVm51WTNmOWtW?= =?utf-8?B?THIzeFpnTXQ5d216WnpiVHlFa2ZtNlphWUVFTDM2VmFkUGtWZXY4Yk9Odjha?= =?utf-8?B?ckx0WlpxSWVsanJRMGZPbWJZOWJ2UzlLNkFWN2R0VXFUZWpWVEZoMWV4TTBp?= =?utf-8?B?UU9KbENvY1lnWSt6c1hmMnNXTE4xVXRobTJlWlE2SEs5T0ZpbVRTVTRwdUIw?= =?utf-8?B?Qm1TNWtXZ2ROWjBGUXdiUUhpTVpQWlRzM3BQWWFpbU91aEU0RW5VdE9ZVDEr?= =?utf-8?B?NFMwdUhkbXhDMFFHYW5VcjlmTGxFeHJ4NzcxeThoN2I0dndnNUdGYk1NNGtp?= =?utf-8?B?NGNGajNoUkptT3p4UXkyR09ONnNxWEZLclBFKzhGcXV3RTNLOEszYlpsWFYx?= =?utf-8?B?VjhTaXU5MXhXQWZQVTViS25VVUtkUWg3dko2MVFkVC83Mnp4UWh1RUVIbHpu?= =?utf-8?B?Vld6RWNJUVdQMUVEZjQyTjdPWmFBcnlITmg2OE11ZXpranJRVXFXclBwMU02?= =?utf-8?B?NWptaW5XZk1qemlyOUtzVUtJdEE4Sng4NWU3Y1ZKMFZvOW5POVozbzVwQlc0?= =?utf-8?B?ZVFhdEkzTmRQa2d4Qzl6MFRmVnJHMHBsVGphNkR5bDdETnhBVzBpVlBWWHg4?= =?utf-8?B?Y0xyZHBtQVdEdFI3S0xvaldVc1ltaXJyN291bFhjSXZkcGRNVHRnSGRqVFFW?= =?utf-8?B?MS9Cay9tU2FEVDlPZ21MYVVla3hYS0w4RE0xd0VwK2l4OGhabE5GUXlaeWJK?= =?utf-8?B?Wk9ZWEN6ZWx3R05LMy9ESkZYdmJIZWF2VG5lYVdTdDZBd2Z4ZnE1ZHJ4YVFq?= =?utf-8?B?Y2JLaUR2RjJybVo3RTlxb3QwamN4ZmFjcWkyM052cjVEaFZweGdPeXJsRXVw?= =?utf-8?B?TzdaWlR0dkxlU2xsSlpGVEtBRU94QkJ5cGtjM0E2NUt4MXZBVUFzaGJEMWN3?= =?utf-8?B?a3hydU5QaU1XeW9ZYUhXZVhhK1J3NXp2MEozeFNwQ2FRVGZiQ3pKRzVSN092?= =?utf-8?B?V3ZvL0VFcitBU1Y1ZWpmWHM3WjNucmNnelV3WGwyeVFMa1o3bmRuMlVGT3U4?= =?utf-8?B?c2tIOUd6c3FUL1c3VXgydjlLL0tkc1MxRFE4WnNGdURDZUVMWjB2NFBuVlZZ?= =?utf-8?B?ZkJvVU5nSWZZZDdkd0ZZYXdxU2hqTERDNGVHVkpZYysvSTJ3UDhOY1dGdjEv?= =?utf-8?B?L0t6T1gyOEJZV1pLVXhrMzMzaE5wSUVVak0wVDhYelFnc2xJeDRCMlhCcEkz?= =?utf-8?B?ODhyR3Q1UW1jYnRnWjFDR3RZV1RZSW5PMmdSQUZaSkppaFF1U0FsbjBPeUVu?= =?utf-8?B?TGNIU1dwZ2syV0U4aXFRMWdndGtYSml6SjNMNktYSDkvT1ZTY20yZUZ5dndi?= =?utf-8?B?YzBSNWNnSW1DWlJXTW9xUCtxakRpS2N6V21lZ0pmVlBDYWhVV05ta3RmRjk5?= =?utf-8?B?TDdlU0Q5VUk1cENyTVg2bXJ5MnhJUGI0T1NLeEN1eHZwaHNzMS91K1kxUTFM?= =?utf-8?B?T3I1MGh1TjNXd3Nmcmtqcmp1QUk5enkxY1JXVFhXblYrQldoc3I2MzRzQ1Ba?= =?utf-8?B?T2RuZmpzRU9BQUlPbEU0d3U2NytKeVQxdVBkdFZ5MnZLVXNsRkhVeVRtaWxZ?= =?utf-8?B?c2kwbnRndnhtUjEycFNFT0Y5ckFzVnAycXBqd2I4dzkrZVJsckFxd1lkdkpB?= =?utf-8?B?enExZ0ZYRTdGTjI0Yk1nc0V1WmEvSk1BMy96a1duRFVyWitVdnA4NHQxT1Rh?= =?utf-8?B?VlVLRkNHWTQrUWtUSUVPV09QQ3J1V21lWG0wbWZsaWtFa1hLV1VBcVQ2VFY2?= =?utf-8?B?cDE5Z01UcFFFdmN5czBzWHhJUC82SFc5dWdIZ0ltUkdIaDlQRmszam0zN2d4?= =?utf-8?B?aGxVMWQ1UXZYY3RSaWlrc0R0MXJ1RmhxZHhkVllMOEZsalRNTlR5akxTZU9D?= =?utf-8?B?UmUydTRPL05iMVpITGtvaEFDcEFFSGFjNGRmVDRyRjZBako1bXQwc25aKy9C?= =?utf-8?Q?Du3JRVcgAwJ4xaFb3TiHeUddZ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2d31ae99-5fb7-4312-ad5f-08dbcfa045f5 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2023 06:05:47.9921 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1OJlLTz3RuIqf0o1jMWdH4FYJY9058B027+gADwKrokBmuKz+RInJVIRg/9YjVb17TK3IqSY9fjEUbbghNSRrg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8930 X-Spam-Status: No, score=-3028.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 18.10.2023 04:32, Cui, Lili wrote: >>>>> --- a/gas/testsuite/gas/i386/x86-64-inval-movbe.s >>>>> +++ b/gas/testsuite/gas/i386/x86-64-inval-movbe.s >>>>> @@ -1,5 +1,6 @@ >>>>> # Check illegal movbe in 64bit mode. >>>>> .text >>>>> + .arch .noapx_f >>>>> foo: >>>>> movbe (%rcx),%bl >>>>> movbe %ecx,%ebx >>>> >>>> I don't understand the need for this addition (and hence for the need >>>> to change the test's expecations). Like was mentioned on the original >>>> AVX10 series, tests like this shall not need modification, or else it >>>> indicates people's code also may need ".arch .noapx_f" additions, >>>> which I'm sure you agree may not be required. Finally, if testcase >>>> expecations like the above would be needed anywhere, please >>>> generalize them such that a similar mere addition of a line doesn't >>>> require the entire test to be touched. Here this means that while for >>>> the diagnostics you of course want exact line number matches, for the >>>> actual listing line numbers don't don't need matching individually. >>>> >>> >>> Agree with you, but movbe is special, movbe didn't support reg to reg >> before, but APX enable it. so I added .arch .noapx_f for this invalid test. >> >> To be honest I didn't really notice this difference so far. That's somewhat ugly, >> because people mistakenly using a reg->reg form would suddenly get an EVEX >> encoding rather than an error. This will need some further thought; please >> mention the "anomaly" explicitly in the description of the respective patch. >> > SPEC: > Note: The promoted versions of MOVBE will be extended to include the “MOVBE reg1, > reg2” form (namely, the ModRM.Mod = 3 case) for both opcodes 0xF0 and 0xF1. This > extension makes the promotion of BSWAP for NDD support unnecessary. > > I'll add a description of movbe to the patch 2/8 changelog. Thanks. I did deduce the connection to BSWAP on the way home yesterday. Which made me come up with a (spec) question: Wouldn't it make sense to name these reg->reg forms BSWAP, not MOVBE? It doesn't really matter that they use the same encoding as the MOVBE (then mem-only) forms. That would then eliminate the concern I raised. As to 2/8: I received two v2 thereof, with different titles, and a v2 of 3/8. But nothing else. The list archives match this. I may take a brief look, but really I'll await a full v2 submission for a proper new review round. Jan