From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id AC64D3858C50; Tue, 12 Jul 2022 13:00:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AC64D3858C50 Received: from localhost.localdomain (xry111.site [IPv6:2001:470:683e::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 1D57A66774; Tue, 12 Jul 2022 09:00:53 -0400 (EDT) Message-ID: <77282eda63ea435d21eb38485651fc5551b4c7e6.camel@xry111.site> Subject: Re: glibc 2.36 - Slushy freeze (3 weeks to release) From: Xi Ruoyao To: caiyinyu , Adhemerval Zanella Netto , WANG Xuerui , Fangrui Song , Alan Modra Cc: Carlos O'Donell , libc-alpha , binutils@sourceware.org, liuzhensong Date: Tue, 12 Jul 2022 21:00:52 +0800 In-Reply-To: <12b025a3-7d10-a9c6-d9e1-54bd3fdca5fe@loongson.cn> References: <7aba5486-ac02-2088-221e-513a6892817a@linaro.org> <612c015a-8d77-d0ee-773a-c51e9cb1d239@linaro.org> <74d08933-d426-c25d-8496-5bd1c76c396b@linaro.org> <12b025a3-7d10-a9c6-d9e1-54bd3fdca5fe@loongson.cn> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.3 MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FROM_SUSPICIOUS_NTLD, LIKELY_SPAM_FROM, PDS_OTHER_BAD_TLD, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jul 2022 13:01:03 -0000 On Tue, 2022-07-12 at 20:48 +0800, caiyinyu wrote: > I can add R_LARCH_NONE handling in boostraping, but there is another=20 > problem: >=20 > binutils 2.38 generates R_LARCH_IRELATIVEs in .rela.plt and now glibc=20 > loongarch ld.so has no R_LARCH_IRELATIVEs handling in elf_machine_lazy_re= l, this will=20 > cause ifunc tests to fail. >=20 > I did not find the way to disable ifunc tests by adding configure=20 > options (if glibc community can accept loongarch port being tested withou= t ifunc tests), > so we have to wait until related patches are merged into binutils communi= ty. "libc_cv_ld_gnu_indirect_function=3Dno" (just append it into configure command line, not "--libc_cv_...", nor "--disable-...") will do the job. I'm not sure how much effort is needed to fix R_LARCH_IRELATIVE issue.=20 If it's trivial I still suggests to get it reviewed and accepted by binutils ASAP. But if it's very tricky (like R_LARCH_NONE) we can disable ifunc support for now by setting libc_cv_ld_gnu_indirect_function=3Dno in machine-specific configure.ac (use commit 600c13b "hurd: disable ifunc for now" as a reference). > Or maybe we can add the following patch back now, and remove it when=20 > binutils fix R_LARCH_IRELATIVE's problems. I don't think it's an option: if a shared object is loaded fine with Glibc-2.36 but rejected by 2.37, we call it a "regression" or "bug". --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University