From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 82F413858C78 for ; Fri, 17 Feb 2023 10:55:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 82F413858C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676631354; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=49cAXGvDIXmHlSVJ1q8fTYvl6QDpck39y/62xVzZNeY=; b=eC/C/Yx8jYLn5EuqKPzSzBmLbclz+gdt8M+2bwjODGL5E5K2L5//rs0BI36ThO/5YtyCg6 cDVbrQtaNOSCSfBZWJJU74mO5g1SzgTyIlzj/QF4Qftm17ki1/B/oitRAeQZHcJKBDC6it sIUp3+Zoy1s/85DR+9eIv0s7uY1J4T0= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-134-pNakfPafMMO6HmUJH4AdPA-1; Fri, 17 Feb 2023 05:55:53 -0500 X-MC-Unique: pNakfPafMMO6HmUJH4AdPA-1 Received: by mail-qv1-f70.google.com with SMTP id cs5-20020ad44c45000000b004ffce246a2bso260457qvb.3 for ; Fri, 17 Feb 2023 02:55:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:from:references:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=49cAXGvDIXmHlSVJ1q8fTYvl6QDpck39y/62xVzZNeY=; b=wPPlYLAQz9eWADR9pa4i3PB4Q5NM1qrxI7NOytZ2pjFEsOEPuVED3JNeNtakUVFzH8 FaswNcQKZsfzZAV0KCkh8v70jO49H9VTXzxgCi0JLwAIV3yaFU1thnFS/qxzRgxv3CdF 7erF8ig5sfDmR2CtKaeYNz8kFhu9AcVm43/Ou0TM+r8ID7JJ5KOP4OQqb8OTm+SoHgvp JppjPmq4wZ/3pFo1NDB2vJD6oQ3O9S+v2WrOceDebcxp9OpvzSPv8wPDRRQ9VXJojP7G Vb75+ALxDmy0KD1W39YMSlHq9+IrTaaEV64fQTc5kr/n52TuDCOBZX8SWjSAq1gasLje jHXg== X-Gm-Message-State: AO0yUKW0M9mRl/DGuWOoXdarUznRnDOl917KOlLbtwiGuotopVCqq99T BSYJQrcmlOxfM+BsR1wsuR5ZZUlYl3E6SotddDojP7H7+8OoNdDm05m4Berx8pUFL/ANPc6l8EU /Mj7457ZHakjH7vZZpw== X-Received: by 2002:a05:622a:10:b0:3bd:16a4:6adf with SMTP id x16-20020a05622a001000b003bd16a46adfmr5348546qtw.19.1676631352798; Fri, 17 Feb 2023 02:55:52 -0800 (PST) X-Google-Smtp-Source: AK7set8ap1vODS1Xro4xyXerQ7FKvKwj3x4TnPp0pgIJCRhI9KDpQlrZFZ2QYLsSYGSis5mR3/weVw== X-Received: by 2002:a05:622a:10:b0:3bd:16a4:6adf with SMTP id x16-20020a05622a001000b003bd16a46adfmr5348539qtw.19.1676631352555; Fri, 17 Feb 2023 02:55:52 -0800 (PST) Received: from [192.168.1.18] ([79.123.86.193]) by smtp.gmail.com with ESMTPSA id i17-20020ac80051000000b003a6a19ee4f0sm3023281qtg.33.2023.02.17.02.55.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Feb 2023 02:55:52 -0800 (PST) Message-ID: <77d80241-860c-2cdb-cf82-cd41ec89e2dc@redhat.com> Date: Fri, 17 Feb 2023 10:55:50 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 To: Ulf Samuelsson , binutils@sourceware.org References: <20230216204006.1977-1-binutils@emagii.com> <1a9ce7de-4006-9ebc-7012-5e11c42a7559@emagii.com> From: Nick Clifton Subject: Re: [RFC v0 0/1] Add support for CRC64 generation in linker In-Reply-To: <1a9ce7de-4006-9ebc-7012-5e11c42a7559@emagii.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Ulf, > Before CRC: > 0x00001100: 0xefbeadde45444f43 0x0000000000000000 0x0000000000000000 0x0000000000001118 > > *CRC [0xc79d3a1ef51fb737] update at 0x00001110 succeeded* > > After CRC: > 0x00001100: 0xefbeadde45444f43 0x0000000000000000 0xc79d3a1ef51fb737 0x0000000000001118 Sorry - I am a little confused here. Does this mean that your v0 patch set is working ? I was going to suggest that the reason that calling bfd_get_section_contents() does not work, is that it is being called too early - before the contents have actually been assigned. I am also concerned that your patch includes copyrighted code that appears to come without any license attached. (Maybe it is in the LICENSE file that you say you could not upload ?) Also - from a flexibility point of view - wouldn't it be better if the CRC were to be computed by an external program, rather than being built into the linker ? That way the user could decide exactly which digest algorithm they wanted to use. I am pretty sure that you can arrange for the patch to fork/exec another program to compute the CRC for you. Cheers Nick