From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2066.outbound.protection.outlook.com [40.107.105.66]) by sourceware.org (Postfix) with ESMTPS id 7E772382D380 for ; Tue, 15 Nov 2022 07:59:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7E772382D380 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VIkTMyNCaOlvYELmkB1UFpELhXqWLSbaZTOIfFwPgZz6LCdEuQWTkNKyu7bTmybol2tQ/dGrOA41XbPLXg7uKY8jb9NEh+YBY8Ptcg+lb/ZLj9axcVXU3akIeuf8CsJa/Pdb0rWcIFcmwfcVcw0FEW8tsK+I3QBK2N8/CbSIgxyqrzdx6hE+c2YCLMIzBgFB7L2WowuvcXJ/Kh5iemBtyfFmvVs9DJ/r+POE3zcEyJu6ZWMh1r6H25RH9xVu1677Qo6yWCbR/KNNTDDWYZ+B8GjrcM54Lv/NXq9dMK1UUQRG9PRqF7+FbV+c8Krt4sZkOd4J3splLmEtQoVtv/YGnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WySyv1dKvhxY0+zFk4MmQ3IGugOye8Hmv54IBkpmHTs=; b=XF0ACbClPtPGi2/V5gotJKJBIoZboosKO1ydg6yVxfae3qAUXJFy4qwrGcrmwIoCUevS1Q7u7cG5d+R1b+sgq2nfZggfCm9Wl6aBZyrH6DDWsEsfiLOg6vEtigcceo/6M2T1gFkkaulsFF2gZ+sU//afxXeyRHlQG7VqxA2bgpj5uZ15HVfCjc4pXOdzTW0aTL+YVyI/XskoZO4cBBwb5Ckze8NiJUyvAlBzXt7O42rALHRaZ5B40tV10N+I7jI1QWgw6f/OCLrQLnSl5vyqJs36DYrsfq0LrI05p6fIDRwjIFflkA7pZWEZ7elbhKdJIbH+YgIHPgz+BdQdH5E5eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WySyv1dKvhxY0+zFk4MmQ3IGugOye8Hmv54IBkpmHTs=; b=0gyAeoz1rh7lzXYIYlpbZyNuecXqvlqX59s/iOP+/y+dGa5x+Wbh8oYa73Ch4KU5S6SlgR3Gtj5IPHdPG8XxkzOq5UYK9xI6J3Xio89M6r5SGPR7/pqGUmgO25CGqnRLNs3DJ6hDP/usVm/ik+xU6qwFeePO0AqyY3nRjYnliTrXZ1j0CTQztoE2M/12E80rpmfAOae/V7YjEcoK13kGN2Ri7oBy5vH97Z0RJW5CynqLZkRpjmuBRIwPoEg6O3XcJbTfNnW5uT8GSP9SiXrEcwObeZtXQHEdrv2Z8wEfGWqybXfC08VsN/cmEfdminguXqMlTuQJH9Iefkw4UboyzA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7826.eurprd04.prod.outlook.com (2603:10a6:20b:234::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Tue, 15 Nov 2022 07:59:03 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5813.018; Tue, 15 Nov 2022 07:59:03 +0000 Message-ID: <77dc27ff-3293-4073-29e2-b9ee1a00016a@suse.com> Date: Tue, 15 Nov 2022 08:59:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] gas: accept custom ".linefile ." Content-Language: en-US To: Nick Clifton References: <40e89395-1438-6cbe-aa37-1a04a724c8c7@suse.com> <8587d119-b296-57b5-d99f-d30f3ec7c846@redhat.com> Cc: Binutils From: Jan Beulich In-Reply-To: <8587d119-b296-57b5-d99f-d30f3ec7c846@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0121.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7826:EE_ X-MS-Office365-Filtering-Correlation-Id: ec655dc5-dafe-4e0a-23b5-08dac6df4301 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bD1+6hWj4vVWpeVmfE0dQYtVQIYxrQk6mMIoCTl5BPFS39MaXZbDzje70Z/R8t/E/vIqDUC0yk94kZBekwYreIuvNfTbnaLiZj3L/7K2TQFG0fFjPpUZbiRGLxuC/2ipmPX4w3cNfmTdNxJd2U+zfjPI/YQHux4y1DF/JVc1MvV3+u/i5DaDFEVgqgyxmswpCZ+rCiKDmz3gAADjA6IUWhsYRMDTyIzWjOqwHULxCA7ZyGurOX/irqRNNpQEMhvy9gh54kTVK+tNpV9BrFh3c643N6kjteDo8mKM/mjOm7iqFziFGGcy5YDoESimLNha5QXVJygNNFj+e9VzSgAt8HijqYYbgaxFnx4lf4SCu3qer8KgwwxM2DtNYx/9onSflWSpIb7rO87HuNuzSR8ye48O3kf1zB+iFoNjvD2eoDn0WHYgrilJkWNRVYA0J63+vk0CqTZh3K2sPSACVOeHltLLqQTBYiKQN7WBVUusuPYPRQ2gWD2042FiDn08M1ARcj9jRvqs0Msc89BjLwScKrpLHplY7vD1AqVuCwawPdhKKse0LCZkRD3AlmI7773FYMxJlXNMkcjs171LEdSXMD4IVMPxcyJlnoiwpg9oQHzn2vsBvDPDzi+c/CMllvSmtiMvTsiwawSFY32vPkF3gcMc8IhHj5WVM4643UaE1RYSsXpFtNfK5dXI/lipSMgFp4RFGpuztZwO3kM40+1wdS2VBXZOCxGrgufjkUn2uO4r3Xj2cRaPbECmst1XnBVOVCJ2m0njOFXjBE/kCCfcD8mjnL/NVqNQm+X2AAuK+EU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(39860400002)(346002)(376002)(396003)(451199015)(6486002)(41300700001)(2616005)(8936002)(478600001)(31686004)(4744005)(36756003)(6506007)(5660300002)(6916009)(316002)(53546011)(66476007)(4326008)(8676002)(66946007)(26005)(31696002)(66556008)(86362001)(6512007)(186003)(2906002)(38100700002)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QkIxanlLZW5sYUt5VlBsdkZVT3ZjY094eGJTbmhUREU1Y0NPSGk3MmhyVjVV?= =?utf-8?B?a0hvd2RXcWdLN1lYWnhLclNQMDBQMlZDOFBXSWRoZXVCeHFxKzNNQWNDVnVU?= =?utf-8?B?d3U3T2QzbW1YdHY2cTdybitrTzFjOVAzUitld2toRjJEc3NvUHpCVE5Zc2JD?= =?utf-8?B?azdjbFN3Q3p2eFpJQmxjbjJIeVNiZjR0RTY1U1lXOUl3QWZmejE3TDN3QnJl?= =?utf-8?B?WHVtM0NTV2JoczlsN0FxSWVwOElzM0tTT0d0d1NwQ0FCNG5Bb0c2U0RQWXgv?= =?utf-8?B?VGpveFlEUDkwL3g1aGEzUmkyREw3dEFzMUVwSlVWSzVXRmhxL3R0V3dqT2Fp?= =?utf-8?B?dDlSbDhSN3JaYnp1OGRyZnNyczA1cFp3VzdlZDUzbHFwSlpFSG9PVkttaWVM?= =?utf-8?B?UXZjUkpVS0VtY3hWZFdEb2IybzE5L050VWtNM1h4STRFUG5Udk53cEhhKzNK?= =?utf-8?B?TUVEYnI5bUdoL25mdkNEdDB2N0xHcWw5eVRIdFVzbTJuVzd5WU42R1RiUlY0?= =?utf-8?B?dUJ5MkpOTk1McXlFak5Xd01BbmExazlpZThBSjZHbzBEalp1Mk9RSVJzdXlB?= =?utf-8?B?QWs2MnVpQ3ZtQS9jTGUvUnZOU2lkNitoWXJIcEo0MGdJbUxWTU1FLzJsVFhx?= =?utf-8?B?b0R6N1AyeWJLMHhZYjZQazBudHZobWF4YlNNMklIeWVsbzBmaGVlNU00dmFl?= =?utf-8?B?WitJRStnRVNTalp5Vis1dkRlYnZRR3RsOHlqNStiUmk0QmFqcFhqd2RCcWsw?= =?utf-8?B?c2NLZWEvay9MUXFTVmEwS2JsV0xpNEx2U05VRGh1OHJScVZXNFl4NVZpZktR?= =?utf-8?B?RVlLZno5NkdZem1qanZtKzBHeXBOWHQ2WHorN2g4TWM1dlpRR041WkJBRURF?= =?utf-8?B?THJpZUM3M0VNS0FYK3AxM3hScnJMQXhkbmM4MUpNQUUzQVo3UmxTcjZzZE0w?= =?utf-8?B?KzYza0JUZUQ5K09XZ1FSaFlIUktZYVNYUEtTNmNjanlLM2IyYVpCdGp5V2dC?= =?utf-8?B?dGV6Ny9WQXk5dVBhenU3Sk50VGdtQzBPMFpvYW5ud3BIanFiSXBPK0xHUmYz?= =?utf-8?B?TTRSd3prZGlkQktPZ1B2ZHZMSkpxeFYvbWtFcldzS3dLdG4yeis2YkxPb1dD?= =?utf-8?B?MEtBaFVZNC9aZEFxNFEveThyNFZqOWQ5Yk9qaG1MRDJhZXpaWkh4Sll6TktH?= =?utf-8?B?OTlueXFSbVhlQm5xL2VmNmp4RnliRis1MWxsR0NDdDlQZkVpUGtuV1NNTHBo?= =?utf-8?B?dERsZ3lVVTVNRG1hWUFraWc2eWJwQlFlajd5QmNaU3ZTTkpqcUxWbGdheDN2?= =?utf-8?B?V1pXejd4RUhkd3Z0NFhvc1ljcE5pTGl6MUdFMXZuMDBGVFN0OWJuNHNnZjli?= =?utf-8?B?bTI0eXpMMmxsN3BsK3dQZ0g5b2JKbFc3SFhBZGJtRU1tODNybDRPOXZHb3Ns?= =?utf-8?B?VVpudDM5V3B0dlk1UEI4cFB2azRERFdmT2FneGJha1NzMGZPbThOOW1YNmZH?= =?utf-8?B?TFFrVFFBaldrakhXajgzVnNVL1BWRFMzdmtSZXdESENYaCs4NFVnNTlGZVNq?= =?utf-8?B?TDl5aXBuV0ZxRWRkVVlNVlpoWHJVeElDdjd5NktldElmZ01wbHkvZ1ZyWnNE?= =?utf-8?B?ZjZLU1pERzU1ai9QTHVuZmtRb1VBL2FraTYrRDZna2FnMzZOYXlNZUE5SjlL?= =?utf-8?B?WHBzRFM0WVdPTzhKajZ0SXlPZ3pmenVwMVdsQ2l0WTZRMys5SnFDN1F6WkpW?= =?utf-8?B?TFJRVU9tck1PRERGdXdnbVNWd2lYMks0QnZhT1QzR0dtZk1RaEE0a1JIekJo?= =?utf-8?B?dFpDdmhSWXhvMzkza0hIYlpMTk5NNmJjWmNseGpROTBQSUp3OGllQ2ZJTEln?= =?utf-8?B?Y0tOclo2VUtwM0pWNDVxYThvdGppSytoekhuRDd5QjdiaGdnVWtyb3pqeVRs?= =?utf-8?B?NzZLNWNEVG13cisySFpGcCt2MThucHE5SXAxMW5ZNXdlWXhwN3ZIY0lyWFps?= =?utf-8?B?WmVIYzg5d1dBR2tXLzkrWE1wRlFIM20wUldIZzhCVHJsTjhTRnU2Q21TK0tP?= =?utf-8?B?akoyZzRRWWV2Z1M4QTNOQ1ZvZDhYdkx3YUUvVGxzcjFjVGpBZGRXb08zRmtD?= =?utf-8?Q?w3S+8OBkRSp78kiXeoCOZHMeg?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ec655dc5-dafe-4e0a-23b5-08dac6df4301 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 07:59:03.3626 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DjLuu1PPN/s6xrr3R6/AxqHekIcRQ2gXxVbHzZA7hvhADjDaFDHwToYxCmCKRk9P+GNJiezbm8Lbyf7DL3pfKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7826 X-Spam-Status: No, score=-3029.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 14.11.2022 14:43, Nick Clifton wrote: >> --- a/gas/input-scrub.c >> +++ b/gas/input-scrub.c >> @@ -469,13 +469,15 @@ new_logical_line_flags (const char *fnam >> /* FIXME: we could check that include nesting is correct. */ >> break; >> case 1 << 3: >> - if (line_number < 0 || fname != NULL || next_saved_file == NULL) >> + if (line_number < 0 || fname != NULL) >> abort (); > > I still hate having calls to abort() in code. Much better to have > a helpful error message IMHO. Not important for this patch though. So do you consider gas_assert() better? I've been using abort() (here and elsewhere) only because of pre-existing adjacent uses and H.J. at some point (in x86 code) asking me to use that in favor of gas_assert(). Personally I'd prefer making things like the above assertions. But perhaps such could also be as_fatal(). Jan