From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2070.outbound.protection.outlook.com [40.107.22.70]) by sourceware.org (Postfix) with ESMTPS id 5C9193858D38 for ; Mon, 7 Nov 2022 09:55:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5C9193858D38 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UvK2hN0H5X36U9p+C371MCfIam30pdgKNV4mU4VB0BV19YUXrhrEE7jsM+tFaxRiWnIL5tCvW81Jd2f1YRse0HCsCXBGOVgFYoiCgx+cHvLc7swyQ3egbIxD0HgagVRv69bjHN0PeervSl4HSFnaW95i2ayBn/9/s2h5KIip2eLlpsgo5raBirhwSDAWzB3SK0BxI713HUnW/bMyRGpBsXxtsMCciGv6yHhOlfsavyZgnVaVtnUTYONgDvTzFyu80SIQEf0aR3SqCNrx3jaDJGkI7IgmRtDua3EdoVcfwDLGYilgUulVpJERpKhxHdPyTNBBMtfAbdvGcxSZKD299w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bhFoPGb5nIwU1pB8wasulT4wipVNTm729QoNrrwTZ4U=; b=cNBfJ9PyeLXTbmXQjv8lD3OFSeexz+3Xz5n4VdotyjWrLVhaPaTd0ixYEujMjyE4Ma65mk6FUsXN8VUgrA8yQUIW0qedAgOSiOobqCzhAQ1EjAu0KamCdprnE9N2CFUVoZiAFHn9ioJ1d0YMvNa59fteRTLFuIxlZLYNkp8259+pzgggR331EkgQA2YNawsmaSUcGMMBNgBiZlXlHB+9+Btl+ND97UvL/nKMhG4gN+MbCsPVh7B8eCOKK8xzIiArykHDfIqXr5XHsMdinj0BEpk1cXKYWjJwroWhsNe/njganhXIG7+Ee8ebtBCbXNj2WfHwcjYs8uTE0h3ozb2reA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bhFoPGb5nIwU1pB8wasulT4wipVNTm729QoNrrwTZ4U=; b=0qENZ7xj9dxjmOCjuZCxnQyeFxxuSDsPtdlD1bovdKfIq6F9KAT8Qnq0HI0M/4jQVV2/p9ONUt8ifOqcEidMicHk5loMwuHsFBrdIqzghsfYM8EtfykRfhBq2x4bHwPpqoofedGEoqEwj+5sNd2fh+Of0DGUyOUqyVvpobFIUUvWWIn+x2faOyIkgobzE6dcIHl/jdsYMFd7HC5RKay3wvr2UHt/MXAXcqVZnIssZY0PzNwOP5HEs0QIBKBIwY7ryLbkyQMXLsMrc9ZdNqEEjsuK8/mbhHUeVxyU2JQ6HB6v5d1mwjMa9ZJpVbEy9CuTRC20KdbsGYyMkXqdz7cSuw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by GV1PR04MB9136.eurprd04.prod.outlook.com (2603:10a6:150:27::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Mon, 7 Nov 2022 09:55:26 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5791.026; Mon, 7 Nov 2022 09:55:26 +0000 Message-ID: <781ed098-079c-212e-7e46-a375c27f5486@suse.com> Date: Mon, 7 Nov 2022 10:55:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH] i386: Check invalid (%dx) usage Content-Language: en-US To: "H.J. Lu" References: <20221104205547.3728827-1-hjl.tools@gmail.com> Cc: binutils@sourceware.org From: Jan Beulich In-Reply-To: <20221104205547.3728827-1-hjl.tools@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0127.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|GV1PR04MB9136:EE_ X-MS-Office365-Filtering-Correlation-Id: abe3df75-2e0d-499f-37e8-08dac0a631be X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZyRo6cnBfvhTYEGBoGvxvV7gEsAlnmHqsF/mRqnyLKYm0Wg+j8p1wABrLtiKSGcG7k/P2V6e+r1XHs+RJyVAIYCDdmKJDafmpGOc3pfFCHzYxtFeCRmhDue/gCxfnypOjRJOJhf0y7F9+sPeob2gVkspUwbZpyNTCyU3WYZYmr/Uo4K7lht7jSV3SogI79GK0LOs5FpL8yBvTw+B9yHmO5X+e9LGroYbvoYv1p1tObGFa/DzuEXQrJhdvYsopSp2csM++a8+b9OeY5xT6zuEzoY/xZW1BKtGMrc0gLHPcPYeVGevzHy9Ke93PdpdXtpyDuFumRF+t0dcXHndWIOEAaT7oa4gYGsoplIwc07OHWi6g/75gpOkJ4VvS72L3JSXsTbN/wXEfqELsg1ZnVqMvsfkhCAh6bT+9JMg99xoYVLj5b/A3flSdrnOXINvZl0P3TYkJt1TQ7Fh6GpO7F9hqP3qkQG9pRnVjdf4Houi3n672kFmai3IPfyrfOvcd4CItPBuSI4xfFYPGT26Zdn+hXUu3Ak7go7ZDSTN3zBtXZ2546uFJall9ER1Rtjkg/SWGRoOuL+WnR9CibSpKmw+Z/gHdLauAoo/pv9t/YG7bKI+z/D7hXfYts24/JRgfWSwrmf4rCWv/nEDiwy9VZ7lX2OVVN0wnQASSq95jxT3CIc7DOck7xWKuV8l9kPKpbaIAfsdxIzcJ22CBsEE5XdzuyzTWeF+DtNHyQoYNsU3soILjx7574Yygoy0ytmMK9p0rBC+Vu454FIa3ihpBK3QvgdOC6WfuKeGqmoGRzDkHKU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(346002)(366004)(376002)(396003)(451199015)(83380400001)(8676002)(6506007)(86362001)(26005)(6512007)(31696002)(2906002)(66476007)(53546011)(41300700001)(2616005)(4326008)(6916009)(8936002)(4744005)(66946007)(66556008)(5660300002)(186003)(36756003)(316002)(31686004)(6486002)(38100700002)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SGtxZmlsR3FFa3MvK1l6RXNrZm1xOHVyTGFYRDd1bGpGaXFnU3lzTEFSZVFj?= =?utf-8?B?TzY2ZDRiVVpFbXM5QUgrTUc5SHJxaEt2YUpNSlpoWXV4S1RVZ0dkRzF4aVYw?= =?utf-8?B?Y3RtNUdwOUNNWlBwVmlqdnhwTEMvRXhDblpoN0N6UTgrKzhnYmVBZnN5M0pu?= =?utf-8?B?RlZyYWFpeFBjdkJJV09EVjM0a1dIZWlNeUg1SVJSL2VhMEtyelRPSHdmM25W?= =?utf-8?B?R3lmU2VOWHU3T2g3dU8yY2RVTGpEbGROQUx3T1crMjF5V28xUGlFbVdWWWRr?= =?utf-8?B?K1ZIVG9NRklHNWdTNk9FT0pWNk52WlEwTmFIRURSYW5qK1c5Tm45UHhoU2t3?= =?utf-8?B?eWE2VmthNmUvZitaT3lXdkoreU1GdFFMSXVBL3RFU1dESnF5NEVibURsUVky?= =?utf-8?B?MFA3VHBPY3FGeGszNWVacVFFZW1QcWFLd0RkQytDK1FJM3AxcUk5TVZWZDhF?= =?utf-8?B?cW1lSlJsMlpsY3A1RHBRTmIxYndXZ2JZRmViZ2ZFS01MV3ZEc2Z5SzZLNjdE?= =?utf-8?B?YUlBQ3VMb3BTNnRIa2xnQkVIMmlGMnBQVWtWYWV6OFoxOVk4UXBLY1U0dmZN?= =?utf-8?B?WjNQSWsxbm9WeFlTWlRuUjRUN1F0d2l6TkxCQjlJWmFPWnZSWXRDZUs3aFFO?= =?utf-8?B?NkRUOTYwdFAxSkxuQ1R1d3Q5dlFQcDdMZzZGUVdXaFVnL3VLQjk5TmtKOUxu?= =?utf-8?B?ZXpEaUU3OVZTazVoVTJBUWlJTDJPTyt2VEZyNm9nb2NJeW5oaHlZYnArRFJX?= =?utf-8?B?bWRzcll1WFB2UDhyMDFvdFd6dzZxY2pjYlZoVnA1VVhuKzNwOUJwd3ArbFVp?= =?utf-8?B?cGR5MkRrMSs5ZzcvcHozZW1VSjV0dTVVeVNGNktqYTAzSW1uRTU2cDZQUVpX?= =?utf-8?B?V3U0TXE1d1p0WW1pQVNxWG91RTYzaGNxMGY0ZkRqRTVKQjJjT2gzVk1yUUxX?= =?utf-8?B?NHhPNTdDZ0JrYnBlMlBLY2tIaEVROUR3azkwNFZVeiswZWl2Tmd4cEpndGpx?= =?utf-8?B?SXM1ZDZRRFNYUzlQV3VpSVpMZmxOTk81TGtqNlN4R1Q4M1VnOThXSlZSemJD?= =?utf-8?B?QkpyN0R1WXNXZ3pVckdRSjhGMGNJdU1LUUw2VGoxbU1iT0pucVNIV1o1SDRR?= =?utf-8?B?amwxS0NIY3FUYTZLckhLRWRrV1hKaytKd0JRN0pucy9meTZIbVcxSWFKSUk5?= =?utf-8?B?aWtLaGMwVG5vSm8wSkZnT0QrVlBLOXpvMTUyNm9TcUxvSEJCL3h2R2lULzhB?= =?utf-8?B?anpBM0VrSWZCV1E2YWtmdkJsNFVBQlc1V0laMWcrcUhSbVhDWTdHakoyNXRZ?= =?utf-8?B?eDFhYmIwZkxjRUNlN3FDejFlZjltUVhKVkIxZ1FYblBWRHBEWDM0dTQ2aE94?= =?utf-8?B?SWtrLzVzSHZIa3o1MXdKSDd5Ry9FQ2F4U0gweTh0MVNoU1hZcEtpcTczNTZM?= =?utf-8?B?RE5aWkw1Q2l4eVgrOWl2bDRiWFEwVHZyaFAzTVpQZGh0akJjVmsxMzBIV1c1?= =?utf-8?B?c3Q3MkwrZEhKYS9iUVNRMUthSXZlNUIzT3B6SHNIVUlxREtaT3MvWnoyakFp?= =?utf-8?B?WEhPNk1TQ0pzQ0hlcWNqSlE2MUVybENzdWhSOGQzN3c3Q25uVG1GK1N1VmNt?= =?utf-8?B?NFU1NklvdHJEOXptYmg2L2k3SDRXdjlkNCs3aTFUalpTU1JiRGZ5V3FIVHNE?= =?utf-8?B?UDVvdExvR1p2eGlTQkRzSUV3WTVIMWFoSGM2M29QMk5RRG82ZklubjVnQzI4?= =?utf-8?B?NG15dU5XaHh2Q29LUUxpVWlUcjVPWUZNakpDUHh0MVhSWEVObE1MMzhiK0lQ?= =?utf-8?B?V1RPMTFkVkhwS1dXS0Znc2k1U205aS9WeUNSZHFORTFaVmhZZjB6ZGNJNDVO?= =?utf-8?B?QUs2YmVuMit1US94MXRVdmduMkJpeW9KQjV6eGZnUHpNNnNQY29kSG1uZHpF?= =?utf-8?B?VnFZWXpoRUtzY2VuYkRBV1U4OHd2cS9qVS9xUGo5TVhnbFB6YTZQWjBXQTVB?= =?utf-8?B?S0FYUmxzS0lCbmVrcXlzaUlOY0RWa2dTbFRBbWJ4NktLOXFjaGdlSlZOcWxi?= =?utf-8?B?blRzdFMrVTF2d2ErUWd6UjZBVlRNcjZ0YzdINXRFS0pUREcvbDlPNXFJeVJz?= =?utf-8?Q?z+FdbgDCp44sMi38K9a8Duko1?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: abe3df75-2e0d-499f-37e8-08dac0a631be X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 09:55:25.9719 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: R0pM3rVUelAyJXcYtmM4g+CHna8SfifTcBM8yFiXeFv8ZWCfUJj5xxcXXhinZho4/kypJpRrPnVkHp20pHwiRg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9136 X-Spam-Status: No, score=-3029.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 04.11.2022 21:55, H.J. Lu via Binutils wrote: > (%dx) isn't a valid memory address in any modes. It is used as a special > memory operand for input/output port address in AT&T syntax and should > only be used with input/output instructions. Update i386_att_operand to > set i.input_output_operand to true for (%dx) and issue an error if (%dx) > is used with non-input/output instructions. Hmm, this shouldn't require a new flag I would hope. We did properly reject bad uses up to 2.31 ("operand type mismatch"). Whatever was broken there would need correcting instead, imo. A possible candidate looks to be 2fb5be8dac9d ("x86: drop {,reg16_}inoutportreg variables"), albeit perhaps combined with later changes - in 2.33 behavior changed again. Jan