From: Jan Beulich <jbeulich@suse.com>
To: Binutils <binutils@sourceware.org>
Cc: "H.J. Lu" <hjl.tools@gmail.com>
Subject: [PATCH 2/3] x86: drop dead SSE2AVX-related code
Date: Fri, 20 Jan 2023 11:00:35 +0100 [thread overview]
Message-ID: <7882acac-b12c-ac86-77f7-063ecd07e799@suse.com> (raw)
In-Reply-To: <fa0b2985-f8b4-fe55-d657-1dc2ba2a1e4f@suse.com>
All (there are just two) SSE2AVX templates with %xmm0 as first operand
also specify VEX3SOURCES. Hence there's no need for an "else" to the
respective if(), and the if() itself can become an assertion.
--- a/gas/config/tc-i386.c
+++ b/gas/config/tc-i386.c
@@ -7965,29 +7965,15 @@ process_operands (void)
if (i.tm.operand_types[0].bitfield.instance == Accum
&& i.tm.operand_types[0].bitfield.xmmword)
{
- if (i.tm.opcode_modifier.vexsources == VEX3SOURCES)
- {
- /* Keep xmm0 for instructions with VEX prefix and 3
- sources. */
- i.tm.operand_types[0].bitfield.instance = InstanceNone;
- i.tm.operand_types[0].bitfield.class = RegSIMD;
- goto duplicate;
- }
- else
- {
- /* We remove the first xmm0 and keep the number of
- operands unchanged, which in fact duplicates the
- destination. */
- for (j = 1; j < i.operands; j++)
- {
- i.op[j - 1] = i.op[j];
- i.types[j - 1] = i.types[j];
- i.tm.operand_types[j - 1] = i.tm.operand_types[j];
- i.flags[j - 1] = i.flags[j];
- }
- }
+ gas_assert (i.tm.opcode_modifier.vexsources == VEX3SOURCES);
+ /* Keep xmm0 for instructions with VEX prefix and 3
+ sources. */
+ i.tm.operand_types[0].bitfield.instance = InstanceNone;
+ i.tm.operand_types[0].bitfield.class = RegSIMD;
+ goto duplicate;
}
- else if (i.tm.opcode_modifier.operandconstraint == IMPLICIT_1ST_XMM0)
+
+ if (i.tm.opcode_modifier.operandconstraint == IMPLICIT_1ST_XMM0)
{
gas_assert ((MAX_OPERANDS - 1) > dupl
&& (i.tm.opcode_modifier.vexsources
next prev parent reply other threads:[~2023-01-20 10:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 9:58 [PATCH 0/3] x86: assorted tidying of opcode/operand handling Jan Beulich
2023-01-20 10:00 ` [PATCH 1/3] x86: use ModR/M for FPU insns with operands Jan Beulich
2023-01-20 10:00 ` Jan Beulich [this message]
2023-01-20 10:00 ` [PATCH 3/3] x86: move reg_operands adjustment Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7882acac-b12c-ac86-77f7-063ecd07e799@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).