From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by sourceware.org (Postfix) with ESMTPS id BF5BB3858D34 for ; Fri, 22 Mar 2024 10:31:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BF5BB3858D34 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BF5BB3858D34 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::633 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711103481; cv=none; b=vXSWjzIwH09bvx7tlP7bfKV9vXiyLirgGYeJIq0tJ9pE52QpKg9FgDxy39tFfhQrc/AU1KqwxMQZ+YVPkV6y9jwl0ngRDJN5iZ/KxtKNnJiDOrKE6mCFoWNpUQIbf711jTkvKsd3DzNjRtlnjcGW/09vBtDsONZNyREyRYNy1Oo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711103481; c=relaxed/simple; bh=yPxKX3oUP9/NkpNH3145sKazpoVVPOkr92/wh5wVs4Q=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=Ab31kHQJ3uruJ4NJShstZbco8wu189hEFUNKGdLbIxaMCM1/K0lQ4qnCk7S0IOb0zhUwkvmDXDdj1+Gb8MazCUvGXj4bTXYypP7IQMsZ0/mV/JkcCARBe/QEY4HMvyNN1L8D3/dfhGkXXg2mjWInkoNs8rT3+YrwGORZVTEC558= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-a46dd7b4bcbso258398066b.3 for ; Fri, 22 Mar 2024 03:31:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1711103478; x=1711708278; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=sVmf30C4EWiT4fUW+up+Ogk5opdVXEw9qX4jS/7U2Vo=; b=TYIi/ykU5tIuC/6mrNRPz7p1ugKPeEySprEdL5uQYj4vcQlS1/+pMzJaN39ocOln8o hqKj+HGx5Ak7MOJ1TKptO8hZ3SH9RAeSM2svd4FpC/NZGnHsE3dbSR50D/b+Q1TPzObm r5jU8jRjwP+iHLCdhXm7NRaYtgN+PQj4+BebipBp2e0Aee/ugnWCoY2afI38odeBrwMH BZ3pt76jLvWYSlpv3dwepdBfCYzj6K7PRvOgoE6cAfJyu0gzcAlFkPNwu5Vw1hgDq1xK 1EhgfK1ns1i/zYyTqtzf1wcQ01Ljaap9c9K6PWEEbsVxo4ewIbkQi/i4xVU8rN5N01qo fqNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711103478; x=1711708278; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sVmf30C4EWiT4fUW+up+Ogk5opdVXEw9qX4jS/7U2Vo=; b=urpseYJXr5PyrMvBpPcnBIebx2jOL9RJYDTWdvVtpkcQZBEv0QXoVQr1I0arsA6hSH B8e1EdNWUIib1PQllGWKoV5FdTSi9cLs5TpaR8RGRCvyl+ywPxWabG0wa9x8uqp/eLFJ /umkagUFvT/IyGqlczsdkqaQWAeyLOXGpw0FLthqBrjD/Bw6Nv+pYBQ5AWweP/J+jYXk ZEhsOjMa2y+mVXamiVx2Ap9IYBe1HKlUDw4gSol6varQndV9J8m2+ZVF9MOBuhSnZ7cQ w6f+IeKcM6cIOLlInqGL4Chfx/KVIKz9IRVskbMIarU7jime0v/RH3DIuKVBYqIwD29h i3rQ== X-Forwarded-Encrypted: i=1; AJvYcCX2AOYM6rb+wNRR2FztEK4nqwTVIW7UsD5ExfylsaUTxKX+DXcgrwfij2GRK6cMRwwbxtaQlepYKBrNe61kbQGIJTXG9ZQH4g== X-Gm-Message-State: AOJu0Ywq+8Urzti6cQyN77JQ88ZvQMShni34qgB2f8BQWyMblY4WXA46 b3VkmTXwmOu18KSES0FjqK+K9Dp7iQHEJqdMjXCvTPUxKgLmBLLzDHeguW9HXA== X-Google-Smtp-Source: AGHT+IFj+pmgQ5/RvS1hsj6Upj14Veg4WQJZMLnLrtZm2urvFlZvHfCjpZtq7zbD/MZRo+VIitVjWg== X-Received: by 2002:a17:906:69c5:b0:a46:bbb3:f0d2 with SMTP id g5-20020a17090669c500b00a46bbb3f0d2mr1250719ejs.47.1711103478439; Fri, 22 Mar 2024 03:31:18 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id wy3-20020a170906fe0300b00a46b10861acsm861902ejb.208.2024.03.22.03.31.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Mar 2024 03:31:18 -0700 (PDT) Message-ID: <7882e22d-3375-427e-8964-cab847ba2c50@suse.com> Date: Fri, 22 Mar 2024 11:31:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 6/9] Support APX NDD Content-Language: en-US From: Jan Beulich To: "Cui, Lili" , hongjiu.lu@intel.com Cc: konglin1 , binutils@sourceware.org References: <20231124070213.3886483-1-lili.cui@intel.com> <20231124070213.3886483-6-lili.cui@intel.com> <8077dbe0-4519-4438-a943-5a310ff5f523@suse.com> Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <8077dbe0-4519-4438-a943-5a310ff5f523@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3025.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 22.03.2024 11:02, Jan Beulich wrote: > On 08.12.2023 15:12, Jan Beulich wrote: >> On 24.11.2023 08:02, Cui, Lili wrote: >>> +rol, 0xd0/0, APX_F, W|Modrm|No_sSuf|CheckOperandSize|DstVVVV|EVex128|EVexMap4|NF, { Imm1, Reg8|Reg16|Reg32|Reg64|Byte|Word|Dword|Qword|Unspecified|BaseIndex, Reg8|Reg16|Reg32|Reg64 } >>> rol, 0xd0/0, 0, W|Modrm|No_sSuf, { Imm1, Reg8|Reg16|Reg32|Reg64|Byte|Word|Dword|Qword|Unspecified|BaseIndex } >>> +rol, 0xc0/0, APX_F, W|Modrm|No_sSuf|CheckOperandSize|DstVVVV|EVex128|EVexMap4|NF, { Imm8|Imm8S, Reg8|Reg16|Reg32|Reg64|Byte|Word|Dword|Qword|Unspecified|BaseIndex, Reg8|Reg16|Reg32|Reg64 } >>> rol, 0xc0/0, i186, W|Modrm|No_sSuf, { Imm8|Imm8S, Reg8|Reg16|Reg32|Reg64|Byte|Word|Dword|Qword|Unspecified|BaseIndex } >>> +rol, 0xd2/0, APX_F, W|Modrm|No_sSuf|CheckOperandSize|DstVVVV|EVex128|EVexMap4|NF, { ShiftCount, Reg8|Reg16|Reg32|Reg64|Byte|Word|Dword|Qword|Unspecified|BaseIndex, Reg8|Reg16|Reg32|Reg64 } >>> rol, 0xd2/0, 0, W|Modrm|No_sSuf, { ShiftCount, Reg8|Reg16|Reg32|Reg64|Byte|Word|Dword|Qword|Unspecified|BaseIndex } >>> +rol, 0xd0/0, APX_F, W|Modrm|No_sSuf|CheckOperandSize|DstVVVV|EVex128|EVexMap4|NF, { Reg8|Reg16|Reg32|Reg64|Byte|Word|Dword|Qword|Unspecified|BaseIndex, Reg8|Reg16|Reg32|Reg64 } >> >> Didn't we agree to avoid adding this (and its sibling) template, for the omitted >> shift count being ambiguous? Consider >> >> rol %cl, %al >> >> Is this a rotate by %cl, or a 1-bit NDD rotate? > > Btw, while this comment was taken into account for the "normal" shifts and > rotates, SHLD / SHRD still have this odd extra form. There's not as much > of an ambiguity there, but I think we should demand %cl to be specified > consistently across all respective APX insn forms. Actually the overall situation (for legacy shift insns) is even worse: For "normal" shifts / rotates, omitting the shift count means "$1", whereas for SHLD/SHRD it means "%cl". Prior to Lili's recent disassembler change it was also the case that only the "$1" would be omitted from output, but not the "%cl" (at least the disassembler is consistent now). Jan