From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2066.outbound.protection.outlook.com [40.107.104.66]) by sourceware.org (Postfix) with ESMTPS id 4A5753858435 for ; Tue, 25 Oct 2022 06:53:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4A5753858435 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q19M0rxK51Fhyb8RYUEloesGnZmtB0S+cwVGHf0zNnBaXQuweRt3WB1lV1wpxNd/7pZNxBvYrjvaaEPMI2hOR/UpPiBS6FLxn2pffY3RDgBJxQ5HeHlImjrVjR1sPttJddV1vJyIrNNh7CasCbxvAOecCYGxSi0qwyeGkurKIGj0vMKV5v2sqyAe7uzHLHzyA/Bl9+OabiKsp3yAuUj0QTQqhXYoipao4iamKF23OkHxDbUqwexRibZJyaHxnhs2bwYbb2r8fmYm71Cqr8f0E1cHxBxYkPWsff1Tb60ECAHXq7EwqQGiY9W+r/o8UyYG+M5Diq+tZksRx29RMdkUEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d9f8g/jzlIxid+oCPm3qCWdhbYyH8SjVDpJkMxIoqs8=; b=Yg+DsItEkiLamp9bELGCV90kOWlEk1qGKe/vsDGTed9iO3YR5NeY6dypd3YsujncKsUPVlJUiZ/Tqmypg2XBQfPbuYGW4WYVe2H+qv6R7T5ZB21fofROo5qguj9ip8Af/9ZrK60mOjTb592VGzzjs+QuEZrW0WODrKpU1c4CVY9Fp6BBYxo223xf7ttpmoL1VYn/yixW1kay4qUO5/oaIKlNLK6bninT5HeySYsqk/FIJpgGkhVhfbsLqef+RaiyFlbC8S2YZfSOjHwLF7PDFJ4S+F999DVXiJ3pNwbm41s7/XfHj7lnwwrbUnG1Jo5jeg2E1HzdvMBMuKQRS78JXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d9f8g/jzlIxid+oCPm3qCWdhbYyH8SjVDpJkMxIoqs8=; b=HtBceL52eKjHiLRCoB8oXtf8F/YIijvc9xVin1MtLTCofTYw/Erjl0WnNgjXJZ99a9Hdu0XXjd/xso3Xkr2hiUo1ixbjROb6G0LZ2dCR8ATecL9Te4K+0BmT4DduC8sGMpB4IBwjTQFdcMzKeoaCMM6fLlSIy5QXyQK6pD6rb4//1jSmygKEYj9VYn/LkVKCw1htqEsiLoVFUDh5GWzS+Dpwkv6UkUvf73wjKF6xC5UU1TSwPe7dMqiuh7w5DF/P0822HhFHB4bmUQetaqTW1Jf65XO1Se3P+1rm05QblmeGG9qRwIYLyXCFidr0KgCen5pz5FAoxOLBMG73wTlJnA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS4PR04MB9361.eurprd04.prod.outlook.com (2603:10a6:20b:4e6::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.26; Tue, 25 Oct 2022 06:53:18 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Tue, 25 Oct 2022 06:53:17 +0000 Message-ID: <789f9132-88b4-1c41-0d1c-e7c2626fa8d4@suse.com> Date: Tue, 25 Oct 2022 08:53:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 04/10] Support Intel CMPccXADD Content-Language: en-US To: "Jiang, Haochen" Cc: "hjl.tools@gmail.com" , "binutils@sourceware.org" References: <20221014091248.4920-1-haochen.jiang@intel.com> <20221014091248.4920-5-haochen.jiang@intel.com> <1d847a52-b1ff-b816-1507-7077724901bb@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0043.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS4PR04MB9361:EE_ X-MS-Office365-Filtering-Correlation-Id: a204437a-f0bc-4fa3-0f92-08dab65598bf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ExfMXF7MNiL7Ug+nMEc1EuX/8ohUDPgnvVH9suBnyfcYHJ5lgCat9zMReEtXF5tbHJmcBUf5sPXHLf62GFNgzyxNDlIBpTzQJ5KWL6SW2+H+MMNNdzW8Q3aRO9vnWhk/2DrrcUQ6IbKxHXD+cLUS9yK3vOiAB35q1FyF4zJMqvPeGFAjQFvAvGcQrl7lHJtWrtQdvuUjx08lb2ZLcBfxLdDRGhnfN86/jDKGlnWsoPlxKXww9ov8ACX533NI3KtcJyfI83tRKLNO+Ujdxj7znI3/9pe86x137UCLaj6Htq9B17UKH3DlYr7WtX5v0Ob+rjN/GMxMQnmjWIkrldSJtoBCo/rc9+wPI4mPTFYXGj942yp0HRSZdwDiGwGd6I+LiUPkJID8iXeHHtGVDHlhpPwHj725T4BlcM6oq5MzfuXj5lsIJ9foga1aSRFi2JaUxs/1kNc8fKrcxnuBvYSbASY9tJ3zrdSIEG1aPoVAKfP8jfTwahXgl9sBQ28Ombi+0XjryhPJAqI0iduv2tdkAM3znVO7xUGxGJuuJkZHAiQGXlEWj/uUq76HveMV3yoKjimI0MVIEpODUIFDvg+0aRbIOTLhP3grehAKGH/kV0F3L72vBdNPgSCpK0/h5lGmZyFvDdIlU9Mhs4BRJzK2wgbNKdvqcpUIiNRRuvuNkAex42/m5aCYayus/9fZlYvGSI9j7HhJqzw/Vqq0iXjVrxpN+aF/7Xat0Vjqb0D9jEp0OxDvUFjsB17yoPld5kCriCY3+nlnzT4DgtgCw4OsOzoKTDS7r8x4ylCiVU1RrxA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(346002)(39860400002)(376002)(136003)(451199015)(31686004)(36756003)(38100700002)(5660300002)(66946007)(8936002)(83380400001)(31696002)(86362001)(66556008)(6916009)(54906003)(2616005)(26005)(186003)(6512007)(6486002)(316002)(478600001)(66476007)(41300700001)(8676002)(4326008)(6506007)(53546011)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGRtVnpEckJId3lXTU1ldzZlWVJ0dUNEN1d0OUNQNUczQndIL3dreFBqamFD?= =?utf-8?B?SytJWjZ1azJTRTJNdzJ3UndIWDczUlUybUxEMzYyMFNiNGxSRXpna3J4eTQ4?= =?utf-8?B?eTZaVTJqaFBiMWVZY3FzU29FZ0drSWRYc05Vdyt2VU53Y1I5SXR0RXdLVGJ1?= =?utf-8?B?SzIrVHhFMnBsWkNQNGM3dm1mVGZSZmFIV2hIR0ZaeGFqZE9zejVIOWJzbHdp?= =?utf-8?B?TXNpanJYVFZPeFU3SkROUElqdGIvclhyUWlJbjJmQ2FsMjVTWXRhVFpzbGJr?= =?utf-8?B?L2dnbHdzcW5jYkJmcUYvendHRDNZNXRETTlSME00ejd3SHEycWRvd1owVVJx?= =?utf-8?B?bWtscmR6MjhsYU11NUZNMjdlSG9PV0dzKytEeW5pSHRPbUd3TSt4SHJacFJ6?= =?utf-8?B?d1NOckpSNHJleFFoVlFzcTQ4QnhVTUxHV1VCK1RJM0JaSjV0dFlXV2lWWERk?= =?utf-8?B?Q1dZK2U3ZUN6dlVkMWpoVFdxL2k3RW1USCthTklDU1pRMnUxSXVhc3FqUjRo?= =?utf-8?B?TXc2MEY2YWkyU2hEbHp1b1YwcVRsWW1xUFNnWEg1ZDVySU9keUJsaExDNE96?= =?utf-8?B?QmJIR2RIYnk2MzNJSnh6dmFtUjhJQllzYzE5Z3NSeXdmUW1mekQ5U1BUUzg0?= =?utf-8?B?YnNsamFwbXFPbU55aUxxOFFZZ2RMcTJTaGphYVgweGI1cW5mcTBPQ2MrYUhx?= =?utf-8?B?STlFV3FaZWRRVFlnZ3NMZWkyekFjOUxSQUkwak9JWTJGRXQxUDFEZ2tnOXZi?= =?utf-8?B?Q3p5RmNSSG5GM2o5Mk5CeTFTdEVrMVZ0VHZNVEpEOVJobHFTaE9yOE5IUDdp?= =?utf-8?B?ZlhYRmx2VmZlbUUyQzdVaTRuS240aEZ4R09zVC9tUldUZHN1OGQ3WklpWXhV?= =?utf-8?B?dGhyNWxQSCtuR0twdTcyTjlkamRSK2o5T2VSd3BBc0dMRjFLWll4c0VMbDho?= =?utf-8?B?TmQxcThuL1ZRZFRDYUJjVThuQk9sazlNNEFRUW90cnB0cnAxc1Z3aWEvRVJh?= =?utf-8?B?U1JmK0hOcG4wNktrZHhTaWhlVkJTMVlNbGRUaXZNOXFnM1N5Q1NmclJrR253?= =?utf-8?B?RUptd0xFY3Blc0pqN2ZHN3RFcFVHMGRTbVRnamZXaFZIYUZYcldITWZjeFhk?= =?utf-8?B?SnJWYjFIdE5vVnJqbW1tSTl4SDd3WW5pb2FONXNjT3U1K1hudFVmcW5TM3FP?= =?utf-8?B?L1RQbEhDZVAzaGxTVVZLQkJadUZtcWY0MDR2cXBVdnFpODNia0RRd3hrVDdu?= =?utf-8?B?U0doY05ublF1RklPMVVFdE41MmF6UTcvVzQrb1lEUVNFQTJqMDg1WW1kWmFj?= =?utf-8?B?Z1JnKzVKcW1TbmJtTFBMWHBBVG5vOEZTZDhod3Z4V0RsMjhyT0IvTGlNdlIz?= =?utf-8?B?RjZxWm5VbXdSU1hjY1JYNW54RVhPYWlCRzlhTTRSNmhpbUtCZGJVSllBTHVW?= =?utf-8?B?bnA2aGE3K2VjNms3ODVLU0JGZGhXVjErb2MzckE2bTZWTUNKTWdlSXZ6QXFK?= =?utf-8?B?UDdDRlJyYTF4eU03MXFLaFRoMkRrQ2dEeFdPZGoxUHh4WngxYlpEdmJOMTZL?= =?utf-8?B?bDFWblRwNjUyd2VCelF4OE5JMmNpMzB0KzNidVAxbHdHVVhsdUkvY1RBL0Jo?= =?utf-8?B?dXhsMUE3ZE5oSzFwZE1pUTExV290V1ZjMWE3cCtiNzlsOFBpT2VmcWZsSWQz?= =?utf-8?B?cUU3VG01OVFSS094MHNmdHF0cjJxbE9wUGV4R0RNSkJqcTBTVVVRWDVyaHJy?= =?utf-8?B?aU5zYzFNQUR6djBNbElRNXU4NC93OUtqR3dRblNzTEhoMFBXMjVLNi9yQ3RO?= =?utf-8?B?YTNZZFBSbXdIeTNHMW9kL2JZcHl2WCtGNWRZS1NycDlnQ3JudzY4Z2hCZ2F3?= =?utf-8?B?VkhIUkd1dnFIRkVMTHVLSE1Pb0U1Ym5LT0ZFRFZaUzN1YURKQzFDZUtaWFFB?= =?utf-8?B?cFU2SG9LdWdtbDkvbnJtQVhQTUJEVXZDdThRT2JMbG9EeGcyZkNjRUpMV1RW?= =?utf-8?B?TkE0TjN5QXNpK2dLMVpyeFVPSWVsd002TW1RZXBhUTNPdHRVQzlWcTdja3Zr?= =?utf-8?B?RVcxM2JtME9CMjBMOVJDaUIvb1VjMkVlay9MVXNOUzZicGtHMzVoZjN2TkJ2?= =?utf-8?Q?3AKkVUxoAx8iKxYdhfCwwO7oG?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a204437a-f0bc-4fa3-0f92-08dab65598bf X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 06:53:17.9198 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +v0s93f76ebPm1H77nwed0VSEZERErP5IoVxX7BDVgXfVy8iaAN3srqR7Cx80VcuIbuKTvlN3NW989W95HLWTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9361 X-Spam-Status: No, score=-3029.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 24.10.2022 07:55, Jiang, Haochen wrote: >> -----Original Message----- >> From: Jan Beulich >> Sent: Friday, October 14, 2022 9:47 PM >> >> On 14.10.2022 11:12, Haochen Jiang wrote: >> And finally - is SwapSources really appropriate to use here? There's only one >> pure source operand, the other two are also serving as destinations. >> I wonder whether an attribute is necessary here in the first place: Vex- encoded >> insns with a memory destination never have two further register operands, so >> that property should suffice for identifying the case in build_modrm_byte(). >> Alternatively you could also simply use the CPU flag. > > We may need a special identifier for CMPccXADD since we have VVVV at > operand 3, where it is always at operand 2 for all other insts which > have VVVV. That is the reason we reuse SwapSources. It might be not > that same as the original meaning. But we want to avoid adding a bit > for this very rare case. Do we need to change that? Re-using existing attributes is certainly preferred. But the question here was whether _any_ special attribute is needed. Did you try out my suggestion, and it didn't work out for some reason? Avoiding the (ab)use of an inappropriately (for the purpose here) named attribute would imo be preferable. Jan