From: WANG Xuerui <i.swmail@xen0n.name>
To: mengqinggang <mengqinggang@loongson.cn>, binutils@sourceware.org
Cc: xuchenghua@loongson.cn, chenglulu@loongson.cn,
liuzhensong@loongson.cn, xry111@xry111.site, i.swmail@xen0n.name,
maskray@google.com
Subject: Re: [PATCH v1 1/2] LoongArch: gas: Add LVZ and LBT instructions support
Date: Fri, 30 Jun 2023 11:52:11 +0800 [thread overview]
Message-ID: <78c011c2-679c-3b01-ab75-e1d59d79cf88@xen0n.name> (raw)
In-Reply-To: <20230630033443.2359278-2-mengqinggang@loongson.cn>
Hi,
On 6/30/23 11:34, mengqinggang wrote:
> [snip]
> +static struct loongarch_opcode loongarch_lbt_opcodes[] =
> +{
> + /* match, mask, name, format, macro, include, exclude, pinfo. */
> + {0x00000800, 0xfffffc1c, "movgr2scr", "cr0:2,r5:5", 0, 0, 0, 0},
> + {0x00000c00, 0xffffff80, "movscr2gr", "r0:5,cr5:2", 0, 0, 0, 0},
Thanks for amending these two!
> [snip]
> + {0x00368000, 0xffffc3e0, "setx86j", "r0:5,u10:4", 0, 0, 0, 0},
> + {0x00007800, 0xfffffc00, "setx86loope", "r0:5,r5:5", 0, 0, 0, 0},
> + {0x00007c00, 0xfffffc00, "setx86loopne", "r0:5,r5:5", 0, 0, 0, 0},
But what about these three? "x86set..." could be more consistent,
especially given "x86settm" is also around. I didn't notice this in my
first review but I've mentioned this part in another reply.
> [snip]
> + {0x0036c000, 0xffffc3e0, "setarmj", "r0:5,u10:4", 0, 0, 0, 0},
Also here (renaming this to "armsetj" would make the LBT/ARM instruction
names entirely consistent).
next prev parent reply other threads:[~2023-06-30 3:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 3:34 [PATCH v1 0/2] " mengqinggang
2023-06-30 3:34 ` [PATCH v1 1/2] " mengqinggang
2023-06-30 3:52 ` WANG Xuerui [this message]
2023-06-30 3:34 ` [PATCH v1 2/2] LoongArch: gas: Fix code style issues mengqinggang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78c011c2-679c-3b01-ab75-e1d59d79cf88@xen0n.name \
--to=i.swmail@xen0n.name \
--cc=binutils@sourceware.org \
--cc=chenglulu@loongson.cn \
--cc=liuzhensong@loongson.cn \
--cc=maskray@google.com \
--cc=mengqinggang@loongson.cn \
--cc=xry111@xry111.site \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).