From: Jan Beulich <jbeulich@suse.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: kong lingling <lingling.kong7@gmail.com>,
Binutils <binutils@sourceware.org>,
"Kong, Lingling" <lingling.kong@intel.com>
Subject: Re: [PATCH] x86-64: Support APX NF TLS IE with 2 operands
Date: Wed, 3 Jul 2024 12:42:28 +0200 [thread overview]
Message-ID: <78d784d9-977c-44f1-9435-45ad7b2a271d@suse.com> (raw)
In-Reply-To: <CAMe9rOqaGZB=etwBmsjtOouqRpkyi3WTuUDGrJOm83kdAKjYtA@mail.gmail.com>
On 03.07.2024 12:20, H.J. Lu wrote:
> On Wed, Jul 3, 2024, 6:11 PM Jan Beulich <jbeulich@suse.com> wrote:
>
>> On 03.07.2024 11:43, H.J. Lu wrote:
>>> On Wed, Jul 3, 2024, 5:23 PM Jan Beulich <jbeulich@suse.com> wrote:
>>>
>>>> On 03.07.2024 09:49, H.J. Lu wrote:
>>>>> Have I missed something? I haven't seen any testcases.
>>>>
>>>> From my description you could have made one yourself, if you really
>> didn't
>>>> believe what I was saying. Here you go:
>>>>
>>>> .text
>>>> gottpoff:
>>>> .irp op, add, sub
>>>> \op foo@gottpoff(%rip), %rax
>>>> \op foo@gottpoff(%rip), %r16
>>>> \op foo@gottpoff(%rip), %rax, %rcx
>>>> \op %rax, foo@gottpoff(%rip), %rcx
>>>> {nf} \op foo@gottpoff(%rip), %rax
>>>> .endr
>>>>
>>>> popcnt foo@gottpoff(%rip), %rax
>>>> popcnt foo@gottpoff(%rip), %r16
>>>> {nf} popcnt foo@gottpoff(%rip), %rax
>>>>
>>>> adox foo@gottpoff(%rip), %rax
>>>> adox foo@gottpoff(%rip), %r16
>>>
>>> What are the issues?
>>
>> Can you just explain the resulting behavior please, as to where errors are
>> raised and where insns assemble without any diagnostic? Did you even try
>> to hand this to the assembler? Because if you did, didn't it occur to you
>> that the set of diagnostics you got is completely arbitrary?
>>
>
> foo@gottpoff(%rip) was added for TLS IE with ADD and MOV. Any other usages
> are undefined.
Yet gas behaves inconsistently in this regard. It accepts (taking just the
example above) SUB, POPCNT, and ADOX, just as long as they're legacy
encoded.
> If clarifications are needed, please raise the issue at x86-64 psABI group.
I don't think clarification is needed there. We simply need to get gas into
a mode where it behaves consistently. That could be consistently more lax
or consistently more strict. I'm tending towards the former, as indicated.
Jan
next prev parent reply other threads:[~2024-07-03 10:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 1:19 kong lingling
2024-07-03 1:55 ` H.J. Lu
2024-07-03 6:43 ` Jan Beulich
2024-07-03 6:48 ` H.J. Lu
2024-07-03 7:10 ` Jan Beulich
2024-07-03 7:14 ` H.J. Lu
2024-07-03 7:27 ` Jan Beulich
2024-07-03 7:49 ` H.J. Lu
2024-07-03 9:23 ` Jan Beulich
2024-07-03 9:43 ` H.J. Lu
2024-07-03 10:11 ` Jan Beulich
2024-07-03 10:20 ` H.J. Lu
2024-07-03 10:42 ` Jan Beulich [this message]
2024-07-03 10:51 ` H.J. Lu
2024-07-03 10:01 ` Hongyu Wang
2024-07-03 10:13 ` Jan Beulich
2024-07-03 7:58 ` Kong, Lingling
2024-07-03 8:10 ` Jan Beulich
2024-07-03 12:37 ` Kong, Lingling
2024-07-03 14:11 ` Jan Beulich
2024-07-04 7:03 ` Kong, Lingling
2024-07-04 7:38 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78d784d9-977c-44f1-9435-45ad7b2a271d@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=lingling.kong7@gmail.com \
--cc=lingling.kong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).