From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) by sourceware.org (Postfix) with ESMTPS id 615CE3858D34 for ; Fri, 1 Mar 2024 01:49:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 615CE3858D34 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 615CE3858D34 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::830 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709257765; cv=none; b=DbSz3n/B+hoxg86R+UB8hpcaqHEIYsrbVvSX8SGOQ9dsp7ljAb7fUqXjxxBR56634p+wU6Xwp1QZHL+1abJIe2PJjsTKJusp9hBRL6mtwGfiUXPqKMxPZkySfk6E9QtlztSF8a7PalMeznmsqdgpHuItZuvOwyGCLQvu+qXGDso= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709257765; c=relaxed/simple; bh=GzDjNN9icZpM0vH4jKeMs7rYVEcXx4T/IRru7FPT6rg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=l37Srb9JazP3McHuu5Cm0O3QD5LFVOnqrnJ43xYwwh5sB88VolfgSQYERBShUNg5xhv05aIoBZsF9cPSTUgrRIeN6y6PCB+P9xorVP52jNWDCtyq0/gaFcMEISTz4l/SjrhVgYFtvckdW3cayXuentMjkBhkdCpU6tTGEK2KSb4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-qt1-x830.google.com with SMTP id d75a77b69052e-42e4f706847so10723481cf.2 for ; Thu, 29 Feb 2024 17:49:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709257754; x=1709862554; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PDHc5RFbp4oLHtapC2+aua6MVWWorYjq5ppZBBSQ1eE=; b=JQFCNRvSC1NnwJ+Dn3s06KyQ+z2tpz9QyHaZGenFvXGKDXo70b9HesLuDjW9uVdN+9 Gw62pawMkmSfrMJzoyuq8jGZ+kt5WEbe0pL0zbLO4FSTUl91ITIQFCbKvlBkG2admkOs Epl3LZpOrIrhGK1/jp/uwA9BJ+Sk9NP7LFrslmv0VJ+35GnsZITkr2S1rNnfpikp3h6Z LaiKosKGy4ew6tLJnYqfdaVA2j3VJOpy1UISz1fj39ijo2RsPkpRKvyYJIq/9v1B4cpR i7Ho5FeNVhbrkfuj3fAHJx7jkTeW3saSmjTGdjKdva8nSUG6AxGx9XXuvRxrYmzjPOo4 lihQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709257754; x=1709862554; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PDHc5RFbp4oLHtapC2+aua6MVWWorYjq5ppZBBSQ1eE=; b=VdHYQNUIxuw/FDG4kzyo5o1ndv7LfuJxMhOxXwnZPTB3S2EuK3V3h344gDe9TpzyE0 8rMIJcUUC5+0WogRe06+mNvtAsDOqgVFnDWJdh+H57n5sy3dHFCLq0TkWcinlE5gOF00 96K7GFPkAO7kvB+hVnz9R63ScMPLnjUjP0tAW86xZX7FrV82D0dreUG2eVUXHB1t8Hbx rvV7NnEx0Tv8rP+lhWmWTaym/065NGJKeYBcH5sOtWbV0A5AQ8Jt9zLby7muNLl5vSY1 auzO8xMM4NGN8T+AwH/wrY+1Z2p8Z5OXtjr7xv9PdqN8JBII2RLRMuj7sVC957lRwpfq JsRQ== X-Forwarded-Encrypted: i=1; AJvYcCUZeOzSwBT+1TZDpGChPFbUAT11YWyvzpXG+mNHcjD9hcWY0HtmKRagBhXZF90RXwdi8UqxAYNjqj70I6UuKKjyz3SXHAdIkg== X-Gm-Message-State: AOJu0Yxk9Fr3ZCm+a5KTBoRv5elFKmC9IyuaKi7AIx+pF4F1koQWZ2Cz dyioUlSHDhM0BlQkDZeLobVOFaj2ro9VAIn4aszxQuCEpDz9go5noYW/ZopR X-Google-Smtp-Source: AGHT+IH7y8TFfyCWbpSS7JZess0BIJY7j07ei77uKArCcReLUBXFIVDa5k9/zVV0RhMJvNE1QsY1xw== X-Received: by 2002:a05:622a:130a:b0:42e:c5c1:3266 with SMTP id v10-20020a05622a130a00b0042ec5c13266mr271843qtk.68.1709257754542; Thu, 29 Feb 2024 17:49:14 -0800 (PST) Received: from ?IPV6:2602:47:d95e:101:6466:7a7:74c3:88f3? ([2602:47:d95e:101:6466:7a7:74c3:88f3]) by smtp.gmail.com with ESMTPSA id b1-20020ac812c1000000b0042e3468a98csm1273043qtj.4.2024.02.29.17.49.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Feb 2024 17:49:14 -0800 (PST) Message-ID: <78f71dff-4190-41ba-bdfc-162e417ab638@gmail.com> Date: Thu, 29 Feb 2024 20:49:12 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [binutils] libctf: Remove undefined functions from ver. map Content-Language: en-US To: Nick Alcock Cc: Sam James , binutils References: <87bk828z6q.fsf@gentoo.org> <877ciqvtgi.fsf@esperi.org.uk> <87v868qwvd.fsf@esperi.org.uk> From: Nicholas Vinson In-Reply-To: <87v868qwvd.fsf@esperi.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/28/24 13:14, Nick Alcock wrote: > On 28 Feb 2024, Nicholas Vinson told this: > >> On 2/27/24 10:05, Nick Alcock wrote: >>> On 27 Feb 2024, Sam James said: >>> >>>> Nicholas Vinson writes: >>>> >>>>> The functions ctf_label_set(), ctf_label_get(), ctf_arc_open(), ctf_fdopen(), >>>>> ctf_open(), ctf_bfdopen(), and ctf_bfdopen_ctfsect() are not defined. Their >>>>> inclusion in libctf/libctf.ver causes clang/llvm LTO optimizatiosn to fail with >>>>> error messages similar to >>> This is definitely not right. They *are* defined, but only for some >>> libraries built from this version script. You can't just take them out. >> >> Could you point me to the definitions for ctf_label_set() and ctf_label_get() ? > > Those two are long dead and gone and should indeed be removed from the > .ver script. (I wonder why Solaris's linker, which is just as picky > about version scripts referencing only symbols that actually exist, > never warned me about this.) > >> I do find definitions for the other so the other symbols, so I'll find >> a different way to handle those symbols in the version file. > > Commenting them as /* libctf only. */ should be enough, I think. Only > one symbol seems to be missing, ctf_arc_open. The others are already > properly marked and should already be being excluded from the .ver > script for libctf_nobfd.so.) > I see what you're talking about in libctf/configure.ac. However, it's protected by a `test -n "$decommented_version_script"` check. Because ld.lld does not understand `-B local`, that variable remains empty and the lines in the version file containing /* libctf only. */ are not removed. Thanks, Nicholas Vinson