From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2089.outbound.protection.outlook.com [40.107.104.89]) by sourceware.org (Postfix) with ESMTPS id 9FADD3945C1D for ; Fri, 25 Nov 2022 08:03:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9FADD3945C1D Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jBIOeod37+3o9W9gh8ZrKTLn2s47LFtqBbglyRRnqxEGSAL/wdSgWaIHHnFDPkwyeVEoQbCRIjzmNgtq788lydP0iQPWDtlJ6onoJtpEj2vDKqADui5phXkcZYafndcphRoYcOYj3h1l9UkVpi1adLV3nqtopYL3ZB5JsdKrm1+2o/vRaUXLXo1wPQyzZwUJNXIuAbOCIcx227DjSYfZdoo7Uiepv4sVEr0GvWJZpqB83iwbE8A2w95bwW6smnsOLgpKxVjBp1dw176xypvBgAovkRGVUvlSIRbIZ34GwU7y0Hr2fmRDEgYzOOxWJcPPJeFWXH36MZWqKNaMg4yyjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9Zmgwep2bo/1aQMPXxsdqpEM8bRXcY9htI+AxkuOTzw=; b=lHJZAFCVfZAi4kg3mjouHt4cq+//BSXGtCbf6LH763nyoue+KDyMK/KP+mgzsWWK9R61UnK6iZx3TI2O3BRY3w6rblQdk0U+hAprCgFIVMMnjyAQWOC3WVnQcKFd7eYdAzly/vodGXa2bFgoQtPg9ZTOHVwDiSDx79o+Gyj3GEdaDyk4neMuWJH8HyL2UcUX4CjZloAZTWcS8ToT385iWaRA3ythUSlLWgPiQ7H/Vac9kF4P6Ni4jv9BmAPTw2lymSlCODcsk9MO7E1fkbjSBd8IBFulAjEERcdc/4Lc4x4tTuigD7rgDooypqkjV7igFWyjzHaP50tGBI7eBmwl2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Zmgwep2bo/1aQMPXxsdqpEM8bRXcY9htI+AxkuOTzw=; b=NNmBOS4yS+pFIs/ZdgKnYQCQ9a8e3z7Jjc4OlrRDNNONvoeyFFajv2mqKOsuDxUK8AUh4DmOBY2dRJUZ0nYyyY9JAGs+w87448aWaih++UWatGMPbdHvaAUI6UueIjmiZWUa+cj/1eMF3Ol2TcC2+oR4McYEONkYMBalIcg2A5WJmb4Lp2lNOfG8foxALMM8EottsLIhBnFTJQ+TwX+lKPEWBYgg3PvLzUvC8JNfzTJm+HOK6NKeIoKVQSf80sB+ccZXamachYD4eL4DRX7lsO8tf2td8GDlD+T2vZ6n8c6jbJ8rWGyXEJtrN1g789t5S8MAESBoBpzCgAMBQSt1DA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB9500.eurprd04.prod.outlook.com (2603:10a6:10:361::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.20; Fri, 25 Nov 2022 08:03:15 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.020; Fri, 25 Nov 2022 08:03:15 +0000 Message-ID: <79b8472b-579b-8253-a572-da1b8bf123e6@suse.com> Date: Fri, 25 Nov 2022 09:03:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v3 1/2] RISC-V: Better support for long instructions (disassembler) Content-Language: en-US To: Tsukasa OI Cc: binutils@sourceware.org, Nelson Chu References: <66ca80358f78d66d66bbf390fc0be8bec8183e93.1669342633.git.research_trasio@irq.a4lg.com> From: Jan Beulich In-Reply-To: <66ca80358f78d66d66bbf390fc0be8bec8183e93.1669342633.git.research_trasio@irq.a4lg.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0100.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB9500:EE_ X-MS-Office365-Filtering-Correlation-Id: df2526c3-182a-45c5-6c08-08dacebb8146 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yQZ2kMvSv91hV1mhbgRdZ8v7sPYJ1IZXfz1fRZu2TbOWN6QIZQzXrPAn5KitLvOsm/UXZsz0FvTZZM7bsXMMOO1v6hWbaRT6ZJCfJ/Kx4smShtbu/0Zrv6IwPOh4yN3KlD9kGfcWyqz9ZKrRQPYGW/bBe45ZDsdxd6KAHliHOG66yvvHpKRNuP6s2A1Gj7iiVG+fx3p/sU7v/MbMXEWXpyiBk56HJiMMORwx/ouInhiaL6K1JgW4nNqSnWqZDzQ/R6Wt/xtgwOckpXZz7NpP7c/yQSb0QkPpEtn0WkOoN/duWv7BXkAi0Ui8gPKfda3Ed1g1k3BuPUD2eqOEAItFUqugWcc79xyhoM3LskHx4cib/oN5xohgHsZamNioG4v5Rcxkh6OsGdUj0amO+bh+ywnDEx/NHD+r56UTEY6vm47XR5lHl/aaApm7xW+LazzqYASzFyUBVpm+sbIAitQSSvC6p+27goJYcNY8EM/GKo3tKaSDSoHnI1ohTO5G37UzSMvrpo/4GG+20yrDk3AcHiDIY7YNPPH1AfP2FrsIcN08R6grK4f8jnTVZxy0sUmU+alV7mlYv6iad7L/7j1J4eDUP4GYf9IYB4SBkYvS7kQCOBT/2edPB+dkCm2vaXcFonqD9PNyVypvrc+U2w/wrThFjMIwHDbacWUXURrjA4GBPiEhIIegPUc4MWmuBGxRlJbba+2jSo0GV+x156RUKCHaiVMWBB/HqI2NHMCqfHM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(376002)(396003)(136003)(366004)(39860400002)(451199015)(2906002)(31686004)(5660300002)(8936002)(316002)(8676002)(36756003)(4326008)(66556008)(66946007)(66476007)(6916009)(6486002)(41300700001)(478600001)(6512007)(186003)(31696002)(86362001)(2616005)(83380400001)(26005)(53546011)(38100700002)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2p1bTM5R2pKZ2VCRHAwYnNGU09VSVM4dm5IMWMzb20xa0VTTllhZjBwN0hp?= =?utf-8?B?dVpiT2VTWW1QZGNobjU1NklqZ01JQjlWU01TYSt6VFRneDRIQ3RPUzd0alF4?= =?utf-8?B?Ni9BdmRqOEdBbEMzSWNBanhMWkE1VERqNTlwSURsUXloMW52cWNNWUJndURs?= =?utf-8?B?MXoweE9xSWdRQ2ZLaXNQUEFuSENnUE8vMDc2c1NDdW01d1g4bnA4bFp4c3ZO?= =?utf-8?B?amQ0OEN1UkZFTjVDTDlhOTNjWU0va003aHJWUTNYMlVoTWJkaVBnOE9kMDcx?= =?utf-8?B?bnN4U1dxK3V0NG1QYmdlVFVybXBFTERKd2NDMXFHcXJpRk9HRkpibm9hbDUz?= =?utf-8?B?SWpZeFlGdDV0SGpDN3dJUHFYSkZkdk5DRXlhWk1rUG5HWnZvV3ZLblVmMFRz?= =?utf-8?B?dDZVTEdreWI2OHMxVTA0ZWJ4ZFNmeWk1dmJQbGh6eit1V0FITTh0cDltNWdU?= =?utf-8?B?bUd4cGR0ZFhwM3JLUjZTNXI2a2g4dzliL2ROR0xpSjEwQXpBQi9GQ3V4bVc2?= =?utf-8?B?Z3NWYzErNlMxMWU3YnJ0WjVreFdNSjFQTERUaHQ1cVlMcGxkcUtYYnZ4QUtC?= =?utf-8?B?eWY4UzFDOGkzbCt2MDFvcDNQVUtiSlFtdytWVFpoUU9iOWVDaEFqM1hiZFZE?= =?utf-8?B?QTRmc2d5ODFSSTZ1KzJsc0t3RGVOZXlxTWp1aTZkWG1OdHg0aWt3MGhPMWJ5?= =?utf-8?B?TGVYZkZVYTlWYkVZa21BZnFVRE5ZYk1zZmRRZXNVTnpHY01LNWtBZ29GdDZn?= =?utf-8?B?ajhkMVgrejRaZlFnMmtYTFZPQnVLdXlpOXVzK00yT1ZQdllrcDJ5akdDejh0?= =?utf-8?B?OTdBK1dJcGRRZXRoYzVWQWg3bXRXaHhZRVEvSlBDa0VZVnVMNFFQdVlmTFF0?= =?utf-8?B?YndUeTIvN2hyRloxZndkejFQOVRQOFhadHcyZkVaZC81cXRmYUVHeWJIRFZU?= =?utf-8?B?aFF5TGxPYVVQdnM5aXE5UkhzSlpBYkxsZDlsblZkOFpCZklVanc0Y0JSeUUr?= =?utf-8?B?am4zUEMwZGVQU0hpd3laSkdiTjFFcm9MM0ZkKzNFZDE1OUhxVE5JS0t5SDA0?= =?utf-8?B?WG9zSjZqRXhCVmtkaVRzM2pUV3Rpek56N1RCNGgvNXNweEJzWmVxZFFwTXZQ?= =?utf-8?B?RE1ONngrOTZnUDVWYkFKVlQ2bzQ5L1JRSFdtMmRmWm5leVRDT2I1bVlydWlZ?= =?utf-8?B?RXdFeGZhcGpXSGM0THhqRkZpV0puamdsN3E0NmcweXkwNUgrR3NyUmFIY0tB?= =?utf-8?B?VWFtUm80aGJHeWE0RUlCdU9YMElXZkozeURLZ0F5NU00Ly9peWx0b0E1cEFD?= =?utf-8?B?T1R5Z3BZREhxYWs5U1dFL2h1Vk1XSGh3aEVUWjhzQkdnQXIrbWJhNVdEbjBq?= =?utf-8?B?Y2c3c1c2cFRKaVVNR0JEczRVQzYrakZSVUw4SXpUWFdDNG1TTnBwSCtPSFln?= =?utf-8?B?NWFrWFQyOHRML05vVmxTWWVMT0MrUm9jNlNTczJFTG1xRTNudEdUVGRCWmpV?= =?utf-8?B?aWJCWWRORzh2bWpoa2J2Z2ZtV0VtM0UyNVFCUjh1RW84NW9pczdVSXhwdGdS?= =?utf-8?B?eHB0UFZzTkZBR1VDaXRNUGdpZ3hZTi80clhXR2NKTEdCRXd2UU1XUnFxbFV1?= =?utf-8?B?NEtFcmxQMFZhR3E3bUJvZ09mL01OOWZWQmdQMXNYc0gwdldqaHlzaHNaYUdF?= =?utf-8?B?ZC9uciswWmE5QTgwMm9pNitiQmI1QncyUUZXeGhnaVJLR1JmaUpWRjRtMm5w?= =?utf-8?B?R29raTVRbjJrbW9oLzZLOTdOMmFZTVpLS3hEM3BES1NIVVN6bUFNZGszSWlw?= =?utf-8?B?OHRHZjZXa1NGYW45VDZzY2FjeHZ4UEVnN2tGcjUrb2Z3c1cydTllalZNS1Bj?= =?utf-8?B?MVc4VTRDSHBrYmN2cC9tditKMitOVERDT2tYTUNYTGdLU1BkbmYwQWJoZDFl?= =?utf-8?B?RGl6QWRlQk5FWWdFWi9MZ3dxZUd4WDBsMm5HYVEzSWNFdmRsOXhLcHZxc0k2?= =?utf-8?B?VmRJa1FwZTZ1Z1ZiUWFOVFJHZEI5N25Ud1piSWlJalRMSnV5YklKeTFORCtK?= =?utf-8?B?Y2J3Q3NOaTZTZzVMZ0czS3VreFBtSXRZWjJsSE9uWW9wWTZxNkE1NnFEMlJz?= =?utf-8?Q?jN4DUzgWkiSk/TvJRsOwFyYci?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: df2526c3-182a-45c5-6c08-08dacebb8146 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2022 08:03:15.1772 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sxcqlEjuogJAzO0gM7BKov0gQC9x7dc/vxEhoGGajf3GPNFnqwqUjocoH7jBjA04tng2gg14pA6CX4FVoEdW0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9500 X-Spam-Status: No, score=-3029.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 25.11.2022 03:17, Tsukasa OI wrote: > From: Tsukasa OI > > Commit bb996692bd96 ("RISC-V/gas: allow generating up to 176-bit > instructions with .insn") tried to start supporting long instructions but > it was insufficient. > > 1. On the disassembler, disassembler dump was limited up to 64-bit. > For long (unknown) instructions, instruction bits are incorrectly > zeroed out. > > To solve these problems, this commit adds packet argument to support dumping > instructions longer than 64-bits. This commit will be tested on the next > commit "RISC-V: Better support for long instructions (assembler)". > > opcodes/ChangeLog: > > * riscv-dis.c (riscv_disassemble_insn): Print unknown instruction > using the new argument packet. > (riscv_disassemble_data): Add unused argument packet. > (print_insn_riscv): Pass packet to the disassemble function. Looks okay to me; just one style nit: > --- a/opcodes/riscv-dis.c > +++ b/opcodes/riscv-dis.c > @@ -641,7 +641,10 @@ print_insn_args (const char *oparg, insn_t l, bfd_vma pc, disassemble_info *info > this is little-endian code. */ > > static int > -riscv_disassemble_insn (bfd_vma memaddr, insn_t word, disassemble_info *info) > +riscv_disassemble_insn (bfd_vma memaddr, > + insn_t word, > + const bfd_byte *packet, Just like you have it here, please add ... > @@ -1037,7 +1040,7 @@ print_insn_riscv (bfd_vma memaddr, struct disassemble_info *info) > bfd_vma dump_size; > int status; > enum riscv_seg_mstate mstate; > - int (*riscv_disassembler) (bfd_vma, insn_t, struct disassemble_info *); > + int (*riscv_disassembler) (bfd_vma, insn_t, const bfd_byte*, struct disassemble_info *); ... a blank before * here. I guess you will also want to wrap this (now long) line. No need to submit a v4 just for that, i.e. feel free to simply commit with the adjustment (after giving Nelson a little bit of time, just in case). Jan